[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62bd33158d92: [LLDB][GUI] Add Environment Variable Field (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Very nice! Looks great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106999/new/ https://reviews.llvm.org/D106999

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

OmarEmaraDev marked an inline comment as done. OmarEmaraDev added a comment. I generalized the implementation as suggested and added a ready to use list version of the field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106999/new/ https://review

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

OmarEmaraDev updated this revision to Diff 362755. OmarEmaraDev added a comment. - Generalize the implementation to any Mapping field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106999/new/ https://reviews.llvm.org/D106999 Files: lldb/source/C

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

clayborg added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1924 + +class EnvironmentVariableFieldDelegate : public FieldDelegate { +public: There are other things that could benefit from having two text fields, like source mapping: ``` (

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. Example list of environment fields: F18194751: 20210728-221522.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106999/new/ https://review

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds an environment variable field. This is usually use