[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe81ba283131c: [lldb/lua] Add scripted watchpoints for Lua (authored by Siger Yang , committed by tammela). Changed prior to co

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

JDevlieghere accepted this revision. JDevlieghere added a comment. Nice! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105034/new/ https://reviews.llvm.org/D105034 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

tammela accepted this revision. tammela added a comment. This revision is now accepted and ready to land. I tested locally and it seems fine! Thanks. Comment at: lldb/test/Shell/ScriptInterpreter/Lua/watchpoint_callback.test:23 +c +# CHECK: conditional watchpoint +# CHECK-NOT:

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

siger-young updated this revision to Diff 355429. siger-young added a comment. Fix some linting and add extra tests for Lua scripted watchpoints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105034/new/ https://reviews.llvm.org/D105034 Files: l

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

siger-young updated this revision to Diff 355428. siger-young added a comment. This patch mainly adds two extra tests for Lua scripted watchpoints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105034/new/ https://reviews.llvm.org/D105034 Files:

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

tammela added a comment. Clang format complained a bit, please fix those. Comment at: lldb/test/Shell/ScriptInterpreter/Lua/watchpoint_callback.test:15 +# CHECK: val=nil +# CHECK: Process {{[0-9]+}} exited More tests cases would be nice Repository: rG LLVM

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

siger-young created this revision. siger-young added reviewers: tammela, JDevlieghere. siger-young added a project: LLDB. siger-young requested review of this revision. Herald added a subscriber: lldb-commits. Add support for Lua scripted watchpoints, with basic tests. Repository: rG LLVM Gith