[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadfffebec6d6: [lldb/Core] Add SourceLocationSpec class (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 342073. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/lldb/Core/SourceLocationSpec.h lldb/source/Core/CMakeLists.txt lldb/source/Core/SourceLoca

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 342068. mib marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/lldb/Core/SourceLocationSpec.h lldb/source/Core/CMakeL

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

JDevlieghere added a comment. A few more comments about things I missed in the previous review. Comment at: lldb/source/Core/SourceLocationSpec.cpp:57 + +void SourceLocationSpec::Dump(llvm::raw_ostream &s) const { + StreamString ss; Should this take a `StreamS

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 341774. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/lldb/Core/SourceLocationSpec.h lldb/source/Core/CMakeLists.txt lldb/source/Core/SourceLoca

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 341763. mib marked 3 inline comments as done. mib added a comment. Address @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/l

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

JDevlieghere added inline comments. Comment at: lldb/source/Core/SourceLocationSpec.cpp:48-61 + if (int result = FileSpec::Compare(a.GetFileSpec(), b.GetFileSpec(), full)) +return result; + + // If both file_spec matches, compare line numbers. + if (a.GetLine() != b.GetLin

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/unittests/Utility/CMakeLists.txt:41 TimerTest.cpp + UUIDTest.cpp UriParserTest.cpp Let's exclude the change to this

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 341752. mib added a comment. Wrap `SourceLocationSpec` column argument into an `llvm::Optional` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/lldb