[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: lldb/tools/driver/Driver.cpp:856 if (const char *reproducer_path = SBReproducer::GetPath()) { -// Leaking the string on purpose. -std::string *finalize_cmd = new std::strin

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

dblaikie added inline comments. Comment at: lldb/tools/driver/Driver.cpp:856 if (const char *reproducer_path = SBReproducer::GetPath()) { -// Leaking the string on purpose. -std::string *finalize_cmd = new std::string(argv0); +static std::string *fi

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lldb/tools/driver/Driver.cpp:856 if (const char *reproducer_path = SBReproducer::GetPath()) { -// Leaking the string on purpose. -std::string *finalize_cmd = new std::strin

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

dblaikie added inline comments. Comment at: lldb/tools/driver/Driver.cpp:856 if (const char *reproducer_path = SBReproducer::GetPath()) { -// Leaking the string on purpose. -std::string *finalize_cmd = new std::string(argv0); +static std::string *fi

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdae6d7711d6: [lldb] Fix one leak in reproducer (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

MaskRay updated this revision to Diff 338688. MaskRay marked an inline comment as done. MaskRay added a comment. remove a stale comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100806/new/ https://reviews.llvm.org/D100806 Files: lldb/tools/

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This LGTM In D100806#2700111 , @MaskRay wrote: > @JDevlieghere The Reproducer library seems to have several other leaks. Maybe > you'd li

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

rupprecht added inline comments. Comment at: lldb/tools/driver/Driver.cpp:856 if (const char *reproducer_path = SBReproducer::GetPath()) { // Leaking the string on purpose. +static std::string *finalize_cmd = new std::string(argv0); This i

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

MaskRay added a comment. @JDevlieghere The Reproducer library seems to have several other leaks. Maybe you'd like to look at them? :) I am unfamiliar with the code... ==2013285==ERROR: LeakSanitizer: detected memory leaks Direct leak of 32 byte(s) in 2 object(s) allocated from: #0 0

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

MaskRay created this revision. MaskRay added reviewers: JDevlieghere, rupprecht, shafik, teemperor. MaskRay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use a variable of static storage duration to reference an intentionally leaked varia