[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-05-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/142215 >From b969aeffa2726ef4e0714bde9de72a5292a8d8fa Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 30 May 2025 14:11:19 -0700 Subject: [PATCH 1/2] [lldb] Add Python properties to SBBreakpointr(Location) ---

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Can you find a test that uses (some of) the old methods and replace them by the properties so these have some coverage? https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Remove unused macro ENABLE_MEMORY_CACHING (PR #142231)

2025-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/142231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adding const modifier to SBAddress methods (PR #142275)

2025-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/142275 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adding const modifier to SBAddress methods (PR #142275)

2025-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. Yes, unfortunately this is ABI breaking. The const qualifier is encoded in the mangling (it'll add a `K`). You can confirm this yourself by running `nm` over the liblldb before and after adding the const qualifier https://

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-31 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/140470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8160276 - [lldb-dap] Synchronously wait for breakpoints resolves in tests (#140470)

2025-05-31 Thread via lldb-commits
Author: Ely Ronnen Date: 2025-05-31T16:59:46+02:00 New Revision: 81602769d830e6791200e8cc7dd10a3afc32570b URL: https://github.com/llvm/llvm-project/commit/81602769d830e6791200e8cc7dd10a3afc32570b DIFF: https://github.com/llvm/llvm-project/commit/81602769d830e6791200e8cc7dd10a3afc32570b.diff LO

[Lldb-commits] [lldb] [lldb] Adding const modifier to SBAddress methods (PR #142275)

2025-05-31 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/142275 >From 7d256c09cd9dbefb35fc852450b38943f5040777 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 31 May 2025 12:30:13 +0200 Subject: [PATCH] Adding const modifier to SBAddress methods --- lldb/include/lldb/

[Lldb-commits] [lldb] [lldb] Adding const modifier to SBAddress methods (PR #142275)

2025-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes I don't know if adding `const` specifier is considered breaking the API, but if not it could be useful as it allows for `lldb-dap` to change some objects to `const &` --- Full diff: https://github.com/llvm/llv

[Lldb-commits] [lldb] [lldb] Adding const modifier to SBAddress methods (PR #142275)

2025-05-31 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/142275 I don't know if adding `const` specifier is considered breaking the API, but if not it could be useful as it allows for `lldb-dap` to change some objects to `const &` >From 85e5ac0369b3d2cb263b82912af90762545c

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-31 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 4 "build". Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/9140 Here is the relevant piece of

[Lldb-commits] [lldb] 3b6ff59 - fix PATH_MAX missing in windows build (#142259)

2025-05-31 Thread via lldb-commits
Author: Ely Ronnen Date: 2025-05-31T10:27:44+02:00 New Revision: 3b6ff59d9b137388fe718a624942f9ff6bbde329 URL: https://github.com/llvm/llvm-project/commit/3b6ff59d9b137388fe718a624942f9ff6bbde329 DIFF: https://github.com/llvm/llvm-project/commit/3b6ff59d9b137388fe718a624942f9ff6bbde329.diff LO

[Lldb-commits] [lldb] fix PATH_MAX missing in windows build (PR #142259)

2025-05-31 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/142259 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer (PR #137793)

2025-05-31 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/16847 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer (PR #137793)

2025-05-31 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/137793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f669b9c - [lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer (#137793)

2025-05-31 Thread via lldb-commits
Author: Michael Buch Date: 2025-05-31T09:05:53+01:00 New Revision: f669b9c3eca9438d33259aefb8156f977f1df382 URL: https://github.com/llvm/llvm-project/commit/f669b9c3eca9438d33259aefb8156f977f1df382 DIFF: https://github.com/llvm/llvm-project/commit/f669b9c3eca9438d33259aefb8156f977f1df382.diff

[Lldb-commits] [lldb] fix PATH_MAX missing in windows build (PR #142259)

2025-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/142259.diff 1 Files Affected: - (modified) lldb/tools/lldb-dap/ProtocolUtils.cpp (+1) ``diff diff --git a/lldb/tools/lldb-dap/ProtocolUtils

[Lldb-commits] [lldb] fix PATH_MAX missing in windows build (PR #142259)

2025-05-31 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/142259 None >From 8f7b6fc7f4bba8b6efe7912557d98c5e9fd634c3 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 31 May 2025 09:29:01 +0200 Subject: [PATCH] fix PATH_MAX missing in windows build --- lldb/tools/lldb-d

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-31 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140470 >From 87cf6aee70458b0e9bbc717ee9a5cf9b91b6242a Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 20:56:47 +0200 Subject: [PATCH 1/8] [lldb-dap] Attempt to synchronously wait for breakpoints resol

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-31 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `lldb` at step 8 "build-default". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/6086 Here is the relevant piece of the bui

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 22dfe9c - [lldb-dap] Reuse source object logics (#141426)

2025-05-30 Thread via lldb-commits
Author: Ely Ronnen Date: 2025-05-31T08:47:18+02:00 New Revision: 22dfe9cb589308d94daa00ae533a16a24a012fd9 URL: https://github.com/llvm/llvm-project/commit/22dfe9cb589308d94daa00ae533a16a24a012fd9 DIFF: https://github.com/llvm/llvm-project/commit/22dfe9cb589308d94daa00ae533a16a24a012fd9.diff LO

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 01/12] Reuse creation of Source objects for assembly and normal sou

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 01/11] Reuse creation of Source objects for assembly and normal sou

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/142224 # Symptom We have seen SIGSEGV like this: ``` * thread #1, name = 'lldb-server', stop reason = SIGSEGV frame #0: 0x7f39e529c993 libc.so.6`__pthread_kill_internal(signo=11, threadid=) at pthread_kill.c:

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-05-30 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thanks for the heads up. The build issue was because we didn't pass `USE_SYSTEM_STDLIB`, which we need when targeting the simulators. I've revived the test in #142244. https://github.com/llvm/llvm-project/pull/139174 ___ lldb-comm

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This test was incorrectly disabled. Reviving it and removing the checks for LC_VERSION_MIN_FOO as more recent Xcode's don't have the necessary simulator runtimes. --- Full diff: https://github.com/

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-05-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/142244 This test was incorrectly disabled. Reviving it and removing the checks for LC_VERSION_MIN_FOO as more recent Xcode's don't have the necessary simulator runtimes. >From 306fde550dbe211e9feff084c7fabd4af99

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140470 >From 2caa403bd34f132198d4e531129529d86d5ae2e9 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 20:56:47 +0200 Subject: [PATCH 1/7] [lldb-dap] Attempt to synchronously wait for breakpoints resol

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 01/10] Reuse creation of Source objects for assembly and normal sou

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-05-30 Thread via lldb-commits
royitaqi wrote: > > > Could we test this in `TestSimulatorPlatform.py`? > > > > @JDevlieghere Thanks for pointer. It seems the tests in that file are all > > **skipped** because of this bug number: `rdar://76995109`. > > E.g. > > ``` > > UNSUPPORTED: LLDB (/Users/royshi/public_llvm/build/bin/cl

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add build option to specify the libxml 2 version (PR #142183)

2025-05-30 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd closed https://github.com/llvm/llvm-project/pull/142183 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a080c74 - [lldb] Add build option to specify the libxml 2 version (#142183)

2025-05-30 Thread via lldb-commits
Author: Fabrice de Gans Date: 2025-05-30T16:21:13-07:00 New Revision: a080c741bc2c013919e7445d108fd532f12549b1 URL: https://github.com/llvm/llvm-project/commit/a080c741bc2c013919e7445d108fd532f12549b1 DIFF: https://github.com/llvm/llvm-project/commit/a080c741bc2c013919e7445d108fd532f12549b1.dif

[Lldb-commits] [lldb] [lldb-dap][test] Fix DAP disassemble test (PR #142129)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -23,15 +19,23 @@ def test_disassemble(self): self.set_source_breakpoints(source, [line_number(source, "// breakpoint 1")]) self.continue_to_next_stop() -_, pc_assembly = self.disassemble(frameIndex=0) -self.assertIn("location", pc_assembly,

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread via lldb-commits
@@ -104,7 +104,7 @@ TEST(Perf, RealLogicalCoreIDs) { ASSERT_GT((int)cpu_ids->size(), 0) << "We must see at least one core"; } -TEST(Perf, RealPtraceScope) { +TEST(Perf, RealPtraceScopeWhenExist) { royitaqi wrote: cc @rupprecht (who added the original unit t

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/9] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Remove unused macro ENABLE_MEMORY_CACHING (PR #142231)

2025-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes This macro does not do what is described. The only thing it actually does control is whether or not the process's memory cache gets flushed when writing to an address. It does not override the setting `ta

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread via lldb-commits
@@ -74,7 +74,7 @@ lldb_private::process_linux::GetAvailableLogicalCoreIDs() { llvm::Expected lldb_private::process_linux::GetPtraceScope() { ErrorOr> ptrace_scope_file = getProcFile("sys/kernel/yama/ptrace_scope"); - if (!*ptrace_scope_file) + if (!ptrace_scope_file)

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/142224 >From 58b8a322a8cc6e3cce3d3e2d405fb915c338791a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Fri, 30 May 2025 14:21:06 -0700 Subject: [PATCH 1/4] Fix crash and add test --- lldb/source/Plugins/Process/Linux/Pr

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread via lldb-commits
@@ -104,7 +104,7 @@ TEST(Perf, RealLogicalCoreIDs) { ASSERT_GT((int)cpu_ids->size(), 0) << "We must see at least one core"; } -TEST(Perf, RealPtraceScope) { +TEST(Perf, RealPtraceScopeWhenExist) { royitaqi wrote: > This will probably fail I don't think so.

[Lldb-commits] [lldb] [lldb][NFC] Remove unused macro ENABLE_MEMORY_CACHING (PR #142231)

2025-05-30 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/142231 This macro does not do what is described. The only thing it actually does control is whether or not the process's memory cache gets flushed when writing to an address. It does not override the setting `targe

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-05-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/142051 >From c0ece622ddf6e2f899d2a184cc0fcb1b44a3ebf5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 28 May 2025 15:45:45 -0700 Subject: [PATCH] [lldb][headers] Create Python script to fix up framewo

[Lldb-commits] [lldb] [lldb][RPC] Upstream LLDB to RPC converstion Python script (PR #138028)

2025-05-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From 208288fc19c742553a4a4c7bb71e54b85a7b8ada Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream LLDB to RPC converstion Python sc

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond requested changes to this pull request. https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread Jacob Lalonde via lldb-commits
@@ -104,7 +104,7 @@ TEST(Perf, RealLogicalCoreIDs) { ASSERT_GT((int)cpu_ids->size(), 0) << "We must see at least one core"; } -TEST(Perf, RealPtraceScope) { +TEST(Perf, RealPtraceScopeWhenExist) { Jlalond wrote: This will probably fail, I don't think `kerne

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread Jacob Lalonde via lldb-commits
@@ -74,7 +74,7 @@ lldb_private::process_linux::GetAvailableLogicalCoreIDs() { llvm::Expected lldb_private::process_linux::GetPtraceScope() { ErrorOr> ptrace_scope_file = getProcFile("sys/kernel/yama/ptrace_scope"); - if (!*ptrace_scope_file) + if (!ptrace_scope_file)

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Plugins/Process/Linux/Procfs.cpp lldb/un

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes # Symptom We have seen SIGSEGV like this: ``` * thread #1, name = 'lldb-server', stop reason = SIGSEGV frame #0: 0x7f39e529c993 libc.so.6`__pthread_kill_internal(signo=11, threadid=) at pthread

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-05-30 Thread via lldb-commits
jimingham wrote: It would be nice to add a few usages, mostly to make sure somebody doesn't remove them or inadvertently scramble up the property -> Getter/Setter while adding a new one or something. https://github.com/llvm/llvm-project/pull/142215 _

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-05-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/142051 >From d39eeaae552395cd79324aaa38eccb3f9dfe4a79 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 28 May 2025 15:45:45 -0700 Subject: [PATCH] [lldb][headers] Create Python script to fix up framewo

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/8] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-05-30 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] 513c1cd - [LLDB][Platform Linux] Flip uid and pid in get signal description (#142200)

2025-05-30 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-05-30T14:21:33-07:00 New Revision: 513c1cdfaaa3432dc4674a2d3be3dcaec2b4343e URL: https://github.com/llvm/llvm-project/commit/513c1cdfaaa3432dc4674a2d3be3dcaec2b4343e DIFF: https://github.com/llvm/llvm-project/commit/513c1cdfaaa3432dc4674a2d3be3dcaec2b4343e.diff

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen deleted https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/142200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
eronnen wrote: oh, yeah I can move it https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpointr(Location) (PR #142215)

2025-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/142215.diff 2 Files Affected: - (modified) lldb/bindings/interface/SBBreakpointExtensions.i (+9) - (modified) lldb/bindings/interface/SBBreakpointL

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/142200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-05-30 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: Cool! Would be nice to change some of the existing tests to make sure these work as expected. https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpointr(Location) (PR #142215)

2025-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpointr(Location) (PR #142215)

2025-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/142215 None >From b969aeffa2726ef4e0714bde9de72a5292a8d8fa Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 30 May 2025 14:11:19 -0700 Subject: [PATCH] [lldb] Add Python properties to SBBreakpointr(Location) --

[Lldb-commits] [lldb] [lldb] Add build option to specify the libxml 2 version (PR #142183)

2025-05-30 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/142183 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread David Peixotto via lldb-commits
https://github.com/dmpots approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/142200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-05-30 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,117 @@ +#!/usr/bin/env python3 + +""" +Usage: + +This script is used when building LLDB.framework or LLDBRPC.framework. For each framework, local includes are converted to their respective framework includes. + +This script is used in 2 ways: +1. It is used on heade

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread David Peixotto via lldb-commits
@@ -0,0 +1,10 @@ +#include dmpots wrote: > Strangely enough all the existing SIGINFO shell tests also live in this > directory FWIW, I do see a [command-thread-siginfo.test](https://github.com/llvm/llvm-project/blob/main/lldb/test/Shell/Commands/command-threa

[Lldb-commits] [lldb] [lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer (PR #137793)

2025-05-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/137793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread John Harrison via lldb-commits
@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread John Harrison via lldb-commits
ashgti wrote: I meant should the file be `lldb/tools/lldb-dap/ProtocolUtils.{h,cpp}` https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread John Harrison via lldb-commits
@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread John Harrison via lldb-commits
@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Remove some dead code in TypeSystemClang (NFC) (PR #142056)

2025-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/142056 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7a80a8b - [lldb] Remove some dead code in TypeSystemClang (NFC) (#142056)

2025-05-30 Thread via lldb-commits
Author: Dave Lee Date: 2025-05-30T13:28:51-07:00 New Revision: 7a80a8b2bc9136e5c6254eef68230a9b56b35779 URL: https://github.com/llvm/llvm-project/commit/7a80a8b2bc9136e5c6254eef68230a9b56b35779 DIFF: https://github.com/llvm/llvm-project/commit/7a80a8b2bc9136e5c6254eef68230a9b56b35779.diff LOG:

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-05-30 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,117 @@ +#!/usr/bin/env python3 + +""" +Usage: + +This script is used when building LLDB.framework or LLDBRPC.framework. For each framework, local includes are converted to their respective framework includes. + +This script is used in 2 ways: +1. It is used on heade

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/142200 >From 05f09fa434c7fa925935337fb44740f1beba52ba Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 30 May 2025 12:02:02 -0700 Subject: [PATCH 1/3] Flip and add test --- .../Plugins/Platform/Linux/PlatformL

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-05-30 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,117 @@ +#!/usr/bin/env python3 + +""" +Usage: + +This script is used when building LLDB.framework or LLDBRPC.framework. For each framework, local includes are converted to their respective framework includes. + +This script is used in 2 ways: +1. It is used on heade

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const lldb::SBTarget &target, return source; } -bool ShouldDisplayAssemblySource( -const lldb::SBLineEntry &line_entry, -lldb::StopDisassemblyType stop_disassembly_display) { - if (stop_disassembly_display

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const lldb::SBTarget &target, return source; } -bool ShouldDisplayAssemblySource( -const lldb::SBLineEntry &line_entry, -lldb::StopDisassemblyType stop_disassembly_display) { - if (stop_disassembly_display

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -139,15 +141,16 @@ static DisassembledInstruction ConvertSBInstructionToDisassembledInstruction( disassembled_inst.instruction = std::move(instruction); - auto line_entry = addr.GetLineEntry(); + auto source = CreateSource(addr, target); + auto line_entry = GetLineEn

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,17 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/7] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,10 @@ +#include Jlalond wrote: I do think it's weird. Strangely enough all the existing SIGINFO shell tests also live in this directory. I think it would lead to more confusion to break that, but it's a great refactoring opportunity https://github

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,6 @@ +# XFAIL: system-darwin Jlalond wrote: Can you give me an example @dmpots? I would want to run this only on Linux https://github.com/llvm/llvm-project/pull/142200 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [clang] [lldb] [lldb] Add filter option to AST dump command (PR #142164)

2025-05-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/142164 >From 662e07aa9bb6560f37c079ba6f13be17e7885b48 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 30 May 2025 15:44:09 +0100 Subject: [PATCH 1/5] [clang][Frontend] Add overload to ASTPrinter that doesn't

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-30 Thread Chelsea Cassanova via lldb-commits
@@ -290,6 +290,45 @@ else() endif() endif() +# Stage all headers in the include directory in the build dir. chelcassanova wrote: The logic of finding all the headers for staging them in a directory should be able to live here alone. The idea is that the fr

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread David Peixotto via lldb-commits
@@ -0,0 +1,10 @@ +#include dmpots wrote: The location of this test is under the "Register" directory, which looks like it is for testing things like `register read`. Since this is not about examining registers can we find a more suitable location? https://git

  1   2   3   4   5   6   7   8   9   10   >