kasper81 added a comment.
@labath, if there is anything needed by me, please let me know. i'm new to
phabricator patch system. :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132510/new/
https://reviews.llvm.org/D132510
_
kasper81 requested review of this revision.
kasper81 added a comment.
@MaskRay could you please take a look?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132510/new/
https://reviews.llvm.org/D132510
___
kasper81 added a comment.
@jasonmolenda, @Emmmer, any other feedback, or good to merge? i will work on
`Plugins/Architecture/RISCV`, unless someone else beat me to it. :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132510/new/
https://reviews.ll
kasper81 added a comment.
@Emmmer, agreed that automated tests for ABI plugins would be a nice thing to
have at some point in the future, but it is out of the scope of this initial
bring up for RISCV, as tests are missing for all architectures. Also we need
`Plugins/Architecture`port for RISCV
kasper81 marked 2 inline comments as done.
kasper81 added a comment.
Addressed review feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132510/new/
https://reviews.llvm.org/D132510
___
lldb-commits
kasper81 updated this revision to Diff 455982.
kasper81 marked 3 inline comments as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132510/new/
https://reviews.llvm.org/D132510
Files:
lldb/source/Plugins/ABI/CMakeLists.txt
lldb/source/Plugin
kasper81 updated this revision to Diff 455977.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132510/new/
https://reviews.llvm.org/D132510
Files:
lldb/source/Plugins/ABI/CMakeLists.txt
lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp
lldb/source
kasper81 added a comment.
@jasonmolenda. @Emmmer, I've addressed your review feedback. Could you please
take another look?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132510/new/
https://reviews.llvm.org/D132510
kasper81 updated this revision to Diff 455371.
kasper81 added a comment.
Added a `FIXME` comment in `CreateDefaultUnwindPlan`, based on advice from
@jasonmolenda.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132510/new/
https://reviews.llvm.org/D
kasper81 added inline comments.
Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:38
+
+enum riscv_dwarf_regnums {
+ dwarf_x0 = 0,
Emmmer wrote:
> This enum can be included from `lldb/source/Utility/RISCV_DWARF_Registers.h`
Thanks, I have reused that h
kasper81 updated this revision to Diff 455177.
kasper81 marked an inline comment as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132510/new/
https://reviews.llvm.org/D132510
Files:
lldb/source/Plugins/ABI/CMakeLists.txt
lldb/source/Plugin
kasper81 updated this revision to Diff 455176.
kasper81 added a comment.
Reuse existing dwarf enum.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132510/new/
https://reviews.llvm.org/D132510
Files:
lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp
kasper81 added a comment.
@jasonmolenda the problem with original review is that we were waiting for the
wholesale support for 3.5 years, and it rendered into an impossible task for
the author. I don't want to make this one "all or none" kind of a deal as well.
This patch is n neither bringing
kasper81 created this revision.
kasper81 added reviewers: DavidSpickett, Emmmer, tzb99.
kasper81 added a project: LLDB.
Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck,
evandro, luismarques, apazos, sameer.abuasal, JDevlieghere, s.egerton, Jim,
benna, psnobl, jocewei, P
kasper81 added a comment.
Hi Luis, are you planning on adding plugin architecture support (in
`lldb/source/Plugins/Architecture`) as part of this work?
Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp:1152
+ triple.getArch() == llvm::Triple::riscv6
kasper81 added a comment.
> I think the main blocker for merging was testing. If it helps, I now have the
> RISC-V server in my hands and I should be able to set up a buildbot soon.
It certainly will help. Thank you! :)
On July 27, 13.x will be branched out. If we can squeeze it in that would b
kasper81 added a comment.
Hi, I have my fingers crossed since this request was opened in 2019. It seems
like it compiles and usable to certain degree. Can this patch be merged and
included in llvm 13 as initial riscv64 support? We can then improve it
subsequently if bugs show up. Otherwise it w
17 matches
Mail list logo
