https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/140599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/140599
None
>From 8bf781af04e046076de1e5d6ebcfcf1f508be211 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 19 May 2025 14:26:36 -0400
Subject: [PATCH 1/2] [lldb][nfc]Make test "xfail" on windows
---
lldb/test/Sh
oontvoo wrote:
fixing now. thanks!
https://github.com/llvm/llvm-project/pull/140588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/140588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/140588
None
>From 8bf781af04e046076de1e5d6ebcfcf1f508be211 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 19 May 2025 14:26:36 -0400
Subject: [PATCH] [lldb][nfc]Make test "xfail" on windows
---
lldb/test/Shell/
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/140585
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/140585
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/140585
…tion doesn't work properly
>From a694c9b4a249ec541115cebdd9a88e75ce8aceb7 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 19 May 2025 13:38:37 -0400
Subject: [PATCH] [lldb][nfc]Temporarily disable test on
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
>From 5746e997eea55c05cbbb63ad6f78ca225c9ac855 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 7 May 2025 21:37:31 -0400
Subject: [PATCH 01/11] [lldb]Make `list` command work with headers when
possible.
-
@@ -1113,17 +1123,25 @@ class CommandObjectSourceList : public
CommandObjectParsed {
ModuleSpec module_spec(module_file_spec);
matching_modules.Clear();
target.GetImages().FindModules(module_spec, matching_modules);
-num_matches
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
>From 5746e997eea55c05cbbb63ad6f78ca225c9ac855 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 7 May 2025 21:37:31 -0400
Subject: [PATCH 01/11] [lldb]Make `list` command work with headers when
possible.
-
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
@@ -714,6 +714,8 @@ uint32_t ModuleList::ResolveSymbolContextsForFileSpec(
const FileSpec &file_spec, uint32_t line, bool check_inlines,
SymbolContextItem resolve_scope, SymbolContextList &sc_list) const {
std::lock_guard guard(m_modules_mutex);
+ // If we're looking
oontvoo wrote:
@labath Hi, do you have any other comment on this? thanks!
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
oontvoo wrote:
> Maybe we should use line 1 than as that's the first real line number?
done! thanks!
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
>From 5746e997eea55c05cbbb63ad6f78ca225c9ac855 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 7 May 2025 21:37:31 -0400
Subject: [PATCH 1/8] [lldb]Make `list` command work with headers when
possible.
---
@@ -1114,15 +1115,15 @@ class CommandObjectSourceList : public
CommandObjectParsed {
matching_modules.Clear();
target.GetImages().FindModules(module_spec, matching_modules);
num_matches += matching_modules.ResolveSymbolContextForFilePath(
-
@@ -1170,10 +1171,41 @@ class CommandObjectSourceList : public
CommandObjectParsed {
if (m_options.num_lines == 0)
m_options.num_lines = 10;
const uint32_t column = 0;
+
+ // Headers aren't always in the DWARF but if they have
+
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
oontvoo wrote:
> When setting a breakpoint, we pass eSymbolContextLineEntry to the function so
> that it returns a line entry matching the query. In this case, we're not
> really interested in the entire line entry, but I think it should be possible
> the line entry as a carrier for the file
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
@@ -0,0 +1,57 @@
+## Test that `list header.h:` works correctly when header is available.
+##
+# RUN: split-file %s %t
+
+# RUN: %clang_host -g %t/main_with_inlined.cc %t/foo.cc -o
%t/main_with_inlined.out
+# RUN: %clang_host -g %t/main_no_inlined.cc %t/foo.cc -o %t/main_no_inli
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
>From 5746e997eea55c05cbbb63ad6f78ca225c9ac855 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 7 May 2025 21:37:31 -0400
Subject: [PATCH 1/5] [lldb]Make `list` command work with headers when
possible.
---
@@ -0,0 +1,58 @@
+## Test that `list header.h:` works correctly when header is available.
+##
+# REQUIRES: x86
oontvoo wrote:
removed
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb
@@ -1170,10 +1171,41 @@ class CommandObjectSourceList : public
CommandObjectParsed {
if (m_options.num_lines == 0)
m_options.num_lines = 10;
const uint32_t column = 0;
+
+ // Headers aren't always in the DWARF but if they have
+
@@ -1170,8 +1171,37 @@ class CommandObjectSourceList : public
CommandObjectParsed {
if (m_options.num_lines == 0)
m_options.num_lines = 10;
const uint32_t column = 0;
+
+ // Headers aren't always in the DWARF but if they have
+
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
>From 5746e997eea55c05cbbb63ad6f78ca225c9ac855 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 7 May 2025 21:37:31 -0400
Subject: [PATCH 1/4] [lldb]Make `list` command work with headers when
possible.
---
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1170,8 +1171,37 @@ class CommandObjectSourceList : public
CommandObjectParsed {
if (m_options.num_lines == 0)
m_options.num_lines = 10;
const uint32_t column = 0;
+
+ // Headers aren't always in the DWARF but if they have
+
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/129728
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/25] [LLDB][Telemetry] Collect telemetry from client when
allowed.
@@ -156,6 +158,52 @@ uint32_t GetLLDBFrameID(uint64_t dap_frame_id);
lldb::SBEnvironment
GetEnvironmentFromArguments(const llvm::json::Object &arguments);
+/// Helper for sending telemetry to lldb server, if client-telemetry is
enabled.
+#ifndef SWIG
oontvoo
oontvoo wrote:
Thanks all, for the feedback! I'll merge this EOD today, if there's no
objection! :)
https://github.com/llvm/llvm-project/pull/129728
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/25] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/24] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/23] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/135924
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/135924
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/135924
If LLDB crashes, it often helpful to know what the user was doing up to the
point of the crash. Reporting the session-id helps us looking up the relevant
logs.
(Given Telemetry is disabled upstream, this chang
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/135763
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/135763
>From dd74c3abe3a69e6c3cc4b9c22a38ca09997848f7 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 15 Apr 2025 04:42:30 -0400
Subject: [PATCH] [NFC][lldb]Fix stack-use-after-free bugs in exit-callbacks.
---
ll
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/135763
None
>From dd74c3abe3a69e6c3cc4b9c22a38ca09997848f7 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 15 Apr 2025 04:42:30 -0400
Subject: [PATCH] [NFC][lldb]Fix stack-use-after-free bugs in exit-callbacks.
-
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/134922
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/134922
>From ab50c89574613178ba2bf79455eaa8aba0f2205d Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 8 Apr 2025 15:58:10 -0400
Subject: [PATCH 1/2] [LLDB][NFC]Also includes the error in log msg.
---
lldb/include
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/134922
None
>From ab50c89574613178ba2bf79455eaa8aba0f2205d Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 8 Apr 2025 15:58:10 -0400
Subject: [PATCH] [LLDB][NFC]Also includes the error in log msg.
---
lldb/inclu
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct ExecModuleInfo : public LLDBBaseTelemetryInfo {
+ lldb::ModuleSP exec_mod;
+
+ /// The same as the executable-module
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/10] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/132043
>From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Mar 2025 10:44:12 -0400
Subject: [PATCH 1/4] Reapply "[LLDB][Telemetry]Define TargetInfo for
collecting data
oontvoo wrote:
> @labath Hi, friendly ping? thanks
Sorry - ignore this ping, i put the comment on the wrong patch. meant to ping
on https://github.com/llvm/llvm-project/pull/129728
https://github.com/llvm/llvm-project/pull/132043
___
lldb-commits mai
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/132043
>From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Mar 2025 10:44:12 -0400
Subject: [PATCH 1/5] Reapply "[LLDB][Telemetry]Define TargetInfo for
collecting data
@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() {
return sb_target;
}
+void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) {
+ LLDB_INSTRUMENT_VA(this);
+ // Disable client-telemetry for SWIG.
+ // This prevent arbitrary python client
@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() {
return sb_target;
}
+void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) {
+ LLDB_INSTRUMENT_VA(this);
+ // Disable client-telemetry for SWIG.
+ // This prevent arbitrary python client
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/134296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
oontvoo wrote:
I think this is a trivial enough fix - i'm going to just merge it.
https://github.com/llvm/llvm-project/pull/134296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/134296
Details: detailed_command_telemetry (bool) and command_id (int) could already
be freed when the dispatcher's dtor runs. So we should just copy them into the
lambda since they are cheap.
>From 96025fd1183f257c
@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() {
return sb_target;
}
+void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) {
+ LLDB_INSTRUMENT_VA(this);
+ // Disable client-telemetry for SWIG.
+ // This prevent arbitrary python client
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/133785
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo approved this pull request.
https://github.com/llvm/llvm-project/pull/134078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/133785
Details: The ScopedDiscpatcher's dtor may reference these fields so we need the
fields' dtor to be be invoked *after* the dispatcher's.
>From 55d20dc85389bdeacf806b18ff132030e2626d9a Mon Sep 17 00:00:00 2001
Fr
https://github.com/oontvoo approved this pull request.
https://github.com/llvm/llvm-project/pull/133662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -88,6 +88,9 @@ class UUID {
DecodeUUIDBytesFromString(llvm::StringRef str,
llvm::SmallVectorImpl &uuid_bytes);
+ /// Generate a random UUID.
oontvoo wrote:
s/Generate/Generates ? (to be consistent with the other comments)
ht
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/132043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/23] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/22] [LLDB][Telemetry] Collect telemetry from client when
allowed.
@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() {
return sb_target;
}
+void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) {
+ LLDB_INSTRUMENT_VA(this);
+ // Disable client-telemetry for SWIG.
+ // This prevent arbitrary python client
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/21] [LLDB][Telemetry] Collect telemetry from client when
allowed.
oontvoo wrote:
All checks ✅ passed so I'm going to merge this
https://github.com/llvm/llvm-project/pull/132043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/20] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/19] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/18] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/18] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/17] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/15] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/16] [LLDB][Telemetry] Collect telemetry from client when
allowed.
oontvoo wrote:
> It might be a good idea to include something like "client_name" field so you
> can differentiate (assuming people don't lie) messages coming from lldb-dap
> from other lldb "clients".
done
https://github.com/llvm/llvm-project/pull/129728
__
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/14] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/13] [LLDB][Telemetry] Collect telemetry from client when
allowed.
oontvoo wrote:
> I'm not really sure what to think about this. You call it "client telemetry",
> which sounds generic, but the implementation (mainly, the "request" field)
> sounds very specific to lldb-dap (not every lldb "client" needs to have a
> "request", or even if it has, the term "requ
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/12] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/11] [LLDB][Telemetry] Collect telemetry from client when
allowed.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/6] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
@@ -119,6 +125,53 @@ llvm::Error TelemetryManager::preDispatch(TelemetryInfo
*entry) {
return llvm::Error::success();
}
+void TelemetryManager::DispatchClientTelemetry(
+const lldb_private::StructuredDataImpl &entry, Debugger *debugger) {
+ if (!m_config->enable_client
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/9] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/8] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/7] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
oontvoo wrote:
@labath @JDevlieghere ping? :bell: Thanks!
https://github.com/llvm/llvm-project/pull/129728
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/5] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/4] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/3] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/132043
>From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Mar 2025 10:44:12 -0400
Subject: [PATCH 1/7] Reapply "[LLDB][Telemetry]Define TargetInfo for
collecting data
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/132043
>From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Mar 2025 10:44:12 -0400
Subject: [PATCH 1/7] Reapply "[LLDB][Telemetry]Define TargetInfo for
collecting data
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/132043
>From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Mar 2025 10:44:12 -0400
Subject: [PATCH 1/6] Reapply "[LLDB][Telemetry]Define TargetInfo for
collecting data
@@ -1064,6 +1065,29 @@ const char *Process::GetExitDescription() {
bool Process::SetExitStatus(int status, llvm::StringRef exit_string) {
// Use a mutex to protect setting the exit status.
std::lock_guard guard(m_exit_status_mutex);
+ telemetry::ScopedDispatcher helper;
+
oontvoo wrote:
@labath Hi, friendly ping? thanks
https://github.com/llvm/llvm-project/pull/132043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/3] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
1 - 100 of 474 matches
Mail list logo
