[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

VladimirMakaev added a comment. Thanks @DavidSpickett for fixing this. I did not intend to use that type. Any number of that size would work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149213/new/ https://reviews.llvm.org/D149213 _

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

VladimirMakaev added a comment. I don't have commit access to the repo. Since this was accepted can somebody commit this to the repo? CC @clayborg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149213/new/ https://reviews.llvm.org/D149213 ___

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

VladimirMakaev marked an inline comment as done. VladimirMakaev added a comment. In D149213#4520309 , @tom.tromey wrote: >> Apart from just implementing type system itself (which is much bigger scope >> than this change) there are other non-trivial issu

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

VladimirMakaev added a comment. I've reached out to Rust wg-debugging for additional feedback (https://rust-lang.zulipchat.com/#narrow/stream/317568-t-compiler.2Fwg-debugging/topic/Feedback.20on.20DW_TAG_variant_part.20support.20in.20LLDB) There a couple of edge cases (when using u128 enums) tha

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

VladimirMakaev updated this revision to Diff 540251. VladimirMakaev added a comment. Herald added a reviewer: sscalpone. Rebased on master (this diff was quite a bit old) Addressed review comments - renamed method to ParseRustVariantPart - added CU check - added a good bunch of test covering case

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

VladimirMakaev added a comment. In D149213#4491594 , @bulbazord wrote: > I'm curious to know why you don't try and implement some kind of > `TypeSystemRust`? I assume it's going to be a lengthy process, but eventually > you (or somebody else) is going t

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

VladimirMakaev created this revision. VladimirMakaev added reviewers: clayborg, ayermolo, Michael137. VladimirMakaev added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. Herald added a project: All. VladimirMakaev requested review of this revision. Herald