[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill abandoned this revision. Endill added a comment. Moved to GitHub: https://github.com/llvm/llvm-project/pull/66879 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.llvm.org/D156774 ___

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill added a comment. @Michael137 I moved this over to GitHub , and I need your help there writing the unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill added a comment. In D156774#4644623 , @Michael137 wrote: > Also, I assume the extra changes to make the PointerIntPair formatter work > will be in a follow-up patch? Yes. That work is not finished yet. Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill added a comment. Ping @Michael137 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.llvm.org/D156774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill added a comment. In D156774#4601830 , @Michael137 wrote: > I think you may want to use `GetCompleteQualType` before iterating the > DeclContext; that's how some of the other TypeSystemClang APIs do it. That > will make sure we complete the type

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill added a comment. In D156774#4601736 , @Michael137 wrote: > What were your lldb commands when you tested this? `script import lldb; frame = lldb.thread.GetFrameAtIndex(0); print(frame.variables[0].type.GetNumberOfMemberEnums())` > LLDB currently

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill updated this revision to Diff 551811. Endill added a comment. Follow the `DW_TAG_subprogram` approach for `DW_TAG_enum_type`, `DW_TAG_structure_type`, and `DW_TAG_union_type`: rely on `ParseType()` called afterwards instead of eagerly parsing them. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill added a comment. I tested this patch together with the following new code: uint32_t TypeSystemClang::GetNumMemberEnums(lldb::opaque_compiler_type_t type) { using EnumIt = clang::DeclContext::specific_decl_iterator; if (!type) return 0; clang::QualType qual_type = Remov

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill added a comment. In D156774#4572947 , @Michael137 wrote: > Are you still planning on moving this forward? Otherwise I could commandeer > the revision to get this in. I do think it's a useful bug to address I do. Locally I've been preparing addit

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Endill added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW_TAG_enumeration_type: +{ Michael137 wrote: > Michael137 wrote: > > Michael137 wrote: > > > Michael137 wrote: > > > > At first glance thi

[Lldb-commits] [PATCH] D156774: [WIP][lldb] Parse enums while parsing a type

Endill added a comment. This patch is intentionally aimed squarely at enums. But I'd like lldb to address the issue of accessing compile-time constants holistically. Or at least agree on a path forward for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D156774: [WIP][lldb] Parse enums while parsing a type

Endill added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3043 + SymbolContextScope *scope; + scope = parent_die.GetDWARF()->GetObjectFile()->GetModule().get(); + assert(scope); I've used https://github

[Lldb-commits] [PATCH] D156774: [WIP][lldb] Parse enums while parsing a type

Endill created this revision. Endill added a reviewer: JDevlieghere. Endill added a project: LLDB. Herald added a reviewer: shafik. Herald added a project: All. Endill requested review of this revision. Herald added a subscriber: lldb-commits. Fixes #64291

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

Endill added a comment. In D140996#4189452 , @bolshakov-a wrote: > Sorry! It's my first time using Phabricator. Maybe, the problem occurs > because I've solved the issue with Arcanist just by means of copy-pasting > patches into "Update Diff" Web GUI f