This revision was automatically updated to reflect the committed changes.
Closed by commit rL287848: Fix a comparison of integers of different signs
warning. (authored by ttsugrii).
Changed prior to commit:
https://reviews.llvm.org/D27081?vs=79173&id=79180#toc
Repository:
rL LLVM
https://re
Author: ttsugrii
Date: Wed Nov 23 19:34:43 2016
New Revision: 287848
URL: http://llvm.org/viewvc/llvm-project?rev=287848&view=rev
Log:
Fix a comparison of integers of different signs warning.
source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:403:21:
warning: comparison
Cool, thank you Zachary!
From: Zachary Turner
Date: Wednesday, August 31, 2016 at 1:11 PM
To: Taras Tsugrii , via lldb-commits
Subject: Re: [Lldb-commits] [LLDB] Please commit accepted changes.
These should be in. I committed all the unused variable fixes in one patch,
and someone had
Awesome, thank you Zachary!
From: Zachary Turner
Date: Wednesday, August 31, 2016 at 10:43 AM
To: Taras Tsugrii , via lldb-commits
Subject: Re: [Lldb-commits] [LLDB] Please commit accepted changes.
I will commit these today.
On Wed, Aug 31, 2016 at 10:41 AM Taras Tsugrii via lldb-commits
Can someone please commit https://reviews.llvm.org/D23950,
https://reviews.llvm.org/D23951, https://reviews.llvm.org/D23952,
https://reviews.llvm.org/D23948 and https://reviews.llvm.org/D24064 to lldb
repo? All differentials are approved.
Thank you,
Taras
___
Thanks for the review Zachary, but I don’t have commit privileges, so I hope
that someone can commit the change for me.
From: Zachary Turner
Date: Tuesday, August 30, 2016 at 6:52 PM
To: "reviews+d24064+public+13175c1cba5ef...@reviews.llvm.org"
, Taras Tsugrii
Cc: "lldb-commits@lists.llvm.org
wttsugrii created this revision.
wttsugrii added a reviewer: zturner.
wttsugrii added a subscriber: lldb-commits.
https://github.com/llvm-mirror/lldb/commit/e80f43fd78fa0fbc04d2d59b5713acb5d06c8308
greatly improved an API, but missed one more occurence of legacy usage.
This leads to:
if (extrac
wttsugrii created this revision.
wttsugrii added a reviewer: jingham.
wttsugrii added a subscriber: lldb-commits.
frame_zero_id local variable is not used and can be safely removed.
https://reviews.llvm.org/D23952
Files:
source/Target/ThreadPlanStepOut.cpp
Index: source/Target/ThreadPlanStepO
wttsugrii created this revision.
wttsugrii added a reviewer: granata.enrico.
wttsugrii added a subscriber: lldb-commits.
any_found variable is not used anywhere and can be safely removed.
https://reviews.llvm.org/D23951
Files:
source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRunti
wttsugrii created this revision.
wttsugrii added a reviewer: granata.enrico.
wttsugrii added a subscriber: lldb-commits.
type variable is not used and can be safely removed.
https://reviews.llvm.org/D23950
Files:
source/DataFormatters/TypeCategoryMap.cpp
Index: source/DataFormatters/TypeCateg
wttsugrii created this revision.
wttsugrii added a reviewer: hhellyer.
wttsugrii added a subscriber: lldb-commits.
range_base variable is not used anywhere, so can be
safely removed.
https://reviews.llvm.org/D23948
Files:
source/Target/Process.cpp
Index: source/Target/Process.cpp
wttsugrii added a comment.
Thanks for the review @clayborg. Could someone please commit this patch to lldb
repo?
https://reviews.llvm.org/D23825
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Summary:
Moving a temporary object prevents copy elision, which is exactly
what clang points out by warning about this pattern.
The fix is simply removal of std::move applied to temporary objects.
Differential Revision: https://reviews.llvm.org/D23825
---
tools/debugserver/source/JSON.cpp | 20 +
Summary:
Moving a temporary object prevents copy elision, which is exactly
what clang points out by warning about this pattern.
The fix is simply removal of std::move applied to temporary objects.
Differential Revision: https://reviews.llvm.org/D23825
---
tools/debugserver/source/JSON.cpp | 20 +
14 matches
Mail list logo
