[Lldb-commits] [lldb] [lldb] Don't query the platform for each load command (PR #140853)

2025-05-20 Thread Tal Keren via lldb-commits
https://github.com/talkeren created https://github.com/llvm/llvm-project/pull/140853 This change remove the call to GetPlatform from GetDeploymentInfo and instead pass it as an argument,so GetPlatform will be called only once for all the load commands. The reason is that if we try to query the p

[Lldb-commits] [lldb] [lldb] Properly cache the result of MachProcess::GetPlatform (PR #140611)

2025-05-20 Thread Tal Keren via lldb-commits
talkeren wrote: Closing it following the discussion in the issue - I made a new PR that fixes it differently without change the current behaviour. https://github.com/llvm/llvm-project/pull/140611 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [lldb] Properly cache the result of MachProcess::GetPlatform (PR #140611)

2025-05-20 Thread Tal Keren via lldb-commits
https://github.com/talkeren closed https://github.com/llvm/llvm-project/pull/140611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Properly cache the result of MachProcess::GetPlatform (PR #140611)

2025-05-19 Thread Tal Keren via lldb-commits
https://github.com/talkeren updated https://github.com/llvm/llvm-project/pull/140611 >From c385e9780e980865461f877c76acaa417b4d736c Mon Sep 17 00:00:00 2001 From: Tal Keren Date: Mon, 19 May 2025 23:15:10 +0300 Subject: [PATCH 1/2] [lldb] Properly cache the result of MachProcess::GetPlatform #

[Lldb-commits] [lldb] [lldb] Properly cache the result of MachProcess::GetPlatform (PR #140611)

2025-05-19 Thread Tal Keren via lldb-commits
https://github.com/talkeren edited https://github.com/llvm/llvm-project/pull/140611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Properly cache the result of MachProcess::GetPlatform (PR #140611)

2025-05-19 Thread Tal Keren via lldb-commits
https://github.com/talkeren edited https://github.com/llvm/llvm-project/pull/140611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Properly cache the result of MachProcess::GetPlatform #140610 (PR #140611)

2025-05-19 Thread Tal Keren via lldb-commits
https://github.com/talkeren updated https://github.com/llvm/llvm-project/pull/140611 >From c385e9780e980865461f877c76acaa417b4d736c Mon Sep 17 00:00:00 2001 From: Tal Keren Date: Mon, 19 May 2025 23:15:10 +0300 Subject: [PATCH] [lldb] Properly cache the result of MachProcess::GetPlatform #1406

[Lldb-commits] [lldb] [lldb] Properly cache the result of MachProcess::GetPlatform #140610 (PR #140611)

2025-05-19 Thread Tal Keren via lldb-commits
https://github.com/talkeren updated https://github.com/llvm/llvm-project/pull/140611 >From 7ccef56ba9d82fae7901bc39ef648b7be6bba473 Mon Sep 17 00:00:00 2001 From: Tal Keren Date: Mon, 19 May 2025 23:15:10 +0300 Subject: [PATCH] [lldb] Properly cache the result of MachProcess::GetPlatform #1406

[Lldb-commits] [lldb] [lldb] Properly cache the result of MachProcess::GetPlatform #140610 (PR #140611)

2025-05-19 Thread Tal Keren via lldb-commits
https://github.com/talkeren created https://github.com/llvm/llvm-project/pull/140611 If `MachProcess::GetProcessPlatformViaDYLDSPI` fails and return 0, we don't want to call it everytime as it won't change the result. So use std::optional to cache wether we already calculated the value. >From 7