[Lldb-commits] [PATCH] D149224: Fix an off-by-one error with armv7 mach-o corefile register contexts (LC_THREADs)

fixathon accepted this revision. fixathon added a comment. This revision is now accepted and ready to land. Great catch. Thank you for finding and fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149224/new/ https://reviews.llvm.org/D1492

[Lldb-commits] [PATCH] D132841: [lldb] Use the NativeSock type instead of plain 'int'

fixathon accepted this revision. fixathon added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132841/new/ https://reviews.llvm.org/D132841 __

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a197772ee30: [LLDB][NFC] Suppress spurious static inspection warnings (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131998/new/ htt

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG163319070947: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread (authored by fixathon). Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

fixathon updated this revision to Diff 453392. fixathon marked an inline comment as done. fixathon added a comment. This revision is now accepted and ready to land. Back out changes for checking the return val of the function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

fixathon planned changes to this revision. fixathon marked 2 inline comments as done. fixathon added a comment. Planning to undo checking the return value of FindLineEntryByAddress() since it's causing an issue on some platform, and re-evaluate the underlying issue. Comment at

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

fixathon updated this revision to Diff 453348. fixathon added a comment. Change to C++ style comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131998/new/ https://reviews.llvm.org/D131998 Files: lldb/include/lldb/Core/ThreadSafeValue.h ll

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

fixathon reopened this revision. fixathon marked an inline comment as done. fixathon added a comment. This revision is now accepted and ready to land. Thank you, @stella.stamenova , will investigate. Added comments with the initial findings Comment at: lldb/source/Commands/Com

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

fixathon added a comment. In D131998#3727664 , @clayborg wrote: > Can we use C++ comments instead of C comments? We can, and I'll make the change. Do you think it would be a good idea to keep the coverity annotations only as C-style comments (comments f

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

fixathon created this revision. fixathon added a reviewer: clayborg. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, a

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

This revision was automatically updated to reflect the committed changes. fixathon marked 3 inline comments as done. Closed by commit rG461b41015942: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fe72001e8d6: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon updated this revision to Diff 453109. fixathon added a comment. Address comments about passing-by-ref for perf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/ https://reviews.llvm.org/D131900 Files: lldb/source/Plugins/Instrum

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon published this revision for review. fixathon added inline comments. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. =

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon marked an inline comment as done. fixathon added a comment. All pending suggestions have been resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/ https://reviews.llvm.org/D131900

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon updated this revision to Diff 452884. fixathon added a comment. Address the style issue by removing "using", and specifying std:: namespace explicitly. Note, lldb style guide does not appear to prohibit the import of individual members from another namespace in a non-header file. Never

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon updated this revision to Diff 452809. fixathon marked an inline comment as done. fixathon added a comment. Convert raw pointers to shared_ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/ https://reviews.llvm.org/D131900 Files

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon planned changes to this revision. fixathon marked 2 inline comments as done. fixathon added a comment. I am going to clean up the code in the entire file where **raw pointers** should be **shared_ptr** (because they get cast to shared_ptr anyways). Also planning to convert the **naked n

[Lldb-commits] [PATCH] D131850: [LLDB][NFC] Reliability Fixes for FormatEntity

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa5124327a01: [LLDB][NFC] Reliability Fixes for FormatEntity (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131850/new/ https://revie

[Lldb-commits] [PATCH] D131795: [LLDB] Fix the 'default' switch case in GetCompatibleArchs()

fixathon planned changes to this revision. fixathon added inline comments. Comment at: lldb/test/API/functionalities/gdb_remote_client/TestPlatformMacOSX.py:22 def qHostInfo(self): -return "cputype:16777223;cpusubtype:2;ostype:%s;vendor:apple;os_version:10.

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon published this revision for review. fixathon added inline comments. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. =

[Lldb-commits] [PATCH] D131850: [LLDB][NFC] Reliability Fixes for FormatEntity

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon published this revision for review. fixathon added inline comments. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. =

[Lldb-commits] [PATCH] D131795: [LLDB] Fix the 'default' switch case in GetCompatibleArchs()

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere. Herald added a subscriber: kristof.beyls. Herald added a project: All. fixathon edited the summary of this revision. fixathon published this revision for review. fixathon added a comment. Herald added a project: LLDB.

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

This revision was automatically updated to reflect the committed changes. fixathon marked an inline comment as done. Closed by commit rG3934a31cfa02: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D131743: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp (part 2)

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2cb417ed9a6: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp (part 2) (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131743/new

[Lldb-commits] [PATCH] D131743: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp (part 2)

fixathon added a comment. Herald added a subscriber: JDevlieghere. Implemented most fixes suggested in https://reviews.llvm.org/D131554 post-push. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131743/new/ https://reviews.llvm.org/D131743 _

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon marked 3 inline comments as done. fixathon added a comment. Replied to comments, and adding the suggested modifications in https://reviews.llvm.org/D131743 because this diff has already been pushed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D131743: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp (part 2)

fixathon created this revision. fixathon added a reviewer: clayborg. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add the fixes suggested post-push in D131554 Rep

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

fixathon marked 3 inline comments as done. fixathon added a comment. Addressed the comments. Will deal with the signed/unsigned issue in a separate diff if still needed. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2582 surface.MoveCursor(0, 1); surface.Horizo

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

This revision was automatically updated to reflect the committed changes. Closed by commit rG256ba7738ea8: [LLDB][NFC] Fix the style issue in TCPSocket (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131543/new/ https://reviews

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

fixathon updated this revision to Diff 451957. fixathon added a comment. Address review comments about the signed/unsigned issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131615/new/ https://reviews.llvm.org/D131615 Files: lldb/source/Core/I

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

fixathon updated this revision to Diff 451952. fixathon added a comment. Fix the style in the entire file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131543/new/ https://reviews.llvm.org/D131543 Files: lldb/source/Host/common/TCPSocket.cpp

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon marked 2 inline comments as done. fixathon added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:540 +for (uint32_t i = 0; + count > 0 && count <= sizeof(gpr.r) && i < count - 1; ++i) { gpr.r[i] = data

[Lldb-commits] [PATCH] D131663: [LLDB][ARM] Extend testing for vpush emulation

fixathon accepted this revision. fixathon added a comment. This revision is now accepted and ready to land. Thank you for adding this test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131663/new/ https://reviews.llvm.org/D131663

[Lldb-commits] [PATCH] D131658: [LLDB] Fix out-of-bounds memory access in EmulationStateArm

This revision was automatically updated to reflect the committed changes. Closed by commit rGab6a0823afc7: [LLDB] Fix out-of-bounds memory access in EmulationStateArm (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131658/new/

[Lldb-commits] [PATCH] D131658: [LLDB] Fix out-of-bounds memory access in EmulationStateArm

fixathon added a comment. Thank you. Yes, this does need a unit test Comment at: lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp:54 uint32_t idx = i - dwarf_d0; - if (i < 16) { + if (idx < 16) { m_vfp_regs.s_regs[idx * 2] = (uint32_t)value; -

[Lldb-commits] [PATCH] D131658: [LLDB] Fix out-of-bounds memory access in EmulationStateArm

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a subscriber: kristof.beyls. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. F

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

fixathon added a comment. Responded to comments Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:391-394 + uint32_t GetMaxX() const { return getmaxx(m_window); } + uint32_t GetMaxY() const { return getmaxy(m_window); } + uint32_t GetWidth() const { return GetMaxX(); } +

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

fixathon added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:391-394 + uint32_t GetMaxX() const { return getmaxx(m_window); } + uint32_t GetMaxY() const { return getmaxy(m_window); } + uint32_t GetWidth() const { return GetMaxX(); } + uint32_t GetHeight

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

fixathon added a comment. Added a comment about a failing test. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561 + default: +LLVM_FALLTHROUGH; + case ArchSpec::eCore_arm_arm64: { JDevlieghere wrote: > fixathon wrote: > > This will de

[Lldb-commits] [PATCH] D131613: [LLDB][NFC] Clean up dead code

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c21ab8b32d: [LLDB][NFC] Clean up dead code (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131613/new/ https://reviews.llvm.org/D131

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. fixathon marked 2 inline comments as done. Closed by commit rGdb9322b2066c: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp (authored by fixathon). Repository:

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon updated this revision to Diff 451652. fixathon marked 4 inline comments as done. fixathon added a comment. Fix some nits in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131554/new/ https://reviews.llvm.org/D131554 Files: lldb/

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon updated this revision to Diff 451629. fixathon added a comment. Addressing reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131554/new/ https://reviews.llvm.org/D131554 Files: lldb/source/Plugins/ObjectFile/Mach-O/ObjectF

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:540 +for (uint32_t i = 0; + count > 0 && count <= sizeof(gpr.r) && i < count - 1; ++i) { gpr.r[i] = data.GetU32(&offset); jasonmol

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131554/new/ https://reviews.llvm.org/D131554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

fixathon added a comment. I'd prefer to not reformat the pre-existing 13 instances of (-1 ==) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131543/new/ https://reviews.llvm.org/D131543 ___ lldb-commits m

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - checking retval of function calls - signe

[Lldb-commits] [PATCH] D131613: [LLDB][NFC] Clean up dead code

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Remove unreachable code that will never exe

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon added a comment. Added inline comments to clarify the fixes. Specifically need feedback on the null-termination of strings since it seems possible this may not be needed based on existing comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Static code inspection guided fixes for the

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

fixathon created this revision. fixathon added a reviewer: jingham. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixing a small style nit described in D131294 Rep

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

fixathon added a comment. Commented on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131294/new/ https://reviews.llvm.org/D131294 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

fixathon added a comment. In D131294#3707154 , @jingham wrote: > We don't use the constant first so you don't accidentally use "=" rather than > "==" convention anywhere else in lldb, so it looks weird here. Good feedback. I'll switch that around. Rep

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon abandoned this revision. fixathon marked an inline comment as done. fixathon added a comment. closing as already patched. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131244/new/ https://reviews.llvm.org/D131244 _

[Lldb-commits] [PATCH] D131312: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. fixathon marked an inline comment as done. Closed by commit rG06ff46d2d77f: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry() (

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon marked an inline comment as done. fixathon added inline comments. Comment at: lldb/source/Plugins/Process/Utility/ARMUtils.h:49 shift_t = SRType_Invalid; return UINT32_MAX; } DavidSpickett wrote: > This is now dead code? This will execute for the

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa4977f2e135: [LLDB][NFC] Reliability fixes to TCPSocket code (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131294/new/ https://revi

[Lldb-commits] [PATCH] D131312: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Current application of bitwise-OR to a bina

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

fixathon added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:640 + } + return {}; +} JDevlieghere wrote: > fixathon wrote: > > JDevlieghere wrote: > > > fixathon wrote: > > > > Could we delete this unreachable return statem

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon updated this revision to Diff 450466. fixathon added a comment. Code update to address the comments Differential Revision: https://reviews.llvm.org/D131244 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131244/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon updated this revision to Diff 450460. fixathon added a comment. Addressed comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131244/new/ https://reviews.llvm.org/D131244 Files: lldb/source/Plugins/Process/Utility/ARMUtils.h Index: lldb/source/Plugins/Process/Utility/AR

[Lldb-commits] [PATCH] D131308: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Looks like a typo from the past code changes. Diff

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Patch the following issues found by static code inspectio

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

fixathon added a comment. Added comments Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:640 + } + return {}; +} JDevlieghere wrote: > fixathon wrote: > > Could we delete this unreachable return statement? It's tripping up static > > code

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

fixathon added a comment. Herald added a project: All. Added some follow up comments Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561 + default: +LLVM_FALLTHROUGH; + case ArchSpec::eCore_arm_arm64: { This will default to the ArchSpec

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon added a comment. Added in-code comments with details Comment at: lldb/source/Plugins/Process/Utility/ARMUtils.h:48-49 } shift_t = SRType_Invalid; return UINT32_MAX; } These lines were unreachable prior to the fix due to the **default** label

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Looks like a typo from the past code changes. Repositor

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

fixathon added a comment. In D130939#3698800 , @DavidSpickett wrote: > Thanks for these fixes! I'll fix up the 0 packets sent behaviour when I find > some spare time. Sounds great. Thanks for the review and suggestions! Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a906b70c11e: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div… (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

fixathon updated this revision to Diff 449736. fixathon edited the summary of this revision. fixathon added a comment. Address the review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130939/new/ https://reviews.llvm.org/D130939 Files:

[Lldb-commits] [PATCH] D131029: [NFC] Remove no-op code, duplicated, with multiple confusing comments, from x86AssemblyInspectionEngine::jmp_to_reg_p

fixathon accepted this revision. fixathon added a comment. This revision is now accepted and ready to land. LGTM Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131029/new/ https://reviews.llvm.org/D131029 ___

[Lldb-commits] [PATCH] D131013: [LLDB][NFC] Fix incorrect return status Some functions always return 'false' for both success and fail return paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4502e3531f62: [LLDB][NFC] Fix incorrect return status Some functions always return 'false'… (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

fixathon added a comment. The function has a void return type, with no way to communicate its success/failure status. Perhaps the right thing to do is to mod the function to return error Status, in addition to adding the assert (or some runtime check that works for all build flavors)? ==

[Lldb-commits] [PATCH] D130972: [LLDB][NFC] Fix LLDB_WATCH_TYPE_IS_VALID macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a569274cb3b: [LLDB][NFC] Fix LLDB_WATCH_TYPE_IS_VALID macro (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130972/new/ https://revie

[Lldb-commits] [PATCH] D131013: [LLDB][NFC] Fix incorrect return status Some functions always return 'false' for both success and fail return paths.

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere, DavidSpickett. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo ht

[Lldb-commits] [PATCH] D130929: [LLDB][Reliability] Remove dead code.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd735307aa2be: [LLDB][Reliability] Remove dead code. (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130929/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D130972: [LLDB][NFC] Fix LLDB_WATCH_TYPE_IS_VALID macro

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB_WATCH_TYPE_IS_VALID would always return true when v

[Lldb-commits] [PATCH] D62764: Detect x86 mid-function epilogues that end in a jump

fixathon added inline comments. Comment at: lldb/trunk/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp:707-713 + if (second_byte_sans_reg == 0x24) +return true; + + // use SIB byte + // ff 24 fe jmpq *(%rsi,%rdi,8) + if (second_byte_sans_reg == 0x24)

[Lldb-commits] [PATCH] D62764: Detect x86 mid-function epilogues that end in a jump

fixathon added a comment. Herald added subscribers: JDevlieghere, pengfei. Herald added a project: All. flagging suspicious duplicate code Comment at: lldb/trunk/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp:707-713 + if (second_byte_sans_reg == 0x24) +

[Lldb-commits] [PATCH] D130937: [LLDB][NFC][Correctness] Fix bad null check

This revision was automatically updated to reflect the committed changes. Closed by commit rG30b391119737: [LLDB][NFC][Correctness] Fix bad null check (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130937/new/ https://reviews.

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

fixathon created this revision. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130939 Files: lldb/source/Plugins/Process/gdb-remote/G

[Lldb-commits] [PATCH] D130937: [LLDB][NFC][Correctness] Fix bad null check

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere. Herald added a subscriber: emaste. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix incorrect null-ch

[Lldb-commits] [PATCH] D130929: [LLDB][Reliability] Remove dead code.

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Remove redundant code that can never execute due to prec

[Lldb-commits] [PATCH] D130795: [LLDB][NFC][Reliability] Fixes for int overflow and uninitialized state

fixathon marked 2 inline comments as done. fixathon added inline comments. Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_x86.cpp:67 + return static_cast(size == 8 ? 0x2 : size - 1) + << (18 + 4 * wp_index); } shafik wrote:

[Lldb-commits] [PATCH] D130802: [LLDB][NFC] Fix memory/resource leak in FifoFiles

fixathon added inline comments. Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:53-54 Expected FifoFileIO::ReadJSON(std::chrono::milliseconds timeout) { // We use a pointer for this future, because otherwise its normal destructor // would wait for the getline to end, rend

[Lldb-commits] [PATCH] D130802: [LLDB][NFC] Fix memory/resource leak in FifoFiles

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The original code is creating a future object on the hea

[Lldb-commits] [PATCH] D130795: [LLDB][NFC][Reliability] Fixes for int overflow and uninitialized state

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7c961cc6ba7: [LLDB][NFC][Reliability] Fixes for int overflow and uninitialized state (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D130795: [LLDB][NFC][Reliability] Fixes for int overflow and uninitialized state

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere. Herald added a reviewer: shafik. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixing potential int ov

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e6b6522296e: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName() (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon marked an inline comment as done. fixathon added a comment. Address the review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 ___ lldb-commit

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon updated this revision to Diff 448463. fixathon added a comment. Address the review comments and inline the tests into an existing test function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 Fil

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon updated this revision to Diff 448457. fixathon added a comment. Fix duplicate name of the test function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 Files: lldb/source/API/SBBreakpointLocat

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon updated this revision to Diff 448453. fixathon added a comment. Added unit tests, and verified the fix is working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 Files: lldb/source/API/SBBreak

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon planned changes to this revision. fixathon added a comment. Working on adding unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 ___ lldb-commi

[Lldb-commits] [PATCH] D130655: [LLDB][NFC] Fix possible resource leak

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cfcbe295a31: [LLDB][NFC] Fix possible resource leak (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130655/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, labath. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Seems like a typo in the function that never returns a significant valu

[Lldb-commits] [PATCH] D130655: [LLDB][NFC] Fix possible resource leak

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, alvinhochun. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. SymbolVendorPECOFF object is leaked on early return at line 110

[Lldb-commits] [PATCH] D130602: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 3

This revision was automatically updated to reflect the committed changes. Closed by commit rG24301569f080: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 3 (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D130602: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 3

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, JDevlieghere, jingham. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Improve LLDB reliability by fixing the following "uninit

  1   2   >