https://github.com/sivachandra closed
https://github.com/llvm/llvm-project/pull/66136
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/sivachandra updated
https://github.com/llvm/llvm-project/pull/66136:
>From d1a9fda20a2be37385b44dcbf2f73b1890fa7d78 Mon Sep 17 00:00:00 2001
From: Siva Chandra Reddy
Date: Tue, 12 Sep 2023 05:42:37 +
Subject: [PATCH 1/3] [libc][NFC] Make entrypoint alias targets real libr
On Mon, Oct 12, 2020 at 10:01 PM Galina Kistanova via lldb-commits
wrote:
> If somebody else could move their AnnotatedCommand bots to the staging area,
> that would be much appreciated.
I moved the libc bots to staging to now.
Thanks,
Siva Chandra
__
Clang is probably right. Why bother to emit an unused file static scalar?
On Mon, Apr 25, 2016 at 4:21 PM, Chaoren Lin wrote:
> Ah, I see. Is that a known clang bug?
>
> On Mon, Apr 25, 2016 at 4:07 PM, Siva Chandra
> wrote:
>>
>> AFAICT, happens only with Clang; Using g_static_var, say as "retu
AFAICT, happens only with Clang; Using g_static_var, say as "return
g_static_var - 123;", fixes for me.
On Mon, Apr 25, 2016 at 3:50 PM, Chaoren Lin via lldb-commits
wrote:
> Is g_global_var necessarily static?
>
> On Linux, we're only seeing 2 static variables when your test expects 3.
>
>> sta
Author: sivachandra
Date: Wed Mar 23 18:27:23 2016
New Revision: 264217
URL: http://llvm.org/viewvc/llvm-project?rev=264217&view=rev
Log:
[JITLoaderGDB] Read jit entry struct manually.
Summary:
Though r264012 was fancy enough to make reading the jit entry struct
work with templates, the packing a
sivachandra added inline comments.
Comment at: source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp:110-119
@@ -80,3 +109,12 @@
-} // anonymous namespace end
+template
+T
+Align(const T v, uint8_t bytes)
+{
+uint8_t rem = v % bytes;
+if (rem == 0)
+
sivachandra updated this revision to Diff 51466.
sivachandra added a comment.
Address comments.
http://reviews.llvm.org/D18379
Files:
source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
source/Plugins/JITLoader/GDB/JITLoaderGDB.h
Index: source/Plugins/JITLoader/GDB/JITLoaderGDB.h
===
sivachandra added a comment.
How does this look?
http://reviews.llvm.org/D18379
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra updated this revision to Diff 51370.
sivachandra added a comment.
Modify according to suggestions.
http://reviews.llvm.org/D18379
Files:
source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
source/Plugins/JITLoader/GDB/JITLoaderGDB.h
Index: source/Plugins/JITLoader/GDB/JITLoaderGDB.h
sivachandra created this revision.
sivachandra added a reviewer: clayborg.
sivachandra added a subscriber: lldb-commits.
Though r264012 was fancy enough to make reading the jit entry struct
work with templates, the packing and alignment attributes do not work on
Windows. So, this change makes it p
Author: sivachandra
Date: Tue Mar 22 16:37:56 2016
New Revision: 264104
URL: http://llvm.org/viewvc/llvm-project?rev=264104&view=rev
Log:
[lldb-mi] Uncomment a line in CMakeLists.txt to make linux build happy.
Reviewers: zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.ll
sivachandra created this revision.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D18377
Files:
tools/lldb-mi/CMakeLists.txt
Index: tools/lldb-mi/CMakeLists.txt
===
---
Author: sivachandra
Date: Mon Mar 21 19:35:31 2016
New Revision: 264012
URL: http://llvm.org/viewvc/llvm-project?rev=264012&view=rev
Log:
[JITLoaderGDB] Pack the jit entry struct according to the target arch.
Reviewers: clayborg
Subscribers: tberghammer, dsrbecky, lldb-commits
Differential Revi
sivachandra added a comment.
Thanks for the quick review.
I will put this in for now. Will revisit if a need for an elaborate solution
arises.
http://reviews.llvm.org/D18334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
sivachandra updated this revision to Diff 51246.
sivachandra added a comment.
Explicitly set the alignment of the size field in the unpacked struct
to 8 bytes. This should take care of the case where in the host is i386
and the target is arm (for example).
http://reviews.llvm.org/D18334
Files:
sivachandra added a comment.
This fixes an issue we are seeing with i386 JIT entry handling.
I have chosen a least disruptive change. However, since alignment is actually
determined by the ABI, one could add some API to the ABI interface to determine
the packing. However, it seemed like an over
sivachandra created this revision.
sivachandra added a reviewer: clayborg.
sivachandra added subscribers: lldb-commits, dsrbecky, tberghammer.
http://reviews.llvm.org/D18334
Files:
source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
source/Plugins/JITLoader/GDB/JITLoaderGDB.h
Index: source/Plugins
On Mon, Mar 14, 2016 at 8:08 AM, Ed Maste wrote:
> On 8 March 2016 at 19:02, Siva Chandra via lldb-commits
> wrote:
>> Author: sivachandra
>> Date: Tue Mar 8 18:02:00 2016
>> New Revision: 262970
>>
>> -@expectedFailureAll(compiler=
Author: sivachandra
Date: Wed Mar 9 19:15:17 2016
New Revision: 263085
URL: http://llvm.org/viewvc/llvm-project?rev=263085&view=rev
Log:
[DWARFASTParserClang] Start with member offset of 0 for members of union types.
Summary:
GCC does not emit DW_AT_data_member_location for members of a union.
S
sivachandra created this revision.
sivachandra added a reviewer: clayborg.
sivachandra added a subscriber: lldb-commits.
GCC does not emit DW_AT_data_member_location for members of a union.
Starting with a 0 value for member locations helps is reading union types
in such cases.
http://reviews.llv
Author: sivachandra
Date: Tue Mar 8 18:02:00 2016
New Revision: 262970
URL: http://llvm.org/viewvc/llvm-project?rev=262970&view=rev
Log:
[TestRegisterVariables] Adjust compiler range in expected failure decorator.
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D17972
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262970: [TestRegisterVariables] Adjust compiler range in
expected failure decorator. (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D17972?vs=50079&id=50086#toc
Repository:
sivachandra created this revision.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D17972
Files:
packages/Python/lldbsuite/test/lang/c/register_variables/TestRegisterVariables.py
Index:
packages/Python/lldbsuite/test/lang/c/register_variables/TestRegisterVariables.py
==
sivachandra updated this revision to Diff 49138.
sivachandra added a comment.
Add more gtest unittests.
http://reviews.llvm.org/D17618
Files:
include/lldb/Symbol/SymbolFile.h
packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py
packages/Python/lldbsuite/test/lang/cpp/stl/main.cpp
sour
sivachandra updated this revision to Diff 49098.
sivachandra added a comment.
Fix a comment in file, fix formatting in another.
http://reviews.llvm.org/D17618
Files:
include/lldb/Symbol/SymbolFile.h
packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py
packages/Python/lldbsuite/test/lang
sivachandra created this revision.
sivachandra added reviewers: spyffe, clayborg.
sivachandra added a subscriber: lldb-commits.
This, in a way, extends the existing "workaroud" by matching function
argument type names individually [instead of just matching "(args1...)"
with "(args2...)"]. For type
Author: sivachandra
Date: Fri Feb 12 20:11:11 2016
New Revision: 260793
URL: http://llvm.org/viewvc/llvm-project?rev=260793&view=rev
Log:
[TestLibCxxAtomic] Skip for GCC.
Summary: This is the form on other libc++ tests.
Reviewers: sivachandra
Subscribers: lldb-commits
Differential Revision: ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260793: [TestLibCxxAtomic] Skip for GCC. (authored by
sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D17230?vs=47885&id=47886#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17230
sivachandra created this revision.
sivachandra added a reviewer: sivachandra.
sivachandra added a subscriber: lldb-commits.
This is the form on other libc++ tests.
http://reviews.llvm.org/D17230
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/ato
Author: sivachandra
Date: Fri Feb 12 18:09:42 2016
New Revision: 260770
URL: http://llvm.org/viewvc/llvm-project?rev=260770&view=rev
Log:
[TestLibCxxAtomic] Fix Makefile so that the test builds on Linux.
Reviewers: granata.enrico
Subscribers: lldb-commits
Differential Revision: http://reviews.l
sivachandra created this revision.
sivachandra added a reviewer: granata.enrico.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D17227
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/atomic/Makefile
Index:
packages/Python/
sivachandra created this revision.
sivachandra added a reviewer: granata.enrico.
sivachandra added a subscriber: lldb-commits.
Gets the build going on Linux again.
http://reviews.llvm.org/D17220
Files:
source/Plugins/Language/CPlusPlus/LibCxxAtomic.cpp
Index: source/Plugins/Language/CPlusPlus
Author: sivachandra
Date: Fri Feb 12 14:30:47 2016
New Revision: 260721
URL: http://llvm.org/viewvc/llvm-project?rev=260721&view=rev
Log:
Adjust for Python-3.
Summary:
This does not yet give us a clean testsuite run but it does help with:
1. Actually building on linux
2. Run the testsuite with ov
sivachandra added inline comments.
Comment at: source/API/liblldb.exports:4
@@ -3,1 +3,2 @@
init_lld*
+PyInit__lld*
labath wrote:
> zturner wrote:
> > I don't really know what the syntax of this file is, but the symbol is
> > called `PyInit__lldb`, not `PyInit__
sivachandra updated this revision to Diff 47835.
sivachandra marked an inline comment as done.
sivachandra added a comment.
Address comments
http://reviews.llvm.org/D17182
Files:
packages/Python/lldbsuite/test/lldbtest.py
packages/Python/lldbsuite/test/plugins/builder_linux.py
packages/Py
sivachandra added a comment.
BTW, I should mention that the testsuite run with Python-2.x is still clean
with this change applied.
http://reviews.llvm.org/D17182
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
sivachandra created this revision.
sivachandra added reviewers: zturner, tfiala, labath.
sivachandra added a subscriber: lldb-commits.
This does not yet give us a clean testsuite run but it does help with:
1. Actually building on linux
2. Run the testsuite with over 70% tests passing on linux.
ht
> Modified:
> lldb/trunk/packages/Python/lldbsuite/test/lang/c/modules/TestCModules.py
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/modules/TestCModules.py?rev=260422&r1=260421&r2=260422&view=diff
> =
Author: sivachandra
Date: Mon Feb 8 20:18:50 2016
New Revision: 260192
URL: http://llvm.org/viewvc/llvm-project?rev=260192&view=rev
Log:
[TestExprsChar] Fix a typo is failure archs list
Reviewers: zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D17014
Modified
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260192: [TestExprsChar] Fix a typo is failure archs list
(authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D17014?vs=47283&id=47284#toc
Repository:
rL LLVM
http://reviews.l
sivachandra created this revision.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D17014
Files:
packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py
Index: packages/Python/lldbsuite/test/expression_command/char/Te
Author: sivachandra
Date: Fri Feb 5 13:10:04 2016
New Revision: 259902
URL: http://llvm.org/viewvc/llvm-project?rev=259902&view=rev
Log:
Take 2: Use an artifical namespace so that member vars do not hide local vars.
Summary: This relands r259810 with fix for failures on Mac.
Reviewers: spyffe,
sivachandra added a comment.
Thanks a lot Todd. I will put this in tomorrow morning just to be on the safer
side.
http://reviews.llvm.org/D16900
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
sivachandra added inline comments.
Comment at: source/Expression/ExpressionSourceCode.cpp:188
@@ +187,3 @@
+ConstString var_name = var_sp->GetName();
+if (var_name == ConstString("this") || var_name ==
ConstString(".block_descriptor"))
+continue;
-
sivachandra created this revision.
sivachandra added reviewers: spyffe, tfiala.
sivachandra added a subscriber: lldb-commits.
This relands r259810 with fix for failures on Mac.
http://reviews.llvm.org/D16900
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDeclContext
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259823: Revert "Use an artifical namespace so that member
vars do not hide local vars." (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D16895?vs=46944&id=46945#toc
Reposito
Author: sivachandra
Date: Thu Feb 4 14:08:40 2016
New Revision: 259823
URL: http://llvm.org/viewvc/llvm-project?rev=259823&view=rev
Log:
Revert "Use an artifical namespace so that member vars do not hide local vars."
Summary:
This reverts commit 8af14b5f9af68c31ac80945e5b5d56f0a14b38e4.
Revertin
sivachandra created this revision.
sivachandra added a reviewer: spyffe.
sivachandra added a subscriber: lldb-commits.
This reverts commit 8af14b5f9af68c31ac80945e5b5d56f0a14b38e4.
Reverting as it breaks a few tests on Mac.
http://reviews.llvm.org/D16895
Files:
include/lldb/Symbol/ClangASTCont
Author: sivachandra
Date: Thu Feb 4 12:38:35 2016
New Revision: 259810
URL: http://llvm.org/viewvc/llvm-project?rev=259810&view=rev
Log:
Use an artifical namespace so that member vars do not hide local vars.
Summary:
While evaluating expressions when stopped in a class method, there was a
proble
sivachandra added a comment.
Thanks a lot for the review. I have changed the arg name as suggested. I will
put this patch in tomorrow morning so that I can monitor the bots afterwards.
http://reviews.llvm.org/D16746
___
lldb-commits mailing list
ll
sivachandra updated this revision to Diff 46861.
sivachandra added a comment.
Address the arg name change comment.
http://reviews.llvm.org/D16746
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDeclContext.h
include/lldb/Symbol/TypeSystem.h
packages/Python/lldb
sivachandra added inline comments.
Comment at:
source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:1381
@@ +1380,3 @@
+clang::NamespaceDecl *namespace_decl =
ClangASTContext::GetUniqueNamespaceDeclaration(
+m_ast_context,
sivachandra updated this revision to Diff 46852.
sivachandra added a comment.
Address Sean's comment.
http://reviews.llvm.org/D16746
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDeclContext.h
include/lldb/Symbol/TypeSystem.h
packages/Python/lldbsuite/test/la
This change broke Android testsuite run:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-android/builds/5147
On Wed, Feb 3, 2016 at 11:20 AM, Zachary Turner via lldb-commits
wrote:
> zturner added a comment.
>
> In http://reviews.llvm.org/D16830#343232, @zturner wrote:
>
>> In http://r
sivachandra added a comment.
In http://reviews.llvm.org/D16746#342507, @spyffe wrote:
> Siva, I've inlined my comments. I believe there's a misunderstanding about
> what role //this// has in the patched version of
> GetUniqueNamespaceDeclaration. In fact, as I argue in my inline comment,
> /
sivachandra added a comment.
A note to Greg: Though you have stamped green on the first version, I think you
should take a look at the new version as I have changes to the API in
TypeSystem (and consequently, in ClangASTContext).
http://reviews.llvm.org/D16746
__
sivachandra marked an inline comment as done.
sivachandra added a comment.
Thanks, Greg and Sean for the review. The new version of the patch has tests
also added. I also have an inline response to a comment by Sean.
Comment at:
source/Plugins/ExpressionParser/Clang/ClangExpre
sivachandra updated this revision to Diff 46717.
sivachandra added a comment.
1. Added tests.
2. Extended the scope of this feature in presense of "using namespace ;"
decls.
3. Addressed one of the two comments by Sean. Will respond to the other on the
review page.
http://reviews.llvm.org/D16
Author: sivachandra
Date: Tue Feb 2 17:49:41 2016
New Revision: 259607
URL: http://llvm.org/viewvc/llvm-project?rev=259607&view=rev
Log:
Fix a thinko in StackFrame::GetInScopeVariableList.
Reviewers: clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D16745
Modi
sivachandra added inline comments.
Comment at: source/Target/StackFrame.cpp:600
@@ -599,3 +599,3 @@
-if (m_sc.comp_unit)
+if (m_sc.comp_unit && get_file_globals)
{
This should not be part of this change. I have another patch for
sivachandra added a comment.
I have tested this with examples and the test run is clean. I will add tests if
you think the overall approach is acceptable.
http://reviews.llvm.org/D16746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
sivachandra created this revision.
sivachandra added reviewers: clayborg, spyffe.
sivachandra added a subscriber: lldb-commits.
While evaluating expressions when stopped in a class method, there was a
problem of member variables hiding local variables. This was happening
because, in the context of
sivachandra added a comment.
I found this while digging into some other problem. Test run is clean for me.
http://reviews.llvm.org/D16745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
sivachandra created this revision.
sivachandra added a reviewer: clayborg.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D16745
Files:
source/Target/StackFrame.cpp
Index: source/Target/StackFrame.cpp
===
--
Thanks a lot.
On Fri, Jan 15, 2016 at 3:26 PM, Zachary Turner wrote:
> Sure
>
> On Fri, Jan 15, 2016 at 3:25 PM Siva Chandra wrote:
>>
>> SGTM. You want to do it?
>>
>> On Fri, Jan 15, 2016 at 3:24 PM, Zachary Turner
>> wrote:
>> > How about `lldb.eStopReasonException if osIsWindows() else
>> >
On Fri, Jan 15, 2016 at 2:18 AM, Pavel Labath via lldb-commits
wrote:
> I don't really understand the purpose of the test, but if the purpose
> of it is to check whether something appears on stdout, then a pexpect
> test does seem like the right tool for the job.
>
> I have tried entering the comm
SGTM. You want to do it?
On Fri, Jan 15, 2016 at 3:24 PM, Zachary Turner wrote:
> How about `lldb.eStopReasonException if osIsWindows() else
> lldb.eStopReasonSignal`?
>
> Seems like that should work for everyone?
>
> On Fri, Jan 15, 2016 at 3:20 PM Siva Chandra wrote:
>>
>> This fails for i386
This fails for i386 (not enabled for x86_64 anyway):
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10400
If I replace lldb.eStopReasonException with lldb.eStopReasonSignal on
my local machine, it works.
On Fri, Jan 15, 2016 at 2:22 PM, Zachary Turner via lldb-commits
wr
Author: sivachandra
Date: Tue Jan 12 16:33:19 2016
New Revision: 257531
URL: http://llvm.org/viewvc/llvm-project?rev=257531&view=rev
Log:
[TestThreadJump] Adjust match sub-string after recent change.
Reviewers: zturner
Subscribers: zturner, lldb-commits
Differential Revision: http://reviews.llv
sivachandra updated this revision to Diff 44674.
sivachandra added a comment.
Address comment
http://reviews.llvm.org/D16125
Files:
packages/Python/lldbsuite/test/functionalities/thread/jump/TestThreadJump.py
Index:
packages/Python/lldbsuite/test/functionalities/thread/jump/TestThreadJump.p
sivachandra created this revision.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D16125
Files:
packages/Python/lldbsuite/test/functionalities/thread/jump/TestThreadJump.py
Index:
packages/Python/lldbsuite/test/functionalities/thre
This broke TestStepNoDebug, atleast on Linux when inferior is compiled
with GCC:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10091
I am able to reproduce this on my machine. Let me know if you need any
help with anything.
On Thu, Jan 7, 2016 at 4:06 PM, Jason Molenda
Author: sivachandra
Date: Thu Jan 7 17:32:34 2016
New Revision: 257113
URL: http://llvm.org/viewvc/llvm-project?rev=257113&view=rev
Log:
Better scheme to lookup alternate mangled name when looking up function address.
Summary:
This change is relevant for inferiors compiled with GCC. GCC does not
sivachandra updated this revision to Diff 44274.
sivachandra added a comment.
Rebase
http://reviews.llvm.org/D12809
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDeclContext.h
include/lldb/Symbol/GoASTContext.h
include/lldb/Symbol/SymbolFile.h
include/lldb/S
sivachandra added a comment.
Thanks a lot Dwan Perchik, for persisting on my behalf.
And thanks to Sean and Greg for taking a look.
I second Dwan's earlier comment about Greg's code reviews. He has been the best
reviewer I have worked with, internally and externally.
Will commit this change sh
Author: sivachandra
Date: Fri Dec 18 18:52:29 2015
New Revision: 256067
URL: http://llvm.org/viewvc/llvm-project?rev=256067&view=rev
Log:
[TestCPPAuto] On linux, we need -fno-limit-debug-info.
Summary: Also xfailed for GCC as there is an problem with debug info generation.
Reviewers: granata.enr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256067: [TestCPPAuto] On linux, we need
-fno-limit-debug-info. (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D15657?vs=43283&id=43284#toc
Repository:
rL LLVM
http://rev
sivachandra created this revision.
sivachandra added a reviewer: granata.enrico.
sivachandra added a subscriber: lldb-commits.
Also xfailed for GCC as there is an problem with debug info generation.
http://reviews.llvm.org/D15657
Files:
packages/Python/lldbsuite/test/lang/cpp/auto/Makefile
p
On Tue, Dec 15, 2015 at 4:22 PM, Siva Chandra via lldb-commits
wrote:
> Author: sivachandra
> Date: Tue Dec 15 18:22:08 2015
> New Revision: 255729
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255729&view=rev
> Log:
> Read macro info from .debug_macro section
Author: sivachandra
Date: Tue Dec 15 18:22:08 2015
New Revision: 255729
URL: http://llvm.org/viewvc/llvm-project?rev=255729&view=rev
Log:
Read macro info from .debug_macro section and use it for expression evaluation.
Summary:
DWARF 5 proposes a reinvented .debug_macro section. This change follow
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255729: Read macro info from .debug_macro section and use it
for expression evaluation. (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D15437?vs=42758&id=42938#toc
Reposito
On Mon, Dec 14, 2015 at 6:42 PM, Zachary Turner wrote:
> zturner added inline comments.
>
>
> Comment at: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py:622
> @@ -621,3 +621,3 @@
> return list_or_lambda(value)
> -elif isinstance(list_or_lambda, list):
> -
Ah, yes! Thank you.
On Mon, Dec 14, 2015 at 6:41 PM, Jim Ingham wrote:
> I think Jason already did (r255597).
>
> Jim
>
>> On Dec 14, 2015, at 6:35 PM, Siva Chandra via lldb-commits
>> wrote:
>>
>> On Mon, Dec 14, 2015 at 4:50 PM, Kamil Rytarowski via lldb-
On Mon, Dec 14, 2015 at 4:50 PM, Kamil Rytarowski via lldb-commits
wrote:
> Author: kamil
> Date: Mon Dec 14 18:50:19 2015
> New Revision: 255592
>
> Added:
> lldb/trunk/source/Plugins/Process/Utility/NetBSDSignals.cpp
> lldb/trunk/source/Plugins/Process/Utility/NetBSDSignals.h
Should the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255584: Make few adjustments after r255542. (authored by
sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D15511?vs=42796&id=42802#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1551
Author: sivachandra
Date: Mon Dec 14 18:26:52 2015
New Revision: 255584
URL: http://llvm.org/viewvc/llvm-project?rev=255584&view=rev
Log:
Make few adjustments after r255542.
Reviewers: zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D15511
Modified:
lldb/tr
sivachandra added a comment.
I went ahead and committed this.
Repository:
rL LLVM
http://reviews.llvm.org/D15511
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra created this revision.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D15511
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Python/lldbsuite/test/lldbtest.py
===
This change looks very innocent, but:
On Mon, Dec 14, 2015 at 1:26 PM, Zachary Turner via lldb-commits
wrote:
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=255542&r1=255541&r2=255542&view=diff
>
On Mon, Dec 14, 2015 at 2:15 PM, Zachary Turner wrote:
> Diff looks like this:
>
> -@dwarf_test
> -@wraps(attrvalue)
> -def dwarf_test_method(self, attrvalue=attrvalue):
> -self.debug_info = "dwarf"
> -return a
Previously, self.debug_info was under different functions
(dwarf_test_method, dwo_test_method etc.). Now, they are all under
test_method. Even I am equally ignorant about the Python nuances here.
On Mon, Dec 14, 2015 at 2:04 PM, Zachary Turner wrote:
> The previous code was just an unrolled loop
Looks like, though that particular test was "fixed", zturner's change
triggered a whole bunch of other failures:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/9446
On Mon, Dec 14, 2015 at 1:56 PM, Siva Chandra wrote:
> I believe zturner already fixed this. However, there
On Mon, Dec 14, 2015 at 10:49 AM, Zachary Turner via lldb-commits
wrote:
> Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=255525&r1=255524&r2=255525&view=diff
>
I believe zturner already fixed this. However, there is a problem with
his original change itself; will bring it up in a different thread.
On Mon, Dec 14, 2015 at 1:49 PM, Todd Fiala via lldb-commits
wrote:
> Author: tfiala
> Date: Mon Dec 14 15:49:39 2015
> New Revision: 255549
>
> URL: http://l
sivachandra added a comment.
PTAL
http://reviews.llvm.org/D15437
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra updated this revision to Diff 42758.
sivachandra added a comment.
Use std::unordered_map instead of std::map.
http://reviews.llvm.org/D15437
Files:
include/lldb/Symbol/CompileUnit.h
include/lldb/Symbol/DebugMacros.h
include/lldb/Symbol/SymbolFile.h
include/lldb/Symbol/Symbol
sivachandra updated this revision to Diff 42754.
sivachandra marked 2 inline comments as done.
sivachandra added a comment.
Remove storing of an unused data structure.
http://reviews.llvm.org/D15437
Files:
include/lldb/Symbol/CompileUnit.h
include/lldb/Symbol/DebugMacros.h
include/lldb/Sy
sivachandra added a comment.
PTAL. I have now covered the case I missed. Added test for that as well.
http://reviews.llvm.org/D15437
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
sivachandra updated this revision to Diff 42614.
sivachandra added a comment.
Use file names.
http://reviews.llvm.org/D15437
Files:
include/lldb/Symbol/CompileUnit.h
include/lldb/Symbol/DebugMacros.h
include/lldb/Symbol/SymbolFile.h
include/lldb/Symbol/SymbolVendor.h
include/lldb/lldb
1 - 100 of 223 matches
Mail list logo
