xgupta wrote:
Could not understand the right fix. Better it to leave it.
https://github.com/llvm/llvm-project/pull/94844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xgupta wrote:
ping!
https://github.com/llvm/llvm-project/pull/94844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/95678
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xgupta wrote:
I think it would be fine not to merge this PR. Asserts are recommended in the
LLDB source code. I will close the PR.
https://github.com/llvm/llvm-project/pull/95678
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/95675
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/95678
>From ef5b9cefb408ca3a721c95d8f6702abba77a602b Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sun, 16 Jun 2024 00:21:51 +0530
Subject: [PATCH 1/4] [LLDB] Add an assert to verify sign_bit_pos is within the
vali
@@ -746,27 +746,18 @@ Status Scalar::SetValueFromData(const DataExtractor &data,
bool Scalar::SignExtend(uint32_t sign_bit_pos) {
const uint32_t max_bit_pos = GetByteSize() * 8;
- if (sign_bit_pos < max_bit_pos) {
-switch (m_type) {
-case Scalar::e_void:
-case S
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94844
>From 5fe77213524d05581eca70b8a0d25e03fe8df793 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sat, 8 Jun 2024 11:52:08 +0530
Subject: [PATCH 1/2] [lldb] Adjust the for loop condition to prevent
unintended incr
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/95678
>From ef5b9cefb408ca3a721c95d8f6702abba77a602b Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sun, 16 Jun 2024 00:21:51 +0530
Subject: [PATCH 1/3] [LLDB] Add an assert to verify sign_bit_pos is within the
vali
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94783
>From 17d39d89ee723881063ecbea19caaa6806e4e095 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sat, 15 Jun 2024 23:57:03 +0530
Subject: [PATCH 1/2] Resolved merge conflict
---
lldb/source/Host/linux/Host.cpp |
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94785
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -287,7 +287,7 @@ Status PlatformAndroid::DownloadModuleSlice(const FileSpec
&src_file_spec,
static constexpr llvm::StringLiteral k_zip_separator("!/");
size_t pos = source_file.find(k_zip_separator);
if (pos != std::string::npos)
-source_file = source_file.substr(
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94785
>From 6ec5b1a005b7551f2857b30e2461d297e7febfa3 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Fri, 7 Jun 2024 23:44:49 +0530
Subject: [PATCH 1/3] [LLDB][NFC] Fix a cppcheck warning in
Platform/Android/Platform
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94785
>From 6ec5b1a005b7551f2857b30e2461d297e7febfa3 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Fri, 7 Jun 2024 23:44:49 +0530
Subject: [PATCH 1/2] [LLDB][NFC] Fix a cppcheck warning in
Platform/Android/Platform
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94783
>From 17d39d89ee723881063ecbea19caaa6806e4e095 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sat, 15 Jun 2024 23:57:03 +0530
Subject: [PATCH 1/2] Resolved merge conflict
---
lldb/source/Host/linux/Host.cpp |
@@ -85,13 +85,17 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
bool has_class_name = !class_name.empty();
bool has_interpreter_dict =
!(llvm::StringRef(m_interpreter.GetDictionaryName()).empty());
-if (!has_class_name && !has_interpr
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94779
>From b8a387d82ed90c98f6bc9c0c7f9bc9da0d8e4d18 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Fri, 7 Jun 2024 23:21:15 +0530
Subject: [PATCH 1/3] [LLDB][NFC] Fix a cppcheck warning in
Python/Interfaces/Scripte
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/95678
>From c02fa111c62f98a20055745d5d8b75aea8fd748a Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sun, 16 Jun 2024 00:21:51 +0530
Subject: [PATCH 1/2] [LLDB] Add an assert to verify sign_bit_pos is within the
vali
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/95675
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/95678
>From 74efb6ae3187fe1e67e61cdca1f99b9de8146db4 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sun, 16 Jun 2024 00:21:51 +0530
Subject: [PATCH 1/2] [LLDB] Add an assert to verify sign_bit_pos is within the
vali
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94779
>From b8a387d82ed90c98f6bc9c0c7f9bc9da0d8e4d18 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Fri, 7 Jun 2024 23:21:15 +0530
Subject: [PATCH 1/2] [LLDB][NFC] Fix a cppcheck warning in
Python/Interfaces/Scripte
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/95713
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/95713
The dead code is caught by PVS studio analyzer -
https://pvs-studio.com/en/blog/posts/cpp/1126/, fragment N12.
Warning message -
V523 The 'then' statement is equivalent to the 'else' statement. Options.cpp
1212
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/95678
None
>From 74efb6ae3187fe1e67e61cdca1f99b9de8146db4 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sun, 16 Jun 2024 00:21:51 +0530
Subject: [PATCH] [LLDB] Add an assert to verify sign_bit_pos is within the
va
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94783
>From 17d39d89ee723881063ecbea19caaa6806e4e095 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sat, 15 Jun 2024 23:57:03 +0530
Subject: [PATCH] Resolved merge conflict
---
lldb/source/Host/linux/Host.cpp | 2 +
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94775
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xgupta wrote:
Gentile ping!
https://github.com/llvm/llvm-project/pull/94779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xgupta wrote:
Gentile ping!
https://github.com/llvm/llvm-project/pull/94775
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/95675
This is described in (N3) https://pvs-studio.com/en/blog/posts/cpp/1126/ so
caught by the PVS Studio analyzer. Warning message -
V547 Expression 'properties ++ > 0' is always false. CommandObjectTarget.cpp:100
I
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94852
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xgupta wrote:
Thanks @jasonmolenda for the review. I do have commit access to merge it.
https://github.com/llvm/llvm-project/pull/94852
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94842
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94841
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94840
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94852
This commit adds a test for lea_rsp_pattern_p which was previously due as FIXME.
>From 1ca5f7e7edefedd12de0745de5afe720f41456b1 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sat, 8 Jun 2024 17:43:55 +0530
Sub
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94844
This PR address the issue reported by static analyser cppcheck regarding
missing bounds check for extra iterator increment in a loop. This could lead to
accessing out-of-bounds memory.
To fix this we have adjust
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94841
>From 5451d769f36528e9640e665d4124103a6c34bf20 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sat, 8 Jun 2024 11:14:06 +0530
Subject: [PATCH 1/2] [lldb] Fix redundant condition in compression type check
(NFC)
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94842
This issue is reported by cppcheck as a pointless test in the watch mask check.
The `else if` condition is opposite to the previous `if` condition, making the
expression always true.
Caught by cppcheck -
lldb/so
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94841
The `else if` condition for checking `m_compression_type` is redundant as it
matches with a previous `if` condition, making the expression always false.
Reported by cppcheck as a possible cut-and-paste error.
Ca
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94840
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94840
>From ebfb9d81ccc9d54a03e33b73143753a6d0f008bb Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sat, 8 Jun 2024 10:43:01 +0530
Subject: [PATCH] [lldb] Use const reference for range variables to improve
performan
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94840
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94840
>From 25fb87d4bb4af55e642ec386f104412b39065a83 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sat, 8 Jun 2024 10:43:01 +0530
Subject: [PATCH] [lldb] Use const reference for range variables to improve
performan
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94840
Cppcheck recommends using a const reference for range variables in a for-each
loop. This avoids unnecessary copying of elements, improving performance.
Caught by cppcheck -
lldb/source/API/SBBreakpoint.cpp:717:22
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94839
Passing the result of c_str() to a stream is slow and redundant. This change
removes unnecessary c_str() calls and uses the string object directly.
Caught by cppcheck -
lldb/tools/debugserver/source/JSON.cpp:398:
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94785
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94785
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94775
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94775
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xgupta wrote:
> The change LGTM, but I have a few suggestions regarding the title and
> description:
>
> * Retitle the PR to something like "[lldb] Remove dead code block (NFC)"
> or something that conveys the intent/outcome. The modified file and line
> number are already part of the com
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94785
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94785
Fix #91211
>From 6ec5b1a005b7551f2857b30e2461d297e7febfa3 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Fri, 7 Jun 2024 23:44:49 +0530
Subject: [PATCH] [LLDB][NFC] Fix a cppcheck warning in
Platform/Androi
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94783
Fix #89710
>From 3fe606e8e9a9eb8df336ac48995eaa52b659aad1 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Fri, 7 Jun 2024 23:37:08 +0530
Subject: [PATCH] [LLDB][NFC] Fix a cppcheck warning in
lldb/source/Host/
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94779
Source code analyser cppcheck says:
lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h:89:11:
warning: Identical inner 'if' condition is always true.
[identicalInnerCondition]
lldb/
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94775
Fixes #85985
lldb/source/Utility/Scalar.cpp:756:23: warning: Opposite inner 'if' condition
leads to a dead code block. [oppositeInnerCondition]
>From da77334ac60233e688812e39480f58bbe1a251eb Mon Sep 17 00:00:00
Author: Shivam Gupta
Date: 2023-02-06T22:07:43+05:30
New Revision: 0b8eff1f8724c6d8e890227597060109cb55e1ca
URL:
https://github.com/llvm/llvm-project/commit/0b8eff1f8724c6d8e890227597060109cb55e1ca
DIFF:
https://github.com/llvm/llvm-project/commit/0b8eff1f8724c6d8e890227597060109cb55e1ca.diff
Author: Daniel Jalkut
Date: 2021-10-21T12:22:52+05:30
New Revision: d531e5cf58413e34dc006a580d2c109863bddaa1
URL:
https://github.com/llvm/llvm-project/commit/d531e5cf58413e34dc006a580d2c109863bddaa1
DIFF:
https://github.com/llvm/llvm-project/commit/d531e5cf58413e34dc006a580d2c109863bddaa1.diff
Author: Shivam Gupta
Date: 2021-09-04T20:57:59+05:30
New Revision: 59c954f76a66c6fc715610e85be71e9c050f2302
URL:
https://github.com/llvm/llvm-project/commit/59c954f76a66c6fc715610e85be71e9c050f2302
DIFF:
https://github.com/llvm/llvm-project/commit/59c954f76a66c6fc715610e85be71e9c050f2302.diff
Author: Shivam Gupta
Date: 2021-08-31T11:45:24+05:30
New Revision: 654e8d6c318a0c4eb9bfd74a9ace6d1a1bda5100
URL:
https://github.com/llvm/llvm-project/commit/654e8d6c318a0c4eb9bfd74a9ace6d1a1bda5100
DIFF:
https://github.com/llvm/llvm-project/commit/654e8d6c318a0c4eb9bfd74a9ace6d1a1bda5100.diff
Author: Shivam Gupta
Date: 2021-08-31T11:45:24+05:30
New Revision: 3af9847a9581fca3c81c7f8669f6f617e35ba9e5
URL:
https://github.com/llvm/llvm-project/commit/3af9847a9581fca3c81c7f8669f6f617e35ba9e5
DIFF:
https://github.com/llvm/llvm-project/commit/3af9847a9581fca3c81c7f8669f6f617e35ba9e5.diff
70 matches
Mail list logo
