[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/

xgupta abandoned this revision. xgupta added a comment. I am sorry for taking time, but I could not understand the right issue. Hence I am abandoning it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142341/new/ https://reviews.llvm.org/D142341 _

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/

xgupta added a comment. gentle ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142341/new/ https://reviews.llvm.org/D142341 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

xgupta added a comment. In D142309#4102284 , @labath wrote: > In D142309#4075745 , @JDevlieghere > wrote: > >> LGTM, but I wonder when we'll be able to get rid of RenderScript completely >> (CC @labath) > > I am

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0b8eff1f8724: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp (authored by xgupta). Repository:

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

xgupta added a comment. In D142309#4075745 , @JDevlieghere wrote: > LGTM, but I wonder when we'll be able to get rid of RenderScript completely > (CC @labath) @JDevlieghere, Shall I commit the changes after running check-lldb? Repository: rG LLVM G

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/

xgupta added a comment. gentle ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142341/new/ https://reviews.llvm.org/D142341 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

xgupta updated this revision to Diff 491601. xgupta added a comment. fix build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142309/new/ https://reviews.llvm.org/D142309 Files: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntim

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

xgupta added a comment. In D142309#4075616 , @jingham wrote: > I don't think this code is going to compile, is it? You took out the `if > (!buffer) {` but left the RHS `}` so now the scopes are unbalanced. I think > you should just change how the shar

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

xgupta updated this revision to Diff 491597. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142309/new/ https://reviews.llvm.org/D142309 Files: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScrip

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix a null pointer check in LibCxx.cpp

xgupta updated this revision to Diff 491288. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142341/new/ https://reviews.llvm.org/D142341 Files: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp lldb/sour

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix a null pointer check in LibCxx.cpp

xgupta added a comment. In D142341#4072810 , @Michael137 wrote: > Looks correct to me, given we seem to allow `valobj_sp` to be null. Though we > seem to be doing it in a lot of other places too around this file. So could > fix those all at once? Yeah

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix a null pointer check in LibCxx.cpp

xgupta created this revision. xgupta added a reviewer: DavidSpickett. Herald added a project: All. xgupta requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The issue is that the SyntheticChildrenFrontEnd constructor is being called with the d

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

xgupta created this revision. xgupta added reviewers: jingham, JDevlieghere. Herald added a project: All. xgupta requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Incorrect use of shared_ptr. found by PVS-Studio https://pvs-studio.com/en/blo

[Lldb-commits] [PATCH] D112199: [LLDB] [NFC] Typo fix in usage text for "type filter" command

This revision was automatically updated to reflect the committed changes. Closed by commit rGd531e5cf5841: [LLDB] [NFC] Typo fix in usage text for "type filter" command (authored by Daniel Jalkut , committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D112199: [LLDB] [NFC] Typo fix in usage text for "type filter" command

xgupta created this revision. xgupta added reviewers: labath, teemperor. xgupta requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When you invoke "help type filter" the resulting help shows: Syntax: type synthetic [] This patch fixes the he

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Move best-practices.txt contain to resources/test.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rG654e8d6c318a: [LLDB][Docs] Move best-practices.txt contain to resources/test.rst (authored by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/n

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

This revision was automatically updated to reflect the committed changes. Closed by commit rG3af9847a9581: [LLDB][Docs] Convert some .txt files to .rst (authored by xgupta). Changed prior to commit: https://reviews.llvm.org/D108807?vs=369253&id=369633#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Move best-practices.txt contain to resources/test.rst

xgupta added a comment. I will ask for commit access and commit it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369376. xgupta added a comment. restore a blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/resources/test.rst lldb/docs/testsuite/best-p

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369375. xgupta added a comment. remove best-practice.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/index.rst lldb/docs/resources/test.rst

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added a comment. In D108812#2971657 , @JDevlieghere wrote: > I'm not convinced this warrants a whole new section. Especially since this is > focussed on lldb developers rather than end users. Could we move this under > the resources/test page?

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369374. xgupta added a comment. Move testsuite/best-practice comtain to resources/test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/index.rst

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added inline comments. Comment at: lldb/docs/testsuite/best-practices.rst:53 + +Cleanup after yourself +-- teemperor wrote: > This section here seems very outdated, can we just delete it? sure Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369328. xgupta added a comment. Remove an outdated paragraph Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/index.rst lldb/docs/testsuite/best-pr

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

xgupta added a comment. I can confirm that it renders correctly, please commit it at your convenience. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108807/new/ https://reviews.llvm.org/D108807

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added a comment. I can confirm that it renders correctly, please commit it at your convenience. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369254. xgupta added a comment. Herald added a subscriber: arphaman. add best-practices entry to index.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lld

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

xgupta updated this revision to Diff 369253. xgupta added a comment. Herald added a subscriber: arphaman. add lldb-for-gdb-users entry to index.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108807/new/ https://reviews.llvm.org/D108807 Files:

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added inline comments. Comment at: lldb/docs/testsuite/best-practices.rst:19 + +:: + mgorny wrote: > …seems to be a common pattern in LLVM. > > (and similarly for other instances of `::`) Thanks, I missed that. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369252. xgupta added a comment. Fix .. code-block:: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/testsuite/best-practices.rst lldb/docs/testsui

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

xgupta added inline comments. Comment at: lldb/docs/use/lldb-for-gdb-users.rst:40 + +> (lldb) process launch -- -program_arg value mgorny wrote: > This style looks a bit weird. Any reason not to use indentation instead of > `>`? Yes, I mistakenly followed http

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

xgupta updated this revision to Diff 369251. xgupta added a comment. remove extra ">" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108807/new/ https://reviews.llvm.org/D108807 Files: lldb/docs/lldb-for-gdb-users.txt lldb/docs/use/links.md l

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added a comment. I later realize that we already have https://lldb.llvm.org/resources/test.html which contains some similar instructions to write testcases. So not sure we want to have this document. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta created this revision. xgupta updated this revision to Diff 369103. xgupta added a comment. xgupta published this revision for review. xgupta added reviewers: teemperor, mgorny, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add ToC This file contain

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

xgupta created this revision. xgupta updated this revision to Diff 369063. xgupta added a comment. xgupta updated this revision to Diff 369099. xgupta retitled this revision from "[LLDB][Docs] Convert some .txt files to .rst" to "[LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to resp

[Lldb-commits] [PATCH] D103744: [lldb][docs] Remove mention of subversion. NFC.

xgupta added a comment. seems you forget to commit it, @brucem :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103744/new/ https://reviews.llvm.org/D103744 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D100053: Fixed bug issue #42017

xgupta added a comment. Thanks @sushmaunnibhavi for the patch. Please update the revision as per the comment of @JDevlieghere. I assume you don't have commit access to commit this patch so please share your email address someone else with the commit access will commit it on you behalf. Repos

[Lldb-commits] [PATCH] D95766: [Branch-Rename] Fix some links

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94fac81fccfe: [Branch-Rename] Fix some links (authored by xgupta).

[Lldb-commits] [PATCH] D95766: [Branch-Rename] Fix some links

xgupta created this revision. xgupta added reviewers: mehdi_amini, sqlbyme. Herald added a reviewer: bollu. Herald added subscribers: libcxx-commits, teijeong, rdzhabarov, tatianashp, ThomasRaoux, AlexeySotkin, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester,

[Lldb-commits] [PATCH] D95766: [Branch-Rename] Fix some links

xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.h:20 // Check for underscores in the names of googletest tests, per -// https://github.com/google/googletest/blob/master/googletest/docs/faq.md#why-should-test-su