This revision was automatically updated to reflect the committed changes.
Closed by commit rL267048: Update Go OS Plugin for newer runtimes. (authored by
ribrdb).
Changed prior to commit:
http://reviews.llvm.org/D19273?vs=54427&id=54572#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19273
Author: ribrdb
Date: Thu Apr 21 15:57:28 2016
New Revision: 267048
URL: http://llvm.org/viewvc/llvm-project?rev=267048&view=rev
Log:
Update Go OS Plugin for newer runtimes.
Differential Revision: http://reviews.llvm.org/D19273
Modified:
lldb/trunk/source/Plugins/OperatingSystem/Go/OperatingS
ribrdb removed rL LLVM as the repository for this revision.
ribrdb updated this revision to Diff 54427.
http://reviews.llvm.org/D19273
Files:
source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp
Index: source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp
=
ribrdb marked an inline comment as done.
ribrdb added a comment.
I'm not sure how else we could identify the runtime version. I'm hoping to
eventually add a producer string that has the version, but this would just be a
git commit for development compilers.
Repository:
rL LLVM
http://review
ribrdb created this revision.
ribrdb added a subscriber: lldb-commits.
ribrdb set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D19273
Files:
source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp
Index: source/Plugins/OperatingSystem/Go/Operating
It would be nice if we could get this into 3.8 to get rid of these asserts.
-- Ryan Brown
On Fri, Jan 15, 2016 at 11:35 AM, Ryan Brown via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: ribrdb
> Date: Fri Jan 15 13:35:48 2016
> New Revision: 257926
>
> URL: h
Author: ribrdb
Date: Fri Jan 15 13:35:48 2016
New Revision: 257926
URL: http://llvm.org/viewvc/llvm-project?rev=257926&view=rev
Log:
Implement missing GoASTContext methods
Modified:
lldb/trunk/source/Symbol/GoASTContext.cpp
Modified: lldb/trunk/source/Symbol/GoASTContext.cpp
URL:
http://llv
ribrdb created this revision.
ribrdb added a reviewer: clayborg.
ribrdb added a subscriber: lldb-commits.
ribrdb set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D16234
Files:
source/Symbol/GoASTContext.cpp
Index: source/Symbol/GoASTContext.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252109: Add go data formatters. (authored by ribrdb).
Changed prior to commit:
http://reviews.llvm.org/D13878?vs=37900&id=39288#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13878
Files:
lldb/t
Author: ribrdb
Date: Wed Nov 4 18:24:36 2015
New Revision: 252109
URL: http://llvm.org/viewvc/llvm-project?rev=252109&view=rev
Log:
Add go data formatters.
Differential Revision: http://reviews.llvm.org/D13878
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/
lldb/tr
Author: ribrdb
Date: Tue Nov 3 16:46:37 2015
New Revision: 252007
URL: http://llvm.org/viewvc/llvm-project?rev=252007&view=rev
Log:
Fix build for go parser unittest.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/unittests/Expression/GoParserTest.cpp
Modified: lldb/trunk
Author: ribrdb
Date: Mon Nov 2 15:28:18 2015
New Revision: 251835
URL: http://llvm.org/viewvc/llvm-project?rev=251835&view=rev
Log:
Move go expression tests to the new location.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/go/expressions/
lldb/trunk/packages/Python/lldbsuite/te
ribrdb added a comment.
Is this ready to submit?
http://reviews.llvm.org/D13878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ribrdb added a comment.
Is this ready to submit?
Comment at: source/Expression/LLVMUserExpression.cpp:43-60
@@ +42,20 @@
+
+LLVMUserExpression::LLVMUserExpression(ExecutionContextScope &exe_scope, const
char *expr, const char *expr_prefix,
+
ribrdb removed rL LLVM as the repository for this revision.
ribrdb updated this revision to Diff 37900.
ribrdb added a comment.
Oops, I ran clang-format with the wrong arguments. Ran it again.
http://reviews.llvm.org/D13878
Files:
cmake/LLDBDependencies.cmake
lldb.xcodeproj/project.pbxproj
ribrdb updated this revision to Diff 37898.
Repository:
rL LLVM
http://reviews.llvm.org/D13878
Files:
cmake/LLDBDependencies.cmake
lldb.xcodeproj/project.pbxproj
source/API/SystemInitializerFull.cpp
source/Plugins/Language/CMakeLists.txt
source/Plugins/Language/Go/CMakeLists.txt
so
ribrdb added inline comments.
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:10
@@ +9,3 @@
+
+#include
+
Eugene.Zelenko wrote:
> Please add include section comments. Same for other sections.
Which sections? I've seen a couple types of section mar
ribrdb updated this revision to Diff 37800.
ribrdb added a comment.
Add tests.
Repository:
rL LLVM
http://reviews.llvm.org/D13878
Files:
cmake/LLDBDependencies.cmake
lldb.xcodeproj/project.pbxproj
source/API/SystemInitializerFull.cpp
source/Plugins/Language/CMakeLists.txt
source/Pl
ribrdb created this revision.
ribrdb added a reviewer: clayborg.
ribrdb added a subscriber: lldb-commits.
ribrdb set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D13878
Files:
cmake/LLDBDependencies.cmake
lldb.xcodeproj/project.pbxproj
source/A
ribrdb closed this revision.
ribrdb added a comment.
Submitted in revisions 249456 and 249459.
Repository:
rL LLVM
http://reviews.llvm.org/D13149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: ribrdb
Date: Tue Oct 6 17:21:08 2015
New Revision: 249478
URL: http://llvm.org/viewvc/llvm-project?rev=249478&view=rev
Log:
Simple readline functionality for interactive python on linux.
Differential Revision: http://reviews.llvm.org/D13268
Modified:
lldb/trunk/CMakeLists.txt
ll
Author: ribrdb
Date: Tue Oct 6 15:31:08 2015
New Revision: 249459
URL: http://llvm.org/viewvc/llvm-project?rev=249459&view=rev
Log:
Add missing GoLanguageRuntime files.
Added:
lldb/trunk/source/Plugins/LanguageRuntime/Go/
lldb/trunk/source/Plugins/LanguageRuntime/Go/CMakeLists.txt
ll
Author: ribrdb
Date: Tue Oct 6 15:29:31 2015
New Revision: 249456
URL: http://llvm.org/viewvc/llvm-project?rev=249456&view=rev
Log:
Create GoLanguageRuntime.
GoLanguageRuntime supports finding the runtime type for Go interfaces.
Modified:
lldb/trunk/cmake/LLDBDependencies.cmake
lldb/tru
I was wondering if we'd need this. Go 1.4 is the minimum supported version.
On Tue, Oct 6, 2015 at 12:17 PM Todd Fiala via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: tfiala
> Date: Tue Oct 6 14:15:56 2015
> New Revision: 249446
>
> URL: http://llvm.org/viewvc/llvm-project?rev=2
ribrdb updated this revision to Diff 36637.
Repository:
rL LLVM
http://reviews.llvm.org/D13268
Files:
CMakeLists.txt
scripts/Python/modules/readline/CMakeLists.txt
scripts/Python/modules/readline/readline.cpp
source/CMakeLists.txt
Index: source/CMakeLists.txt
=
ribrdb updated this revision to Diff 36295.
ribrdb marked an inline comment as done.
ribrdb added a comment.
Updated comments.
Repository:
rL LLVM
http://reviews.llvm.org/D13268
Files:
scripts/Python/modules/readline/CMakeLists.txt
scripts/Python/modules/readline/readline.cpp
Index: scr
Oh, now I see the search in 249027.
But how does this work with multiple type systems?
Target no longer manages persistent variable names so won't each type
system generate conflicting names?
e.g.
(lldb) expr -l c -- 1
$1 = 1
(lldb) expr -l go -- 2
$1 = 2
(lldb) expr -l go -- $1
Which $1 do you ge
Shouldn't Target::GetPersistentVariable take a language parameter instead
of assuming clang?
On Wed, Sep 30, 2015 at 12:59 PM Sean Callanan via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: spyffe
> Date: Wed Sep 30 14:57:57 2015
> New Revision: 248934
>
> URL: http://llvm.org/view
ribrdb updated this revision to Diff 36031.
ribrdb added a comment.
Fix cmake build.
Repository:
rL LLVM
http://reviews.llvm.org/D13149
Files:
cmake/LLDBDependencies.cmake
lldb.xcodeproj/project.pbxproj
source/API/SystemInitializerFull.cpp
source/Plugins/LanguageRuntime/CMakeLists.tx
ribrdb created this revision.
ribrdb added a reviewer: tfiala.
ribrdb added a subscriber: lldb-commits.
ribrdb set the repository for this revision to rL LLVM.
This implements basic line editing for the interactive python interpreter on
linux.
No tab completion, but at least backspace works.
Rep
ribrdb created this revision.
ribrdb added a reviewer: clayborg.
ribrdb added a subscriber: lldb-commits.
ribrdb set the repository for this revision to rL LLVM.
GoLanguageRuntime supports finding the runtime type for Go interfaces.
Repository:
rL LLVM
http://reviews.llvm.org/D13149
Files:
ribrdb added a comment.
I suppose JIT might make more sense if we want to implement more complicated
expressions like looping and calling in to go code.
There's lots of issues to solve before we can call into go code however. In
addition to the stack I'm not sure what to do about the GC. Also I
ribrdb added a comment.
Hmm. I assumed you're using clang to generate llvm IR, is that not the case?
I don't really want to write a whole go compiler.
Right now I'm interpreting the AST using the ValueObject API. This also lets me
reuse the error checking and things implemented in the type system
The doc comment for SortTypeList() is wrong.
On Sep 23, 2015 12:20 AM, "Ravitheja Addepally via lldb-commits" <
lldb-commits@lists.llvm.org> wrote:
> Author: ravitheja
> Date: Wed Sep 23 02:19:02 2015
> New Revision: 248366
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248366&view=rev
> Log:
>
Author: ribrdb
Date: Wed Sep 16 16:20:44 2015
New Revision: 247852
URL: http://llvm.org/viewvc/llvm-project?rev=247852&view=rev
Log:
Add an OperatingSystem plugin to support goroutines
The Go runtime schedules user level threads (goroutines) across real threads.
This adds an OS plugin to create m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247852: Add an OperatingSystem plugin to support goroutines
(authored by ribrdb).
Changed prior to commit:
http://reviews.llvm.org/D5871?vs=34914&id=34925#toc
Repository:
rL LLVM
http://reviews.llvm
ribrdb marked 2 inline comments as done.
ribrdb added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D5871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ribrdb updated this revision to Diff 34914.
ribrdb added a comment.
> I am confused as to why we need to do this. If you have a memory thread, it
> might be backed by a real thread, or it might not. If it is backed by a
> real thread, we should be asking the real thread why it really stopp
ribrdb updated this revision to Diff 34839.
ribrdb added a comment.
Fix cmake build.
Repository:
rL LLVM
http://reviews.llvm.org/D5871
Files:
cmake/LLDBDependencies.cmake
include/lldb/Core/PluginManager.h
lib/Makefile
lldb.xcodeproj/project.pbxproj
source/Core/PluginManager.cpp
s
ribrdb updated this revision to Diff 34813.
ribrdb added a comment.
Ok, I've changed it to use the symbol table like the ASAN runtime does.
I'm not seeing any language info in the elf or macho file headers.
It looks like there's also a gosymtab section I could look for, but the name is
different
ribrdb updated the summary for this revision.
ribrdb set the repository for this revision to rL LLVM.
ribrdb updated this revision to Diff 34806.
ribrdb added a comment.
I've updated this to load the plugin when modules are loaded, added a setting
to enable/disable the goroutine plugin, and added
ribrdb accepted this revision.
ribrdb added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D12872
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: ribrdb
Date: Mon Sep 14 19:50:43 2015
New Revision: 247647
URL: http://llvm.org/viewvc/llvm-project?rev=247647&view=rev
Log:
Fix error on windows:
c:\buildbot\lldb-windows-x86\lldb-windows-x86\llvm\tools\lldb\source\symbol\goastcontext.cpp(906)
: warning C4715: 'lldb_private::GoASTContex
On Wed, Sep 9, 2015 at 2:57 PM Enrico Granata wrote:
> On Sep 9, 2015, at 2:47 PM, Ryan Brown wrote:
>
>
> On Tue, Sep 8, 2015 at 3:10 PM Enrico Granata via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> Author: enrico
>> Date: Tue Sep 8 17:09:19 2015
>> New Revision: 247082
>>
>> UR
On Tue, Sep 8, 2015 at 3:10 PM Enrico Granata via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: enrico
> Date: Tue Sep 8 17:09:19 2015
> New Revision: 247082
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247082&view=rev
> Log:
> Implement a Target::GetTypeSystemForLanguage API,
45 matches
Mail list logo
