[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

royjacobson added a comment. In D140996#4185795 , @bolshakov-a wrote: > @royjacobson, I've added some test cases for using the new NTTP arguments in > clang modules. It uses serialization, in principle. Or more specialized tests > are still needed? No

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

royjacobson added a comment. There are no AST [de]serialization tests in this PR, right? Would be nice to add some. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 ___

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

royjacobson added a comment. In D130689#3709834 , @thieta wrote: > In D130689#3709742 , @aaron.ballman > wrote: > >> One thing I think would be a definite improvement is to have done an RFC on >> Discourse for t

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

royjacobson added a comment. In D130689#3705145 , @thieta wrote: > In D130689#3705131 , @royjacobson > wrote: > >> This seems to have been more disruptive than expected, since an existing >> CMakeCache.txt can m

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

royjacobson added a comment. This seems to have been more disruptive than expected, since an existing CMakeCache.txt can make LLVM compile in previous C++14 configuration. This seems to make some of the bots fail in a way that makes the patches making use of C++17 features seem at fault. See: