[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

2023-01-12 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. What's the status here? Should this be abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

2021-06-04 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Removing from queue - i don't expect to review this. Looks like this has been reverted twice now, presumably llvm stage 2/linux kernel/chrome should be enough of a coverage to be s

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

2021-05-30 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri resigned from this revision. lebedev.ri added a comment. (removing from my queue - i don't expect to provide any review here) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102942/new/ https://reviews.llvm.org/D102942 ___

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

2021-04-23 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri added a comment. In D98179#2689075 , @mstorsjo wrote: > Something related to the time recording seems to fail intermittently on > buildbots: https://lab.llvm.org/buildbot#builders/93/builds/2697 I'll cut to the fix here: @davezarzycki is there

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

2021-03-29 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri added a comment. Thank you! The changes here look about reasonable to me. I have not checked if there are some changes that were missed. Usage of `CMAKE_INSTALL_FULL_` is suspect to me. Are you sure those are correct? Comment at: compiler-rt/cmake/Modules/AddCompiler

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

2021-03-22 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri added a comment. @nlopes are you talking about sorting *all* lit output, or the summary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98179/new/ https://reviews.llvm.org/D98179 ___ lldb-commi

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

2021-03-22 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri added a comment. In D98179#2639476 , @nlopes wrote: > I'm talking about sorting just the summary of failed tests, not the whole > output. We need the whole -vv output, but that can be out of order. Aha! +1 then, i think sorting summary should

[Lldb-commits] [PATCH] D89813: [CMake][NFC] Limit the use of uppercase_CMAKE_BUILD_TYPE

2020-10-22 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri requested changes to this revision. lebedev.ri added inline comments. This revision now requires changes to proceed. Comment at: libcxx/utils/google-benchmark/test/CMakeLists.txt:8-9 # strip -DNDEBUG from the default CMake flags in DEBUG mode. -string(TOUPPER "${CMAKE

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

2019-06-15 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri added a comment. In D63370#1544970 , @siedentop wrote: > In D63370#1544767 , @lebedev.ri > wrote: > > > The `llvm/utils/benchmark/` changes - can you please either submit them > > upstream yourself, or

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

2019-06-15 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri added a comment. The `llvm/utils/benchmark/` changes - can you please either submit them upstream yourself, or explicitly state that it is okay to **steal** them from you and submit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63370/new/ https://reviews.llvm.org/D63370

[Lldb-commits] [PATCH] D59539: [llvm-exegesis] Option to lobotomize dbscan (PR40880)

2019-03-19 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri created this revision. lebedev.ri added a reviewer: courbet. lebedev.ri added a project: LLVM. Herald added subscribers: lldb-commits, jdoerfert, abidh, tschuett. Herald added a project: LLDB. Let's suppose we have measured 4 different opcodes, and got: `0.5`, `1.0`, `1.5`, `2.0`. Let'

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

2019-02-07 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri added a comment. In D56322#1389013 , @labath wrote: > Btw, I've just noticed that the files you've added here still have the old > license header. Would be good to get at least an automatic Herald rule for this I suspect there might be more o

[Lldb-commits] [PATCH] D41962: Fix TestYMMRegisters for older machines without AVX2

2018-01-11 Thread Roman Lebedev via Phabricator via lldb-commits
lebedev.ri added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_avx/main.c:21 + static volatile unsigned haveAVX2; + haveAVX2 = __builtin_cpu_supports("avx2"); unsigned int ymmallones = 0x; Note that you n