[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

https://github.com/rnk approved this pull request. https://github.com/llvm/llvm-project/pull/123308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

@@ -117,13 +121,13 @@ class OptTable { private: // A unified string table for these options. Individual strings are stored as // null terminated C-strings at offsets within this table. - const char *StrTable; + const StringTable *StrTable; rnk wrote: Got

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/123308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

@@ -117,13 +121,13 @@ class OptTable { private: // A unified string table for these options. Individual strings are stored as // null terminated C-strings at offsets within this table. - const char *StrTable; + const StringTable *StrTable; rnk wrote: Can

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

@@ -33,25 +33,26 @@ using namespace llvm::opt; namespace { struct OptNameLess { - const char *StrTable; - ArrayRef PrefixesTable; + const StringTable *StrTable; rnk wrote: Can this be a const reference instead? Is there a reason you chose to make this a p

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

https://github.com/rnk commented: Thanks, I just had one question. https://github.com/llvm/llvm-project/pull/123308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

@@ -53,10 +53,8 @@ class OptTable { public: /// Entry for a single option instance in the option data table. struct Info { -/// A null terminated array of prefix strings to apply to name while -/// matching. -ArrayRef Prefixes; -StringLiteral PrefixedName; +

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

https://github.com/rnk approved this pull request. Thanks! I think this is ready to land. https://github.com/llvm/llvm-project/pull/119198 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

@@ -845,13 +845,14 @@ MemoryBufferRef LinkerDriver::convertResToCOFF(ArrayRef mbs, // Create OptTable +#define OPTTABLE_STR_TABLE_CODE rnk wrote: I convinced myself this is not worth it. The changes to the `PrecomputedOptTable` are hard to abstract away. I

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

@@ -845,13 +845,14 @@ MemoryBufferRef LinkerDriver::convertResToCOFF(ArrayRef mbs, // Create OptTable +#define OPTTABLE_STR_TABLE_CODE rnk wrote: Is it feasible to split out all the tool driver updates, like refactor all these PREFIX definitions into the t

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

@@ -53,10 +53,8 @@ class OptTable { public: /// Entry for a single option instance in the option data table. struct Info { -/// A null terminated array of prefix strings to apply to name while -/// matching. -ArrayRef Prefixes; -StringLiteral PrefixedName; +

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

@@ -80,15 +78,56 @@ class OptTable { const char *AliasArgs; const char *Values; -StringRef getName() const { - unsigned PrefixLength = Prefixes.empty() ? 0 : Prefixes[0].size(); - return PrefixedName.drop_front(PrefixLength); +bool hasNoPrefix() const

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

@@ -53,10 +53,8 @@ class OptTable { public: /// Entry for a single option instance in the option data table. struct Info { -/// A null terminated array of prefix strings to apply to name while -/// matching. -ArrayRef Prefixes; -StringLiteral PrefixedName; +

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

https://github.com/rnk approved this pull request. https://github.com/llvm/llvm-project/pull/114303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

rnk wrote: > As a data point, I've been setting core.autocrlf=true on Windows for years. If that's the case, my information is stale, which I accept. > To be clear, this may do nothing on checkout if a user has set a config > option. That addresses my concerns. https://github.com/llvm/llv

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

rnk wrote: I think it makes sense to remove carriage returns on checkin, but I'm not sure it makes sense to add them back on checkout on Windows. Historically, it's been really easy to write LLVM tests that fail when the source is checked out with CRLF. Many Windows developers have noted that

[Lldb-commits] [compiler-rt] [lldb] [llvm] [openmp] [lld] [mlir] [clang-tools-extra] [libcxx] [clang] [flang] [clang] Add `intrin0.h` header to mimic `intrin0.h` used by MSVC STL for clang-cl (PR #757

rnk wrote: > > I would like some measurements so we can compare build times on Windows. > > I took some benchmarks with `-ftime-trace` on the parse times with and > without this change. > ... > clang-cl built with this PR frontend took ~1368ms to parse. `intrin.h` took > ~969ms to parse. Most

[Lldb-commits] [compiler-rt] [clang] [flang] [clang-tools-extra] [mlir] [lldb] [llvm] [Profile] Add binary profile correlation for code coverage. (PR #69493)

rnk wrote: @david-xl , Zequan posted an [RFC](https://discourse.llvm.org/t/rfc-add-binary-profile-correlation-to-not-load-profile-metadata-sections-into-memory-at-runtime/74565/8) for this. Is there a PGO tag, or something we can use to increase visibility for PGO reviewers? I think most of th

[Lldb-commits] [lldb] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/rnk commented: Seems reasonable to me. https://github.com/llvm/llvm-project/pull/66295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

FWIW, I don't see any issues with my two bots that use buildbot annotated commands: http://lab.llvm.org:8011/#/builders/sanitizer-windows http://lab.llvm.org:8011/#/builders/clang-x64-windows-msvc The individual steps don't highlight as green or red, but that's OK for now. On Mon, Oct 12, 2020 at

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

On Wed, Oct 7, 2020 at 4:32 PM Galina Kistanova via lldb-commits < lldb-commits@lists.llvm.org> wrote: > They are online now - http://lab.llvm.org:8011/#/waterfall?tags=sanitizer > > AnnotatedCommand has severe design conflict with the new buildbot. > We have changed it to be safe and still do som

[Lldb-commits] [lldb] 1c03389 - Re-land "Migrate the rest of COFFObjectFile to Error"

Author: Reid Kleckner Date: 2020-06-11T14:46:16-07:00 New Revision: 1c03389c29f32cce81a642365c484c71aba1a1cb URL: https://github.com/llvm/llvm-project/commit/1c03389c29f32cce81a642365c484c71aba1a1cb DIFF: https://github.com/llvm/llvm-project/commit/1c03389c29f32cce81a642365c484c71aba1a1cb.diff

[Lldb-commits] [lldb] 47cc6db - Re-land [Debug][CodeView] Emit fully qualified names for globals

Author: Reid Kleckner Date: 2020-05-18T17:31:00-07:00 New Revision: 47cc6db928d063d96e11e70c196bd5601b2bdd06 URL: https://github.com/llvm/llvm-project/commit/47cc6db928d063d96e11e70c196bd5601b2bdd06 DIFF: https://github.com/llvm/llvm-project/commit/47cc6db928d063d96e11e70c196bd5601b2bdd06.diff

[Lldb-commits] [lldb] 58c7bf2 - Update LLDB filespec tests for remove_dots change

Author: Reid Kleckner Date: 2020-05-04T17:27:16-07:00 New Revision: 58c7bf246ec4056ca40ea37f16cb3314161863f7 URL: https://github.com/llvm/llvm-project/commit/58c7bf246ec4056ca40ea37f16cb3314161863f7 DIFF: https://github.com/llvm/llvm-project/commit/58c7bf246ec4056ca40ea37f16cb3314161863f7.diff

[Lldb-commits] [lldb] 213aea4 - Remove unused Endian.h includes, NFC

Author: Reid Kleckner Date: 2020-03-11T15:45:34-07:00 New Revision: 213aea4c5836934771eb97eb97e4c964053a8596 URL: https://github.com/llvm/llvm-project/commit/213aea4c5836934771eb97eb97e4c964053a8596 DIFF: https://github.com/llvm/llvm-project/commit/213aea4c5836934771eb97eb97e4c964053a8596.diff

[Lldb-commits] [lldb] e08464f - Avoid including FileManager.h from SourceManager.h

Author: Reid Kleckner Date: 2020-03-11T13:53:12-07:00 New Revision: e08464fb450456881733c885267b32dc7339cf11 URL: https://github.com/llvm/llvm-project/commit/e08464fb450456881733c885267b32dc7339cf11 DIFF: https://github.com/llvm/llvm-project/commit/e08464fb450456881733c885267b32dc7339cf11.diff

[Lldb-commits] [lldb] c915cb9 - Avoid including Module.h from ExternalASTSource.h

Author: Reid Kleckner Date: 2020-03-11T13:37:41-07:00 New Revision: c915cb957dc37275ce1ca1a0b993239c82f12692 URL: https://github.com/llvm/llvm-project/commit/c915cb957dc37275ce1ca1a0b993239c82f12692 DIFF: https://github.com/llvm/llvm-project/commit/c915cb957dc37275ce1ca1a0b993239c82f12692.diff

[Lldb-commits] [lldb] e3a9b0f - [Support] Remove byte swapping from MathExtras.h

Author: Reid Kleckner Date: 2020-02-27T17:23:48-08:00 New Revision: e3a9b0f35955ab0fdcba3da713bb2f4cd0b29680 URL: https://github.com/llvm/llvm-project/commit/e3a9b0f35955ab0fdcba3da713bb2f4cd0b29680 DIFF: https://github.com/llvm/llvm-project/commit/e3a9b0f35955ab0fdcba3da713bb2f4cd0b29680.diff

[Lldb-commits] [lldb] 4c2a656 - Avoid ASTContext.h -> TargetInfo.h dep

Author: Reid Kleckner Date: 2020-02-27T14:35:00-08:00 New Revision: 4c2a6567bb12559cfc091bca2b25ae907cbd4e0f URL: https://github.com/llvm/llvm-project/commit/4c2a6567bb12559cfc091bca2b25ae907cbd4e0f DIFF: https://github.com/llvm/llvm-project/commit/4c2a6567bb12559cfc091bca2b25ae907cbd4e0f.diff

[Lldb-commits] [lldb] 34312ed - Remove unneeded Compiler.h and DataTypes.h includes, NFC

Author: Reid Kleckner Date: 2020-02-26T10:36:17-08:00 New Revision: 34312ed24e17a0e8269611b954e489fa7759f115 URL: https://github.com/llvm/llvm-project/commit/34312ed24e17a0e8269611b954e489fa7759f115 DIFF: https://github.com/llvm/llvm-project/commit/34312ed24e17a0e8269611b954e489fa7759f115.diff

[Lldb-commits] [lldb] 50d2d33 - Fix BroadcasterManager::RemoveListener to really remove the listener

Author: Reid Kleckner Date: 2020-02-04T17:19:44-08:00 New Revision: 50d2d33b8ef530fbee369cbf8e7ea4479597742d URL: https://github.com/llvm/llvm-project/commit/50d2d33b8ef530fbee369cbf8e7ea4479597742d DIFF: https://github.com/llvm/llvm-project/commit/50d2d33b8ef530fbee369cbf8e7ea4479597742d.diff

[Lldb-commits] [lldb] 0c86dfb - Fix -Wunused-result warnings in LLDB

Author: Reid Kleckner Date: 2020-02-04T15:58:38-08:00 New Revision: 0c86dfb86de53e74f376c3f2800fc114afaae2ba URL: https://github.com/llvm/llvm-project/commit/0c86dfb86de53e74f376c3f2800fc114afaae2ba DIFF: https://github.com/llvm/llvm-project/commit/0c86dfb86de53e74f376c3f2800fc114afaae2ba.diff

[Lldb-commits] [lldb] 8a81daa - [AST] Split parent map traversal logic into ParentMapContext.h

Author: Reid Kleckner Date: 2020-01-24T13:42:28-08:00 New Revision: 8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082 URL: https://github.com/llvm/llvm-project/commit/8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082 DIFF: https://github.com/llvm/llvm-project/commit/8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082.diff

[Lldb-commits] [lldb] 4d23764 - Fix -Wunused-result warnings in LLDB

Author: Reid Kleckner Date: 2019-11-15T16:38:00-08:00 New Revision: 4d23764dddc23e74ad165086d7f471a3e0e52bf8 URL: https://github.com/llvm/llvm-project/commit/4d23764dddc23e74ad165086d7f471a3e0e52bf8 DIFF: https://github.com/llvm/llvm-project/commit/4d23764dddc23e74ad165086d7f471a3e0e52bf8.diff

[Lldb-commits] [lldb] 5565d36 - Revert "Forward declare Optional in STLExtras.h"

Author: Reid Kleckner Date: 2019-11-13T16:36:21-08:00 New Revision: 5565d365f2af0f6d17f12ed1a980e6d9415a6607 URL: https://github.com/llvm/llvm-project/commit/5565d365f2af0f6d17f12ed1a980e6d9415a6607 DIFF: https://github.com/llvm/llvm-project/commit/5565d365f2af0f6d17f12ed1a980e6d9415a6607.diff

[Lldb-commits] [lldb] a36f316 - Forward declare Optional in STLExtras.h

Author: Reid Kleckner Date: 2019-11-13T16:34:00-08:00 New Revision: a36f316390d4bc1bcb0e9de0f55831385ab24099 URL: https://github.com/llvm/llvm-project/commit/a36f316390d4bc1bcb0e9de0f55831385ab24099 DIFF: https://github.com/llvm/llvm-project/commit/a36f316390d4bc1bcb0e9de0f55831385ab24099.diff

[Lldb-commits] [lldb] bfe663c - Revert a hunk from 9634064cfa1b9bf7b7

Author: Reid Kleckner Date: 2019-11-13T15:43:54-08:00 New Revision: bfe663ce22db6697459510ae5c139da2197df56c URL: https://github.com/llvm/llvm-project/commit/bfe663ce22db6697459510ae5c139da2197df56c DIFF: https://github.com/llvm/llvm-project/commit/bfe663ce22db6697459510ae5c139da2197df56c.diff

[Lldb-commits] [lldb] 90c64a3 - Move endian constant from Host.h to SwapByteOrder.h, prune include

Author: Reid Kleckner Date: 2019-10-19T00:48:11Z New Revision: 90c64a3456b972432a21ef043b205c18a91e011b URL: https://github.com/llvm/llvm-project/commit/90c64a3456b972432a21ef043b205c18a91e011b DIFF: https://github.com/llvm/llvm-project/commit/90c64a3456b972432a21ef043b205c18a91e011b.diff

Re: [Lldb-commits] [lldb] r361915 - build: only search for the needed python type

Doesn't this regress building with the VS generator? Was that already broken? It seems like this should've been sent to Zach, who added this logic, for review. On Tue, May 28, 2019 at 7:23 PM Saleem Abdulrasool via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Tue

[Lldb-commits] [lldb] r366247 - Fix LLDB Windows build Python version logic after r366243

Author: rnk Date: Tue Jul 16 11:46:51 2019 New Revision: 366247 URL: http://llvm.org/viewvc/llvm-project?rev=366247&view=rev Log: Fix LLDB Windows build Python version logic after r366243 Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [lldb] r360076 - Fix the cmake build by removing non-existant source file

Author: rnk Date: Mon May 6 13:36:58 2019 New Revision: 360076 URL: http://llvm.org/viewvc/llvm-project?rev=360076&view=rev Log: Fix the cmake build by removing non-existant source file Modified: lldb/trunk/unittests/Symbol/CMakeLists.txt Modified: lldb/trunk/unittests/Symbol/CMakeLists.txt

[Lldb-commits] [lldb] r357658 - [codeview] Remove Type member from CVRecord

Author: rnk Date: Wed Apr 3 17:28:48 2019 New Revision: 357658 URL: http://llvm.org/viewvc/llvm-project?rev=357658&view=rev Log: [codeview] Remove Type member from CVRecord Summary: Now CVType and CVSymbol are effectively type-safe wrappers around ArrayRef. Make the kind() accessor load it from

[Lldb-commits] [lldb] r347254 - Fix clang test suite on Windows by reverting part of r347216

Author: rnk Date: Mon Nov 19 11:36:28 2018 New Revision: 347254 URL: http://llvm.org/viewvc/llvm-project?rev=347254&view=rev Log: Fix clang test suite on Windows by reverting part of r347216 Otherwise, the clang analyzer tests fail on Windows when attempting to unpickle AnalyzerTest objects in th

[Lldb-commits] [lldb] r345882 - Fix clang -Wimplicit-fallthrough warnings across llvm, NFC

Author: rnk Date: Thu Nov 1 12:54:45 2018 New Revision: 345882 URL: http://llvm.org/viewvc/llvm-project?rev=345882&view=rev Log: Fix clang -Wimplicit-fallthrough warnings across llvm, NFC This patch should not introduce any behavior changes. It consists of mostly one of two changes: 1. Replacing

[Lldb-commits] [lldb] r339920 - Fix lldb-vscode build on Windows

Author: rnk Date: Thu Aug 16 11:24:59 2018 New Revision: 339920 URL: http://llvm.org/viewvc/llvm-project?rev=339920&view=rev Log: Fix lldb-vscode build on Windows Include PosixAPI.h to get a PATH_MAX definition and replace CreateEvent with CreateEventObject to avoid conflicts with the windows.h d

[Lldb-commits] [lldb] r339910 - Update LLDB for LLVM CodeView API change in r339907

Author: rnk Date: Thu Aug 16 10:51:58 2018 New Revision: 339910 URL: http://llvm.org/viewvc/llvm-project?rev=339910&view=rev Log: Update LLDB for LLVM CodeView API change in r339907 Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.cpp Modified: lldb/trunk/sour

[Lldb-commits] [lldb] r313332 - Fix syntax in lldb lit.cfg

Author: rnk Date: Thu Sep 14 18:30:52 2017 New Revision: 313332 URL: http://llvm.org/viewvc/llvm-project?rev=313332&view=rev Log: Fix syntax in lldb lit.cfg Modified: lldb/trunk/lit/lit.cfg Modified: lldb/trunk/lit/lit.cfg URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/lit.cfg?rev=

[Lldb-commits] [lldb] r298402 - Remove stray paren that got in while attempting to fix the build for AttributeList

Author: rnk Date: Tue Mar 21 12:15:50 2017 New Revision: 298402 URL: http://llvm.org/viewvc/llvm-project?rev=298402&view=rev Log: Remove stray paren that got in while attempting to fix the build for AttributeList Modified: lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptR

[Lldb-commits] [lldb] r298399 - Update for LLVM API rename of AttributeSet -> AttributeList

Author: rnk Date: Tue Mar 21 12:09:20 2017 New Revision: 298399 URL: http://llvm.org/viewvc/llvm-project?rev=298399&view=rev Log: Update for LLVM API rename of AttributeSet -> AttributeList Modified: lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86AB

[Lldb-commits] [lldb] r298011 - Update for LLVM API removal of Function::getArgumentList()

Author: rnk Date: Thu Mar 16 18:13:49 2017 New Revision: 298011 URL: http://llvm.org/viewvc/llvm-project?rev=298011&view=rev Log: Update for LLVM API removal of Function::getArgumentList() Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp lldb/trunk/source/Plugin

[Lldb-commits] [lldb] r259689 - Fix sign conversion warnings in LLDB Python unittests

Author: rnk Date: Wed Feb 3 14:48:09 2016 New Revision: 259689 URL: http://llvm.org/viewvc/llvm-project?rev=259689&view=rev Log: Fix sign conversion warnings in LLDB Python unittests Modified: lldb/trunk/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp Modified: lldb/trunk/uni