Re: [Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

pieandcakes added a comment. Would you be willing to please take another look? I think this should be the fix. Repository: rL LLVM https://reviews.llvm.org/D23026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

pieandcakes updated this revision to Diff 70107. pieandcakes added a comment. Fixed bracket. Repository: rL LLVM https://reviews.llvm.org/D23026 Files: tools/lldb-mi/MICmdCmdBreak.cpp tools/lldb-mi/MICmnResources.cpp tools/lldb-mi/MICmnResources.h Index: tools/lldb-mi/MICmnResources.h

Re: [Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

pieandcakes updated this revision to Diff 70088. pieandcakes added a comment. Added error message if location is not specified per reviewers comments. Repository: rL LLVM https://reviews.llvm.org/D23026 Files: tools/lldb-mi/MICmdCmdBreak.cpp tools/lldb-mi/MICmnResources.cpp tools/lldb-

Re: [Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

pieandcakes added a comment. Hi Ilia, Thanks for the review. There is another change I do need to make in the Execute() method and probably add some tests. I reviewed this spec for G

[Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

pieandcakes created this revision. pieandcakes added a reviewer: lldb-commits. pieandcakes set the repository for this revision to rL LLVM. pieandcakes added a project: LLDB. Herald added a subscriber: ki.stfu. [[ https://llvm.org/bugs/show_bug.cgi?id=28698 | bug 28698]] Repository: rL LLVM ht