petrhosek wrote:
@vogelsgesang Can we please merge this PR to unbreak the builders that were
broken by #104523?
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/petrhosek edited
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -53,10 +54,32 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
public:
LibCXXFrameRecognizer()
- : m_hidden_function_regex(
-R"(^std::__1::(__function.*::operator\(\)|__invoke))"
-R"((\[.*\])?)"// ABI tag.
-R"(( c
petrhosek wrote:
> Would be interesting if this is fixed by #105695. How can I run the test
> cases against libc++'s unstable ABI locally?
Set `-D LIBCXX_ABI_VERSION=2` in your CMake invocation.
https://github.com/llvm/llvm-project/pull/104523
___
ll
petrhosek wrote:
Looks like libc++ uses a different layout for `std::function` with ABI v1 and
v2, see
https://github.com/llvm/llvm-project/blob/52ae891036e3ab1f668eb103c46ca57257901c6b/libcxx/include/__functional/function.h#L827-L831.
https://github.com/llvm/llvm-project/pull/104523
_
petrhosek wrote:
I attempted a fix forward in
https://github.com/llvm/llvm-project/commit/68a1593a59c3d50aff43ef4f82ded224fc6a25db
but the test is still failing, although with a slightly different error now:
```
==
FAIL: test_b
Author: Petr Hosek
Date: 2024-08-26T01:23:09Z
New Revision: 68a1593a59c3d50aff43ef4f82ded224fc6a25db
URL:
https://github.com/llvm/llvm-project/commit/68a1593a59c3d50aff43ef4f82ded224fc6a25db
DIFF:
https://github.com/llvm/llvm-project/commit/68a1593a59c3d50aff43ef4f82ded224fc6a25db.diff
LOG: [l
petrhosek wrote:
> I reverted the reverts and pushed two commits to fix the missing
> initialization.
The libc++ issue I described earlier still hasn't been addressed so I'm going
to revert the changes again...
https://github.com/llvm/llvm-project/pull/104523
_
petrhosek wrote:
The `lldb-api :: lang/cpp/std-function-recognizer/TestStdFunctionRecognizer.py`
test has been failing on our builders with the following error:
```
Script:
--
/b/s/w/ir/x/w/lldb_install/python3/bin/python3
/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u
petrhosek wrote:
This `subtleFrames` is failing on our builders, would it be possible to take a
look?
```
Script:
--
/b/s/w/ir/x/w/lldb_install/python3/bin/python3
/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS
--env ARCHIVER=/b/s/w/ir/x/w/cipd/bin/llvm-ar --env
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/104831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/104831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,3 +1,14 @@
+include(CheckSymbolExists)
+include(CMakePushCheckState)
+
+cmake_push_check_state()
+set(CMAKE_REQUIRED_DEFINITIONS -D_GNU_SOURCE)
+check_symbol_exists(gettid "unistd.h" HAVE_GETTID)
+if(HAVE_GETTID)
+ add_compile_definitions(-DHAVE_GETTID)
pet
https://github.com/petrhosek approved this pull request.
LGTM but I'd wait for @JDevlieghere to respond.
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
petrhosek wrote:
I think a more idiomatic approach would be to use CMake to check if `gettid` is
available:
```
check_symbol_exists(gettid "unistd.h" HAVE_GETTID)
```
Then in `lldb/unittests/Process/elf-core/ThreadElfCoreTest.cpp` you'd define
`gettid` only `#if !HAVE_GETTID`.
https://github.c
petrhosek wrote:
> > Our bots and sysroot are based on the oldest supported versions of Debian,
> > based on the project's stated minimum requirements.
>
> @ilovepi Could you say which of the versions that you are using? That would
> help, I think.
It's Ubuntu 14.04 which uses glibc 2.19.
ht
petrhosek wrote:
> > What do you mean by "normal" location?
>
> "normal" as defined by whoever wrote Makefile.rules originally and thought
> that was the correct place to file tools like ar and objcopy, I guess? So, on
> your build machine, do you know where the llvm-dwp file might be installe
petrhosek wrote:
> > @petrhosek Is there a way you can help @kevinfrei validate this on Fuchsia
>
> Specifically, I'm adding tests that require dwp/llvm-dwp laying around
> somewhere, and it looks like Fuchsia doesn't put it in the 'normal' location,
> and I have no idea how to simply disable
petrhosek wrote:
We're seeing the same issue as well on our builders, will you be able to
address this today?
https://github.com/llvm/llvm-project/pull/95312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/petrhosek approved this pull request.
Thanks for a quick fix!
https://github.com/llvm/llvm-project/pull/96564
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
petrhosek wrote:
This broke the Windows build with the following error:
```
C:\b\s\w\ir\x\w\cipd\bin\clang-cl.exe /nologo -TP -DGTEST_HAS_RTTI=0
-DLIBXML_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE
-D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS
-D_ENABLE_EXTE
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/92865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1251,6 +1253,10 @@ elseif(LLVM_ENABLE_LTO)
endif()
endif()
+if(LLVM_ENABLE_FATLTO AND (FUCHSIA OR UNIX))
+append("-ffat-lto-objects" CMAKE_EXE_LINKER_FLAGS
CMAKE_SHARED_LINKER_FLAGS)
petrhosek wrote:
I think you also need to append this flag to `CM
petrhosek wrote:
I tried this branch on our Windows builders although I'm not sure if it's
related or not to this patch:
```
# COMPILED WITH
C:/b/s/w/ir/x/w/llvm_build/./bin/clang-cl.exe
C:\b\s\w\ir\x\w\github-H-G-Hristov-llvm-project\libcxx\test\libcxx\fuzzing\random.pass.cpp
--driver-mode=g+
petrhosek wrote:
This is still broken so I'm going to revert the change.
https://github.com/llvm/llvm-project/pull/76449
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
petrhosek wrote:
Please ignore 04c85587596ab10d885a957a00c8fa22740f15c1 which addresses a
different issue, this is still broken in tip-of-tree.
https://github.com/llvm/llvm-project/pull/76449
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
petrhosek wrote:
The `llvm-libc++-static-clangcl.cfg.in ::
std/utilities/format/format.arguments/format.arg/visit.return_type.pass.cpp` is
failing on Windows with the following error:
```
Exit Code: 1
Command Output (stdout):
--
# COMPILED WITH
C:/b/s/w/ir/x/w/llvm_build/./bin/clang-cl.exe
C:
petrhosek wrote:
`lldb-api :: functionalities/executable_first/TestExecutableFirst.py` is
failing on our Linux builders with the following error:
```
Script:
--
/b/s/w/ir/x/w/lldb_install/python3/bin/python3
/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS
--env AR
petrhosek wrote:
I have discovered another issue, on Fuchsia `libclang_rt.builtins.a` now has a
reference to `getauxval` which it didn't have before. This is really
undesirable because on Fuchsia, there's no `auxv` to begin with. I believe this
is because before, the `__init_cpu_features` defi
petrhosek wrote:
We're still seeing the following error on our builders:
```
/b/s/w/ir/x/w/llvm_build/./bin/clang --target=aarch64-unknown-linux-gnu
--sysroot=/b/s/w/ir/x/w/cipd/linux -DHAS_ASM_LSE -DVISIBILITY_HIDDEN
--target=aarch64-unknown-linux-gnu -O2 -g -DNDEBUG -fno-lto -std=c11 -fPIC
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
petrhosek wrote:
Can you break up all the changes to tests that replace `-debug-info-correlate`
with `--profile-correlate=debug-info` into a separate PR to reduce the size of
this PR?
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits m
@@ -702,6 +708,8 @@ serializeValueProfDataFrom(ValueProfRecordClosure *Closure,
#define INSTR_PROF_COVMAP_COMMON __llvm_covmap
#define INSTR_PROF_COVFUN_COMMON __llvm_covfun
#define INSTR_PROF_ORDERFILE_COMMON __llvm_orderfile
petrhosek wrote:
This just a nit,
petrhosek wrote:
Can we add back the constant to the declaration? It's been a week and the
progress on #72730 seems to have stalled while our builders are still broken.
https://github.com/llvm/llvm-project/pull/71780
___
lldb-commits mailing list
lldb
Author: Petr Hosek
Date: 2022-03-11T15:43:01-08:00
New Revision: 0c0f6cfb7b9fab0ee69ef67ed95c194698c9d794
URL:
https://github.com/llvm/llvm-project/commit/0c0f6cfb7b9fab0ee69ef67ed95c194698c9d794
DIFF:
https://github.com/llvm/llvm-project/commit/0c0f6cfb7b9fab0ee69ef67ed95c194698c9d794.diff
LO
Author: Petr Hosek
Date: 2020-08-31T20:06:21-07:00
New Revision: 3c7bfbd6831b2144229734892182d403e46d7baf
URL:
https://github.com/llvm/llvm-project/commit/3c7bfbd6831b2144229734892182d403e46d7baf
DIFF:
https://github.com/llvm/llvm-project/commit/3c7bfbd6831b2144229734892182d403e46d7baf.diff
LO
Author: Petr Hosek
Date: 2020-08-05T16:07:11-07:00
New Revision: 1adc494bce44f6004994deed61b30d4b71fe1d05
URL:
https://github.com/llvm/llvm-project/commit/1adc494bce44f6004994deed61b30d4b71fe1d05
DIFF:
https://github.com/llvm/llvm-project/commit/1adc494bce44f6004994deed61b30d4b71fe1d05.diff
LO
Author: Petr Hosek
Date: 2020-07-27T17:13:55-07:00
New Revision: 64d99cc6abed78c00a2a7863b02ce54911a5264f
URL:
https://github.com/llvm/llvm-project/commit/64d99cc6abed78c00a2a7863b02ce54911a5264f
DIFF:
https://github.com/llvm/llvm-project/commit/64d99cc6abed78c00a2a7863b02ce54911a5264f.diff
LO
Thanks for the heads up, this should be addressed
by c86f56e32e724c6018e579bb2bc11e667c96fc96, let me know if there are other
issues.
On Fri, Jul 24, 2020 at 12:33 PM Vedant Kumar via Phabricator <
revi...@reviews.llvm.org> wrote:
> vsk added a comment.
>
> @phosek I suspect this is causing a cma
Author: Petr Hosek
Date: 2020-07-24T13:36:13-07:00
New Revision: c86f56e32e724c6018e579bb2bc11e667c96fc96
URL:
https://github.com/llvm/llvm-project/commit/c86f56e32e724c6018e579bb2bc11e667c96fc96
DIFF:
https://github.com/llvm/llvm-project/commit/c86f56e32e724c6018e579bb2bc11e667c96fc96.diff
LO
Author: Petr Hosek
Date: 2020-07-23T23:05:36-07:00
New Revision: 10b1b4a231a485f1711d576e6131f6755e008abe
URL:
https://github.com/llvm/llvm-project/commit/10b1b4a231a485f1711d576e6131f6755e008abe
DIFF:
https://github.com/llvm/llvm-project/commit/10b1b4a231a485f1711d576e6131f6755e008abe.diff
LO
Author: Petr Hosek
Date: 2020-07-23T15:12:42-07:00
New Revision: 38c71b7c85cac4c8de39329ff3ed682e63f61525
URL:
https://github.com/llvm/llvm-project/commit/38c71b7c85cac4c8de39329ff3ed682e63f61525
DIFF:
https://github.com/llvm/llvm-project/commit/38c71b7c85cac4c8de39329ff3ed682e63f61525.diff
LO
Author: Petr Hosek
Date: 2020-07-23T14:47:25-07:00
New Revision: 1d09ecf36175f7910ffedd6d497c07b5c74c22fb
URL:
https://github.com/llvm/llvm-project/commit/1d09ecf36175f7910ffedd6d497c07b5c74c22fb
DIFF:
https://github.com/llvm/llvm-project/commit/1d09ecf36175f7910ffedd6d497c07b5c74c22fb.diff
LO
Author: phosek
Date: Tue Feb 5 19:51:00 2019
New Revision: 353268
URL: http://llvm.org/viewvc/llvm-project?rev=353268&view=rev
Log:
[CMake] Unify scripts for generating VCS headers
Previously, there were two different scripts for generating VCS headers:
one used by LLVM and one used by Clang and
Author: phosek
Date: Wed Jan 30 23:12:43 2019
New Revision: 352733
URL: http://llvm.org/viewvc/llvm-project?rev=352733&view=rev
Log:
Revert "[CMake] Unify scripts for generating VCS headers"
This reverts commits r352729 and r352731: this broke Sanitizer Windows bots
Modified:
lldb/trunk/sour
Author: phosek
Date: Wed Jan 30 22:47:10 2019
New Revision: 352731
URL: http://llvm.org/viewvc/llvm-project?rev=352731&view=rev
Log:
[CMake] Migrate lldb to the new VCS script
This was accidentaly omitted from r352729 and broke lldb bots.
Modified:
lldb/trunk/source/CMakeLists.txt
lldb/t
Author: phosek
Date: Tue Dec 12 17:14:27 2017
New Revision: 320537
URL: http://llvm.org/viewvc/llvm-project?rev=320537&view=rev
Log:
[lldb] Set component when invoking add_llvm_install_targets
This is needed to ensure that the distribution and install-distribution
targets work properly.
Differen
48 matches
Mail list logo
