peter.smith added a comment.
From the Arm side this looks good. Strictly speaking R_ARM_ABS32 doesn't
require overflow checking, but in this context adding it makes sense. It is
definitely the case that addends are signed in Arm, I guess there may be a
32-bit ABI that has unsigned REL addends,
peter.smith added a comment.
This change has broken a test in the Arm and AArch64 buildbots.
Specificallyclang/test/Import/cxx-anon-namespace/test.cpp For example
(http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/10542/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Atest.cpp)
F
