[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

2019-10-30 Thread Peiyuan Song via Phabricator via lldb-commits
SquallATF added a comment. In D69612#1726829 , @labath wrote: > LGTM, modulo the `(void) result` stuff. Do you need someone to commit this > for you? Yes I need. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

2019-10-30 Thread Peiyuan Song via Phabricator via lldb-commits
SquallATF created this revision. SquallATF added a reviewer: mstorsjo. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. _setmode in assert will not run when build with NDEBUG Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69612 Files: lldb/tools/lldb-vs