[Lldb-commits] [lldb] [lldb][AArch64] Handle core file tag segments missing tag data (PR #145338)

2025-06-24 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. Looks good to me. There was a comment somewhere in the core file tests which tells how to the core dump got generated. If you could update that to add information on which flags are needed to generate the attached core dump for this notag

[Lldb-commits] [lldb] [lldb][AArch64] Handle core file tag segments missing tag data (PR #145338)

2025-06-24 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid edited https://github.com/llvm/llvm-project/pull/145338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Handle core file tag segments missing tag data (PR #145338)

2025-06-24 Thread Omair Javaid via lldb-commits
omjavaid wrote: How do we generate this core file? Any particular flags to avoid generating tag data.? https://github.com/llvm/llvm-project/pull/145338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] b86b529 - [lldb][test] Mark DynamicValueTestCase XFAIL on Windows

2025-05-05 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2025-05-06T03:37:54+05:00 New Revision: b86b5296cb649c06abbb6471d6f0f777b91a29c9 URL: https://github.com/llvm/llvm-project/commit/b86b5296cb649c06abbb6471d6f0f777b91a29c9 DIFF: https://github.com/llvm/llvm-project/commit/b86b5296cb649c06abbb6471d6f0f777b91a29

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-22 Thread Omair Javaid via lldb-commits
omjavaid wrote: I have tested the using clang and used lld-link as the default linker the symbols are still zero. For now I have added a bypass commit for this to make buildbot happy. https://github.com/llvm/llvm-project/pull/136226 ___ lldb-commits

[Lldb-commits] [lldb] 974a8cc - [LLDB] Silence Windows buildbot failure caused by #136226

2025-04-22 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2025-04-22T18:03:54+05:00 New Revision: 974a8ccb2b9f5b930ce47f65122b5a86481e57fe URL: https://github.com/llvm/llvm-project/commit/974a8ccb2b9f5b930ce47f65122b5a86481e57fe DIFF: https://github.com/llvm/llvm-project/commit/974a8ccb2b9f5b930ce47f65122b5a86481e57

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-22 Thread Omair Javaid via lldb-commits
omjavaid wrote: the reported number of symbols is zero on Windows "symbolsLoaded": 0, ... }, ... ], ... "totalSymbolTablesLoaded": 0, "totalSymbolsLoaded": 0 } https://github.com/llvm/llvm-project/pull/136226 ___ lldb-commits

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-22 Thread Omair Javaid via lldb-commits
omjavaid wrote: this PR caused lldb windows buildbot to fail https://lab.llvm.org/buildbot/#/builders/141/builds/8084 https://github.com/llvm/llvm-project/pull/136226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [lldb] Add more ARM checks in TestLldbGdbServer.py (PR #130277)

2025-03-11 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. Looks good https://github.com/llvm/llvm-project/pull/130277 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5c065f0 - [lldb][Windows] Fix build with MSVC compiler broken by (#108072)

2025-02-03 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2025-02-03T15:17:08+05:00 New Revision: 5c065f01cee5dfca28d703983d0ebefa65128e09 URL: https://github.com/llvm/llvm-project/commit/5c065f01cee5dfca28d703983d0ebefa65128e09 DIFF: https://github.com/llvm/llvm-project/commit/5c065f01cee5dfca28d703983d0ebefa65128e

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-02-02 Thread Omair Javaid via lldb-commits
omjavaid wrote: > https://lab.llvm.org/buildbot/#/builders/197/builds/1447/steps/8/logs/stdio > > https://lab.llvm.org/buildbot/#/builders/197/builds/1447 > > Could you take care of it? @dzhidzhoev I am taking a look. Thanks for spotting this. https://github.com/llvm/llvm-project/pull/108072

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-31 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid closed https://github.com/llvm/llvm-project/pull/108072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-30 Thread Omair Javaid via lldb-commits
@@ -575,6 +575,10 @@ Changes to LLDB 24 int main() { Likely cause: f->b->d accessed 0x4 ``` +* LLDB now supports hardware watchpoints for AArch64 Windows targets. Windows + does not provide API to query the number of supported hardware watchpoints. + Therefore curr

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-30 Thread Omair Javaid via lldb-commits
omjavaid wrote: > This is a problem with watchpoints too, right? Yes this happens with watchpoints too on both AArch64 and x64 WIndows. > I can see an argument that says code breakpoints are much more likely to be > placed before the initial stop, so watchpoints are still useful even with > t

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-29 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid updated https://github.com/llvm/llvm-project/pull/108072 >From 82ee1429a0fcf67aa36bf6ca7debb5518211d16c Mon Sep 17 00:00:00 2001 From: Muhammad Omair Javaid Date: Tue, 10 Sep 2024 18:03:29 +0500 Subject: [PATCH 1/7] WoA hardware breakpoint/watchpoint support --- ..

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-29 Thread Omair Javaid via lldb-commits
omjavaid wrote: > ### Known Issues (Just for documentation): > 1. I have updates the PR description the "Known Issues (Just for documentation):" part will be skipped in the final patch description. https://github.com/llvm/llvm-project/pull/108072 ___

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-29 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid edited https://github.com/llvm/llvm-project/pull/108072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-29 Thread Omair Javaid via lldb-commits
@@ -575,6 +575,10 @@ Changes to LLDB 24 int main() { Likely cause: f->b->d accessed 0x4 ``` +* LLDB now supports hardware watchpoints for AArch64 Windows targets. Windows + does not provide API to query the number of supported hardware watchpoints. + Therefore curr

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-29 Thread Omair Javaid via lldb-commits
@@ -110,8 +110,8 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_x86_64::NativeRegisterContextWindows_x86_64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-29 Thread Omair Javaid via lldb-commits
@@ -492,23 +492,40 @@ NativeProcessWindows::OnDebugException(bool first_chance, } case DWORD(STATUS_BREAKPOINT): case STATUS_WX86_BREAKPOINT: omjavaid wrote: yes. Heres the detail from ntstatus.h // // MessageId: STATUS_WX86_BREAKPOINT // // MessageText:

[Lldb-commits] [lldb] [lldb][AArch64] Add register fields for Guarded Control Stack registers (PR #124295)

2025-01-28 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. Looks Good Thanks https://github.com/llvm/llvm-project/pull/124295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Add Guarded Control Stack support for Linux core files (PR #124293)

2025-01-28 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. Looks good. Thanks! https://github.com/llvm/llvm-project/pull/124293 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (PR #123918)

2025-01-27 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. I agree this is as good as we can get for now with failure handling during expression. https://github.com/llvm/llvm-project/pull/123918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-26 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid updated https://github.com/llvm/llvm-project/pull/108072 >From 8d064dae8f4addce2b9db0ba70a32c51e758d2cb Mon Sep 17 00:00:00 2001 From: Muhammad Omair Javaid Date: Tue, 10 Sep 2024 18:03:29 +0500 Subject: [PATCH 1/6] WoA hardware breakpoint/watchpoint support --- ..

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-26 Thread Omair Javaid via lldb-commits
@@ -492,23 +492,36 @@ NativeProcessWindows::OnDebugException(bool first_chance, } case DWORD(STATUS_BREAKPOINT): case STATUS_WX86_BREAKPOINT: -if (FindSoftwareBreakpoint(record.GetExceptionAddress())) { - LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-26 Thread Omair Javaid via lldb-commits
@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-26 Thread Omair Javaid via lldb-commits
@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-26 Thread Omair Javaid via lldb-commits
@@ -492,23 +492,36 @@ NativeProcessWindows::OnDebugException(bool first_chance, } case DWORD(STATUS_BREAKPOINT): case STATUS_WX86_BREAKPOINT: -if (FindSoftwareBreakpoint(record.GetExceptionAddress())) { - LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-26 Thread Omair Javaid via lldb-commits
@@ -492,23 +492,36 @@ NativeProcessWindows::OnDebugException(bool first_chance, } case DWORD(STATUS_BREAKPOINT): case STATUS_WX86_BREAKPOINT: -if (FindSoftwareBreakpoint(record.GetExceptionAddress())) { - LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.

[Lldb-commits] [lldb] [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (PR #123918)

2025-01-23 Thread Omair Javaid via lldb-commits
@@ -103,6 +156,9 @@ bool ABISysV_arm64::PrepareTrivialCall(Thread &thread, addr_t sp, return_addr)) return false; + if (GetProcessSP()->GetTarget().GetArchitecture().GetTriple().isOSLinux()) +PushToLinuxGuardedControlStack(return_addr, reg_ctx, thread); ---

[Lldb-commits] [lldb] [lldb][AArch64] Add Guarded Control Stack registers (PR #123720)

2025-01-23 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. This look good. Just a minor nit to add more details about how GCS locking testing is being done. https://github.com/llvm/llvm-project/pull/123720 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [lldb][AArch64] Add Guarded Control Stack registers (PR #123720)

2025-01-23 Thread Omair Javaid via lldb-commits
@@ -83,3 +83,137 @@ def test_gcs_fault(self): "stop reason = signal SIGSEGV: control protection fault", ], ) + +@skipUnlessArch("aarch64") +@skipUnlessPlatform(["linux"]) +def test_gcs_registers(self): +if not self.isAArch

[Lldb-commits] [lldb] [lldb][AArch64] Add Guarded Control Stack registers (PR #123720)

2025-01-23 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid edited https://github.com/llvm/llvm-project/pull/123720 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Add Guarded Control Stack registers (PR #123720)

2025-01-23 Thread Omair Javaid via lldb-commits
@@ -2,8 +2,8 @@ #include #include -#ifndef HWCAP2_GCS -#define HWCAP2_GCS (1UL << 63) +#ifndef HWCAP_GCS +#define HWCAP_GCS (1UL << 32) omjavaid wrote: Apprently following entry is misleading "Support for GCS is reported to userspace via HWCAP_GCS in the

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-01-21 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid requested changes to this pull request. This should be able make lldb\test\API\tools\lldb-dap\runInTerminal\TestDAP_runInTerminal.py pass all tests. Please tests and remove the skipping decorators. https://github.com/llvm/llvm-project/pull/121269 ___

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-01-21 Thread Omair Javaid via lldb-commits
@@ -71,12 +74,14 @@ class FifoFileIO { /// \return /// An \a llvm::Error object indicating whether the data was consumed by /// a reader or not. - llvm::Error SendJSON( - const llvm::json::Value &json, - std::chrono::milliseconds timeout = std::chrono::

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-01-21 Thread Omair Javaid via lldb-commits
@@ -71,12 +74,14 @@ class FifoFileIO { /// \return /// An \a llvm::Error object indicating whether the data was consumed by /// a reader or not. - llvm::Error SendJSON( - const llvm::json::Value &json, - std::chrono::milliseconds timeout = std::chrono::

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-01-21 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid edited https://github.com/llvm/llvm-project/pull/121269 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Linux] Add Control Protection Fault signal (PR #122917)

2025-01-20 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. https://github.com/llvm/llvm-project/pull/122917 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-14 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. https://github.com/llvm/llvm-project/pull/117861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -101,12 +105,13 @@ class MemoryRegionInfo { bool operator==(const MemoryRegionInfo &rhs) const { return m_range == rhs.m_range && m_read == rhs.m_read && m_write == rhs.m_write && m_execute == rhs.m_execute && - m_shared == rhs.m_shared && -

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -1629,10 +1630,10 @@ Status GDBRemoteCommunicationClient::GetMemoryRegionInfo( std::tie(flag, flags) = flags.split(' '); omjavaid wrote: instead of tokenizing and checking cant we just use `if (value.contains("mt")) region_info.SetMemoryTagged

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -164,12 +164,17 @@ void lldb_private::ParseLinuxSMapRegions(llvm::StringRef linux_smap, if (!name.contains(' ')) { if (region) { if (name == "VmFlags") { - if (value.contains("mt")) -region->SetMemoryTagged(MemoryRegionInfo::eYes); -

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -2796,11 +2796,17 @@ GDBRemoteCommunicationServerLLGS::Handle_qMemoryRegionInfo( // Flags MemoryRegionInfo::OptionalBool memory_tagged = region_info.GetMemoryTagged(); -if (memory_tagged != MemoryRegionInfo::eDontKnow) { +MemoryRegionInfo::OptionalBo

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-08 Thread Omair Javaid via lldb-commits
omjavaid wrote: @DavidSpickett have you posted rest of the patches for GCS other than this one? https://github.com/llvm/llvm-project/pull/117861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2025-01-08 Thread Omair Javaid via lldb-commits
omjavaid wrote: I read the documentation again and find some minor points. Feel free to ignore them if you want. https://github.com/llvm/llvm-project/pull/117860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -229,3 +229,64 @@ bytes. `zt0`'s value and whether it is active or not will be saved prior to expression evaluation and restored afterwards. + +## Guarded Control Stack Extension (GCS) + +GCS support includes the following new registers: + +* `gcs_features_enabled` +* `gcs_

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -229,3 +229,64 @@ bytes. `zt0`'s value and whether it is active or not will be saved prior to expression evaluation and restored afterwards. + +## Guarded Control Stack Extension (GCS) + +GCS support includes the following new registers: + +* `gcs_features_enabled` +* `gcs_

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -229,3 +229,64 @@ bytes. `zt0`'s value and whether it is active or not will be saved prior to expression evaluation and restored afterwards. + +## Guarded Control Stack Extension (GCS) + +GCS support includes the following new registers: + +* `gcs_features_enabled` +* `gcs_

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2024-12-11 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. Looks good. Thanks for making the changes. https://github.com/llvm/llvm-project/pull/117860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2024-12-11 Thread Omair Javaid via lldb-commits
@@ -229,3 +229,54 @@ bytes. `zt0`'s value and whether it is active or not will be saved prior to expression evaluation and restored afterwards. + +## Guarded Control Stack Extension (GCS) + +GCS support includes the following new registers: + +* `gcs_features_enabled` +* `gcs_

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2024-12-11 Thread Omair Javaid via lldb-commits
omjavaid wrote: Can we test this with QEMU? https://github.com/llvm/llvm-project/pull/117861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2024-12-11 Thread Omair Javaid via lldb-commits
@@ -229,3 +229,54 @@ bytes. `zt0`'s value and whether it is active or not will be saved prior to expression evaluation and restored afterwards. + +## Guarded Control Stack Extension (GCS) + +GCS support includes the following new registers: + +* `gcs_features_enabled` +* `gcs_

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2024-12-11 Thread Omair Javaid via lldb-commits
@@ -229,3 +229,54 @@ bytes. `zt0`'s value and whether it is active or not will be saved prior to expression evaluation and restored afterwards. + +## Guarded Control Stack Extension (GCS) + +GCS support includes the following new registers: + +* `gcs_features_enabled` +* `gcs_

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2024-12-11 Thread Omair Javaid via lldb-commits
@@ -229,3 +229,54 @@ bytes. `zt0`'s value and whether it is active or not will be saved prior to expression evaluation and restored afterwards. + +## Guarded Control Stack Extension (GCS) + +GCS support includes the following new registers: + +* `gcs_features_enabled` +* `gcs_

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2024-12-11 Thread Omair Javaid via lldb-commits
@@ -229,3 +229,54 @@ bytes. `zt0`'s value and whether it is active or not will be saved prior to expression evaluation and restored afterwards. + +## Guarded Control Stack Extension (GCS) + +GCS support includes the following new registers: + +* `gcs_features_enabled` +* `gcs_

[Lldb-commits] [lldb] [lldb] Set LLDB_USE_NATIVE_PDB_READER at the directory level (PR #114455)

2024-10-31 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. Looks good to me https://github.com/llvm/llvm-project/pull/114455 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3bc58fc - [lldb][test] Fix FileActionTest.cpp for Windows (#112657)

2024-10-31 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-10-31T14:37:32+05:00 New Revision: 3bc58fc7f79a9b0cbf931573cb257344bfeaca1e URL: https://github.com/llvm/llvm-project/commit/3bc58fc7f79a9b0cbf931573cb257344bfeaca1e DIFF: https://github.com/llvm/llvm-project/commit/3bc58fc7f79a9b0cbf931573cb257344bfeaca

[Lldb-commits] [lldb] [lldb] Remove SymbolFilePDB and make the native one the default (PR #113647)

2024-10-25 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid requested changes to this pull request. I will test this and may be we can move ahead in case failures are trivial https://github.com/llvm/llvm-project/pull/113647 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] [lldb] Remove SymbolFilePDB and make the native one the default (PR #113647)

2024-10-25 Thread Omair Javaid via lldb-commits
omjavaid wrote: We set DIA SDK as the default symbol provider on windows. So I don think this change is appropriate at this stage without testing the complete fallout. Although I believe we should move in that direction sooner or later. https://github.com/llvm/llvm-project/pull/113647

[Lldb-commits] [lldb] [lldb][AArch64] Read fpmr register from core files (PR #110104)

2024-10-25 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. Looks Good. Sorry about delayed review! https://github.com/llvm/llvm-project/pull/110104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] 69f7758 - Revert "[lldb] Fix command-expr-diagnostics.test for Windows (#112109)"

2024-10-15 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-10-16T06:08:13+05:00 New Revision: 69f7758ddba662b63667507f2c472c008909dd7e URL: https://github.com/llvm/llvm-project/commit/69f7758ddba662b63667507f2c472c008909dd7e DIFF: https://github.com/llvm/llvm-project/commit/69f7758ddba662b63667507f2c472c008909dd

[Lldb-commits] [lldb] eca3206 - [lldb] Fix command-expr-diagnostics.test for Windows (#112109)

2024-10-15 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-10-16T05:33:27+05:00 New Revision: eca3206d29e7ce97dd6336deaa3da96be37f8277 URL: https://github.com/llvm/llvm-project/commit/eca3206d29e7ce97dd6336deaa3da96be37f8277 DIFF: https://github.com/llvm/llvm-project/commit/eca3206d29e7ce97dd6336deaa3da96be37f82

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2024-10-09 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid updated https://github.com/llvm/llvm-project/pull/108072 >From ac61e5a75ce59f7834034494a03b43e81bf02d41 Mon Sep 17 00:00:00 2001 From: Muhammad Omair Javaid Date: Tue, 10 Sep 2024 18:03:29 +0500 Subject: [PATCH 1/4] WoA hardware breakpoint/watchpoint support --- ..

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2024-10-09 Thread Omair Javaid via lldb-commits
omjavaid wrote: @DavidSpickett @labath I have updated this PR and dropped hardware breakpoint support for the unresolved "set hw break on main" issue As x86_64 windows also does not support hardware breakpoints (probably for the same reason). This PR now only implements HW watchpoint support.

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2024-10-09 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid edited https://github.com/llvm/llvm-project/pull/108072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2024-10-09 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid edited https://github.com/llvm/llvm-project/pull/108072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-10-09 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid updated https://github.com/llvm/llvm-project/pull/108072 >From ac61e5a75ce59f7834034494a03b43e81bf02d41 Mon Sep 17 00:00:00 2001 From: Muhammad Omair Javaid Date: Tue, 10 Sep 2024 18:03:29 +0500 Subject: [PATCH 1/3] WoA hardware breakpoint/watchpoint support --- ..

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-10-09 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid updated https://github.com/llvm/llvm-project/pull/108072 >From ac61e5a75ce59f7834034494a03b43e81bf02d41 Mon Sep 17 00:00:00 2001 From: Muhammad Omair Javaid Date: Tue, 10 Sep 2024 18:03:29 +0500 Subject: [PATCH 1/2] WoA hardware breakpoint/watchpoint support --- ..

[Lldb-commits] [lldb] [lldb][AArch64] Add register fields for the fpmr register (PR #109934)

2024-09-26 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. Looks good to me but I have not tested this. https://github.com/llvm/llvm-project/pull/109934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add Floating Point Mode Register (PR #106695)

2024-09-25 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. This looks good to me. I haven't tested it myself though. Just one thing that's bothering me is that we are now gradually implementing a number of similar functions to read/write feature registers like ZT ZA or FPMR etc. There will be m

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-12 Thread Omair Javaid via lldb-commits
omjavaid wrote: > > Yes I think there might be a Windows API launch flag that can let us do > > early detection of hardware breakpoints and watchpoints. But so far after > > lots of experimentation I have not been able to find the right set. > > Is it possible this is a bug in Windows itself?

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-11 Thread Omair Javaid via lldb-commits
@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-11 Thread Omair Javaid via lldb-commits
@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-11 Thread Omair Javaid via lldb-commits
omjavaid wrote: > Seems ok to me. > > If I had to guess, I'd say that the initial stop problem is due to us > stopping the process "too early" (i.e., in a state where it's not yet fully > initialized and ready to accept debugger commands). Maybe there's a different > way to stop the process a

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-11 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid edited https://github.com/llvm/llvm-project/pull/108072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-11 Thread Omair Javaid via lldb-commits
omjavaid wrote: > Remind me, does lldb support hardware breakpoints for x86 right now either? > From the content of this PR, I assume it does not. > > (which is fine, I'm just trying to be clear what our starting point is) yes x86_64 windows does not support hardware breakpoints. However it doe

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-11 Thread Omair Javaid via lldb-commits
@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-11 Thread Omair Javaid via lldb-commits
@@ -491,24 +491,47 @@ NativeProcessWindows::OnDebugException(bool first_chance, return ExceptionResult::MaskException; } case DWORD(STATUS_BREAKPOINT): - case STATUS_WX86_BREAKPOINT: -if (FindSoftwareBreakpoint(record.GetExceptionAddress())) { - LLDB_LOG(log,

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-11 Thread Omair Javaid via lldb-commits
@@ -178,9 +178,41 @@ Status NativeThreadWindows::RemoveWatchpoint(lldb::addr_t addr) { Status NativeThreadWindows::SetHardwareBreakpoint(lldb::addr_t addr, size_t size) { +#if defined(__aarch64__) || defined(_M_ARM64)

[Lldb-commits] [lldb] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-10 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid updated https://github.com/llvm/llvm-project/pull/108072 >From ac61e5a75ce59f7834034494a03b43e81bf02d41 Mon Sep 17 00:00:00 2001 From: Muhammad Omair Javaid Date: Tue, 10 Sep 2024 18:03:29 +0500 Subject: [PATCH] WoA hardware breakpoint/watchpoint support --- .../Wi

[Lldb-commits] [lldb] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-10 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid created https://github.com/llvm/llvm-project/pull/108072 This pull request adds support for hardware breakpoints and watchpoints in LLDB on Windows on ARM. ### Known Issues: 1. **Number of Supported Hardware Breakpoints/Watchpoints:** Windows does not provide the

[Lldb-commits] [lldb] 07b3e2c - [LLDB] XFail on Windows TestThreadAPI.py test_StepInstruction

2024-07-04 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-07-04T15:59:05+05:00 New Revision: 07b3e2c0c68b93a3d4d89426dc7fd14cc31ca6be URL: https://github.com/llvm/llvm-project/commit/07b3e2c0c68b93a3d4d89426dc7fd14cc31ca6be DIFF: https://github.com/llvm/llvm-project/commit/07b3e2c0c68b93a3d4d89426dc7fd14cc31ca6

[Lldb-commits] [lldb] 95038a5 - [LLDB] Import decorators in TestPythonOSPlugin.py

2024-07-01 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-07-02T02:29:16+05:00 New Revision: 95038a58268f8aeb7e35ce07fd82bbb3f48e4673 URL: https://github.com/llvm/llvm-project/commit/95038a58268f8aeb7e35ce07fd82bbb3f48e4673 DIFF: https://github.com/llvm/llvm-project/commit/95038a58268f8aeb7e35ce07fd82bbb3f48e46

[Lldb-commits] [lldb] f5dd845 - [LLDB] SkipIf TestPythonOSPlugin.py on Windows

2024-07-01 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-07-02T02:21:23+05:00 New Revision: f5dd8450940b003afb446846840cd19b067d327d URL: https://github.com/llvm/llvm-project/commit/f5dd8450940b003afb446846840cd19b067d327d DIFF: https://github.com/llvm/llvm-project/commit/f5dd8450940b003afb446846840cd19b067d32

[Lldb-commits] [lldb] 781ba3c - [LLDB] Fix TestGdbRemoteConnection.py on Windows

2024-07-01 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-07-02T01:41:32+05:00 New Revision: 781ba3c6b0bc5e4f6b54b43cce94a4aee175ffc1 URL: https://github.com/llvm/llvm-project/commit/781ba3c6b0bc5e4f6b54b43cce94a4aee175ffc1 DIFF: https://github.com/llvm/llvm-project/commit/781ba3c6b0bc5e4f6b54b43cce94a4aee175ff

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-06-29 Thread Omair Javaid via lldb-commits
omjavaid wrote: This breaks lldb-api :: tools/lldb-server/commandline/TestGdbRemoteConnection.py on lldb-aarch64-windows bot. https://lab.llvm.org/buildbot/#/builders/141/builds/376 https://github.com/llvm/llvm-project/pull/91570 ___ lldb-commits

[Lldb-commits] [lldb] 02b6089 - [LLDB] xfail SymbolFile/DWARF/packed.cpp for Windows

2024-06-29 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-06-29T16:51:39+05:00 New Revision: 02b60893c3858d5d76cdca1bd9b684bdd7093fb7 URL: https://github.com/llvm/llvm-project/commit/02b60893c3858d5d76cdca1bd9b684bdd7093fb7 DIFF: https://github.com/llvm/llvm-project/commit/02b60893c3858d5d76cdca1bd9b684bdd7093f

[Lldb-commits] [lldb] [lldb/aarch64] Fix unwinding when signal interrupts a leaf function (PR #91321)

2024-05-13 Thread Omair Javaid via lldb-commits
omjavaid wrote: > > LLDB became unresponsive on windows when a `thread backtrace` command was > > issued after hitting the exception i have temporarily reverted the change > > to make buildbot green. > > Could you please give me some more information about the problem? I don't > have access t

[Lldb-commits] [lldb] 6cfac49 - [lldb][DWARF] Mark delayed-definition-die-searching.test unsupported on Windows

2024-05-13 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-05-14T03:58:26+05:00 New Revision: 6cfac497e96978f2bfc50a00b51c198f2ed50f82 URL: https://github.com/llvm/llvm-project/commit/6cfac497e96978f2bfc50a00b51c198f2ed50f82 DIFF: https://github.com/llvm/llvm-project/commit/6cfac497e96978f2bfc50a00b51c198f2ed50f

[Lldb-commits] [lldb] bc17361 - [lldb][DWARF] Fix delayed-definition-die-searching.test for Windows

2024-05-13 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-05-13T16:53:15+05:00 New Revision: bc17361c2baa0351f7f19b716fbe76bc9f99e903 URL: https://github.com/llvm/llvm-project/commit/bc17361c2baa0351f7f19b716fbe76bc9f99e903 DIFF: https://github.com/llvm/llvm-project/commit/bc17361c2baa0351f7f19b716fbe76bc9f99e9

[Lldb-commits] [lldb] [lldb/aarch64] Fix unwinding when signal interrupts a leaf function (PR #91321)

2024-05-13 Thread Omair Javaid via lldb-commits
omjavaid wrote: LLDB became unresponsive on windows when a `thread backtrace` command was issued after hitting the exception i have temporarily reverted the change to make buildbot green. https://github.com/llvm/llvm-project/pull/91321 ___ lldb-commi

[Lldb-commits] [lldb] 4b44502 - Revert "[lldb/aarch64] Fix unwinding when signal interrupts a leaf function (#91321)"

2024-05-13 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-05-13T16:05:02+05:00 New Revision: 4b44502ac81259630b422e791a82e0252e6478c3 URL: https://github.com/llvm/llvm-project/commit/4b44502ac81259630b422e791a82e0252e6478c3 DIFF: https://github.com/llvm/llvm-project/commit/4b44502ac81259630b422e791a82e0252e6478

[Lldb-commits] [lldb] 0a6103e - Revert "[lldb] Attempt to fix signal-in-leaf-function-aarch64 on darwin"

2024-05-13 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-05-13T16:05:02+05:00 New Revision: 0a6103eaeb7f22c009f9add87c84780b6f7f293a URL: https://github.com/llvm/llvm-project/commit/0a6103eaeb7f22c009f9add87c84780b6f7f293a DIFF: https://github.com/llvm/llvm-project/commit/0a6103eaeb7f22c009f9add87c84780b6f7f29

[Lldb-commits] [lldb] [lldb/aarch64] Fix unwinding when signal interrupts a leaf function (PR #91321)

2024-05-13 Thread Omair Javaid via lldb-commits
omjavaid wrote: @labath this seems to have broken lldb-aarch64-windows bot with TestInterruptBacktrace.py failing on num_frames = thread.GetNumFrames() https://github.com/llvm/llvm-project/pull/91321 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] 7fc2fbb - Revert "DebugInfoD tests + fixing issues exposed by tests (#85693)"

2024-03-22 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-03-23T03:31:56+05:00 New Revision: 7fc2fbb3f1961e0ad0722c2d749ddd6264195a1c URL: https://github.com/llvm/llvm-project/commit/7fc2fbb3f1961e0ad0722c2d749ddd6264195a1c DIFF: https://github.com/llvm/llvm-project/commit/7fc2fbb3f1961e0ad0722c2d749ddd6264195a

[Lldb-commits] [lldb] 4406e4a - Revert "Missed a null-ptr check in previous PR for Debuginfod testing (#86292)"

2024-03-22 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-03-23T03:31:25+05:00 New Revision: 4406e4a8bd5acadd980d84356b36030cadf9a61d URL: https://github.com/llvm/llvm-project/commit/4406e4a8bd5acadd980d84356b36030cadf9a61d DIFF: https://github.com/llvm/llvm-project/commit/4406e4a8bd5acadd980d84356b36030cadf9a6

[Lldb-commits] [lldb] DebugInfoD tests + fixing issues exposed by tests (PR #85693)

2024-03-22 Thread Omair Javaid via lldb-commits
omjavaid wrote: both commits from this PR broke LLDB buildbots on Arm and AArch64 Linux. New tests apparently are failing on Arm/AArch64 Linux. https://lab.llvm.org/buildbot/#/builders/96/builds/54867 https://lab.llvm.org/buildbot/#/builders/17/builds/50824 I will be reverting [b1575f9](https:/

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-19 Thread Omair Javaid via lldb-commits
omjavaid wrote: I have reverted this temporarily as it broke TestLinuxCore.py on lldb-*-windows. Kindly have a look at https://lab.llvm.org/buildbot/#/builders/219/builds/7014 https://github.com/llvm/llvm-project/pull/71769 ___ lldb-commits maili

[Lldb-commits] [lldb] c1fe190 - Revert "Add new API in SBTarget for loading core from SBFile (#71769)"

2023-11-19 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2023-11-20T11:12:34+05:00 New Revision: c1fe1900491ae773e45e41604af25312e5fc6559 URL: https://github.com/llvm/llvm-project/commit/c1fe1900491ae773e45e41604af25312e5fc6559 DIFF: https://github.com/llvm/llvm-project/commit/c1fe1900491ae773e45e41604af25312e5fc65

  1   2   3   4   5   6   >