[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

chapuni added inline comments. Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:19 +#include + Odd layering... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148384/new/ https://reviews.llvm.org/D148384

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

chapuni added inline comments. Comment at: clang/test/Modules/gmodules-preferred-name-alias.cpp:6 +// RUN: -fmodules -mllvm -debug-only=pchcontainer -x c++ \ +// RUN: -I %S/Inputs %s &> %t.ll +// RUN: cat %t.ll | FileCheck %s I guess it made difficult to

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

chapuni added inline comments. Comment at: clang/lib/Sema/TypeLocBuilder.cpp:159 - assert(Capacity - Index == TypeLoc::getFullDataSizeForType(T) && + unsigned FDSz = TypeLoc::getFullDataSizeForType(T); + assert(Capacity - Index == FDSz && It causes a warning

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

chapuni accepted this revision. chapuni added a comment. Regardless of https://reviews.llvm.org/D36211, I hope this to be landed. It's not late, if we would revert this again, after the discussion would be concluded. This is an issue around hidden header-header dependencies. If clang's -fmodule

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

chapuni added a comment. @mgorny was doing the right thing. The user of llvm/ExecutionEngine/SectionMemoryManager.h (from lldb/Expression/IRExecutionUnit.h) may depend on RuntimeDyld. If a derived class from RTDyldMemoryManager is implemented, it should depend on RuntimeDyld. Repository: rL