https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/160149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/160067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -105,24 +106,21 @@ enum {
#include "SymbolFilePDBPropertiesEnum.inc"
};
-#if LLVM_ENABLE_DIA_SDK && defined(_WIN32)
-bool ShouldUseNativeReaderByDefault() {
- static bool g_use_native_by_default = true;
-
- static llvm::once_flag g_initialize;
- llvm::call_once(g_initial
@@ -118,11 +118,14 @@ TEST(ScalarTest, RightShiftOperator) {
int a = 0x1000;
int b = 0x;
int c = 4;
+ unsigned d = 0x;
Scalar a_scalar(a);
Scalar b_scalar(b);
Scalar c_scalar(c);
+ Scalar d_scalar(d);
ASSERT_EQ(a >> c, a_scalar >> c_scala
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/160149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,65 @@
+// REQUIRES: !diasdk, target-windows
+
+// Test plugin.symbol-file.pdb.reader setting without the DIA SDK
+// RUN: %build -o %t.exe -- %s
+// RUN: env -u LLDB_USE_NATIVE_PDB_READER %lldb %t.exe -o 'target modules dump
symfile' 2>&1 | FileCheck --check-prefix=NO-
@@ -136,6 +141,21 @@ class PluginProperties : public Properties {
bool UseNativeReader() const {
#if LLVM_ENABLE_DIA_SDK && defined(_WIN32)
+return IsNativeReaderRequested();
+#else
+if (!IsNativeReaderRequested()) {
+ static std::once_flag g_warning_shown;
+
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/160074
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/160132
>From 6293105c42e29cc9151eaac33a4208a91e40a0e9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 22 Sep 2025 16:02:35 +0100
Subject: [PATCH 1/4] Init
---
.../SymbolFile/DWARF/DWARFASTParserClang.cpp |
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/160132
>From 6293105c42e29cc9151eaac33a4208a91e40a0e9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 22 Sep 2025 16:02:35 +0100
Subject: [PATCH 1/2] Init
---
.../SymbolFile/DWARF/DWARFASTParserClang.cpp |
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/160132
None
>From 6293105c42e29cc9151eaac33a4208a91e40a0e9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 22 Sep 2025 16:02:35 +0100
Subject: [PATCH] Init
---
.../SymbolFile/DWARF/DWARFASTParserClang.cpp
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/159401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/159401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -117,11 +117,16 @@ bool ShouldUseNativeReaderByDefault() {
!env_value.equals_insensitive("1") &&
!env_value.equals_insensitive("true"))
g_use_native_by_default = false;
+
+#if !LLVM_ENABLE_DIA_SDK || !defined(_WIN32)
+// if the environment value is
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/160074
…e persistent variables
Here's an example crash that we've seen sporadically over the years:
```
0 libsystem_kernel.dylib 0x19d392388 __pthread_kill + 8
1 libsystem_pthread.dylib
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/160074
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
The `m_passthrough` guard was added in
https://github.com/llvm/llvm-project/commit/4e969da33e113dffc1dfcf5c5e3ef97e3b594161
I assume something got refactored since then that broke it again. Or maybe it
was fixing a different codepath leading to this crash
https://github.com/
@@ -1,51 +1,63 @@
REQUIRES: target-windows, lld
RUN: %build --compiler=clang-cl --output=%t.exe %S/Inputs/UdtLayoutTest.cpp
-RUN: %lldb -b -s %S/Inputs/UdtLayoutTest.script -- %t.exe | FileCheck %s
+RUN: env LLDB_USE_NATIVE_PDB_READER=0 %lldb -b -s
%S/Inputs/UdtLayoutTest.scrip
https://github.com/Michael137 approved this pull request.
Do you have a C++ example snippet of how this happens?
https://github.com/llvm/llvm-project/pull/159401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
@@ -1676,6 +1676,14 @@ TypeSystemClang::CreateClassTemplateSpecializationDecl(
class_template_specialization_decl->setInstantiationOf(class_template_decl);
class_template_specialization_decl->setTemplateArgs(
TemplateArgumentList::CreateCopy(ast, args));
+ void *Inse
https://github.com/Michael137 approved this pull request.
LGTM (module remaining comments)
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/133079
>From 8f3f629b3913a5402a87786c4e1387d880d83f11 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 26 Mar 2025 12:54:36 +
Subject: [PATCH] [lldb][Instrumentation] Set selected frame to outside
sanitiz
Michael137 wrote:
/cherry-pick 39572f5e9168b1b44c2f9078494616fed8752086
879f40ab041b31fa73b9b25e4ec9e06e810bc767
bdf645bb9b509b60bdb6a71d865b4f8999187977
5326b3b176e82191b18ffc368118b36e0103af3d
https://github.com/llvm/llvm-project/pull/133079
___
l
@@ -959,6 +959,9 @@ CompilerType
TypeSystemClang::GetBuiltinTypeForDWARFEncodingAndBitSize(
if (type_name == "long double" &&
QualTypeMatchesBitSize(bit_size, ast, ast.LongDoubleTy))
return GetType(ast.LongDoubleTy);
+if (type_name == "__bf16" &&
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/122265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/149827
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -599,6 +599,39 @@ TEST_F(DWARFASTParserClangTests,
TestDefaultTemplateParamParsing) {
}
}
+TEST_F(DWARFASTParserClangTests, TestSpecDeclExistsError) {
+ // Tests checking error if ClassTemplateSpecializationDecl already exists.
Michael137 wrote:
```sug
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/122265
>From a9e13ad8d2a7a95d431dddcced611bea1e83b99a Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Jan 2025 10:01:31 +
Subject: [PATCH 01/14] [clang][DebugInfo] Expand detection of structured
bindin
Michael137 wrote:
> Just as few nits (sorry for the delay and thanks for the pings!)
No worries! Thanks for the review
https://github.com/llvm/llvm-project/pull/122265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/122265
>From a9e13ad8d2a7a95d431dddcced611bea1e83b99a Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Jan 2025 10:01:31 +
Subject: [PATCH 01/14] [clang][DebugInfo] Expand detection of structured
bindin
Michael137 wrote:
any objections to latest version @cor3ntin ?
https://github.com/llvm/llvm-project/pull/122265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Sorry for the delay. Thanks for adding the test. That was really helpful
This is the DWARF of the test yaml:
```
test.o: file format elf64-x86-64
.debug_info contents:
0x: Compile Unit: length = 0x009e, format = DWARF32, version =
0x0004, abbr_offset = 0x, add
https://github.com/Michael137 commented:
thanks!
https://github.com/llvm/llvm-project/pull/158286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1791,6 +1797,7 @@ bool TypeSystemClang::RecordHasFields(const RecordDecl
*record_decl) {
for (base_class = cxx_record_decl->bases_begin(),
base_class_end = cxx_record_decl->bases_end();
base_class != base_class_end; ++base_class) {
+ assert(record
@@ -82,7 +82,7 @@ def test(self):
value = self.expect_expr("temp7", result_type="Foo<__fp16, __fp16>")
Michael137 wrote:
Shouldn't this one show up as `_Float16` now? Or is there some other place
we're missing support for this?
https://github.com/llvm/
https://github.com/Michael137 auto_merge_enabled
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/156033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 auto_merge_enabled
https://github.com/llvm/llvm-project/pull/133079
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-09-16T10:30:49+01:00
New Revision: f5022bd03e7beab522ab3684228d531ef5c0789a
URL:
https://github.com/llvm/llvm-project/commit/f5022bd03e7beab522ab3684228d531ef5c0789a
DIFF:
https://github.com/llvm/llvm-project/commit/f5022bd03e7beab522ab3684228d531ef5c0789a.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/86159
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-09-09T13:37:07+01:00
New Revision: 6dfc255ee103fda23d14ef2765123dd34f646ccd
URL:
https://github.com/llvm/llvm-project/commit/6dfc255ee103fda23d14ef2765123dd34f646ccd
DIFF:
https://github.com/llvm/llvm-project/commit/6dfc255ee103fda23d14ef2765123dd34f646ccd.diff
Michael137 wrote:
Hmm test failures look odd. I did recently re-enable all the import-std-module
tests. Though i havent heard reports of them failing on CI. Can you rerun the
CO and aee if these are just flakey?
https://github.com/llvm/llvm-project/pull/158286
_
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/86159
>From e028a31433ef1dced308f485851b0eb3d43ff54c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 21 Mar 2024 17:45:23 +
Subject: [PATCH 1/3] [lldb][TypeSystem] Enable colored AST dump
This patch sets
Michael137 wrote:
> You can't get from a TypeSystem to a Target directly, because TypeSystem's
> live in Modules and Modules live outside any particular target in the global
> module cache. Maybe you need to pass this in to the call to dump the functions
Ended up taking this approach
https://
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/86159
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -113,10 +113,10 @@ CompilerType
lldb_private::formatters::LibcxxStdUnorderedMapSyntheticFrontEnd::
// wraps a std::pair. Peel away the internal wrapper type - whose structure
is
// of no value to users, to expose the std::pair. This matches the structure
// returned
Michael137 wrote:
> > @da-viper since you can repro this issue locally, mind confirming @labath's
> > theory ([#156033 (comment)]
> > ([#156033
> > (comment)](https://github.com/llvm/llvm-project/pull/156033#issuecomment-3253156453)))?
>
> > The "frame var" expression would be more similar to
Michael137 wrote:
> > What I'm a bit confused about is why the map even contains a `__cc_` member
> > in the first place.
>
> Maybe because the binary is built in c++03 mode, so it uses the c++03
> implementation of the map? The c++ library doesn't have to be old, the member
> is still presen
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/158115
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
@da-viper since you can repro this issue locally, mind confirming @labath's
theory
(https://github.com/llvm/llvm-project/pull/156033#issuecomment-3253156453)?
https://github.com/llvm/llvm-project/pull/156033
___
lldb-commits mailing
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/158304
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 commented:
With each addition to this function my desire to move this into libClang grows
stronger. Though I understand that the indexing is an LLDB-specific scheme, so
might not be easy to move.
https://github.com/llvm/llvm-project/pull/158256
__
https://github.com/Michael137 approved this pull request.
LGTM
Could you update the PR description and title before merging?
https://github.com/llvm/llvm-project/pull/156033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.
@@ -113,7 +113,6 @@ def do_test_ptr(self):
Test that pointers to std::unordered_map are formatted correctly.
"""
-self.build()
Michael137 wrote:
Can we do this in a separate PR?
https://github.com/llvm/llvm-project/pull/156033
___
Michael137 wrote:
gentle ping
https://github.com/llvm/llvm-project/pull/122265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Ok so I looked at this with @da-viper offline. This is an existing issue with
formatting specifically `const std::unordered_map<..> *`. I added the test as
part of this issue: https://github.com/llvm/llvm-project/issues/146040. The
following is the discrepancy:
```
(lldb) fra
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/157872
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
LGTM if this works for your use-case, thanks! I'd give @JDevlieghere some time
to look at this before merging
https://github.com/llvm/llvm-project/pull/157474
___
lldb-commits mailing list
lldb
Author: Michael Buch
Date: 2025-09-08T22:48:34+01:00
New Revision: 5326b3b176e82191b18ffc368118b36e0103af3d
URL:
https://github.com/llvm/llvm-project/commit/5326b3b176e82191b18ffc368118b36e0103af3d
DIFF:
https://github.com/llvm/llvm-project/commit/5326b3b176e82191b18ffc368118b36e0103af3d.diff
Author: Michael Buch
Date: 2025-09-08T19:27:18+01:00
New Revision: bdf645bb9b509b60bdb6a71d865b4f8999187977
URL:
https://github.com/llvm/llvm-project/commit/bdf645bb9b509b60bdb6a71d865b4f8999187977
DIFF:
https://github.com/llvm/llvm-project/commit/bdf645bb9b509b60bdb6a71d865b4f8999187977.diff
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/157674
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -959,6 +959,9 @@ CompilerType
TypeSystemClang::GetBuiltinTypeForDWARFEncodingAndBitSize(
if (type_name == "long double" &&
QualTypeMatchesBitSize(bit_size, ast, ast.LongDoubleTy))
return GetType(ast.LongDoubleTy);
+if (type_name == "__bf16" &&
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> Might be fixed next build, I saw the Linux ones fail then go green right
> after.
Yea I hoped so too, but looks like that test run had both my changes. I think
this is just not supported on Windows for now (i doubt this worked before the
tests were added either). I XFAILed
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/133079
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Can you rebase your PR on `main` and resolve the conflict in
`TypeSystemClang.cpp`?
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -218,6 +222,10 @@ def compiler_rt_asan_tests(self):
self.check_traces()
+# Make sure we're not stopped in the sanitizer library but instead at
the
Michael137 wrote:
Should be fixed now. Let me know if you're still seeing issues
https://g
@@ -1873,6 +1873,18 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+if (!class_specialization_decl) {
+ if (log) {
+dwarf->GetObjectFile()
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149827
>From f979958249187a1b89b4b87c46e90d63b6dc4042 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 18 Aug 2025 15:14:40 +0100
Subject: [PATCH 1/3] [clang][DebugInfo] Emit unified (Itanium) mangled name to
@@ -0,0 +1,29 @@
+/// Check that LLDB does not emit "GetDIE for DIE {{0x[0-9a-f]+}} is outside
of its CU"
+/// error message when user is searching for a matching symbol from
.debug_names
+/// and fail to locate the corresponding .dwo file.
+
+/// -gsplit-dwarf is supported only
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149827
>From f979958249187a1b89b4b87c46e90d63b6dc4042 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 18 Aug 2025 15:14:40 +0100
Subject: [PATCH 1/2] [clang][DebugInfo] Emit unified (Itanium) mangled name to
https://github.com/Michael137 auto_merge_enabled
https://github.com/llvm/llvm-project/pull/149827
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
Seems to align with how the PDB plugin does it, so LGTM
https://github.com/llvm/llvm-project/pull/154121
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
@@ -959,6 +959,9 @@ CompilerType
TypeSystemClang::GetBuiltinTypeForDWARFEncodingAndBitSize(
if (type_name == "long double" &&
QualTypeMatchesBitSize(bit_size, ast, ast.LongDoubleTy))
return GetType(ast.LongDoubleTy);
+if (type_name == "__bf16" &&
@@ -74,6 +74,7 @@ def test_hitting(self):
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples() + ["windows"])
@skipIf(archs=no_match(["x86_64", "aarch64"]))
+@skipTestIfFn(linker_script_syntax_unsupported)
Michael137 wrote:
Did you try wrapping th
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149827
>From f979958249187a1b89b4b87c46e90d63b6dc4042 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 18 Aug 2025 15:14:40 +0100
Subject: [PATCH 1/2] [clang][DebugInfo] Emit unified (Itanium) mangled name to
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/155485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/157649
>From 0939db4e9adf79cc02342d66d2402ab72babb64b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 9 Sep 2025 12:14:02 +0100
Subject: [PATCH 1/2] [lldb][test] Re-enable import-std-module tests on Linux
T
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/157649
This reverts commit 76bd5da3248fd4affedfefec3b2a3e1acbe0a94a.
These were originally skipped for
https://github.com/llvm/llvm-project/issues/137046 because they were failing on
Fuchsia buildbots.
I couldn't
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/157474
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,29 @@
+/// Check that LLDB does not emit "GetDIE for DIE {{0x[0-9a-f]+}} is outside
of its CU"
+/// error message when user is searching for a matching symbol from
.debug_names
+/// and fail to locate the corresponding .dwo file.
+
+/// -gsplit-dwarf is supported only
@@ -1725,6 +1725,7 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
const dw_tag_t tag = die.Tag();
SymbolFileDWARF *dwarf = die.GetDWARF();
LanguageType cu_language = SymbolFileDWARF::GetLanguage(*die.GetCU());
+ ModuleSP module_sp = dwarf->GetObj
@@ -599,6 +599,39 @@ TEST_F(DWARFASTParserClangTests,
TestDefaultTemplateParamParsing) {
}
}
+TEST_F(DWARFASTParserClangTests, TestSpecDeclExistsError) {
+ // Tests checking error if ClassTemplateSpecializationDecl already exists.
+ auto BufferOrError = llvm::MemoryBuffer
@@ -51,41 +46,28 @@ class StackID {
void Dump(Stream *s);
- // Operators
- const StackID &operator=(const StackID &rhs) {
-if (this != &rhs) {
- m_pc = rhs.m_pc;
- m_cfa = rhs.m_cfa;
- m_symbol_scope = rhs.m_symbol_scope;
-}
-return *this;
- }
Michael137 wrote:
> @Michael137, probably we should return finding and adding specialization in
> DWARFASTParserClang.cpp?
That would be equivalent to the way your current version handles this right? I
don't see how that would change anything.
I now realize this is trickier than expected. E.g
https://github.com/Michael137 auto_merge_disabled
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/133078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> As far as I know, there isn't anything in the debug info that says "this
> variable is the this pointer" other than the name/type of a variable and the
> type of the function.
How does the DIA PDB plugin do it then? Why can't the native plugin use
`PDB_DataKind::ObjectPtr`
@@ -1873,6 +1874,24 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+// Try to find an existing specialization with these template arguments and
+//
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/157483
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Based on the test failure in `TestCppTemplateArguments.py` maybe we need to
return the `ClassTemplateDeclSpecialization` that we found, instead of
returning `nullptr`. We would create a new `TypeSP` for it, but that shouldn't
be an issue i think
https://github.com/llvm/llvm-
@@ -1873,6 +1873,17 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
Michael137 wrote:
lets move the check before we call `CreateClassTemplat
@@ -1676,6 +1676,13 @@ TypeSystemClang::CreateClassTemplateSpecializationDecl(
class_template_specialization_decl->setInstantiationOf(class_template_decl);
class_template_specialization_decl->setTemplateArgs(
TemplateArgumentList::CreateCopy(ast, args));
+ // Special
Michael137 wrote:
> @Michael137, do you think that this PR(#154134) is still needed?
I'll comment on that PR
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
@@ -1676,6 +1676,13 @@ TypeSystemClang::CreateClassTemplateSpecializationDecl(
class_template_specialization_decl->setInstantiationOf(class_template_decl);
class_template_specialization_decl->setTemplateArgs(
TemplateArgumentList::CreateCopy(ast, args));
+ // Special
@@ -1873,6 +1873,17 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+if (!class_specialization_decl) {
+ if (log) {
+dwarf->GetObjectFile()
Michael137 wrote:
friendly ping
https://github.com/llvm/llvm-project/pull/155485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1873,6 +1873,19 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+// If we got nullptr, then such specialization already exists.
Mic
1 - 100 of 2378 matches
Mail list logo
