https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149827
>From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/6] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149827
>From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/6] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/149519
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/149801
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,18 @@
+b main
+r
+
+type lookup S
+type lookup ::S
+type lookup Outer::S
+type lookup Outer::Inner1::S
+type lookup Inner1::S
+type lookup Outer::Inner1::Inner2::S
+type lookup Inner2::S
+type lookup Outer::Inner2::S
+type lookup Outer::A
+type lookup A
+type lookup ::A
@@ -1784,6 +1787,17 @@ static void
LoadMsvcStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
stl_summary_flags,
MsvcStlStringSummaryProvider,
"MSVC STL std::u32string summary provider"));
+
+ stl_summary_flags.SetDontShowChildren(false);
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149827
>From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/5] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149827
>From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/5] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149827
>From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/4] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/149827
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/148877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/149827
None
>From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/3] [lldb][Expression] Encode Module and DIE UIDs into
@@ -1784,6 +1787,17 @@ static void
LoadMsvcStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
stl_summary_flags,
MsvcStlStringSummaryProvider,
"MSVC STL std::u32string summary provider"));
+
+ stl_summary_flags.SetDontShowChildren(false);
@@ -1784,6 +1787,17 @@ static void
LoadMsvcStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
stl_summary_flags,
MsvcStlStringSummaryProvider,
"MSVC STL std::u32string summary provider"));
+
+ stl_summary_flags.SetDontShowChildren(false);
@@ -1784,6 +1787,17 @@ static void
LoadMsvcStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
stl_summary_flags,
MsvcStlStringSummaryProvider,
"MSVC STL std::u32string summary provider"));
+
+ stl_summary_flags.SetDontShowChildren(false);
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/149801
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
nice
https://github.com/llvm/llvm-project/pull/149519
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -127,8 +123,16 @@ def look_for_content_and_continue(self, var_name,
patterns):
@add_test_categories(["libstdcxx"])
def test_with_run_command_libstdcpp(self):
-self.do_test_with_run_command(USE_LIBSTDCPP)
+self.build(dictionary={"USE_LIBSTDCPP": 1})
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/148554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -130,8 +139,11 @@ Module *Module::GetAllocatedModuleAtIndex(size_t idx) {
return nullptr;
}
+// TODO: needs a mutex
+static lldb::user_id_t g_unique_id = 1;
+
Module::Module(const ModuleSpec &module_spec)
-: m_unwind_table(*this), m_file_has_changed(false),
+: Us
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/2] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/148877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 ready_for_review
https://github.com/llvm/llvm-project/pull/148877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/148877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -888,22 +890,27 @@ PdbAstBuilder::CreateFunctionDecl(PdbCompilandSymId
func_id,
tag_record = CVTagRecord::create(index.tpi().getType(*eti)).asTag();
}
}
+
+ConstString mangled_name;
+if (auto mangled_name_opt = pdb->FindMangledFunctionName(func_id)
@@ -2353,3 +2356,67 @@
SymbolFileNativePDB::GetParentType(llvm::codeview::TypeIndex ti) {
return std::nullopt;
return parent_iter->second;
}
+
+std::optional
+SymbolFileNativePDB::FindMangledFunctionName(PdbCompilandSymId func_id) {
+ const CompilandIndexItem *cci =
+
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/149701
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 commented:
I don't see anything wrong with trying to attach a mangled name to methods here.
Though not a PDB expert so CCing @rnk @ZequanWu
https://github.com/llvm/llvm-project/pull/149701
___
lldb-commits mailing list
ll
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/148554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/149545
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH] [lldb][Expression] Encode Module and DIE UIDs into function
A
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From bad568743a00fef16b8af90492cf12ab85b38175 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/2] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From 019e83d2e589b0b90da2db1cc56bb567559db04b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/2] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From 54604daf17de2b1c3e9c41bcdc66ca2cab7fb486 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/3] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From 7a077675e3671c6c1697f57066ab20d5d1d129d9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/4] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From 7a077675e3671c6c1697f57066ab20d5d1d129d9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/3] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/148877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -96,6 +96,41 @@ class Expression {
///invalid.
};
+/// Holds parsed information about a function call label that
+/// LLDB attaches as an AsmLabel to function AST nodes it parses
+/// from debug-info.
+///
+/// The format being:
+///
+///
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/148877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From f640beff5da2edb9d928e3a0b1ce4128194c055b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/3] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From f640beff5da2edb9d928e3a0b1ce4128194c055b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/3] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From f640beff5da2edb9d928e3a0b1ce4128194c055b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/2] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From b8e611658f462d2963a3f63018823c9f8908c772 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/2] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From b8e611658f462d2963a3f63018823c9f8908c772 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH] [lldb][Expression] Encode Module and DIE UIDs into function
A
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/149545
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1664,6 +1665,8 @@ static void
LoadCommonStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
SyntheticChildren::Flags stl_synth_flags;
stl_synth_flags.SetCascades(true).SetSkipPointers(false).SetSkipReferences(
false);
+ SyntheticChildren::Flags stl_deref_f
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From 727ab0818b609f3f946af78b8679d3a80c25e175 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/2] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 approved this pull request.
that bothered me too, thanks!
https://github.com/llvm/llvm-project/pull/149480
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
Michael137 wrote:
I think as a pre-requisite to this we should remove the non-native PDB parser
(and anything associated with it). That way we wouldn't need any special
environment variable setting etc.
We agreed that the native parser would be the way forward in the last EuroLLVM
round-table
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/149490
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From 386c354b54f619bdad4d3b3f965771282a4647b8 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH] [lldb][Expression] Encode Module and DIE UIDs into function
A
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From 4d8da53285939b9db314d374214efd4c3302d1f3 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH] [lldb][Expression] Encode Module and DIE UIDs into function
A
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/146740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/149490
The only place that passes a target to `LoadAddressResolver` already checks for
pointer validity. And inside of the resolver we have been dereferencing the
target anyway without nullptr checks. So codify the
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From 0cc8acace55c0f0638643bfd2922a289a373ec38 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/6] [lldb][Expression] Encode Module and DIE UIDs into
functi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From 0cc8acace55c0f0638643bfd2922a289a373ec38 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH 1/5] [lldb][Expression] Encode Module and DIE UIDs into
functi
Author: Michael Buch
Date: 2025-07-18T10:05:18+01:00
New Revision: 3121cc31baa1aed697cc07c72d283891ffa529f6
URL:
https://github.com/llvm/llvm-project/commit/3121cc31baa1aed697cc07c72d283891ffa529f6
DIFF:
https://github.com/llvm/llvm-project/commit/3121cc31baa1aed697cc07c72d283891ffa529f6.diff
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/149322
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
nope doesn't need dwarf, thanks!
https://github.com/llvm/llvm-project/pull/149322
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/148877
>From 31d9f127ede936a525e8a1630a0d910a2eef0369 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH] [lldb][Expression] Encode Module and DIE UIDs into function
A
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149282
>From 2be8d8ddb03116776f2f1d04ec98da6da595959c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 17 Jul 2025 10:42:27 +0100
Subject: [PATCH 1/2] [lldb] Adjust default target.max-children-depth
Deeply ne
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/149282
Deeply nested structs can be noisy, so Apple's LLDB fork sets the default to
`4`:
https://github.com/swiftlang/llvm-project/blob/9c93adbb283005ab416fd155b75fd43e6a8288ca/lldb/source/Target/TargetProperties.t
Author: Michael Buch
Date: 2025-07-17T10:49:05+01:00
New Revision: 4797a6c4e8244ab06829b2e462b1329e94286dbf
URL:
https://github.com/llvm/llvm-project/commit/4797a6c4e8244ab06829b2e462b1329e94286dbf
DIFF:
https://github.com/llvm/llvm-project/commit/4797a6c4e8244ab06829b2e462b1329e94286dbf.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/149088
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 commented:
Appreciate the effort to support both PDB *and* DWARF, but I don't think we
should be jumping through hoops to support PDB when there is no bots running
the API tests for it. It's too easy for that to bit-rot. So I would suggest
dropping PDB support fro
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149112
>From c14caf77cd3fbb0d4d94a9e34122bc75eb07dfb8 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 16 Jul 2025 16:01:30 +0100
Subject: [PATCH 1/3] [lldb][SBType] GetBasicType to unwrap canonical type
`SBT
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149112
>From c14caf77cd3fbb0d4d94a9e34122bc75eb07dfb8 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 16 Jul 2025 16:01:30 +0100
Subject: [PATCH 1/2] [lldb][SBType] GetBasicType to unwrap canonical type
`SBT
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/149112
`SBType::GetBasicType` fails on typedefs to primitive types. The docs for
`GetBasicType` state:
```
Returns the BasicType value that is most appropriate to this type
```
But, e.g., for `uint64_t` this would c
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/148285
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/149088
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/149088
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/149088
When dumping variables, LLDB will print a one-time warning about truncating
children (when the children count exceeds the default
`target.max-children-count`). But we only do this for `frame variable`. So if
@@ -249,6 +250,41 @@ static unsigned GetCXXMethodCVQuals(const DWARFDIE
&subprogram,
return cv_quals;
}
+// TODO:
+// 0. Adjust FindInSymbols
+// 1. log failure paths
+// 2. What happens for functions without a linkage name? Previously we didn't
+// attach a label for those
@@ -2015,8 +2015,6 @@ llvm::Expected DWARFExpression::Evaluate(
if (stack.size() < 1) {
UpdateValueTypeFromLocationDescription(log, dwarf_cu,
LocationDescriptionKind::Empty);
-// Reset for the next piece.
-
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/148929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/148929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/147538
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/148548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/148548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/147538
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -249,6 +250,41 @@ static unsigned GetCXXMethodCVQuals(const DWARFDIE
&subprogram,
return cv_quals;
}
+// TODO:
+// 0. Adjust FindInSymbols
+// 1. log failure paths
+// 2. What happens for functions without a linkage name? Previously we didn't
+// attach a label for those
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/148877
None
>From 7f805d67f73d9683d69410895be1d042f0c6da14 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 15 Nov 2024 01:59:36 +
Subject: [PATCH] [lldb][Expression] Encode Module and DIE UIDs into funct
@@ -1642,19 +1662,34 @@ static void
LoadCommonStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
},
"MSVC STL/libstdc++ std::wstring summary provider"));
+ stl_summary_flags.SetDontShowChildren(false);
+ stl_summary_flags.SetSkipPointers(false);
+
@@ -0,0 +1,297 @@
+//===-- MsvcStlVector.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,297 @@
+//===-- MsvcStlVector.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,297 @@
+//===-- MsvcStlVector.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,297 @@
+//===-- MsvcStlVector.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -1656,9 +1658,6 @@ static void
LoadCommonStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
},
"MSVC STL/libstdc++ std::wstring summary provider"));
- stl_summary_flags.SetDontShowChildren(false);
Michael137 wrote:
Why did thes
https://github.com/Michael137 approved this pull request.
Modulo my last set of comments, LGTM
https://github.com/llvm/llvm-project/pull/148285
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
@@ -1642,19 +1662,34 @@ static void
LoadCommonStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
},
"MSVC STL/libstdc++ std::wstring summary provider"));
+ stl_summary_flags.SetDontShowChildren(false);
+ stl_summary_flags.SetSkipPointers(false);
+
@@ -1501,22 +1499,19 @@ static void
LoadLibStdcppFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
"^std::(__debug::)?unordered_(multi)?(map|set)<.+> >$",
stl_summary_flags, true);
- AddCXXSummary(cpp_category_sp,
-lldb_pr
@@ -1,8 +1,3 @@
-// Evil hack: To simulate memory corruption, we want to fiddle with some
internals of std::list.
Michael137 wrote:
Would be nice to fix the test to cover cycle detection. Happy to do that in a
separate PR though. Since this is already how this
Michael137 wrote:
All that being said, i think we can defer the questions about capping list
size, etc. until after this lands. Since this just mimicks what libc++ already
does
https://github.com/llvm/llvm-project/pull/148285
___
lldb-commits mailing
Michael137 wrote:
> > Side-note, I'm also a bit wary of all the cycle-detection stuff. Might be a
> > remnant of protection against old libcxx bugs? We don't really do this
> > stuff for other libcxx containers.
>
> We don't do that for other containers, but it's not really as acute there.
>
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/148600
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/148248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/148248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> The implementation makes it hard to detect if the empty tuple is from this
> STL. Fortunately, libstdc++'s synthetic children provider works for empty
> MSVC STL tuples as well.
This is why i wish we had something definitive in debug-info to tell us what
STL a compile-unit
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/148548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/148600
Ran my python script from
https://github.com/llvm/llvm-project/pull/97043 over the repo again and there
was 1 duplicate test-case that has been introduced since I last did this.
This patch renames that test.
1 - 100 of 2260 matches
Mail list logo