[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. In D131858#3984855 , @arphaman wrote: > Ping @mizvekov. > > Unfortunately I'm unable to revert this commit now so we won't be able to get > the bot back to green until it's fixed. Hello, sorry for the long time to respond. Can

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov added a comment. @alexfh Thanks! While there is a huge increase in the amount of UsingTypes, it seems the total amount is still reasonable and does not explain the perf hit. Perhaps this is a case of bad hashing and they are all falling into the same bucket? cc @sam.mcall for awarene

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov added a comment. In D136565#3911884 , @alexfh wrote: > Hi Matheus, 279fe6281d2ca5b2318c7437316c28750feaac8d > causes > compilation timeout on some of our internal files. Hi

[Lldb-commits] [PATCH] D127695: [clang] Template Specialization Resugaring - TypeDecl

mizvekov added a comment. In D127695#3860316 , @rjmccall wrote: > I see, thank you. I know you've marked this a WIP, but it's always good to > describe these things in the patch description; that's what it's for. Done! I have also removed the WIP. While

[Lldb-commits] [PATCH] D127695: [clang] Template Specialization Resugaring - TypeDecl

mizvekov retitled this revision from "[clang] Implement Template Specialization Resugaring" to "[clang] Template Specialization Resugaring - TypeDecl". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 472416. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG279fe6281d2c: [clang] Instantiate alias templates with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov updated this revision to Diff 472021. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136565/new/ https://reviews.llvm.org/D136565 Files: clang-tools-extra/clangd/unittests/HoverTests.cpp clang/lib/Sema/SemaTemplate.cpp clang/test/AST/a

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c44c91ad980: [clang] Instantiate alias templates with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136565/new/ https://revie

[Lldb-commits] [PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4c2a3c65684: [clang] Implement sugared substitution changes to infrastructure (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/n

[Lldb-commits] [PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470660. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td clang/include/clang

[Lldb-commits] [PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470348. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td clang/include/clang

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov created this revision. Herald added subscribers: jeroen.dobbelaere, kadircet, arphaman. Herald added a project: All. mizvekov requested review of this revision. Herald added projects: clang, LLDB, clang-tools-extra. Herald added subscribers: cfe-commits, lldb-commits. This makes use of th

[Lldb-commits] [PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470011. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td clang/include/clang

[Lldb-commits] [PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov retitled this revision from "[clang] Instiantiate early substituted entities with sugared template arguments" to "[clang] Implement sugared substitution changes to infrastructure". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 470008. Herald added a

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:3427 +TemplateParameterList *getReplacedTemplateParameterList(Decl *D); + mizvekov wrote: > davrec wrote: > > davrec wrote: > > > I don't object with making this public, and I ca

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:3427 +TemplateParameterList *getReplacedTemplateParameterList(Decl *D); + davrec wrote: > davrec wrote: > > I don't object with making this public, and I can see the argument for

[Lldb-commits] [PATCH] D127695: [clang] Implement Template Specialization Resugaring

mizvekov added a comment. In D127695#3860237 , @rjmccall wrote: > What is this work about? I have written more about it in this discourse thread: https://discourse.llvm.org/t/rfc-improving-diagnostics-with-template-specialization-resugaring/64294 Repo

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. I pushed some late changes: - Implement this new scheme uniformly across all template parameter kinds. Before we were doing only type parameters, now we are doing non-type and template template parameters. While the diff is not very small, it's more of the same stuff.

[Lldb-commits] [PATCH] D134604: [clang] Instiantiate early substituted entities with sugared template arguments

mizvekov updated this revision to Diff 467920. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang-tools-extra/clangd/unitte

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/include/clang/AST/Type.h:1836 +// The index of the template parameter this substitution represents. +unsigned Index : 15; + erichkeane wrote: > Is it a problem for this to be a different number of bits use

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67e229831154: [clang] use getCommonSugar in an assortment of place

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460723. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaff1f6310e5f: [clang] use getCommonSugar in an assortment of place

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460587. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3792825 , @Abramo-Bagnara wrote: > These changes introduce a subtle bug in template instantiation of newly added > ElaboratedType around TypedefType: > > bool refersInstantiatedDecl(QualType T) in SemaTemplateInstant

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460220. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460036. mizvekov marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariab

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov marked an inline comment as not done. mizvekov added a subscriber: davrec. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1091-1150 +QualType fpTy = ComplexTy->castAs()->getElementType(); IntExpr = S.ImpCastExprToType(IntExpr.get(), fpTy

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 459369. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 459362. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3778883 , @MaskRay wrote: > Sorry, I just reverted it:) You may check whether the fix fixes GCC > libstdc++-v3/src/c++98/complex_io.cc I confirm it does not crash on my system with this patch. Repository: rG LLVM

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1091-1150 +QualType fpTy = ComplexTy->castAs()->getElementType(); IntExpr = S.ImpCastExprToType(IntExpr.get(), fpTy, CK_IntegralToFloating); IntExpr = S.ImpCastExprToType(IntExpr.get(), ComplexT

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 459070. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariabl

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 459067. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 458924. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3778879 , @MaskRay wrote: > Since the fix was not merged, I will revert this soon. > > I saw a clang segfault with `clang++ libstdc++-v3/src/c++98/complex_io.cc` Would you mind if I just merge it? I was hoping there w

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. Fix at https://reviews.llvm.org/D133522 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3778277 , @ronlieb wrote: > i am seeing similar issues in openmp buildbot failing with this patch I got a small patch coming up soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. Thanks for the repro! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd42122cd5db0: [clang] use getCommonSugar in an assortment of place

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 458608. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 456197. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 453829. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3718417 , @ilya-biryukov wrote: > We don't match GCC in other cases. GCC seems to always print the type name > without qualifiers, clang used to always print with qualifiers, but will now > print what was typed in t

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov marked an inline comment as done. mizvekov added a comment. In D112374#3716944 , @alexfh wrote: > One more problem related to this patch: it changes the behavior of > __PRETTY_FUNCTION__: https://gcc.godbolt.org/z/Mvnj9j74E. There may be > depe

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/AST/QualTypeNames.cpp:455 + if (const auto *UT = QT->getAs()) { +return getFullyQualifiedType(UT->getUnderlyingType(), Ctx, + WithGlobalNsPrefix);

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3684722 , @hans wrote: > Here's an example where I think this regressed a Clang diagnostic. Consider: Consider this simple extension of this example, to show how this general problem already existed: https://godbolt.

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3684722 , @hans wrote: > The problem is that just based on `Template` it's not clear whether it's > `S1::Foo` or `S2::Foo` that's referred to. The logic in the diagnostic here ended up doing a silent single step desu

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 447974. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15f3cd6bfc67: [clang] Implement ElaboratedType sugaring for types

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 447890. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3168178 , @shafik wrote: > Changing how types are printed can effect LLDB expression parsing tests. I > ran the LLDB test suite with this change: > > ninja check-lldb > > and it changes to the results for `TestScala

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 447087. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 447085. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3666531 , @kimgr wrote: > From a purely personal perspective, I'd prefer if this landed after the > branch for llvm-15. > > We try to co-release IWYU shortly after LLVM/Clang are released, to get a > public API-compa

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3665249 , @sammccall wrote: > I've seen plenty of (useful) out-of-tree tidy checks written by people fuzzy > on the difference between a Type and a TypeLoc, or what sugar is. Clang makes > it (almost) easy to write t

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 446173. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. @JDevlieghere @teemperor ping Can you please verify that everything works with LLDB, we just changed how those types are printed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 445648. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 445646. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 445643. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3659597 , @nikic wrote: > Given that LLVM 15 branches off in one week, maybe it would be better to wait > for that before relanding the change, as it seems to have significant impact > on plugins? I think it would m

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov marked an inline comment as done. mizvekov added a comment. @JDevlieghere @teemperor ping. Sorry for the urgency here, but I have a lot of work built on top of this patch. And this patch fixes a bunch of bugs that other people are unaware and duplicating effort, see github issues. Re

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 445365. mizvekov marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTe

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Sema/TypeLocBuilder.cpp:159 - assert(Capacity - Index == TypeLoc::getFullDataSizeForType(T) && + unsigned FDSz = TypeLoc::getFullDataSizeForType(T); + assert(Capacity - Index ==

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 445319. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3658059 , @kimgr wrote: > Haha. Pun intended? :-) Yes :-) > As you noticed, it's not our tests that care about the AST, it's the tool > itself. IWYU has been around since 2010-11, so there's probably lots of code >

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. @kimgr One other general comment. The way this function is implemented is quite error prone: static const NamedDecl* TypeToDeclImpl(const Type* type, bool as_written) { // Get past all the 'class' and 'struct' prefixes, and namespaces. type = RemoveElaboration

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3657472 , @kimgr wrote: > I can't say what the best solution is, but this patch generates quite a lot > of work for me, and I would really hope that catching up with the new AST > does not generate even more work dow

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3657472 , @kimgr wrote: > I'm coming at this from pretty far away, so there's very likely lots of > details that I'm overlooking. But it seems to me the mainline had only had an > `ElaboratedType` node if there was e

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov reopened this revision. mizvekov added a comment. In D112374#3653967 , @JDevlieghere wrote: > I'm sorry to hear you're having trouble building LLDB. The LLDB website has > quite an elaborate guide with instructions in how to build LLDB: > http

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7c51f02effdb: [clang] Implement ElaboratedType sugaring for types written bare (authored by mizvekov). Changed prior to c

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. @JDevlieghere I spent a lot of time trying to get this test running on my machine to no avail. I think lldb build and test setup is quite convoluted, fragile and antiquated. It uses many deprecated CMake features, It fails to properly link to system libraries it needs

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3650749 , @glandium wrote: > FWIW, this change also broke this check in Firefox's clang plugin: > https://searchfox.org/mozilla-central/rev/0d11f3660945ce35c49501bb44bc4f82bb2b503c/build/clang-plugin/NoPrincipalGetURI

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3648624 , @JDevlieghere wrote: > This breaks all the LLDB tests that import the std module: > > Given that the bot has been red for 14 hours I went ahead and reverted this > change. Please keep an eye on this bot whe

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3647530 , @nikic wrote: > FYI this change had a noticeable compile-time impact > (http://llvm-compile-time-tracker.com/compare.php?from=ee88c0cf09969ba44307068797e12533b94768a6&to=bdc6974f92304f4ed542241b9b89ba58ba6b2

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdc6974f9230: [clang] Implement ElaboratedType sugaring for types

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 444104. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 444067. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 444066. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 443951. mizvekov marked 2 inline comments as done. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 443772. Herald added subscribers: usaxena95, kadircet, arphaman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/Ext

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. Herald added a subscriber: JDevlieghere. In D111509#3168178 , @shafik wrote: > llvm-lit -sv lldb/test --filter TestScalarURem.py > > The change looks expected. Thanks for letting me know. Unfortunately that test is not suppor

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 443769. Herald added subscribers: lldb-commits, Enna1. Herald added projects: LLDB, All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.ll

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Fix pushed to https://reviews.llvm.org/D114207 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Isolated example: template struct span {}; auto make_span() { using T = int; return span(); } void WontCompile() { span s1 = make_span(); } https://godbolt.org/z/rjd6Y6f9d testcc:9:13: error: no viable conversion from 'span' to 'span'

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3139129 , @lkail wrote: > Hi we found regression in our internal tests. It compiles with clang-13.0.0 > https://godbolt.org/z/3abGrcf7o and gcc https://godbolt.org/z/K9oj3Grs1, but > fails with clang-trunk https://go

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3137375 , @hans wrote: >> I am not sure how to reproduce this. > > Attaching preprocessed source. With Clang built at > 508aa4fe0c82b3b409e2e194d591ee6d665c8623 it reproduces for me like this: > > $ clang++ -c /tmp/

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3135461 , @hans wrote: > We're seeing a diagnostic change in Chromium which looks funny. For the > following code (span<> is our own class): > > the diagnostic changes from: > > fatal error: no viable conversio

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. FYI this is a minimal repro taken from Martin's preprocessed source (Thanks!): template struct a { using b = const float; }; template using d = typename a::b; template void e(d *, c) {} template void e(typename a::b *, int); Repository: rG LLVM Github

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov reopened this revision. mizvekov added a comment. Reverting for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3130184 , @mstorsjo wrote: > Do you happen to know what's going on here? The files mentioned are > https://code.qt.io/cgit/qt/qtbase.git/tree/src/3rdparty/angle/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.cpp?h=

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Okay, libcxx pipeline passes, disregarding the clang-format failure for pre-existing badness in those files, which would need to be fixed separately or else git loses track of the rename. The AIX failures also seem completely unrelated. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D113722: [lldb] fix test expectation broken by clang fix at D110216

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG55085952175e: [lldb] fix test expectation broken by clang fix at D110216 (authored by mizvekov). Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D113722: [lldb] fix test expectation broken by clang fix at D110216

mizvekov added a comment. Herald added a subscriber: JDevlieghere. Fixes buildbot failure seen at http://lab.llvm.org:8011/#/builders/68/builds/21662/steps/6/logs/stdio Caused by a fix in D110216 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D113722: [lldb] fix test expectation broken by clang fix at D110216

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113722 Files: lldb/test/Shell/SymbolFile/NativePD