[Lldb-commits] [PATCH] D62183: [Windows] Fix race condition between state changes

2019-07-21 Thread Martin Andersson via Phabricator via lldb-commits
martin added a comment. What is the next step to get this commited? Can you commit it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62183/new/ https://reviews.llvm.org/D62183 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D62183: [Windows] Fix race condition between state changes

2019-07-17 Thread Martin Andersson via Phabricator via lldb-commits
martin added a comment. In D62183#1589937 , @amccarth wrote: > This change looks fine to me, but I wish there was a reliable way to test it. > Is it a true race condition (e.g., because the unpredictability of thread > scheduling), or is there a way to

[Lldb-commits] [PATCH] D62183: [Windows] Fix race condition between state changes

2019-07-17 Thread Martin Andersson via Phabricator via lldb-commits
martin added a comment. In D62183#1556645 , @amccarth wrote: > zturner is not a regular here anymore. I think he pops in from time-to-time, > but I wouldn't depend on just him for a review. > > Are you still wanting to land this? If you rebase and add m

[Lldb-commits] [PATCH] D62183: [Windows] Fix race condition between state changes

2019-07-17 Thread Martin Andersson via Phabricator via lldb-commits
martin updated this revision to Diff 210365. martin added a reviewer: amccarth. martin added a comment. Rebased against master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62183/new/ https://reviews.llvm.org/D62183 Files: source/Plugins/Process/Windows/Common/ProcessWindows.cpp In

[Lldb-commits] [PATCH] D62183: [Windows] Fix race condition between state changes

2019-05-21 Thread Martin Andersson via Phabricator via lldb-commits
martin created this revision. martin added a reviewer: zturner. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If the process is resumed before the state is changed to "running" there is a possibility (when single stepping) that the debugger stops and changes the state to