[Lldb-commits] [lldb] [lldb] Fix ThreadPlanStepOverRange name in log message (PR #94611)

https://github.com/mariannems created https://github.com/llvm/llvm-project/pull/94611 None >From b17a12f78f19e59bce7ee52308502f2eeea4e8cd Mon Sep 17 00:00:00 2001 From: Marianne Mailhot-Sarrasin Date: Wed, 5 Jun 2024 15:56:12 -0400 Subject: [PATCH] [lldb] Fix ThreadPlanStepOverRange name in lo

[Lldb-commits] [lldb] r269340 - [LLDB] Added support for PHI nodes to IR interpreter

Author: mamai Date: Thu May 12 15:00:53 2016 New Revision: 269340 URL: http://llvm.org/viewvc/llvm-project?rev=269340&view=rev Log: [LLDB] Added support for PHI nodes to IR interpreter This allows expressions such as 'i == 1 || i == 2` to be executed using the IR interpreter, instead of relying

Re: [Lldb-commits] [PATCH] D19124: [LLDB] Added support for PHI nodes to IR interpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rL269340: [LLDB] Added support for PHI nodes to IR interpreter (authored by mamai). Changed prior to commit: http://reviews.llvm.org/D19124?vs=54134&id=57093#toc Repository: rL LLVM http://reviews.llv

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

This revision was automatically updated to reflect the committed changes. Closed by commit rL266733: LLDB: Fixed two race conditions when stopping private state thread (authored by mamai). Changed prior to commit: http://reviews.llvm.org/D19122?vs=54098&id=54185#toc Repository: rL LLVM http

[Lldb-commits] [lldb] r266733 - LLDB: Fixed two race conditions when stopping private state thread

Author: mamai Date: Tue Apr 19 08:21:46 2016 New Revision: 266733 URL: http://llvm.org/viewvc/llvm-project?rev=266733&view=rev Log: LLDB: Fixed two race conditions when stopping private state thread When stopping the private state thread, there was a race condition between the time the thread ex

[Lldb-commits] [lldb] r263233 - Fixed MemoryCache L1 cache flush

Author: mamai Date: Fri Mar 11 07:50:10 2016 New Revision: 263233 URL: http://llvm.org/viewvc/llvm-project?rev=263233&view=rev Log: Fixed MemoryCache L1 cache flush Use the same method to find the cache line as in Read(). Differential Revision: http://reviews.llvm.org/D18050 Added: lldb/tru

Re: [Lldb-commits] [PATCH] D18050: Fixed MemoryCache L1 cache flush

This revision was automatically updated to reflect the committed changes. Closed by commit rL263233: Fixed MemoryCache L1 cache flush (authored by mamai). Changed prior to commit: http://reviews.llvm.org/D18050?vs=50297&id=50422#toc Repository: rL LLVM http://reviews.llvm.org/D18050 Files:

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

This revision was automatically updated to reflect the committed changes. Closed by commit rL263166: Fixed ValueObject::GetExpressionPath() for paths including anonymous… (authored by mamai). Changed prior to commit: http://reviews.llvm.org/D18005?vs=50192&id=50353#toc Repository: rL LLVM h

[Lldb-commits] [lldb] r263166 - Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

Author: mamai Date: Thu Mar 10 16:10:59 2016 New Revision: 263166 URL: http://llvm.org/viewvc/llvm-project?rev=263166&view=rev Log: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union When the parent of an expression is anonymous, skip adding '.' or '->' before the

Re: [Lldb-commits] [PATCH] D18050: Fixed MemoryCache L1 cache flush

mamai added a comment. Could someone commit it for me please? I don't have commit access. Repository: rL LLVM http://reviews.llvm.org/D18050 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D18050: Fixed MemoryCache L1 cache flush

mamai created this revision. mamai added a reviewer: clayborg. mamai added a subscriber: lldb-commits. mamai set the repository for this revision to rL LLVM. Use the same method to find the cache line as in Read(). Repository: rL LLVM http://reviews.llvm.org/D18050 Files: packages/Python/ll

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

mamai added a comment. Thanks! Could someone commit it for me? I don't have commit access. Repository: rL LLVM http://reviews.llvm.org/D18005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

mamai updated this revision to Diff 50192. mamai added a comment. Replaced the test by a new case in lang/c/anonymous test, as suggested by Jim. Is this correct? Repository: rL LLVM http://reviews.llvm.org/D18005 Files: packages/Python/lldbsuite/test/lang/c/anonymous/TestAnonymous.py so

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

mamai added a comment. Sure. Would you have a suggestion of how to call it? Maybe something like variable_flat since it is the command used? Also, is it the right place to add it in functionalities or should it be elsewhere? Repository: rL LLVM http://reviews.llvm.org/D18005

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

mamai updated this revision to Diff 50172. mamai added a comment. Fixed test header, removed useless include. Repository: rL LLVM http://reviews.llvm.org/D18005 Files: packages/Python/lldbsuite/test/functionalities/expression_path/Makefile packages/Python/lldbsuite/test/functionalities/

[Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

mamai created this revision. mamai added a reviewer: clayborg. mamai added a subscriber: lldb-commits. mamai set the repository for this revision to rL LLVM. When the parent of an expression is anonymous, skip adding '.' or '->' before the expression name. Repository: rL LLVM http://reviews.l

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

Really sorry about the breakage. Is there anybody who understands what is the issue of using WriteScalarToMemory when the register value is a scalar? >From my understanding, using WriteScalarToMemory handles the byte swap needed when the Host endianness is different from the Target endianness, wh

Re: [Lldb-commits] [PATCH] D17167: Fix bug with register values byte order in expression evaluation

mamai added a comment. Are the changes correct? And if so, could someone commit it for me? I don't have commit access. Repository: rL LLVM http://reviews.llvm.org/D17167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D17167: Fix bug with register values byte order in expression evaluation

mamai updated this revision to Diff 48486. mamai added a comment. I have updated the patch to add the assertion. Repository: rL LLVM http://reviews.llvm.org/D17167 Files: source/Expression/Materializer.cpp Index: source/Expression/Materializer.cpp =

[Lldb-commits] [PATCH] D17167: Fix bug with register values byte order in expression evaluation

mamai created this revision. mamai added a reviewer: spyffe. mamai added subscribers: phlav, lldb-commits. mamai set the repository for this revision to rL LLVM. The evaluation of expressions containing register values was broken for targets for which endianness differs from host. This patch fix

Re: [Lldb-commits] [PATCH] D16868: [lldb] Fix invalid shift operator overload in Scalar

mamai added a comment. I don't have commit access. It would be great if you can push it for me. Thanks ! Repository: rL LLVM http://reviews.llvm.org/D16868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [Lldb-commits] [PATCH] D16868: [lldb] Fix invalid shift operator overload in Scalar

mamai updated this revision to Diff 47218. mamai added a comment. Added a small unit test for scalar right shift operator, which invokes the >>= operator. Repository: rL LLVM http://reviews.llvm.org/D16868 Files: source/Core/Scalar.cpp unittests/CMakeLists.txt unittests/Core/CMakeList

Re: [Lldb-commits] [PATCH] D16868: [lldb] Fix invalid shift operator overload in Scalar

mamai added a comment. Scalar::operator<<= works well as-is because it uses APInt &operator<<=(unsigned shiftAmt), whereas the right shift equivalent is not implemented. Should I add APInt &operator>>=, or should I change Scalar::operator<<= for consistency ? Repository: rL LLVM http://r

Re: [Lldb-commits] [PATCH] D16868: [lldb] Fix invalid shift operator overload in Scalar

mamai added reviewers: labath, tberghammer. mamai updated this revision to Diff 47190. Repository: rL LLVM http://reviews.llvm.org/D16868 Files: source/Core/Scalar.cpp Index: source/Core/Scalar.cpp === --- source/Core/Scalar.cp

[Lldb-commits] [PATCH] D16868: [lldb] Fix invalid shift operator overload in Scalar

mamai created this revision. mamai added a reviewer: sagar. mamai added a subscriber: lldb-commits. mamai set the repository for this revision to rL LLVM. This also fixes an infinite recursion between lldb_private::operator>> () and Scalar::operator>>= (). Repository: rL LLVM http://reviews.l