[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

2023-06-15 Thread Leonard Chan via Phabricator via lldb-commits
leonardchan added a comment. Hi. I think this is leading to the lldb test failures we're seeing on our linux builder (https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778187770933863505/+/u/lldb/test/stdout?format=raw): FAIL: lldb-unit :: Host/./HostTe

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

2022-12-06 Thread Leonard Chan via Phabricator via lldb-commits
leonardchan accepted this revision. leonardchan added a comment. LGTM tested on mac on my end Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ lldb-commits m

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

2022-07-08 Thread Leonard Chan via Phabricator via lldb-commits
leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM although I think I'd be more comfortable with Petr's +2 for cmake changes. Would it be better instead to expose `LLVM_ENABLE_ZSTD` to subrepos like clangd or flang until they're