[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added a comment. Herald added a project: All. Sorry for the very late response. I looked into using the `CompilerDeclContext()`. This does not work in this case because the context is not set in this specific use case and I'm not sure if it case be set. It is initialized with an inv

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added a comment. I'm still planning to look into this just couldn't find the time this week and the last. Sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added a comment. In D114627#3306300 , @clayborg wrote: > Sorry I am late to making comments on this patch. > > This patch wants to add "llvm::StringRef scope" to the FindTypes calls, but > this is what "const CompilerDeclContext &parent_decl_

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:241 + virtual void + FindTypes(ConstString name, ConstString scope, +const CompilerDeclContext &parent_decl_ctx, uint32_t max_matches, JDevlieghere wrote: > Does th

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger updated this revision to Diff 406355. lassefolger marked 2 inline comments as done. lassefolger added a comment. update according to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627 Fi

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger updated this revision to Diff 401947. lassefolger added a comment. rebase patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Sym

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2470 + const char *qn = die.GetQualifiedName(storage); + if (qn && !llvm::StringRef(qn).startswith(sc)) +return true; werat wrote: > `llvm::S

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger updated this revision to Diff 393485. lassefolger marked 2 inline comments as done. lassefolger added a comment. fixed comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627 Files: lldb/inc

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added inline comments. Comment at: lldb/source/Symbol/SymbolFile.cpp:148 + std::string(scope.GetCString()), type_class, + true); +} I need to change this. This was correct in the first iteratio

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger updated this revision to Diff 391896. lassefolger added a comment. rebased on nfc and completed implementation to expose function in API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627 Files:

[Lldb-commits] [PATCH] D115110: [lldb][nfc] clang-format some files as preperation for https://reviews.llvm.org/D114627

lassefolger created this revision. lassefolger requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115110 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Symbol/Symb

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added a comment. In D114627#3162109 , @shafik wrote: > Is there a specific use case that motivated this feature? The motivation is performance. If there are many (>1000) types with the same base name this implementation performs much better

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger updated this revision to Diff 390001. lassefolger added a comment. rebased on nfc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627 Files: lldb/include/lldb/Symbol/SymbolFile.h lldb/source/P

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger created this revision. lassefolger added reviewers: werat, teemperor. lassefolger requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Searching for fully qualified types in a SymbolFile can be inefficient if it contains many types w

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

lassefolger updated this revision to Diff 380435. lassefolger added a comment. rebased after NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111715/new/ https://reviews.llvm.org/D111715 Files: lldb/source/Core/Mangled.cpp llvm/include/llvm/D

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

lassefolger added a comment. created a NFC for formatting: https://reviews.llvm.org/D111934 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111715/new/ https://reviews.llvm.org/D111715 ___ lldb-commits mai

[Lldb-commits] [PATCH] D111934: [NFC] clang format change

lassefolger created this revision. lassefolger added reviewers: teemperor, werat. lassefolger requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. clang format on some demangling files Repository: rG LLVM Github Monorepo h

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

lassefolger updated this revision to Diff 380155. lassefolger added a comment. add tests for the change and adjust description to include examples Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111715/new/ https://reviews.llvm.org/D111715 Files:

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

lassefolger created this revision. lassefolger added reviewers: teemperor, werat. Herald added a subscriber: hiraditya. lassefolger requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. When printing names in lldb on windows the