[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

kubamracek added a comment. Okay. @jingham, any more comments, or is this okay to land? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60737/new/ https://reviews.llvm.org/D60737 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

kubamracek updated this revision to Diff 195596. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60737/new/ https://reviews.llvm.org/D60737 Files: packages/Python/lldbsuite/test/lang/cpp/global_variables/Makefile packages/Python/lldbsuite/test/lang/cpp/global_variables/TestGlobalVaria

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

kubamracek updated this revision to Diff 195422. kubamracek added a comment. Updating test to use run_to_source_breakpoint CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60737/new/ https://reviews.llvm.org/D60737 Files: packages/Python/lldbsuite/test/lang/cpp/global_variables/Makefile

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

kubamracek updated this revision to Diff 195413. kubamracek added a comment. Adding a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60737/new/ https://reviews.llvm.org/D60737 Files: packages/Python/lldbsuite/test/lang/cpp/global_variables/Makefile packages/Python/lldbsu

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

kubamracek created this revision. kubamracek added a reviewer: jingham. kubamracek added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D60737 Files: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Index: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp ===

[Lldb-commits] [PATCH] D56221: [lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values

kubamracek closed this revision. kubamracek added a comment. Landed in r353363. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56221/new/ https://reviews.llvm.org/D56221 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D56221: [lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values

kubamracek added a comment. Herald added a reviewer: serge-sans-paille. Ping. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56221/new/ https://reviews.llvm.org/D56221 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D56115: [lldb] Check SafeToCallFunctions before calling functions in GetExceptionObjectForThread

kubamracek added a comment. > I recently started writing these early-exit returns as return {}; Good suggestion! > A testcase that triggers this situation would be nice, too. I think this is too tricky. If I understand correctly, an example of an unsafe-to-call thread state is when we're parke

[Lldb-commits] [PATCH] D56221: [lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values

kubamracek created this revision. kubamracek added a reviewer: jingham. kubamracek added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D56221 Files: include/lldb/Target/StackFrameRecognizer.h packages/Python/lldbsuite/test/functionalities/frame-recognizer/TestFrameRecog

[Lldb-commits] [PATCH] D56115: [lldb] Check SafeToCallFunctions before calling functions in GetExceptionObjectForThread

kubamracek created this revision. kubamracek added a reviewer: jingham. kubamracek added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D56115 Files: source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp Index: source/Plugins/LanguageRuntime/

[Lldb-commits] [PATCH] D56027: [lldb] Fix ObjCExceptionRecognizedStackFrame to populate the list of recognized arguments

kubamracek created this revision. kubamracek added a reviewer: jingham. kubamracek added a project: LLDB. Looks like ObjCExceptionRecognizedStackFrame is only vending the recognized exception via GetExceptionObject. It should also present it just as a regular recognized argument, i.e. populate t

[Lldb-commits] [PATCH] D55954: [lldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default

kubamracek updated this revision to Diff 179170. kubamracek retitled this revision from "[ldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default" to "[lldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default". kub

[Lldb-commits] [PATCH] D55954: [ldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default

kubamracek created this revision. kubamracek added a reviewer: jingham. kubamracek added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D55954 Files: include/lldb/API/SBTarget.h include/lldb/API/SBVariablesOptions.h include/lldb/Target/Target.h scripts/interface/SBVar

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

kubamracek added a comment. Thanks for the review! Switched to self.assertFalse and self.assertTrue and landed in r349718. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44072/new/ https://reviews.llvm.org/D44072 ___

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

kubamracek updated this revision to Diff 178991. kubamracek added a comment. Addressed comment 2. Changed the test to use an Obj-C++ source file, and added a case that throws a plain C++ exception. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44072/new/ https://reviews.llvm.org/D44072

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

kubamracek updated this revision to Diff 178954. kubamracek added a comment. Addressing comment 1 (checking that GetCurrentException and GetCurrentExceptionBacktrace returns nothing when there's no exception in flights). Will address comment 2 in a bit. CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D55116: [CMake] llvm_codesign workaround for Xcode double-signing errors

kubamracek accepted this revision. kubamracek added a comment. This revision is now accepted and ready to land. I'd slightly prefer to use --force for *all* builds, not just Xcode builds, to have uniformity. But LGTM even in this form if you feel strongly about it. Repository: rL LLVM CHANGE

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

kubamracek added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44072/new/ https://reviews.llvm.org/D44072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type

kubamracek updated this revision to Diff 175961. Herald added a subscriber: jfb. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44072/new/ https://reviews.llvm.org/D44072 Files: include/lldb/API/SBThread.h include/lldb/Target/LanguageRuntime.h include/lldb/Target/Thread.h packages

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes

kubamracek added a comment. Landed, thanks for the review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43886/new/ https://reviews.llvm.org/D43886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes

kubamracek updated this revision to Diff 175752. kubamracek added a comment. Updated patch. I've added a static `AppleObjCRuntime::GetExceptionThrowLocation()`, which returns the location of the exception throw breakpoint for the Obj-C runtime. I tried adding it as virtual method on LanguageRun

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes

kubamracek updated this revision to Diff 173747. kubamracek retitled this revision from "[lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread" to "[lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes". kubam

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek marked an inline comment as done. kubamracek added a comment. Thanks for the review! https://reviews.llvm.org/D43884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54432: [lldb] Fix the typo (replace underscore with dash) in svn:ignore on test/ and add "lldb-test-build.noindex" to ignored files

kubamracek created this revision. kubamracek added reviewers: davide, aprantl. Herald added a subscriber: arphaman. https://reviews.llvm.org/D54432 Files: . ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D54431: [lldb] Add "ninja" to svn:ignore

kubamracek created this revision. kubamracek added reviewers: davide, aprantl. https://reviews.llvm.org/D54431 Files: . ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44081: [lldb] Add synthetic frontend for _NSCallStackArray

kubamracek marked an inline comment as done. kubamracek added inline comments. Comment at: source/Plugins/Language/ObjC/NSArray.cpp:446-451 + } else if (class_name == g_NSCallStackArray) { +Status error; +value = process_sp->ReadUnsignedIntegerFromMemory( +valobj

[Lldb-commits] [PATCH] D44081: [lldb] Add synthetic frontend for _NSCallStackArray

kubamracek updated this revision to Diff 173695. https://reviews.llvm.org/D44081 Files: packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py source/Plugins/Language/ObjC/NSArray.cpp source/Plugins/Language/ObjC/ObjCLanguage.cpp Index: packages/Python/lldbsuite/test/lan

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek marked an inline comment as done. kubamracek added inline comments. Comment at: source/Plugins/Language/ObjC/NSException.cpp:161-168 +static ConstString g___name("name"); +static ConstString g___reason("reason"); static ConstString g___userInfo("userInfo")

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek updated this revision to Diff 173692. https://reviews.llvm.org/D43884 Files: packages/Python/lldbsuite/test/lang/objc/exceptions/Makefile packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py packages/Python/lldbsuite/test/lang/objc/exceptions/main.m source/

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread

kubamracek added a comment. Hi, I've updated this patch after a while. Since then, StackFrameRecognizers have already landed, so this patch now just adds one subclass of a StackFrameRecognizer. > It seems however like providing some interesting ValueObjects is a pretty > common thing to do, so

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread

kubamracek updated this revision to Diff 173603. kubamracek added a comment. Updating patch for the recently-landed StackFrameRecognizers. https://reviews.llvm.org/D43886 Files: include/lldb/API/SBThread.h include/lldb/Target/StackFrameRecognizer.h include/lldb/Target/Thread.h source/AP

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a reviewer: aprantl. kubamracek added a comment. Ping. https://reviews.llvm.org/D43884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44081: [lldb] Add synthetic frontend for _NSCallStackArray

kubamracek added a reviewer: aprantl. kubamracek added a comment. Ping. https://reviews.llvm.org/D44081 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44073: [lldb] Refactor ObjC/NSException.cpp (cleanup, avoid code duplication). NFC.

kubamracek added a reviewer: aprantl. kubamracek added a comment. Ping. https://reviews.llvm.org/D44073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44060: [lldb] Fix "code requires global destructor" warning in g_architecture_mutex

kubamracek added a comment. Ping. https://reviews.llvm.org/D44060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek added a comment. Ping. https://reviews.llvm.org/D44603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48226: [lldb] Remove enableThreadSanitizer from shared Xcode schemes

kubamracek closed this revision. kubamracek added a comment. r345155. https://reviews.llvm.org/D48226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek updated this revision to Diff 170809. kubamracek added a comment. Adding class comments, adding IDs to recognizers. https://reviews.llvm.org/D44603 Files: include/lldb/API/SBVariablesOptions.h include/lldb/Interpreter/OptionGroupVariable.h include/lldb/Interpreter/ScriptInterpr

[Lldb-commits] [PATCH] D48226: [lldb] Remove enableThreadSanitizer from shared Xcode schemes

kubamracek added a reviewer: aprantl. kubamracek added a comment. Ping. https://reviews.llvm.org/D48226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek updated this revision to Diff 170724. kubamracek added a comment. Updating patch, addressing most comments. Changed '-m' to '-s'. Added 'frame recognizer info' subcommand. Improved wording in documentation. I didn't add the possibility to specify multiple '-s' and '-n' args. Do you t

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek added a comment. friendly ping :) https://reviews.llvm.org/D44603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek updated this revision to Diff 152017. kubamracek added a comment. Fixing up test (it was using the "-t" flag). Removing a leftover printf(). https://reviews.llvm.org/D44603 Files: include/lldb/API/SBVariablesOptions.h include/lldb/Interpreter/OptionGroupVariable.h include/lldb/

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek updated this revision to Diff 152004. kubamracek added a comment. Switched on showing recognized args by default in "frame variable". Switched "-t" to mean "omit" instead of "include". Added documentation and an example into "help frame recognizer add" and into python-reference.html.

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek updated this revision to Diff 151991. kubamracek added a comment. Rebasing to current master. https://reviews.llvm.org/D44603 Files: include/lldb/API/SBVariablesOptions.h include/lldb/Interpreter/OptionGroupVariable.h include/lldb/Interpreter/ScriptInterpreter.h include/lldb/

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek updated this revision to Diff 151985. kubamracek added a comment. Cleaned up patch, clang-formatted, respects 80-columns now. Expanded test case. Implemented all "frame recognizer" commands (add, delete, clear, list). Changed iteration order on the list of active recognizers (so that

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek added a comment. In https://reviews.llvm.org/D44603#1133149, @jingham wrote: > This is going as I imagined it should, looks great! > We probably want to turn this on by default for "frame var" or no one will > ever discover it. The IDE folks can decide on their own what to do from t

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek added inline comments. Comment at: source/Commands/CommandObjectFrame.cpp:833 +bool CommandObjectFrameRecognizerAdd::DoExecute(Args &command, CommandReturnObject &result) { + if (m_options.m_class_name.empty()) { +result.AppendErrorWithFormat("%s needs a Python c

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek added a comment. @jingham, @jasonmolenda, I haven't addresses the comments yet, but I'll do that in the next round. I'd seeking approval of the high-level approach first. The patch is getting a bit large, but the added test (and the Python implementation of a recognizer) should showc

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek updated this revision to Diff 150891. kubamracek edited the summary of this revision. kubamracek added a comment. Updating StackFrameRecognizer with a Python plugin implementation and a testcase using a Python recognizer. Also removing the Darwin-specific parts. https://reviews.llvm.

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread

kubamracek added a comment. > Are you planning to rewrite this the command part of this patch using the > changes from https://reviews.llvm.org/D44603 once that's approved? Yes. https://reviews.llvm.org/D43886 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread

kubamracek added a comment. Hi, I've moved the part that introduces the frame recognizers to https://reviews.llvm.org/D44603. https://reviews.llvm.org/D43886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

kubamracek created this revision. kubamracek added reviewers: jingham, jasonmolenda. Herald added a subscriber: mgorny. This is following on the discussion and goals of https://reviews.llvm.org/D43886. The patch introduces a concept of "frame recognizer" and "recognized frame". This should be an

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a comment. The changes for _NSCallStackArray are at https://reviews.llvm.org/D44081. https://reviews.llvm.org/D43884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D44081: [lldb] Add synthetic frontend for _NSCallStackArray

kubamracek created this revision. kubamracek added reviewers: jingham, jasonmolenda, davide. An Obj-C array type _NSCallStackArray is used in NSException backtraces. This patch adds a synthetic frontend for _NSCallStackArray, which now correctly returns frame PCs. https://reviews.llvm.org/D440

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a comment. I simplified what this patch is doing by removing the other independent parts. I extended the test to be testing both CLI text output and SB APIs (which also means it cannot be moved to a lit test). https://reviews.llvm.org/D43884

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek updated this revision to Diff 136933. https://reviews.llvm.org/D43884 Files: packages/Python/lldbsuite/test/lang/objc/exceptions/Makefile packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py packages/Python/lldbsuite/test/lang/objc/exceptions/main.m source/

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a comment. The NFC refactoring part of this is at https://reviews.llvm.org/D44073. https://reviews.llvm.org/D43884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44073: [lldb] Refactor ObjC/NSException.cpp (cleanup, avoid code duplication). NFC.

kubamracek created this revision. kubamracek added reviewers: jingham, jasonmolenda, davide. - Refactor reading of NSException fields into ExtractFields method to avoid code duplication. - Remove "m_child_ptr" field, as it's not used anywhere. - Clang-format. https://reviews.llvm.org/D44073 Fi

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type

kubamracek created this revision. kubamracek added reviewers: jingham, jasonmolenda, davide. This builds on https://reviews.llvm.org/D43884 and https://reviews.llvm.org/D43886 and extends LLDB support of Obj-C exceptions to also look for a "current exception" for a thread in the C++ exception ha

[Lldb-commits] [PATCH] D44058: [lldb] Fix "code unreachable" warning in DNBArchImplX86_64::SetRegisterValue

kubamracek added a comment. In https://reviews.llvm.org/D44058#1026646, @davide wrote: > This seems scary. We really need a test case for this. Agreed, but I don't know this code, so I'm not able to come up with a test for this. https://reviews.llvm.org/D44058

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread

kubamracek added a comment. Thanks for the high-level feedback! I'll split the patch and we can discuss further. https://reviews.llvm.org/D43886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D44060: [lldb] Fix "code requires global destructor" warning in g_architecture_mutex

kubamracek created this revision. kubamracek added reviewers: jingham, jasonmolenda, davide, aprantl. https://reviews.llvm.org/D44060 Files: source/Core/PluginManager.cpp Index: source/Core/PluginManager.cpp === --- source/Core/P

[Lldb-commits] [PATCH] D44058: [lldb] Fix "code unreachable" warning in DNBArchImplX86_64::SetRegisterValue

kubamracek created this revision. kubamracek added reviewers: jingham, jasonmolenda, aprantl, davide. Looks like an actual bug and a result of a bag merge. https://reviews.llvm.org/D44058 Files: tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp Index: tools/debugserver/source/Mac

[Lldb-commits] [PATCH] D44056: [lldb] Fix "code unreachable" warning in HostThreadPosix::Cancel

kubamracek created this revision. kubamracek added reviewers: davide, jasonmolenda, jingham, aprantl. https://reviews.llvm.org/D44056 Files: source/Host/posix/HostThreadPosix.cpp Index: source/Host/posix/HostThreadPosix.cpp === -

[Lldb-commits] [PATCH] D44055: [lldb] Fix "requires global constructor" warning in g_range_specifiers

kubamracek created this revision. kubamracek added reviewers: jingham, davide, jasonmolenda, aprantl. https://reviews.llvm.org/D44055 Files: source/Breakpoint/BreakpointID.cpp Index: source/Breakpoint/BreakpointID.cpp === --- sou

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a comment. > This seems like it is two patches, one fixing the NSCallStackArray data > formatter, and one extracting fields from NSException. Is that right. I'm > more asking to make sure I'm not missing something about this patch. I'll split the patch. There's actually proba

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added inline comments. Comment at: packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py:1-4 +# encoding: utf-8 +""" +Test lldb Obj-C exception support. +""" davide wrote: > This looks like it doesn't need any interactivity whatsoe

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread

kubamracek created this revision. kubamracek added reviewers: jasonmolenda, jingham. Herald added a subscriber: mgorny. This adds new APIs and commands to deal with exceptions (mostly Obj-C exceptions): - SBThread and Thread get GetCurrentException API, which returns an SBValue/ValueObjectSP wi

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek created this revision. kubamracek added reviewers: jingham, jasonmolenda. This patch teaches LLDB about more fields on NSException Obj-C objects, specifically we can now retrieve the "name" and "reason" of an NSException. The goal is to eventually be able to have SB API that can provi

[Lldb-commits] [PATCH] D34774: [lldb] Add a testcase for MainThreadCheckerRuntime plugin

kubamracek added a comment. In https://reviews.llvm.org/D34774#907636, @SeanChense wrote: > Hi there, I am here to find help. Is there a way to get > `libMainThreadChecker.dylib` output ? Then we can analyze the output to > generate a report ? Hi, what are you trying to do? What info are you

[Lldb-commits] [PATCH] D36977: Add 'break' into GDBRemoteClientBase::SendContinuePacketAndWaitForResponse to fix a warning

kubamracek created this revision. Currently, clang complains here about an non-annotated fall-through. Repository: rL LLVM https://reviews.llvm.org/D36977 Files: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp Index: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp ===

[Lldb-commits] [PATCH] D34774: [lldb] Add a testcase for MainThreadCheckerRuntime plugin

kubamracek added a comment. Landed in r307170. https://reviews.llvm.org/D34774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D34774: [lldb] Add a testcase for MainThreadCheckerRuntime plugin

kubamracek updated this revision to Diff 104514. https://reviews.llvm.org/D34774 Files: packages/Python/lldbsuite/test/functionalities/mtc/simple/Makefile packages/Python/lldbsuite/test/functionalities/mtc/simple/TestMTCSimple.py packages/Python/lldbsuite/test/functionalities/mtc/simple/mai

[Lldb-commits] [PATCH] D34774: [lldb] Add a testcase for MainThreadCheckerRuntime plugin

kubamracek added a comment. Actually, I think I need to extract the detection of libMainThreadChecker.dylib into a helper function, because I want to add more tests that will use it. https://reviews.llvm.org/D34774 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D34774: [lldb] Add a testcase for MainThreadCheckerRuntime plugin

kubamracek created this revision. This adds a simple testcase for MainThreadCheckerRuntime. The tool (Main Thread Checker) is only available on Darwin and in very new Xcode versions, so the test also detects the presence of `libMainThreadChecker.dylib` and is skipped if the tool is not availab

[Lldb-commits] [PATCH] D34553: Shorten sanitizer plugin names

kubamracek added a comment. Oh wow, we really need to limit path lengths? What about files like `./packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/breakpoints_delayed_breakpoint_one_watchpoint/TestConcurrentBreakpointsDelayedBreakpointOneWatchpoint.py`? https://reviews.

[Lldb-commits] [PATCH] D34322: [lldb] Correctly escape newlines and backslashes in the JSON serializer

kubamracek added a comment. I see. The approach to escape as little as possible can be valid, I guess. In any case, this patch seems to do exactly this. We must escape backslashes, otherwise we’ll produce invalid output: imagine a backslash at the end of the string. Same about newlines: ther

[Lldb-commits] [PATCH] D34322: [lldb] Correctly escape newlines and backslashes in the JSON serializer

kubamracek created this revision. kubamracek added a project: LLDB. Herald added a subscriber: mgorny. JSON serializer fails to escape newlines and backslashes. Let's fix that. https://reviews.llvm.org/D34322 Files: lldb.xcodeproj/project.pbxproj source/Utility/JSON.cpp unittests/Utility

[Lldb-commits] [PATCH] D30007: [lldb] Provide API to know which sanitizer generated an eStopReasonInstrumentation

kubamracek added a comment. This revision now requires changes to proceed. ping https://reviews.llvm.org/D30007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D30007: [lldb] Provide API to know which sanitizer generated an eStopReasonInstrumentation

kubamracek updated this revision to Diff 95469. kubamracek added a comment. Addressing review comments. https://reviews.llvm.org/D30007 Files: include/lldb/API/SBThread.h include/lldb/API/SBThreadPlan.h include/lldb/Target/InstrumentationRuntimeStopInfo.h include/lldb/Target/StopInfo.h

[Lldb-commits] [PATCH] D30007: [lldb] Provide API to know which sanitizer generated an eStopReasonInstrumentation

kubamracek added a comment. @jingham ping https://reviews.llvm.org/D30007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D30024: [lldb] Add support for "external" reports in ThreadSanitizer LLDB plugin

kubamracek added inline comments. Comment at: source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89 + +void *dlsym(void* handle, const char* symbol); +int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long idx, const char

[Lldb-commits] [PATCH] D30024: [lldb] Add support for "external" reports in ThreadSanitizer LLDB plugin

kubamracek added inline comments. Comment at: source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89 + +void *dlsym(void* handle, const char* symbol); +int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long idx, const char

[Lldb-commits] [PATCH] D30024: [lldb] Add support for "external" reports in ThreadSanitizer LLDB plugin

kubamracek created this revision. TSan now has the ability to report races on "external" object, i.e. any library class/object that has read-shared write-exclusive threading semantics. The detection and reporting work almost out of the box, but TSan can now provide the type of the object (as a

[Lldb-commits] [PATCH] D30007: [lldb] Provide API to know which sanitizer generated an eStopReasonInstrumentation

kubamracek created this revision. kubamracek added a project: Sanitizers. We can provide this via StopReason->GetValue(). This is important so that users of SB API can treat various sanitizers differently (the extended stop reason data is also structured differently for different sanitizers).

[Lldb-commits] [PATCH] D30006: [lldb] Remove the "MemoryHistory" plugin type and merge it into InstrumentationRuntime

kubamracek created this revision. kubamracek added a project: Sanitizers. Herald added a subscriber: mgorny. There is currently a single MemoryHistory plugin, which is for AddressSanitizer. Let's merge the feature into InstrumentationRuntime plugins. I'm thinking of implementing another provid

[Lldb-commits] [PATCH] D28035: Stop limiting the number of TSan backtrace size to 8

kubabrecka added a comment. We're dealing with ValueObjects here, so assuming GetNumChildren() returns a valid number of children, I think this cannot cause any issues. https://reviews.llvm.org/D28035 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D28035: Stop limiting the number of TSan backtrace size to 8

kubabrecka created this revision. kubabrecka added reviewers: jasonmolenda, clayborg. kubabrecka added subscribers: lldb-commits, zaks.anna. kubabrecka added a project: Sanitizers. We currently limit the length of TSan returned backtraces to 8, which is not necessary (and a bug, most likely). Le

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

kubabrecka added a comment. Thanks for reviewing this! Repository: rL LLVM https://reviews.llvm.org/D27017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

kubabrecka added a comment. In https://reviews.llvm.org/D27017#611894, @filcab wrote: > LGTM > > (I commented on a minor nit. It might just be me, so feel free to keep the > current wording if you feel it's preferred) I'm not seeing this comment. Can you post it again? https://reviews.llvm.

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

kubabrecka added a comment. In https://reviews.llvm.org/D27017#604265, @clayborg wrote: > Looks fine. One question though: do we always have a shared library that > contains the ASAN runtime? If so, then we can actually put the array of short > to long description into the ASAN dylib and then w

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

kubabrecka added reviewers: filcab, zaks.anna, dcoughlin. kubabrecka removed rL LLVM as the repository for this revision. kubabrecka updated this revision to Diff 79611. kubabrecka added a comment. Updating the patch. https://reviews.llvm.org/D27017 Files: source/Plugins/InstrumentationRunti