[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

2019-05-08 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine added a comment. @labath @jingham @teemperor I've updated the documentation in both, the new and the old places. Can you please merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61483/new/ https://reviews.llvm.org/D61483 ___

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

2019-05-05 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine updated this revision to Diff 198223. kkleine added a comment. - [www] move `run ` command down for educational purposes - Add documentation to docs/use/map.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61483/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

2019-05-03 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine updated this revision to Diff 197944. kkleine added a comment. - [www] move `run ` command down for educational purposes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61483/new/ https://reviews.llvm.org/D61483 Files: lldb/www/lldb-gdb.ht

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

2019-05-03 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine updated this revision to Diff 197943. kkleine added a comment. Amend previous commit with copy paste error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61483/new/ https://reviews.llvm.org/D61483 Files: lldb/www/lldb-gdb.html Index: l

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

2019-05-03 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk edited the summary of this revision. kkleine updated this revision to Diff 197943. kkleine added a comment. Amend previous commit with copy paste error. The `run` command is only an abbrevia

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

2019-05-03 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine updated this revision to Diff 197922. kkleine added a comment. - Address formatting issues brought up in https://reviews.llvm.org/D61440#1488450 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61440/new/ https://reviews.llvm.org/D61440 File

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

2019-05-02 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine updated this revision to Diff 197848. kkleine added a comment. - Address formatting issues brought up in https://reviews.llvm.org/D61440#1488450 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61440/new/ https://reviews.llvm.org/D61440 File

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

2019-05-02 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine updated this revision to Diff 197846. kkleine added a comment. - Fix https://reviews.llvm.org/D61440#inline-545102 - Fix https://reviews.llvm.org/D61440#inline-545098 - Fix https://reviews.llvm.org/D61440#inline-545099 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

2019-05-02 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine created this revision. Herald added subscribers: lldb-commits, kadircet, arphaman. Herald added a project: LLDB. According to [C128] "Virtual functions should specify exactly one of `virtual`, `override`, or `final`", I've added override where a virtual function is overriden but the explic

[Lldb-commits] [PATCH] D61368: Fix build URL in new LLDB website

2019-05-01 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. After the LLDB website was migrated to be generated by Sphinx the build.html file lives in another location. See http://lists.llvm.org/pipermail/lldb-dev/2019-April/014992.html. Repository:

[Lldb-commits] [PATCH] D60443: Fix doxygen warning about function argument

2019-04-09 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kkleine added a reviewer: JDevlieghere. This fixes the following doxygen warning when building the lldb-cpp-doc target: This commit fixes: llvm-project/lldb/include/lldb/API/SBStructuredData.h

[Lldb-commits] [PATCH] D60442: Add missing space between \btrue

2019-04-09 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine updated this revision to Diff 194263. kkleine added a comment. - Fix doxygen warning about function argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60442/new/ https://reviews.llvm.org/D60442 Files: lldb/include/lldb/API/SBStructur

[Lldb-commits] [PATCH] D60442: Add missing space between \btrue

2019-04-09 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine added a comment. In D60442#1459367 , @JDevlieghere wrote: > Please let me know if you don't have commit access (yet) and need someone to > commit this for you. I think I don't have commit access (yet) and would like if someone can commit this

[Lldb-commits] [PATCH] D60442: Add missing space between \btrue

2019-04-09 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine updated this revision to Diff 194259. kkleine added a comment. Updated summary to reflect what doxygen error was addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60442/new/ https://reviews.llvm.org/D60442 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D60442: Add missing space between \btrue

2019-04-09 Thread Konrad Kleine via Phabricator via lldb-commits
kkleine created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There was a space missing in some the documentation for lldb::BreakpointsWriteToFile. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60442 Files: lldb/include/lldb/API/SBTa