[Lldb-commits] [lldb] f091b40 - [lldb] Fix warnings

2025-08-08 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-08-08T14:44:35-07:00 New Revision: f091b401844e3c689c06f5ea6c1674e1a0bb4e86 URL: https://github.com/llvm/llvm-project/commit/f091b401844e3c689c06f5ea6c1674e1a0bb4e86 DIFF: https://github.com/llvm/llvm-project/commit/f091b401844e3c689c06f5ea6c1674e1a0bb4e86.diff L

[Lldb-commits] [lldb] [lldb] Remove an unnecessary cast (NFC) (PR #152642)

2025-08-08 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/152642 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Complete a missing register format mapping in the gdb-remote p… (PR #152170)

2025-08-05 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @walter-erquinigo I've landed 40fbc76dc8e81ede437b581a652ce6e5850cbc7b to fix the build breakage from this PR. Thanks! https://github.com/llvm/llvm-project/pull/152170 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] 40fbc76 - [lldb] Fix the build

2025-08-05 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-08-05T11:09:56-07:00 New Revision: 40fbc76dc8e81ede437b581a652ce6e5850cbc7b URL: https://github.com/llvm/llvm-project/commit/40fbc76dc8e81ede437b581a652ce6e5850cbc7b DIFF: https://github.com/llvm/llvm-project/commit/40fbc76dc8e81ede437b581a652ce6e5850cbc7b.diff L

[Lldb-commits] [lldb] [lldb] Include bit.h instead of SwapByteOrder.h (NFC) (PR #151903)

2025-08-04 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/151903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Include bit.h instead of SwapByteOrder.h (NFC) (PR #151903)

2025-08-03 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/151903 We use llvm::byteswap from bit.h, but we don't use any feature from SwapByteOrder.h. >From 9d3b29f2da95e0328ef73a71f15815a9f71d3e88 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 3 Aug 2025 14:45

[Lldb-commits] [lldb] [lldb] Use std::optional::value_or (NFC) (PR #151629)

2025-08-01 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/151629 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use std::optional::value_or (NFC) (PR #151629)

2025-07-31 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/151629 None >From ce46f3df1109b25c660bc70de9f2f52f93e13ba0 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 31 Jul 2025 13:36:45 -0700 Subject: [PATCH] [lldb] Use std::optional::value_or (NFC) --- lldb/s

[Lldb-commits] [lldb] [lldb] Remove a redundant call to std::unique_ptr::get (NFC) (PR #151283)

2025-07-30 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/151283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove HasCallbackParameter (PR #150366)

2025-07-24 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/150366 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove HasCallbackParameter (PR #150366)

2025-07-24 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: > This actually does get used, but the patches that use this haven't landed > yet, so they can be removed for now. Thanks for the review! When you re-introduce it, would you mind converting this to a range-based for loop? Thanks again! https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] [lldb] Remove HasCallbackParameter (PR #150366)

2025-07-23 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: Note that I've removed the sole use of HasCallbackParameter in 5f35f06e5f50f5e2797cebf1e6204e1a15fc83bc to fix warnings. https://github.com/llvm/llvm-project/pull/150366 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Remove HasCallbackParameter (PR #150366)

2025-07-23 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/150366 None >From d2b134f3885eca8ad499303cf986a6f3e9e6c0cb Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 23 Jul 2025 20:48:04 -0700 Subject: [PATCH] [lldb] Remove HasCallbackParameter --- lldb/tools/l

[Lldb-commits] [lldb] 5f35f06 - [lldb] Fix warnings

2025-07-23 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-07-23T20:46:14-07:00 New Revision: 5f35f06e5f50f5e2797cebf1e6204e1a15fc83bc URL: https://github.com/llvm/llvm-project/commit/5f35f06e5f50f5e2797cebf1e6204e1a15fc83bc DIFF: https://github.com/llvm/llvm-project/commit/5f35f06e5f50f5e2797cebf1e6204e1a15fc83bc.diff L

[Lldb-commits] [lldb] [lldb] Proofread formatting.rst (PR #149768)

2025-07-21 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/149768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Proofread formatting.rst (PR #149768)

2025-07-21 Thread Kazu Hirata via lldb-commits
@@ -203,7 +203,7 @@ Scoping Many times the information that you might have in your prompt might not be available and you won``t want it to print out if it isn``t valid. To take care kazutakahirata wrote: Fixed in the latest revision. Thanks! https://github.

[Lldb-commits] [lldb] [lldb] Proofread formatting.rst (PR #149768)

2025-07-21 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/149768 >From b9c3f2c64644b0fcde6677151a8e49795c18c6cb Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 20 Jul 2025 23:41:50 -0700 Subject: [PATCH 1/2] [lldb] Proofread formatting.rst --- lldb/docs/use/for

[Lldb-commits] [lldb] [lldb] Proofread formatting.rst (PR #149768)

2025-07-20 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/149768 None >From b9c3f2c64644b0fcde6677151a8e49795c18c6cb Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 20 Jul 2025 23:41:50 -0700 Subject: [PATCH] [lldb] Proofread formatting.rst --- lldb/docs/use/f

[Lldb-commits] [lldb] [lldb] Proofread python-reference.rst (PR #149643)

2025-07-20 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/149643 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Proofread python-reference.rst (PR #149643)

2025-07-19 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/149643 None >From fe1bf575f69b88108a3efdd668944ce060a02349 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 18 Jul 2025 19:43:06 -0700 Subject: [PATCH] [lldb] Proofread python-reference.rst --- lldb/docs

[Lldb-commits] [lldb] [lldb] Use a range-based for loop instead of llvm::for_each (NFC) (PR #149541)

2025-07-18 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/149541 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use a range-based for loop instead of llvm::for_each (NFC) (PR #149541)

2025-07-18 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/149541 LLVM Coding Standards discourages llvm::for_each unless we already have a callable. >From 906c5777505f9aeedef88c5eecf3327bf56406dd Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 17 Jul 2025 10:05

[Lldb-commits] [lldb] 4647398 - [lldb] Fix a warning

2025-07-08 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-07-08T15:00:08-07:00 New Revision: 4647398d6a44d4596c6716875d8d92750f731f90 URL: https://github.com/llvm/llvm-project/commit/4647398d6a44d4596c6716875d8d92750f731f90 DIFF: https://github.com/llvm/llvm-project/commit/4647398d6a44d4596c6716875d8d92750f731f90.diff L

[Lldb-commits] [lldb] [lldb] Use llvm::erase_if (NFC) (PR #146624)

2025-07-01 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/146624 Note that erase_if combines erase and remove_if. >From f284559ea2ba13678d65c6e68e3799e03e28a36a Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Tue, 1 Jul 2025 11:18:31 -0700 Subject: [PATCH] [lldb] Us

[Lldb-commits] [lldb] 98e6d5c - [lldb] Fix warnings

2025-07-01 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-07-01T10:41:07-07:00 New Revision: 98e6d5cd47d4db020a1406032f96fd5cdfc56563 URL: https://github.com/llvm/llvm-project/commit/98e6d5cd47d4db020a1406032f96fd5cdfc56563 DIFF: https://github.com/llvm/llvm-project/commit/98e6d5cd47d4db020a1406032f96fd5cdfc56563.diff L

[Lldb-commits] [lldb] [lldb] Fix a typo in documentation (PR #146115)

2025-06-27 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/146115 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a typo in documentation (PR #146115)

2025-06-27 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/146115 None >From fdd6b1a9ce8f8faacb0b4afb9c3f8a15ca6d3a93 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 27 Jun 2025 00:47:43 -0700 Subject: [PATCH] [lldb] Fix a typo in documentation --- lldb/docs/re

[Lldb-commits] [lldb] [lldb] Remove an unused local variable (NFC) (PR #145212)

2025-06-23 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/145212 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Migrate away from ValueRange(std::nullopt) (NFC) (PR #145245)

2025-06-22 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/145245 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Migrate away from ValueRange(std::nullopt) (NFC) (PR #145245)

2025-06-22 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/145245 ArrayRef has a constructor that accepts std::nullopt. This constructor dates back to the days when we still had llvm::Optional. Since the use of std::nullopt outside the context of std::optional is kind

[Lldb-commits] [lldb] [lldb] Remove an unused local variable (NFC) (PR #145212)

2025-06-21 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/145212 None >From a29f94fa549fefc8db9fd7d804363401ed836f39 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 21 Jun 2025 15:41:17 -0700 Subject: [PATCH] [lldb] Remove an unused local variable (NFC) --- ll

[Lldb-commits] [lldb] [lldb] Remove a redundant control flow statement (NFC) (PR #144284)

2025-06-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/144284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove a redundant control flow statement (NFC) (PR #144284)

2025-06-15 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/144284 None >From 7763d82df4c8d050598fac2b6347ce3ba0e3518d Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 15 Jun 2025 10:48:33 -0700 Subject: [PATCH] [lldb] Remove a redundant control flow statement (NFC

[Lldb-commits] [lldb] [lldb/aarch64] Fix PC register info augmentation (PR #143499)

2025-06-10 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @labath I've landed 50313a5f556b9967e7d8eb53ee45f79f0fc5b2b8 to fix warnings from this PR. Thanks! https://github.com/llvm/llvm-project/pull/143499 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [lldb] 50313a5 - [lldb] Fix warnings

2025-06-10 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-06-10T11:27:30-07:00 New Revision: 50313a5f556b9967e7d8eb53ee45f79f0fc5b2b8 URL: https://github.com/llvm/llvm-project/commit/50313a5f556b9967e7d8eb53ee45f79f0fc5b2b8 DIFF: https://github.com/llvm/llvm-project/commit/50313a5f556b9967e7d8eb53ee45f79f0fc5b2b8.diff L

[Lldb-commits] [lldb] [lldb] Use llvm::find (NFC) (PR #143338)

2025-06-08 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/143338 This patch should be mostly obvious, but in one place, this patch changes: const auto &it = std::find(...) to: auto it = llvm::find(...) We do not need to bind to a temporary with const ref. >Fro

[Lldb-commits] [lldb] [lldb] Use std::none_of (NFC) (PR #143319)

2025-06-08 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/143319 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use std::none_of (NFC) (PR #143319)

2025-06-08 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/143319 None >From 1a40e7f3ec442feb3e79787504a290ded109422e Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 8 Jun 2025 09:45:19 -0700 Subject: [PATCH] [lldb] Use std::none_of (NFC) --- lldb/source/Utilit

[Lldb-commits] [lldb] [lldb] Remove an unused local variable (NFC) (PR #142882)

2025-06-04 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/142882 Note that CommandArgumentEntry is an alias for: std::vector >From 2e800e08e7645c82e86d2b466bd7cc0ba2b0d915 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 4 Jun 2025 12:50:57 -0700 Subject: [PA

[Lldb-commits] [lldb] c9e1c52 - [lldb] Fix a warning

2025-06-04 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-06-04T07:00:25-07:00 New Revision: c9e1c52e2e75a91a44a98df818cc9bd11655e51d URL: https://github.com/llvm/llvm-project/commit/c9e1c52e2e75a91a44a98df818cc9bd11655e51d DIFF: https://github.com/llvm/llvm-project/commit/c9e1c52e2e75a91a44a98df818cc9bd11655e51d.diff L

[Lldb-commits] [lldb] [lldb] Avoid creating a temporary instance of std::string (NFC) (PR #142294)

2025-06-01 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/142294 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid creating a temporary instance of std::string (NFC) (PR #142294)

2025-05-31 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/142294 GetExceptionBreakpoint takes StringRef to look for a matching breakpoint, so we don't need to create a temporary instance of std::string on our own. >From 9004075793013620dd5bf2aa542b7fbe77415ceb Mon Sep

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @charles-zablit I've verified that this PR fixes `check-lldb-unit` in my local build. Thank you for fixing this! https://github.com/llvm/llvm-project/pull/141790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] [lldb] Use llvm::any_of (NFC) (PR #141443)

2025-05-26 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/141443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::any_of (NFC) (PR #141443)

2025-05-25 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141443 None >From 5748dfe7f68a0778a7b7caeacbf79c2fb3536bd1 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 25 May 2025 10:41:49 -0700 Subject: [PATCH] [lldb] Use llvm::any_of (NFC) --- lldb/source/Break

[Lldb-commits] [lldb] [lldb] Use std::tie to implement operator< (NFC) (PR #141416)

2025-05-25 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/141416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use std::tie to implement operator< (NFC) (PR #141416)

2025-05-25 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141416 None >From e2a76ae23d253dc1802d2eb4fb3fc2789b5ee64f Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 24 May 2025 20:51:21 -0700 Subject: [PATCH] [lldb] Use std::tie to implement operator< (NFC) ---

[Lldb-commits] [lldb] [lldb] Use llvm::find_if (NFC) (PR #141385)

2025-05-25 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/141385 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a typo in documentation (PR #141384)

2025-05-25 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/141384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::find_if (NFC) (PR #141385)

2025-05-24 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141385 None >From ac77c0122b5f698017ef2c937e6f8bdc9397930d Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 24 May 2025 16:51:58 -0700 Subject: [PATCH] [lldb] Use llvm::find_if (NFC) --- .../lldb/Breakpo

[Lldb-commits] [lldb] [lldb] Fix a typo in documentation (PR #141384)

2025-05-24 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141384 None >From 47d8abfbc263505f34a5cef8214127748b95fae5 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 24 May 2025 15:04:00 -0700 Subject: [PATCH] [lldb] Fix a typo in documentation --- lldb/docs/us

[Lldb-commits] [lldb] [lldb] Use llvm::stable_sort (NFC) (PR #141352)

2025-05-24 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/141352 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::stable_sort (NFC) (PR #141352)

2025-05-24 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141352 None >From e7fb3d02c3a27a77a234c3ca485a7c6ca3a7b6a7 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 23 May 2025 20:01:29 -0700 Subject: [PATCH] [lldb] Use llvm::stable_sort (NFC) --- lldb/include

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-23 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: > I think this should fix the problem: #141259 . Kazu, could you verify that it > does please? @cmtice Yes, it does. I've LGTMed #141259. Thank you for fixing this quickly! https://github.com/llvm/llvm-project/pull/138093 ___

[Lldb-commits] [lldb] [LLDB] Fix warning about unused private members. (PR #141259)

2025-05-23 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata approved this pull request. LGTM. I've verified that your patch fixes the warning. Thanks! I suppose you're going to use these accessors in the near future !? https://github.com/llvm/llvm-project/pull/141259 ___ ll

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-23 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @cmtice I'm getting: ``` lldb/include/lldb/ValueObject/DILParser.h:121:8: error: private field 'm_fragile_ivar' is not used [-Werror,-Wunused-private-field] 121 | bool m_fragile_ivar; |^ lldb/include/lldb/ValueObject/DILParser.h:122:8: error: private fiel

[Lldb-commits] [lldb] [lldb] Remove redundant control flow statements (NFC) (PR #141183)

2025-05-22 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/141183 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove redundant control flow statements (NFC) (PR #141183)

2025-05-22 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141183 None >From ab8b6e252e6d62f6dcac140127dae8700634d117 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 21 May 2025 20:04:38 -0700 Subject: [PATCH] [lldb] Remove redundant control flow statements (NFC)

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: > Thanks, I'll fix those ASAP. @jansvoboda11 Please feel free to add me as a reviewer. I am happy to build things with your fix. https://github.com/llvm/llvm-project/pull/139584 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @jansvoboda11 I also see: ``` clang-tools-extra/clang-tidy/plugin/ClangTidyPlugin.cpp:45:51: error: too few arguments to function call, expected 2, have 1 45 | Context->setDiagnosticsEngine(DiagEngine.get()); | ~

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: > > @jansvoboda11 I've revered your PR due buildbot failures above (and my > > local build failures with the same error messages). I'm happy to try your > > revised patch to see if it build cleanly. Thanks! > > I already forward-fixed both failures: > [d25f95f](https://g

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @jansvoboda11 I've revered your PR due buildbot failures above (and my local build failures with the same error messages). I'm happy to try your revised patch to see if it build cleanly. Thanks! https://github.com/llvm/llvm-project/pull/139584 _

[Lldb-commits] [lldb] [lldb] Use llvm::is_contained (NFC) (PR #140466)

2025-05-19 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::is_contained (NFC) (PR #140466)

2025-05-18 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140466 None >From 71e7fe5e2898b6ccaef56622515f7e7f8eca005d Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 18 May 2025 10:39:39 -0700 Subject: [PATCH] [lldb] Use llvm::is_contained (NFC) --- lldb/source

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (NFC) (PR #140440)

2025-05-18 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140440 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (NFC) (PR #140440)

2025-05-17 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140440 None >From 308551bc503d13d3a9f991325fdeba0126a54f7e Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 17 May 2025 22:59:12 -0700 Subject: [PATCH] [lldb] Remove redundant calls to std::unique_ptr::get

[Lldb-commits] [lldb] [lldb] Use llvm::replace (NFC) (PR #140343)

2025-05-17 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140343 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::replace (NFC) (PR #140343)

2025-05-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140343 None >From e0f9312651d1e884547bf44b44dd2c6b8ff09ff6 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 16 May 2025 20:07:05 -0700 Subject: [PATCH] [lldb] Use llvm::replace (NFC) --- lldb/source/Inte

[Lldb-commits] [lldb] [lldb-dap] Avoid creating temporary instances of std::string (NFC) (PR #140325)

2025-05-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140325 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Avoid creating temporary instances of std::string (NFC) (PR #140325)

2025-05-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140325 EmplaceSafeString accepts StringRef for the last parameter, str, and then internally creates a copy of str via StringRef::str or llvm::json::fixUTF8, so caller do not need to create their own temporary ins

[Lldb-commits] [lldb] [lldb] Use std::optional::value_or (NFC) (PR #140011)

2025-05-15 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140011 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::unique (NFC) (PR #139910)

2025-05-15 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139910 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use std::optional::value_or (NFC) (PR #140011)

2025-05-14 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata edited https://github.com/llvm/llvm-project/pull/140011 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use std::optional::value_of (NFC) (PR #140011)

2025-05-14 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140011 None >From cb827a2d99f3d700378ddbe4064b60281c5ef85e Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 14 May 2025 23:29:42 -0700 Subject: [PATCH] [lldb] Use std::optional::value_of (NFC) --- .../Pl

[Lldb-commits] [lldb] [lldb] Simplify a string comparison (NFC) (PR #139932)

2025-05-14 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139932 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Simplify a string comparison (NFC) (PR #139932)

2025-05-14 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139932 None Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica

[Lldb-commits] [lldb] [lldb] Use llvm::unique (NFC) (PR #139910)

2025-05-14 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139910 While I am at it, this patch removes the "if" statement. std::vector::erase(first, last) doesn't do anything when first == last. Rate limit · GitHub body {

[Lldb-commits] [lldb] [lldb] Fix typos in documentation (PR #139839)

2025-05-13 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::is_contained (NFC) (PR #139758)

2025-05-13 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139758 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use std:::string::find with std::string_view (NFC) (PR #139679)

2025-05-13 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::is_contained (NFC) (PR #139758)

2025-05-13 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139758 None >From dbe2a85661292455f0c6c141bb6d61d938212cc6 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Tue, 13 May 2025 08:56:44 -0700 Subject: [PATCH] [lldb] Use llvm::is_contained (NFC) --- lldb/tools/

[Lldb-commits] [lldb] [lldb] Use std:::string::find with std::string_view (NFC) (PR #139679)

2025-05-13 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata edited https://github.com/llvm/llvm-project/pull/139679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use std:::string::find with a std::string_view (NFC) (PR #139679)

2025-05-13 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139679 std::string::find accepts anything that can be converted to std::string_view starting in C++17. Since StringRef can be converted to std::string_view, we do not need to create a temporary instance of std::

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139428)

2025-05-10 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139428 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139428)

2025-05-10 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139428 None >From 4001252c4cd0cc8fedfb1773ef3a53befe2774f6 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Tue, 25 Mar 2025 00:24:37 -0700 Subject: [PATCH] [lldb] Remove redundant calls to std::unique_ptr::get

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139395)

2025-05-10 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139395 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Simplify string comparisons (NFC) (PR #139394)

2025-05-10 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139394 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139395)

2025-05-10 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139395 None Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica

[Lldb-commits] [lldb] [lldb] Simplify string comparisons (NFC) (PR #139394)

2025-05-10 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139394 None >From ab137cc177482af73941f2b4cf22aef886d500f6 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 28 Apr 2025 09:38:32 -0700 Subject: [PATCH] [lldb] Simplify string comparisons (NFC) --- lldb/s

[Lldb-commits] [lldb] [lldb] Use -Wno-documentation-deprecated-sync if available (PR #138909)

2025-05-07 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/138909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use -Wno-documentation-deprecated-sync if available (PR #138909)

2025-05-07 Thread Kazu Hirata via lldb-commits
@@ -16,6 +16,15 @@ if (CXX_SUPPORTS_DOCUMENTATION) PRIVATE -Wdocumentation) endif() +# Apply -Wno-documentation-deprecated-sync while we migrate away from +# report_fatal_error in llvm/include/llvm/Support/ErrorHandling.h +# and llvm/include/llvm/Support/Error.h. -

[Lldb-commits] [lldb] [lldb] Use llvm::bit_ceil (NFC) (PR #138723)

2025-05-06 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/138723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::bit_ceil (NFC) (PR #138723)

2025-05-06 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/138723 This patch replaces a local implementation of bit_ceil with llvm::bit_ceil. Technically, the local implementation evaluates to 0 on input 0, whereas llvm::bit_ceil evaluates to 1, but that doesn't matter

[Lldb-commits] [lldb] [lldb] Remove unused local variables (NFC) (PR #138457)

2025-05-04 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/138457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove unused local variables (NFC) (PR #138457)

2025-05-04 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/138457 None >From 3f79743b6f2a71f764cd86201820c25efee33851 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 4 May 2025 09:28:01 -0700 Subject: [PATCH] [lldb] Remove unused local variables (NFC) --- lldb/

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-05-01 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @real-mikhail @jimingham I've landed 2bff80f25d51e24d3c552e033a2863dd36ef648b to fix a warning from this PR. Thanks! https://github.com/llvm/llvm-project/pull/129092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [lldb] 2bff80f - [lldb] Fix a warning

2025-05-01 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-05-01T12:27:08-07:00 New Revision: 2bff80f25d51e24d3c552e033a2863dd36ef648b URL: https://github.com/llvm/llvm-project/commit/2bff80f25d51e24d3c552e033a2863dd36ef648b DIFF: https://github.com/llvm/llvm-project/commit/2bff80f25d51e24d3c552e033a2863dd36ef648b.diff L

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #137379)

2025-04-25 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata commented: I've locally applied your change on the top of tree, but I still get: ``` lldb/source/Target/Statistics.cpp:75:39: error: use of undeclared identifier 'num_symbols_loaded' module.try_emplace("symbolsLoaded", num_symbols_loaded);

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #134563)

2025-04-25 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @GeorgeHuyubo I've reverted this PR. I'm happy to try your revised patch. Thanks! https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] bc716a7 - Revert "Add symbol locator time for each module in statistics (#134563)"

2025-04-25 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-04-25T11:01:19-07:00 New Revision: bc716a755a9bd0e5f0b5de0da0ffcc77374690db URL: https://github.com/llvm/llvm-project/commit/bc716a755a9bd0e5f0b5de0da0ffcc77374690db DIFF: https://github.com/llvm/llvm-project/commit/bc716a755a9bd0e5f0b5de0da0ffcc77374690db.diff L

  1   2   3   >