slackito wrote:
Thanks for the quick response, Jim!
https://github.com/llvm/llvm-project/pull/114158
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slackito wrote:
Repro was pretty straightforward from the description above.
common.cc:
```c++
#include
#define XSTR(x) STR(x)
#define STR(x) #x
namespace NAMESPACE {
void DoSomeStuff() {
printf("%s::DoSomeStuff()\n", XSTR(NAMESPACE));
}
} // end NAMESPACE
```
main.cc:
```c++
namespace
slackito wrote:
Hi,
I'm having some problems with one of our tests, that also reproduce after
[#114337](https://github.com/llvm/llvm-project/pull/114337).
I don't have a repro yet but I'll describe what I know of the problem so far in
case it rings a bell.
The test in question has a common s
https://github.com/slackito approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/113220
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slackito edited
https://github.com/llvm/llvm-project/pull/112451
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slackito edited
https://github.com/llvm/llvm-project/pull/112451
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slackito edited
https://github.com/llvm/llvm-project/pull/112451
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -98,10 +94,31 @@ void RenderDiagnosticDetails(Stream &stream,
continue;
}
-auto &loc = *detail.source_location;
remaining_details.push_back(detail);
+ }
+
+ // Sort the diagnostics.
+ auto sort = [](auto &ds) {
+llvm::sort(ds.begin(), ds.end(), [](
@@ -98,10 +94,31 @@ void RenderDiagnosticDetails(Stream &stream,
continue;
}
-auto &loc = *detail.source_location;
remaining_details.push_back(detail);
+ }
+
+ // Sort the diagnostics.
+ auto sort = [](auto &ds) {
+llvm::sort(ds.begin(), ds.end(), [](
slackito wrote:
> Could you do me another favor and try swapping out line 292 in LineTable.cpp
> for:
> ```
> line_entry.SetFile(
>
> std::make_shared(m_comp_unit->GetSupportFiles().GetFileSpecAtIndex(entry.file_idx)));
> ```
With that modification the test goes back to passing :)
ht
slackito wrote:
I tested the two patches separately.
With the first one, [Make LineEntry::file
private](https://github.com/llvm/llvm-project/pull/85892/commits/0914ecdf582831ec4da776e26ae5ebd2cf9f984f),
my problematic test case still passes.
When I apply the second one, [Swap FileSpec for
Su
https://github.com/slackito approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -437,7 +434,7 @@ std::string
CreateUniqueVariableNameForDisplay(lldb::SBValue v,
/// context (e.g. locals). This can happen due to shadowed variables in
/// nested blocks.
///
-/// As VSCode doesn't render two of more variables with the same name, we
---
https://github.com/slackito commented:
Thanks for doing this!
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slackito edited
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -196,6 +196,9 @@ Changes to LLDB
for formatters to quickly find directly nested type when it's known
where to search for it, avoiding more expensive global search via
``SBTarget::FindFirstType``.
+* ``lldb-vscode`` was renamed to ``lldb-dap`` and and its installation
+
@@ -388,7 +385,7 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread, uint32_t stop_id);
/// The variable name of \a value or a default placeholder.
const char *GetNonNullVariableName(lldb::SBValue value);
-/// VSCode can't display two variables with the same
Author: Jorge Gorbe Moya
Date: 2023-05-30T14:21:21-07:00
New Revision: a79b0f9f1d8275b023bcd2bf1763b148d088ad97
URL:
https://github.com/llvm/llvm-project/commit/a79b0f9f1d8275b023bcd2bf1763b148d088ad97
DIFF:
https://github.com/llvm/llvm-project/commit/a79b0f9f1d8275b023bcd2bf1763b148d088ad97.di
Author: Jorge Gorbe Moya
Date: 2023-05-22T10:41:11-07:00
New Revision: d25fb4e90c96f8fcb22fbed9009295026f1d20cf
URL:
https://github.com/llvm/llvm-project/commit/d25fb4e90c96f8fcb22fbed9009295026f1d20cf
DIFF:
https://github.com/llvm/llvm-project/commit/d25fb4e90c96f8fcb22fbed9009295026f1d20cf.di
Author: Jorge Gorbe Moya
Date: 2023-05-11T13:11:38-07:00
New Revision: 1b11034c672fc90d35b4bc0e93f3507657b14094
URL:
https://github.com/llvm/llvm-project/commit/1b11034c672fc90d35b4bc0e93f3507657b14094
DIFF:
https://github.com/llvm/llvm-project/commit/1b11034c672fc90d35b4bc0e93f3507657b14094.di
Author: Jorge Gorbe Moya
Date: 2023-05-02T14:50:39-07:00
New Revision: 2b6c5bb995be1b675c1d92e2d46403c76764e5c7
URL:
https://github.com/llvm/llvm-project/commit/2b6c5bb995be1b675c1d92e2d46403c76764e5c7
DIFF:
https://github.com/llvm/llvm-project/commit/2b6c5bb995be1b675c1d92e2d46403c76764e5c7.di
Author: Jorge Gorbe Moya
Date: 2023-05-01T16:19:01-07:00
New Revision: d69518b4e52d527b3f8fcc41e90ae21f1f234555
URL:
https://github.com/llvm/llvm-project/commit/d69518b4e52d527b3f8fcc41e90ae21f1f234555
DIFF:
https://github.com/llvm/llvm-project/commit/d69518b4e52d527b3f8fcc41e90ae21f1f234555.di
Author: Jorge Gorbe Moya
Date: 2023-05-01T14:14:09-07:00
New Revision: 45351120105a7257ccb1e38ec1b1f8a452269da2
URL:
https://github.com/llvm/llvm-project/commit/45351120105a7257ccb1e38ec1b1f8a452269da2
DIFF:
https://github.com/llvm/llvm-project/commit/45351120105a7257ccb1e38ec1b1f8a452269da2.di
Author: Jorge Gorbe Moya
Date: 2023-05-01T13:08:04-07:00
New Revision: d366da97bd24ddfb91c9f260fa0aaf105d947652
URL:
https://github.com/llvm/llvm-project/commit/d366da97bd24ddfb91c9f260fa0aaf105d947652
DIFF:
https://github.com/llvm/llvm-project/commit/d366da97bd24ddfb91c9f260fa0aaf105d947652.di
Author: Jorge Gorbe Moya
Date: 2023-04-17T17:03:29-07:00
New Revision: 3c91d016349a5189691cf788da84608cae68bc13
URL:
https://github.com/llvm/llvm-project/commit/3c91d016349a5189691cf788da84608cae68bc13
DIFF:
https://github.com/llvm/llvm-project/commit/3c91d016349a5189691cf788da84608cae68bc13.di
Author: Jorge Gorbe Moya
Date: 2023-04-10T18:18:05-07:00
New Revision: 53aa22cd9ac4a779208cf9907354cc6d4211e783
URL:
https://github.com/llvm/llvm-project/commit/53aa22cd9ac4a779208cf9907354cc6d4211e783
DIFF:
https://github.com/llvm/llvm-project/commit/53aa22cd9ac4a779208cf9907354cc6d4211e783.di
Author: Jorge Gorbe Moya
Date: 2023-03-27T16:07:36-07:00
New Revision: 4a38d33268959309dd97d9ef423327607bda4104
URL:
https://github.com/llvm/llvm-project/commit/4a38d33268959309dd97d9ef423327607bda4104
DIFF:
https://github.com/llvm/llvm-project/commit/4a38d33268959309dd97d9ef423327607bda4104.di
Author: Jorge Gorbe Moya
Date: 2023-03-22T11:28:52-07:00
New Revision: 984354fbbe4e207798f6d83c6f46b7603952dd36
URL:
https://github.com/llvm/llvm-project/commit/984354fbbe4e207798f6d83c6f46b7603952dd36
DIFF:
https://github.com/llvm/llvm-project/commit/984354fbbe4e207798f6d83c6f46b7603952dd36.di
Author: Jorge Gorbe Moya
Date: 2023-01-31T10:26:39-08:00
New Revision: b27e4f72213e78cacf0ce5bfd127261ec0b9309b
URL:
https://github.com/llvm/llvm-project/commit/b27e4f72213e78cacf0ce5bfd127261ec0b9309b
DIFF:
https://github.com/llvm/llvm-project/commit/b27e4f72213e78cacf0ce5bfd127261ec0b9309b.di
Author: Jorge Gorbe Moya
Date: 2023-01-27T10:15:35-08:00
New Revision: 805600c7d573cf88cf035d01a2ea9389fc24d435
URL:
https://github.com/llvm/llvm-project/commit/805600c7d573cf88cf035d01a2ea9389fc24d435
DIFF:
https://github.com/llvm/llvm-project/commit/805600c7d573cf88cf035d01a2ea9389fc24d435.di
Author: Jorge Gorbe Moya
Date: 2022-11-10T10:29:38-08:00
New Revision: 868186cf6cb7edba08c916f98f5f87a942bf50ba
URL:
https://github.com/llvm/llvm-project/commit/868186cf6cb7edba08c916f98f5f87a942bf50ba
DIFF:
https://github.com/llvm/llvm-project/commit/868186cf6cb7edba08c916f98f5f87a942bf50ba.di
mething an option to "type summary add"
>> and "type synthetic add" to indicate that the name passed is neither a type
>> name nor a regex but a recognizer function instead. Maybe
>> -R/--recognizer-function?
>>
>> Is it too horrible of me t
Author: Jorge Gorbe Moya
Date: 2022-10-27T15:05:27-07:00
New Revision: 7d4d25c42a682ec5abcc008225268a6ce82673f3
URL:
https://github.com/llvm/llvm-project/commit/7d4d25c42a682ec5abcc008225268a6ce82673f3
DIFF:
https://github.com/llvm/llvm-project/commit/7d4d25c42a682ec5abcc008225268a6ce82673f3.di
t;
> Is it too horrible of me to ask you to do these as a follow-up? Otherwise
> I fear you will be the only one to use this feature...
>
> Jim
>
>
> > On Oct 19, 2022, at 12:54 PM, Jorge Gorbe Moya via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
> >
&g
Author: Jorge Gorbe Moya
Date: 2022-10-19T12:53:38-07:00
New Revision: d76566417e592cfac9c710f82575473b1b4a9285
URL:
https://github.com/llvm/llvm-project/commit/d76566417e592cfac9c710f82575473b1b4a9285
DIFF:
https://github.com/llvm/llvm-project/commit/d76566417e592cfac9c710f82575473b1b4a9285.di
Author: Jorge Gorbe Moya
Date: 2022-10-10T15:14:55-07:00
New Revision: e5fd507f9b6f774c83c7b061fa77c906c882935b
URL:
https://github.com/llvm/llvm-project/commit/e5fd507f9b6f774c83c7b061fa77c906c882935b
DIFF:
https://github.com/llvm/llvm-project/commit/e5fd507f9b6f774c83c7b061fa77c906c882935b.di
Author: Jorge Gorbe Moya
Date: 2022-10-06T13:27:11-07:00
New Revision: 69c661a65ff8c04ce9408a788a77df67481545a1
URL:
https://github.com/llvm/llvm-project/commit/69c661a65ff8c04ce9408a788a77df67481545a1
DIFF:
https://github.com/llvm/llvm-project/commit/69c661a65ff8c04ce9408a788a77df67481545a1.di
Author: Jorge Gorbe Moya
Date: 2022-10-06T12:11:27-07:00
New Revision: dee9c7f5d7e53aa6a9e7f85cdf9935341ba7e636
URL:
https://github.com/llvm/llvm-project/commit/dee9c7f5d7e53aa6a9e7f85cdf9935341ba7e636
DIFF:
https://github.com/llvm/llvm-project/commit/dee9c7f5d7e53aa6a9e7f85cdf9935341ba7e636.di
Author: Jorge Gorbe Moya
Date: 2022-09-27T14:28:41-07:00
New Revision: 1f2a21820dfa2c97de8cc9e09cd03cf1c1684e31
URL:
https://github.com/llvm/llvm-project/commit/1f2a21820dfa2c97de8cc9e09cd03cf1c1684e31
DIFF:
https://github.com/llvm/llvm-project/commit/1f2a21820dfa2c97de8cc9e09cd03cf1c1684e31.di
Author: Jorge Gorbe Moya
Date: 2022-09-20T10:41:06-07:00
New Revision: dce68873360097be77ff8b3ce68b6eedc612fbef
URL:
https://github.com/llvm/llvm-project/commit/dce68873360097be77ff8b3ce68b6eedc612fbef
DIFF:
https://github.com/llvm/llvm-project/commit/dce68873360097be77ff8b3ce68b6eedc612fbef.di
Author: Jorge Gorbe Moya
Date: 2022-09-13T12:50:55-07:00
New Revision: ef3fa232b338fd73475656ed61847295b0beef24
URL:
https://github.com/llvm/llvm-project/commit/ef3fa232b338fd73475656ed61847295b0beef24
DIFF:
https://github.com/llvm/llvm-project/commit/ef3fa232b338fd73475656ed61847295b0beef24.di
Author: Jorge Gorbe Moya
Date: 2022-09-02T16:04:04-07:00
New Revision: f021cb57ce786f7d5a6c921a19bbcf56709b6ce0
URL:
https://github.com/llvm/llvm-project/commit/f021cb57ce786f7d5a6c921a19bbcf56709b6ce0
DIFF:
https://github.com/llvm/llvm-project/commit/f021cb57ce786f7d5a6c921a19bbcf56709b6ce0.di
Author: Jorge Gorbe Moya
Date: 2022-08-09T10:48:49-07:00
New Revision: fe01292457fc04532c5d2eccc9d0674df4582fa6
URL:
https://github.com/llvm/llvm-project/commit/fe01292457fc04532c5d2eccc9d0674df4582fa6
DIFF:
https://github.com/llvm/llvm-project/commit/fe01292457fc04532c5d2eccc9d0674df4582fa6.di
Author: Jorge Gorbe Moya
Date: 2022-07-21T09:22:40-07:00
New Revision: fa3a2e611d84c29ddb3b48afea0ac64ef85b2de9
URL:
https://github.com/llvm/llvm-project/commit/fa3a2e611d84c29ddb3b48afea0ac64ef85b2de9
DIFF:
https://github.com/llvm/llvm-project/commit/fa3a2e611d84c29ddb3b48afea0ac64ef85b2de9.di
Author: Jorge Gorbe Moya
Date: 2022-05-23T11:31:53-07:00
New Revision: f0a61c2ce2afec200967c59d45181c7a9fbe2c3f
URL:
https://github.com/llvm/llvm-project/commit/f0a61c2ce2afec200967c59d45181c7a9fbe2c3f
DIFF:
https://github.com/llvm/llvm-project/commit/f0a61c2ce2afec200967c59d45181c7a9fbe2c3f.di
Author: Jorge Gorbe Moya
Date: 2021-02-23T13:26:11-08:00
New Revision: 979ca1c05f83114483caec3e6d1b75daae86da79
URL:
https://github.com/llvm/llvm-project/commit/979ca1c05f83114483caec3e6d1b75daae86da79
DIFF:
https://github.com/llvm/llvm-project/commit/979ca1c05f83114483caec3e6d1b75daae86da79.di
Author: Jorge Gorbe Moya
Date: 2021-01-05T16:40:37-08:00
New Revision: a39b19821b6b8c6b4ae853f6b6a88128275ea2c7
URL:
https://github.com/llvm/llvm-project/commit/a39b19821b6b8c6b4ae853f6b6a88128275ea2c7
DIFF:
https://github.com/llvm/llvm-project/commit/a39b19821b6b8c6b4ae853f6b6a88128275ea2c7.di
Author: jgorbe
Date: Fri Jun 7 14:09:30 2019
New Revision: 362843
URL: http://llvm.org/viewvc/llvm-project?rev=362843&view=rev
Log:
[lldb] Fix msan use-of-uninitialized-value in DWARFDebugLine::FileNameEntry.
lldb/lit/SymbolFile/DWARF/debug-types-expressions.test fails with msan.
This change fix
Author: jgorbe
Date: Thu May 23 13:11:17 2019
New Revision: 361546
URL: http://llvm.org/viewvc/llvm-project?rev=361546&view=rev
Log:
[lldb] Make sure RegularExpression constructors always initialize member
variables
The copy constructor of RegularExpression doesn't initialize m_comp_err. This
c
Author: jgorbe
Date: Wed May 22 16:37:48 2019
New Revision: 361444
URL: http://llvm.org/viewvc/llvm-project?rev=361444&view=rev
Log:
[lldb] Fix use-of-uninitialized-value in Driver
The driver passes by reference an uninitialized num_errors variable to
RunCommandInterpreter. This should be fine, a
Author: jgorbe
Date: Thu May 9 09:47:07 2019
New Revision: 360355
URL: http://llvm.org/viewvc/llvm-project?rev=360355&view=rev
Log:
[lldb] build.py: fix behavior when passing --compiler=/path/to/compiler
All the other paths in the find_toolchain function return a tuple
(detected_toolchain_type,
Author: jgorbe
Date: Wed Apr 3 13:43:20 2019
New Revision: 357633
URL: http://llvm.org/viewvc/llvm-project?rev=357633&view=rev
Log:
Re-enable most lldb-vscode tests on Linux.
Summary:
After https://reviews.llvm.org/D59828 and https://reviews.llvm.org/D59849,
I believe the problems with these tes
Author: jgorbe
Date: Mon Apr 1 13:37:22 2019
New Revision: 357426
URL: http://llvm.org/viewvc/llvm-project?rev=357426&view=rev
Log:
[lldb-vscode] Add logic to handle EOF when reading from lldb-vscode stdout.
Summary:
This change prevents the lldb-vscode test harness from hanging up waiting for
n
Author: jgorbe
Date: Tue Mar 26 11:36:44 2019
New Revision: 357016
URL: http://llvm.org/viewvc/llvm-project?rev=357016&view=rev
Log:
Add lldb-vscode as a dependency of lldb tests.
Summary:
In the current state, 'ninja check-lldb' runs the lldb-vscode tests, but it
won't rebuild lldb-vscode if any
Author: jgorbe
Date: Thu Mar 14 18:46:50 2019
New Revision: 356227
URL: http://llvm.org/viewvc/llvm-project?rev=356227&view=rev
Log:
[lldb-vscode] Fix dangling pointer in request_evaluate.
SBError::GetCString() returns a pointer to a string owned by the SBError
object. The code here was calling G
Author: jgorbe
Date: Wed Mar 13 16:50:35 2019
New Revision: 356110
URL: http://llvm.org/viewvc/llvm-project?rev=356110&view=rev
Log:
[lldb-vscode] Don't try to launch an invalid program.
If an invalid program is specified, lldb-vscode will send back a
response with "success" = false, but then wil
Author: jgorbe
Date: Fri Feb 15 09:54:00 2019
New Revision: 354149
URL: http://llvm.org/viewvc/llvm-project?rev=354149&view=rev
Log:
Disable stop-hook-threads.test on Linux
ExecControl/StopHook/stop-hook-threads.test is flaky on Linux (it's
consistently failing on my machine, but doesn't fail on
Author: jgorbe
Date: Mon Jan 7 13:04:12 2019
New Revision: 350570
URL: http://llvm.org/viewvc/llvm-project?rev=350570&view=rev
Log:
[lldb] Fix -Wstring-plus-int warning in POSIX-DYLD/AuxVector.cpp
Modified:
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
Modified: lldb/trun
Author: jgorbe
Date: Thu Nov 8 14:04:58 2018
New Revision: 346441
URL: http://llvm.org/viewvc/llvm-project?rev=346441&view=rev
Log:
[lldb] Silence unhandled enums warning.
The warning was introduced by r346392, which introduces new builtin
types (to support cl_intel_device_side_avc_motion_estima
Author: jgorbe
Date: Thu Nov 8 11:57:59 2018
New Revision: 346435
URL: http://llvm.org/viewvc/llvm-project?rev=346435&view=rev
Log:
[lldb] Fix initialization order warnings.
Moved the declaration of m_kind below the declaration of cvclass,
cvunion and cvenum. This order is necessary because in o
60 matches
Mail list logo
