rjmccall added a comment.
I see, thank you. I know you've marked this a WIP, but it's always good to
describe these things in the patch description; that's what it's for.
This is quite exciting! Thank you for looking into this.
I think you could usefully be much more incremental here. Obvious
rjmccall added a comment.
What is this work about?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127695/new/
https://reviews.llvm.org/D127695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67774/new/
https://reviews.llvm.org/D67774
___
lldb-commits mailing list
rjmccall added a comment.
Thanks. One last and minor request: please mention in the comment on
IsLiteralLabel that non-literal labels are used by some external AST sources
like LLDB.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67774/new/
https://reviews.llvm.org/D67774
__
rjmccall added inline comments.
Comment at: clang/lib/AST/Mangle.cpp:130
+ return;
+}
+
vsk wrote:
> rjmccall wrote:
> > This is actually backwards, right? A literal label is one that doesn't get
> > the global prefix and therefore potentially needs th
rjmccall added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:734
+// TODO: Make it possible to specify this in source.
+BoolArgument<"LiteralLabel">
+ ];
`LiteralLabel` is an unfortunate name for this property because
`getLiteralLabel`
rjmccall added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:725
let Spellings = [Keyword<"asm">, Keyword<"__asm__">];
- let Args = [StringArgument<"Label">];
+ let Args = [StringArgument<"Label">, BoolArgument<"LiteralLabel">];
let SemaHandler = 0;
-
rjmccall added inline comments.
Comment at: clang/lib/AST/Mangle.cpp:137
+(!Source || Source->UseGlobalPrefixInAsmLabelMangle()))
Out << '\01'; // LLVM IR Marker for __asm("foo")
This is one of those bugs where looking at the code really reveals
