https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/149620
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
Incidentally, this is always something get a little confused by when reading
assembly, we see it with backtraces. A CALL instruction executes and the
return address is the next instruction. That confuses people looking at the
assembly language -- the "pc" pointer is point
jasonmolenda wrote:
Interesting PR, thanks for looking at adding these annotations. I think
exposing these dwarf location expressions in a more user-visible way is going
to put a lot of pressure on making them more meaningful to users, as opposed to
debugging prints for debugger/compiler deve
@@ -2015,8 +2015,6 @@ llvm::Expected DWARFExpression::Evaluate(
if (stack.size() < 1) {
UpdateValueTypeFromLocationDescription(log, dwarf_cu,
LocationDescriptionKind::Empty);
-// Reset for the next piece.
-
@@ -2015,8 +2015,6 @@ llvm::Expected DWARFExpression::Evaluate(
if (stack.size() < 1) {
UpdateValueTypeFromLocationDescription(log, dwarf_cu,
LocationDescriptionKind::Empty);
-// Reset for the next piece.
-
jasonmolenda wrote:
The general discussion of how to test this class of change is interesting, but
I don't want to lose sight of the fact that this PR will not work. It does
nothing but break existing functionality for RISC-V users (disabling
instruction emulation used to do instruction stepp
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/148105
>From 74995e8f1a982a82bafaa150fb407187fa4b95e4 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 10 Jul 2025 22:31:54 -0700
Subject: [PATCH 1/6] [lldb][WIP] dump riscv opcode bytes as blocks of 2/4
b
jasonmolenda wrote:
I didn't little-endian swap the bytes for the 48-bit and 64-bit instructions
properly in my unit test, which is why those two were failing. Fixed now.
https://github.com/llvm/llvm-project/pull/148105
___
lldb-commits mailing list
jasonmolenda wrote:
nb: I didn't little-endian swap the bytes for the 48-bit and 64-bit
instructions properly in my unit test in
https://github.com/llvm/llvm-project/pull/148105 , which is why those tests
were failing. Fixed.
https://github.com/llvm/llvm-project/pull/145793
_
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/148105
>From 74995e8f1a982a82bafaa150fb407187fa4b95e4 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 10 Jul 2025 22:31:54 -0700
Subject: [PATCH 1/5] [lldb][WIP] dump riscv opcode bytes as blocks of 2/4
b
jasonmolenda wrote:
I'm also getting back an instruction size of 2 for the 48-bit instruction, in
my unit test, it looks like.
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/148105
>From 74995e8f1a982a82bafaa150fb407187fa4b95e4 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 10 Jul 2025 22:31:54 -0700
Subject: [PATCH 1/4] [lldb][WIP] dump riscv opcode bytes as blocks of 2/4
b
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/148105
>From 74995e8f1a982a82bafaa150fb407187fa4b95e4 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 10 Jul 2025 22:31:54 -0700
Subject: [PATCH 1/3] [lldb][WIP] dump riscv opcode bytes as blocks of 2/4
b
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/148105
>From 74995e8f1a982a82bafaa150fb407187fa4b95e4 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 10 Jul 2025 22:31:54 -0700
Subject: [PATCH 1/2] [lldb][WIP] dump riscv opcode bytes as blocks of 2/4
b
jasonmolenda wrote:
I mentioned it last week but I know there was a lot of different comments on
this PR, so I wanted to be more clear about what I was talking about. The
Opcode class is given a Type argument which it uses to decide how to format the
bytes when it Dumps them. But this PR add
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/148105
Part of the changes by Ted Woodward et al in
https://github.com/llvm/llvm-project/pull/145793
to change the riscv disassemble --bytes mode output to match llvm-objdump
prints the instruction bytes as sequen
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/147434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/147434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
If you look at an existing EmulateInstruction target plugin that we live on
today, such as ARM64, it returns context types for
`UnwindAssemblyInstEmulation` like
```
eContextAdjustBaseRegister
eContextAdjustStackPointer
eContextAdvancePC
eContextImmediate
eContextPopRegist
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/147011
>From bf1838f4676bab0f7c998d3dbb03b6b593103335 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Fri, 4 Jul 2025 00:11:30 -0700
Subject: [PATCH 1/2] [lldb] Pass address expression command args through
Fix
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/147011
>From bf1838f4676bab0f7c998d3dbb03b6b593103335 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Fri, 4 Jul 2025 00:11:30 -0700
Subject: [PATCH 1/3] [lldb] Pass address expression command args through
Fix
jasonmolenda wrote:
FTR armv7 has one of the few FixCodeAddress methods that actually clears the
low bits, because the low bit is sometimes used to indicate arm/thumb processor
state of functions.
https://github.com/llvm/llvm-project/pull/147011
___
jasonmolenda wrote:
I didn't have a solid way to test this except rely on the arm-ubuntu bot, so I
enhanced a random armv7 mach-o corefile creator tool I wrote ages ago to add a
memory segment, and try to read from an odd address to confirm that it behaves
correctly, but this test will only ru
jasonmolenda wrote:
I can't imagine which 32-bit arm hater made this kind of change originally.
https://github.com/llvm/llvm-project/pull/147011
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/147011
>From bf1838f4676bab0f7c998d3dbb03b6b593103335 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Fri, 4 Jul 2025 00:11:30 -0700
Subject: [PATCH] [lldb] Pass address expression command args through
FixAnyA
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/147011
Commands that take an address expression/address through the
OptionArgParser::ToAddress method, which has filtered this user-specified
address through one of the Process Fix methods to clear non-addressabl
https://github.com/jasonmolenda approved this pull request.
Seems like a reasonable RP to me.
https://github.com/llvm/llvm-project/pull/146972
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
Author: Jason Molenda
Date: 2025-07-02T11:16:04-07:00
New Revision: 00e071d6906246192b344f3e28d9e15a0e0faf68
URL:
https://github.com/llvm/llvm-project/commit/00e071d6906246192b344f3e28d9e15a0e0faf68
DIFF:
https://github.com/llvm/llvm-project/commit/00e071d6906246192b344f3e28d9e15a0e0faf68.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/146480
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> > Doesn't seem the ideal format given that we have a known size, today most
> > often 16/32/64, and I guess 48 for funsies.
>
> Standard instructions are right now only 16/32, but custom instructions can
> be any multiple of 16. This was the change to llvm-objdump to grou
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/146609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
ah sure enough, ``` } else if (packet_cmd == 'z') {
// remove
switch (break_type) {
case '0': // remove software breakpoint
case '1': // remove hardware breakpoint
if (DNBBreakpointClear(pid, addr)) {
```
there's no requirement to be correct about which
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/146480
>From e0e19746256fa8db4b94d3b3f747b22487589be7 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 1 Jul 2025 00:32:21 -0700
Subject: [PATCH 1/2] [lldb][NFC][MachO] Clean up LC_THREAD reading code,
rem
jasonmolenda wrote:
> Sorry for going off-topic, but what does this say about the support for
> `i386-apple-*` as a whole? I find the prospect of dropping that exciting, as
> I believe that is the only target where eh_ and debug_frame register numbers
> are different.
I think we can remove i3
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/146460
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/146460
>From a9b23cc16ca7b3a20ccc7c63e64f840fcbf7da9d Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 30 Jun 2025 20:26:40 -0700
Subject: [PATCH 1/2] [lldb][Mach-O] Fix several bugs in x86_64 Mach-O corefi
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/144627
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 01/19] [lldb][Mach-O] Allow "process metadata" LC_NOTE to
s
@@ -0,0 +1,300 @@
+//===-- RegisterContextUnifiedCore.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,300 @@
+//===-- RegisterContextUnifiedCore.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,300 @@
+//===-- RegisterContextUnifiedCore.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,300 @@
+//===-- RegisterContextUnifiedCore.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 01/18] [lldb][Mach-O] Allow "process metadata" LC_NOTE to
s
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 01/17] [lldb][Mach-O] Allow "process metadata" LC_NOTE to
s
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 01/16] [lldb][Mach-O] Allow "process metadata" LC_NOTE to
s
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 01/15] [lldb][Mach-O] Allow "process metadata" LC_NOTE to
s
@@ -70,27 +77,49 @@ lldb::RegisterContextSP
ThreadMachCore::GetRegisterContext() {
lldb::RegisterContextSP
ThreadMachCore::CreateRegisterContextForFrame(StackFrame *frame) {
- lldb::RegisterContextSP reg_ctx_sp;
uint32_t concrete_frame_idx = 0;
if (frame)
concre
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 01/14] [lldb][Mach-O] Allow "process metadata" LC_NOTE to
s
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 01/13] [lldb][Mach-O] Allow "process metadata" LC_NOTE to
s
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 01/12] [lldb][Mach-O] Allow "process metadata" LC_NOTE to
s
@@ -0,0 +1,293 @@
+//===-- RegisterContextUnifiedCore.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 01/10] [lldb][Mach-O] Allow "process metadata" LC_NOTE to
s
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 1/7] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supp
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/144627
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,293 @@
+//===-- RegisterContextUnifiedCore.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 1/8] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supp
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 1/9] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supp
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 1/6] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supp
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 1/5] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supp
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 1/4] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supp
jasonmolenda wrote:
> Hi @JDevlieghere,
>
> I think I know why - it's by design: In the `Host::FindProcessImpl()` for iOS
> simulator, after getting all processes in the macOS, it filters out the
> processes which are being debugged
FWIW in general this is done so that you can have multiple
https://github.com/jasonmolenda approved this pull request.
Looks good to me, test addition is nice. Usually when I've seen lldb sending
qC, something has gone off the rails enough that the debug session is dead, but
I can see vRun being a particular instance where it might not be.
https://gi
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 1/3] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supp
https://github.com/jasonmolenda approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/140875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> Sorry for missing this one earlier. I'm a little confused about earlier in
> this method,
>
> At the end of the loops, `sme_regnum` is the index of the final SME register
> we've added to `m_dynamic_reg_infos`. Then if we have the ZT0 register, we
> reuse that index a
@@ -425,7 +425,7 @@ void RegisterInfoPOSIX_arm64::AddRegSetSME(bool has_zt) {
//
// This must be added now, rather than when vg is defined because SME is a
// dynamic set that may or may not be present.
- static uint32_t vg_invalidates[] = {sme_regnum + 1 /*svg*/,
+ sta
jasonmolenda wrote:
Sorry for missing this one earlier. I'm a little confused about earlier in
this method,
```
for (uint32_t i = 0; i < k_num_sme_register; ++i, ++sme_regnum) {
m_sme_regnum_collection.push_back(sme_regnum);
m_dynamic_reg_infos.push_back(g_register_infos_sme[i]);
m
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 1/2] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supp
jasonmolenda wrote:
The API test case included in the PR makes it pretty easy to see what the
format looks like, if the english description wasn't clear.
https://github.com/llvm/llvm-project/pull/144627
___
lldb-commits mailing list
lldb-commits@lists
jasonmolenda wrote:
One design note. I wanted a format that describes the register layout for each
thread separately, instead of coming up with a shared register set for all
threads. In a JTAG style environment, a "thread" is really a core, and we may
have cores with different capabilities a
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/144627
The "process metadata" LC_NOTE allows for thread IDs to be specified in a
Mach-O corefile. This extends the JSON recognzied in that LC_NOTE to allow for
additional registers to be supplied on a per-thread
jasonmolenda wrote:
> One idea is to add a new string method on the llvm::Triple class:
>
> ```
> const std::string strNoObjectFormat() const;
> ```
>
> And this would check if the object format is in the string in
> `llvm::Triple::Data` and if so strip it and return it, else return the
> `
jasonmolenda wrote:
> Hi @jasonmolenda,
>
> > I don't want to see -macho in a triple that we're creating for any of these
> > modules; this is going to break things down the line with firmware
> > environments, I'm sure of it. It's also ugly.
>
> For context, could you elaborate where/why are
Author: Jason Molenda
Date: 2025-06-17T17:41:31-07:00
New Revision: 4e090b6e84e33e2a442e3951253ca570f8f842f8
URL:
https://github.com/llvm/llvm-project/commit/4e090b6e84e33e2a442e3951253ca570f8f842f8
DIFF:
https://github.com/llvm/llvm-project/commit/4e090b6e84e33e2a442e3951253ca570f8f842f8.diff
jasonmolenda wrote:
I don't want to go with this approach, I don't want to see `-macho` in a triple
that we're creating for any of these modules; this is going to break things
down the line with firmware environments, I'm sure of it. It's also ugly.
This is an undesired behavior from llvm's T
jasonmolenda wrote:
> > I also needed to remove the brk #0xf000 instruction because lldb is not
> > able to step over it -- it just ends up spinning forever. FWICS, it's not
> > actually necessary now that you're stepping through the test. Nonetheless,
> > this is a bug -- one that @DavidSpick
jasonmolenda wrote:
I thought we augmented the target.xml from the remote gdb stub via
`ABI::AugmentRegisterInfo` -- adding eh_frame/dwarf register numbers that were
not supplied by the stub, for instance -- but looking at AArch64 & x86, it
looks like it's just adding the slice registers like
jasonmolenda wrote:
Thanks for help, I didn't realize I regressed this with my NFC reorg.
https://github.com/llvm/llvm-project/pull/143499
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/139817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/139817
>From e63e53adc0909f481a165eca958a3ac2ca4374ee Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 13 May 2025 17:11:08 -0700
Subject: [PATCH 1/9] [lldb][NFC] Split
RegisterContextUnwind::SavedLocation
Author: Jason Molenda
Date: 2025-06-09T17:42:31-07:00
New Revision: f5733b0b859ada51ab4a1cc239ce901ea30b297f
URL:
https://github.com/llvm/llvm-project/commit/f5733b0b859ada51ab4a1cc239ce901ea30b297f
DIFF:
https://github.com/llvm/llvm-project/commit/f5733b0b859ada51ab4a1cc239ce901ea30b297f.diff
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/139817
>From e63e53adc0909f481a165eca958a3ac2ca4374ee Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 13 May 2025 17:11:08 -0700
Subject: [PATCH 1/9] [lldb][NFC] Split
RegisterContextUnwind::SavedLocation
jasonmolenda wrote:
FTR I suspect the correct fix for
https://github.com/llvm/llvm-project/pull/142704 is
1. This Triple object file setting should be done in ArchSpec::SetArchitecture,
so it doesn't depending on hitting an LC_BUILD load command, if anything is
going to depend on it.
2. There
jasonmolenda wrote:
e.g. https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/27150/
but it reproduced on my arm64 macOS desktop no problem when I did `ninja
check-lldb-shell`
https://github.com/llvm/llvm-project/pull/139170
___
lldb-c
jasonmolenda wrote:
Ultimately I expect
```
// Don't create a debug map if the object file isn't a Mach-O.
if (!objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
```
was not succeeding for this binary. I didn't debug what was special about this
binary; the compile command in the sh
jasonmolenda wrote:
I'll admit I didn't debug it very far, but when I reverted the
ObjectFileMachO.cpp change, `lldb/test/Shell/Breakpoint/case-sensitive.test`
started failing on the bots. When I built main myself and ran it, it failed on
my desktop. When I used the built lldb on the `case-s
jasonmolenda wrote:
NB I reverted this on main because it depends on
https://github.com/llvm/llvm-project/pull/142704
which I also reverted as it adds "-macho" to every Module's Triple string, and
we need to find a way to mark the object file as MachO without doing that.
https://github.com/llvm
Author: Jason Molenda
Date: 2025-06-05T17:47:04-07:00
New Revision: 7730093596b898fa2773003f396da4b3ad1f3c0a
URL:
https://github.com/llvm/llvm-project/commit/7730093596b898fa2773003f396da4b3ad1f3c0a
DIFF:
https://github.com/llvm/llvm-project/commit/7730093596b898fa2773003f396da4b3ad1f3c0a.diff
jasonmolenda wrote:
I've reverted this commit on main for now,
```
commit f961d6a89abe5a6fb70afc043f33b2efcec77536
Author: Jason Molenda
Date: Thu Jun 5 16:23:27 2025 -0700
Revert "[lldb] Set default object format to `MachO` in `ObjectFileMachO`
(#142704)"
```
Until we can find a way t
Author: Jason Molenda
Date: 2025-06-05T16:24:31-07:00
New Revision: f961d6a89abe5a6fb70afc043f33b2efcec77536
URL:
https://github.com/llvm/llvm-project/commit/f961d6a89abe5a6fb70afc043f33b2efcec77536
DIFF:
https://github.com/llvm/llvm-project/commit/f961d6a89abe5a6fb70afc043f33b2efcec77536.diff
jasonmolenda wrote:
In `ArchSpec::SetArchitecture` if we passed in the vendor in addition to the
architecture, that would set the ObjectFile to MachO correctly *without*
calling `Triple::setObjectFormat` which adds the object file name to the triple
as an environment, if there is no environmen
jasonmolenda wrote:
Aha, I see. Any call to llvm's `setObjectFormat` is going to add this to the
triple string if there is no environ set:
```
1608 void Triple::setObjectFormat(ObjectFormatType Kind) {
1609 if (Environment == UnknownEnvironment)
-> 1610 return setEnvironmentName(ge
jasonmolenda wrote:
In `ObjectFileMachO::GetAllArchSpecs()`, we call `ArchSpec::SetArchitecture()`,
```
base_arch.SetArchitecture(eArchTypeMachO, header.cputype, header.cpusubtype);
```
given a `mach_header`. This does
```
890 m_triple.setArchName(llvm::StringRef(core_def->name));
jasonmolenda wrote:
nb this PR is causing a failure on the x86_64 macOS CI bot
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/ in
TestUniversal.py where `image list -t -b` returns a triple name of
`x86_64-apple-macosx10.9.0-macho` instead of `x86_64-apple-macosx10.9.0` and
t
Author: Jason Molenda
Date: 2025-05-29T01:30:02-07:00
New Revision: 57f3151a3144259f4e830fc43a1424e4c1f15985
URL:
https://github.com/llvm/llvm-project/commit/57f3151a3144259f4e830fc43a1424e4c1f15985
DIFF:
https://github.com/llvm/llvm-project/commit/57f3151a3144259f4e830fc43a1424e4c1f15985.diff
Author: Jason Molenda
Date: 2025-05-28T22:02:16-07:00
New Revision: 3788d459472fb28c244bad6bf010fdcbad907de7
URL:
https://github.com/llvm/llvm-project/commit/3788d459472fb28c244bad6bf010fdcbad907de7
DIFF:
https://github.com/llvm/llvm-project/commit/3788d459472fb28c244bad6bf010fdcbad907de7.diff
Author: Jason Molenda
Date: 2025-05-27T21:50:56-07:00
New Revision: 7c471e12c80f86ba089fb5951ece4d516996d9a1
URL:
https://github.com/llvm/llvm-project/commit/7c471e12c80f86ba089fb5951ece4d516996d9a1
DIFF:
https://github.com/llvm/llvm-project/commit/7c471e12c80f86ba089fb5951ece4d516996d9a1.diff
https://github.com/jasonmolenda approved this pull request.
This looks good to me.
https://github.com/llvm/llvm-project/pull/138416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
Looks good to me.
https://github.com/llvm/llvm-project/pull/140927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
OK.
https://github.com/llvm/llvm-project/pull/140228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 1443 matches
Mail list logo
