[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

2021-08-30 Thread Hiroki Imai via Phabricator via lldb-commits
HirokiImai added a comment. Thanks for the review! I didn't know how to write tests very well, so the review was very helpful for me. I found the LLVM project to be beautiful in its componentization. I'll learn more about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

2021-08-30 Thread Hiroki Imai via Phabricator via lldb-commits
HirokiImai updated this revision to Diff 369412. HirokiImai added a comment. Add a regression test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108817/new/ https://reviews.llvm.org/D108817 Files: lldb/source/Host/common/Editline.cpp lldb/test

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion with using file path.

2021-08-27 Thread Hiroki Imai via Phabricator via lldb-commits
HirokiImai updated this revision to Diff 369220. HirokiImai added a comment. Apply clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108817/new/ https://reviews.llvm.org/D108817 Files: lldb/source/Host/common/Editline.cpp Index: lldb/

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion with using file path.

2021-08-27 Thread Hiroki Imai via Phabricator via lldb-commits
HirokiImai created this revision. Herald added a subscriber: pengfei. HirokiImai requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When I run a lldb command that uses filename completion, if I enter a string that is not only a filename but