[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

2020-05-20 Thread Haruki Imai via Phabricator via lldb-commits
imaihal updated this revision to Diff 264769. imaihal added a comment. Herald added subscribers: lldb-commits, kbarton, hiraditya, nemanjai. Herald added a project: LLDB. [mlir][SystemZ] Fix incompatible datalayout in SystemZ MLIR tests in "mlir/test/mlir-cpu-runner" fails in SystemZ (z14) becaus

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

2020-05-20 Thread Haruki Imai via Phabricator via lldb-commits
imaihal marked an inline comment as done. imaihal added a comment. Thanks for the review! I changed the variable name to `camelBack` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80130/new/ https://reviews.llvm.org/D80130 ___

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

2020-05-20 Thread Haruki Imai via Phabricator via lldb-commits
imaihal added a comment. My wrong operation(submission) may add LLDB tag on this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80130/new/ https://reviews.llvm.org/D80130 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

2020-05-20 Thread Haruki Imai via Phabricator via lldb-commits
imaihal updated this revision to Diff 264770. imaihal added a comment. - [NFC] Replace MaybeAlign with Align in TargetTransformInfo. - [mlir][SystemZ] Fix incompatible datalayout in SystemZ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80130/new/ h

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

2020-05-19 Thread Haruki Imai via Phabricator via lldb-commits
imaihal added a comment. @ftynse and @mehdi_amini, Could you help to commit this if this patch ready for commit? I don't have write access to the repository. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80130/new/ https://reviews.llvm.org/D8013

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

2020-05-19 Thread Haruki Imai via Phabricator via lldb-commits
imaihal marked 2 inline comments as done. imaihal added inline comments. Comment at: mlir/lib/ExecutionEngine/ExecutionEngine.cpp:123 } - std::unique_ptr machine( - target->createTargetMachine(targetTriple, "generic", "", {}, {})); + std::string cpu = std::string(llvm::

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

2020-05-19 Thread Haruki Imai via Phabricator via lldb-commits
imaihal updated this revision to Diff 265107. imaihal added a comment. Changed getHostCPUName() part to reflect the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80130/new/ https://reviews.llvm.org/D80130 Files: mlir/lib/ExecutionEngine