hokein wrote:
> Ah, not a problem, the new one is fine. I was just very thrown/wondering why
> I was reviewing something so similar again.
Sorry for not being clearer about that. I’ll go ahead and close the previous
review. The new one should already incorporate your review comments from the
hokein wrote:
The enhancement to the pretty-printer looks reasonable to me.
I'm not familiar with the LLDB codebase, so I'll leave the approval to the LLDB
maintainers.
https://github.com/llvm/llvm-project/pull/141516
___
lldb-commits mailing list
l
https://github.com/hokein approved this pull request.
Thank you!
https://github.com/llvm/llvm-project/pull/126215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
hokein wrote:
Heads-up: this patch triggers a MSAN failure in an lldb test
(`lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py`),
the stacktrace:
```
==5633==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 in decltype(auto)
clang::ASTNodeImporter::CallOv
hokein wrote:
I saw the msan failure when integrating LLVM into our internal codebase, it is
a msan-build lldb.
The second error `AssertionError: launching (4) != stopped (5)` occurred in a
non-msan-build lldb from the upstream repository. And I ran `llvm-lit -sv
lldb/test/API/functionalitie
hokein wrote:
@Jlalond, I revert it in 86f7374078288e2b3d3d0fd66428f7752e2319e6 to keep the
trunk green. Feel free to reland the patch with the fix.
https://github.com/llvm/llvm-project/pull/101770
___
lldb-commits mailing list
lldb-commits@lists.llvm
Author: Haojian Wu
Date: 2024-08-05T09:37:36+02:00
New Revision: 86f7374078288e2b3d3d0fd66428f7752e2319e6
URL:
https://github.com/llvm/llvm-project/commit/86f7374078288e2b3d3d0fd66428f7752e2319e6
DIFF:
https://github.com/llvm/llvm-project/commit/86f7374078288e2b3d3d0fd66428f7752e2319e6.diff
LO
hokein wrote:
The newly-added test causes a msan failure:
```
==1960==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x55e25271b29e in RetryAfterSignal
llvm-project/llvm/include/llvm/Support/Errno.h:37:11
#1 0x55e25271b29e in lldb_private::NativeFile::Write(void const*, unsigne
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/73307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
hokein wrote:
@Michael137, I'm merging this patch now. I'm happy to address any post comments.
https://github.com/llvm/llvm-project/pull/73307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/73307
>From 5fb8fd532fe767feb2d361f9552ff31ea7770663 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 24 Nov 2023 10:46:03 +0100
Subject: [PATCH 1/3] [LLDB] Respect the DW_AT_alignment attribute.
Part of fixes for
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/73307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1926,12 +1930,13 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
// TypeSystemClang is always in C++ mode, but some compilers such as
// GCC and Clang give empty structs a size of 0 in C mode (in contrast to
// the size of 1 for emp
https://github.com/hokein commented:
Thanks for the review.
https://github.com/llvm/llvm-project/pull/73307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/73307
>From 5fb8fd532fe767feb2d361f9552ff31ea7770663 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 24 Nov 2023 10:46:03 +0100
Subject: [PATCH 1/2] [LLDB] Respect the DW_AT_alignment attribute.
Part of fixes for
@@ -1926,12 +1930,13 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
// TypeSystemClang is always in C++ mode, but some compilers such as
// GCC and Clang give empty structs a size of 0 in C mode (in contrast to
// the size of 1 for emp
https://github.com/hokein created
https://github.com/llvm/llvm-project/pull/73307
Part of fixes for #72913.
clang emits `DW_AT_alignment` attribute, however LLDB didn't respect it,
resulting in incorrect RecordDecls built by lldb.
This only fixes non-inheritance cases. The inheritance case wi
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
hokein wrote:
Thanks for the review.
https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/71928
>From 08c3b1a40b508d360f47bed6d7d42050c18b01a0 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 10 Nov 2023 12:35:10 +0100
Subject: [PATCH 1/5] [LLDB] Display artificial __promise and __coro_frame
variables.
@@ -78,8 +78,19 @@ def do_test(self, stdlib_type):
],
)
-# Run until after the `co_yield`
process = self.process()
+
+# Break at a coroutine body
+lldbutil.continue_to_source_breakpoint(
+ self, process, "//
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/71928
>From 08c3b1a40b508d360f47bed6d7d42050c18b01a0 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 10 Nov 2023 12:35:10 +0100
Subject: [PATCH 1/4] [LLDB] Display artificial __promise and __coro_frame
variables.
Author: Haojian Wu
Date: 2023-11-13T10:12:55+01:00
New Revision: 0515ccc0c48b919dae03edc391304e66cdb75d66
URL:
https://github.com/llvm/llvm-project/commit/0515ccc0c48b919dae03edc391304e66cdb75d66
DIFF:
https://github.com/llvm/llvm-project/commit/0515ccc0c48b919dae03edc391304e66cdb75d66.diff
LO
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hokein commented:
Thanks for the comments.
https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -78,8 +78,19 @@ def do_test(self, stdlib_type):
],
)
-# Run until after the `co_yield`
process = self.process()
+
+# Break at a coroutine body
+lldbutil.continue_to_source_breakpoint(
+ self, process, "//
@@ -41,7 +41,10 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ return name == g_this ||
+ // Artificial coroutine-related vari
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/71928
>From 08c3b1a40b508d360f47bed6d7d42050c18b01a0 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 10 Nov 2023 12:35:10 +0100
Subject: [PATCH 1/3] [LLDB] Display artificial __promise and __coro_frame
variables.
hokein wrote:
@Caslyn , I added the `# REQUIRES: gcc` to the test in
https://github.com/llvm/llvm-project/commit/81a76902ae0fc08138e37212239c5c704eec2f26
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.
Author: Haojian Wu
Date: 2023-11-10T20:56:27+01:00
New Revision: 81a76902ae0fc08138e37212239c5c704eec2f26
URL:
https://github.com/llvm/llvm-project/commit/81a76902ae0fc08138e37212239c5c704eec2f26
DIFF:
https://github.com/llvm/llvm-project/commit/81a76902ae0fc08138e37212239c5c704eec2f26.diff
LO
hokein wrote:
> Did you configure your build with `LLDB_INCLUDE_TESTS=ON` and
> `LLDB_INCLUDE_PYTHON=ON`? Those CMake variables are necessary to get the API
> tests to run
Thanks! I was able to run the test locally now with `-DLLDB_INCLUDE_TESTS=On`,
`-DLLDB_ENABLE_PYTHON=On`, and all deps i
@@ -41,7 +41,11 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ // FIXME: use a list when the list grows more.
hokein
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/71928
>From 1ac7e612bf6917af4e347407fb98affa9bb296c6 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 10 Nov 2023 12:35:10 +0100
Subject: [PATCH 1/2] [LLDB] Display artificial __promise and __coro_frame
variables.
hokein wrote:
Thank you very much for the fix!
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
hokein wrote:
> I think I have a fix for this, will commit it soon.
Ah, I just saw your new message. If you can fix that, that would be fantastic
(I don't know too much about lldb).
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mai
hokein wrote:
> Hi, this is failing on Linaro's Linux LLDB bots:
> https://lab.llvm.org/buildbot/#/builders/96/builds/48277
> Looks like the -m64 (or -m32) is being passed to an AArch64 (or ARM) g++, and
> those are X86 only flags.
Sorry for the breakage. I removed this test temporarily in
3
Author: Haojian Wu
Date: 2023-11-10T13:46:36+01:00
New Revision: 343eb4b4253fea31767f6a98e1cf77a7d69c856a
URL:
https://github.com/llvm/llvm-project/commit/343eb4b4253fea31767f6a98e1cf77a7d69c856a
DIFF:
https://github.com/llvm/llvm-project/commit/343eb4b4253fea31767f6a98e1cf77a7d69c856a.diff
LO
https://github.com/hokein ready_for_review
https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
hokein wrote:
Is there a way to run the tests under `lldb/test/API/` directory? `ninja
check-lldb` doesn't seem to run these tests on my linux machine.
```
./bin/llvm-lit -sv
/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/
Testing Time: 0.02s
https://github.com/hokein created
https://github.com/llvm/llvm-project/pull/71928
See the discussion in #69309.
>From 1ac7e612bf6917af4e347407fb98affa9bb296c6 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 10 Nov 2023 12:35:10 +0100
Subject: [PATCH] [LLDB] Display artificial __promise an
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
hokein wrote:
Thank you very much for the review!
> Are you still going to make the change to CommandObjectFrame such that frame
> var doesn't hide the artificial fields?
Yes, that's my next step.
https://github.com/llvm/llvm-project/pull/70779
___
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/70779
>From 2ff56f181659a0079c66ce646d50780844ffb080 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Tue, 31 Oct 2023 11:15:45 +0100
Subject: [PATCH 1/4] [LLDB] Don't ignore artificial variables and members for
corouti
@@ -771,6 +771,10 @@ TypeSystemClang
*TypeSystemClang::GetASTContext(clang::ASTContext *ast) {
return clang_ast;
}
+bool TypeSystemClang::ShouldIgnoreArtificialField(llvm::StringRef Name) {
+ return Name.starts_with("_vptr$");
hokein wrote:
> TypeSystemCl
hokein wrote:
Thanks for the comment, I updated the patch, this is ready for another round of
review.
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/hokein ready_for_review
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -771,6 +771,10 @@ TypeSystemClang
*TypeSystemClang::GetASTContext(clang::ASTContext *ast) {
return clang_ast;
}
+bool TypeSystemClang::ShouldIgnoreArtificialField(llvm::StringRef Name) {
+ return Name.starts_with("_vptr$");
hokein wrote:
Thanks, good c
@@ -41,7 +41,10 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ // FIXME: use a list when the list grows more.
+ return name == g_this
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3059,9 +3059,8 @@ void DWARFASTParserClang::ParseSingleMember(
// This needs to be done after updating FieldInfo which keeps track of where
// field start/end so we don't later try to fill the space of this
// artificial member with (unnamed bitfield) padding.
- // F
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/70779
>From 2ff56f181659a0079c66ce646d50780844ffb080 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Tue, 31 Oct 2023 11:15:45 +0100
Subject: [PATCH 1/3] [LLDB] Don't ignore artificial variables and members for
corouti
@@ -3061,7 +3061,8 @@ void DWARFASTParserClang::ParseSingleMember(
// artificial member with (unnamed bitfield) padding.
// FIXME: This check should verify that this is indeed an artificial member
// we are supposed to ignore.
- if (attrs.is_artificial) {
+ if (attrs.is
https://github.com/hokein commented:
Thanks for the review.
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -41,7 +41,10 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ // FIXME: use a list when the list grows more.
+ return name == g_this
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/70779
>From 4cc40aafef4db5133f4360b2fb367e1776dc2901 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Tue, 31 Oct 2023 11:15:45 +0100
Subject: [PATCH 1/2] [LLDB] Don't ignore artificial variables and members for
corouti
https://github.com/hokein created
https://github.com/llvm/llvm-project/pull/70779
Fixes #69309
* always populate all fields for the generated coroutine frame type;
* make the artificial variables `__promise`, `__coro_frame` visible, so that
they are present in the `frame var` command;
>From
Author: Haojian Wu
Date: 2023-07-04T08:52:45+02:00
New Revision: 2a579db32a7a0a5f10ddd989eb4cb14974c17c26
URL:
https://github.com/llvm/llvm-project/commit/2a579db32a7a0a5f10ddd989eb4cb14974c17c26
DIFF:
https://github.com/llvm/llvm-project/commit/2a579db32a7a0a5f10ddd989eb4cb14974c17c26.diff
LO
Author: Haojian Wu
Date: 2022-10-28T11:56:19+02:00
New Revision: bf07c338bb78c54b8d96fb42a75b168bf1550ad7
URL:
https://github.com/llvm/llvm-project/commit/bf07c338bb78c54b8d96fb42a75b168bf1550ad7
DIFF:
https://github.com/llvm/llvm-project/commit/bf07c338bb78c54b8d96fb42a75b168bf1550ad7.diff
LO
Author: Haojian Wu
Date: 2021-12-09T17:54:27+01:00
New Revision: eaf4f60507fd7e5d20c5dcee711ca12f13f1acc1
URL:
https://github.com/llvm/llvm-project/commit/eaf4f60507fd7e5d20c5dcee711ca12f13f1acc1
DIFF:
https://github.com/llvm/llvm-project/commit/eaf4f60507fd7e5d20c5dcee711ca12f13f1acc1.diff
LO
Author: Haojian Wu
Date: 2020-12-09T10:43:52+01:00
New Revision: 6883042528d0338b776bb2316e58999650e94892
URL:
https://github.com/llvm/llvm-project/commit/6883042528d0338b776bb2316e58999650e94892
DIFF:
https://github.com/llvm/llvm-project/commit/6883042528d0338b776bb2316e58999650e94892.diff
LO
Author: Haojian Wu
Date: 2020-12-09T09:32:13+01:00
New Revision: ce14ffa1bba2b609eaba81186c51cf26e9cd60ac
URL:
https://github.com/llvm/llvm-project/commit/ce14ffa1bba2b609eaba81186c51cf26e9cd60ac
DIFF:
https://github.com/llvm/llvm-project/commit/ce14ffa1bba2b609eaba81186c51cf26e9cd60ac.diff
LO
Author: hokein
Date: Thu Jan 24 01:35:08 2019
New Revision: 352035
URL: http://llvm.org/viewvc/llvm-project?rev=352035&view=rev
Log:
Fix potential ODR vialation.
Modified:
lldb/trunk/source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h
Modified: lldb/trunk/source/Plugins/ObjectFile/Breakpad/
Author: hokein
Date: Wed Nov 14 01:53:45 2018
New Revision: 346841
URL: http://llvm.org/viewvc/llvm-project?rev=346841&view=rev
Log:
Suppress a "-Wliteral-conversion" compiler warning.
error: implicit conversion from 'double' to 'uint64_t' (aka 'unsigned long')
changes value from -0 to 0 [-Werro
Author: hokein
Date: Wed Nov 14 01:42:28 2018
New Revision: 346839
URL: http://llvm.org/viewvc/llvm-project?rev=346839&view=rev
Log:
Fix the "make_unique is ambiguous" compiler error.
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
lldb/trunk/source/Utility/Rep
68 matches
Mail list logo
