[Lldb-commits] [lldb] r285710 - Fix RHEL 6 build with missing cerrno and some other Include What You Use warnings.

Author: eugenezelenko Date: Tue Nov 1 12:11:10 2016 New Revision: 285710 URL: http://llvm.org/viewvc/llvm-project?rev=285710&view=rev Log: Fix RHEL 6 build with missing cerrno and some other Include What You Use warnings. Differential revision: https://reviews.llvm.org/D26171 Modified: lld

[Lldb-commits] [PATCH] D26171: [LLDB] Fix RHEL 6 build and some Include What You Use warnings

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: labath, zturner. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Build problem happens because of errno. Repository: rL LLVM https://reviews.llvm.org/D26171

[Lldb-commits] [PATCH] D25733: Add data formatter for libstdc++ tuple

Eugene.Zelenko added a comment. Headers orders is still not correct. Repository: rL LLVM https://reviews.llvm.org/D25733 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

Eugene.Zelenko added a comment. Headers orders is still not correct. https://reviews.llvm.org/D25734 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

Eugene.Zelenko added a comment. There are same problems with formatting as in https://reviews.llvm.org/D25726. Also test case main() has wrong indentation. https://reviews.llvm.org/D25734 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D25733: Add data formatter for libstdc++ tuple

Eugene.Zelenko added a comment. There are same problems with formatting as in https://reviews.llvm.org/D25726. Also test case main() has wrong indentation. https://reviews.llvm.org/D25733 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

Eugene.Zelenko added a comment. Please run Clang-format over new code. Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:12 + +#include +#include STL headers should be after application's headers. Comment at: source/Pl

[Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

Eugene.Zelenko added a comment. Looks like patch was not committed. Please rebase with trunk and run Clang-format. https://reviews.llvm.org/D24124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [PATCH] D24549: [LLDB][MIPS] Skip some test case which were causing LLDB to go into infinite loop

Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D24549 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25246: Disable warnings in LLDBWrapPython.cpp when LLVM_ENABLE_WERROR is used

Eugene.Zelenko added a comment. You could use -Wno-error= instead. https://reviews.llvm.org/D25246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25247: Make LLDB -Werror clean under clang

Eugene.Zelenko added inline comments. > Platform.h:16 > #include > #include > +#include This is application header. Should be in quotes. Same below. https://reviews.llvm.org/D25247 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

Re: [Lldb-commits] [PATCH] D6127: Fix code formatting in lldbtest.py introduced with r220583.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL221467. https://reviews.llvm.org/D6127 ___ lldb-commits mailing list lldb-commits@lists.l

Re: [Lldb-commits] [PATCH] D10167: Fix TestJoinAfterBreak test on Windows

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL238787. https://reviews.llvm.org/D10167 ___ lldb-commits mailing list lldb-commits@lists.

Re: [Lldb-commits] [PATCH] D10216: Initial diff for FreeBSD kernel debugging support

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. Need to be rebased and format with Clang-format. https://reviews.llvm.org/D10216 ___ lldb-commits mailing list lldb-commits@lists

Re: [Lldb-commits] [PATCH] D13154: [MIPS] Use Address::GetAddressClass() instead of elf flags to decide address space of an address

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. Repository: rL LLVM https://reviews.llvm.org/D13154 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D13350 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D13578: Allow generic arm ArchSpec to merge with specific arm ArchSpec; allow Cortex M0-7's to always force thumb mode

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL265377. Repository: rL LLVM https://reviews.llvm.org/D13578 ___ lldb-commits mailing l

Re: [Lldb-commits] [PATCH] D14136: Refactor Windows process plugin to enable sharing of code between live and post-mortem debugging

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL251540. https://reviews.llvm.org/D14136 ___ lldb-commits mailing list lldb-commits@lists.

Re: [Lldb-commits] [PATCH] D17635: Continue after process exit

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D17635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D21032: Eliminate differences in lldbinline-generated Makefiles and ensure they're regenerated every time

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Appear to be reverted in r272062. Repository: rL LLVM https://reviews.llvm.org/D21032 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.o

Re: [Lldb-commits] [PATCH] D21152: Hunt for unused memory properly when dealing with processes that can tell us about memory mappings

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was part of r272301. Repository: rL LLVM https://reviews.llvm.org/D21152 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

Re: [Lldb-commits] [PATCH] D12363: Read module list from mini dump

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r246302. https://reviews.llvm.org/D12363 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D6042: Fix junk content handling within GDBRemoteCommunication::CheckForPacket.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r220983. https://reviews.llvm.org/D6042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D6105: Redirect stdin, stdout and stderr to /dev/null when launching LLGS process.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r221324. https://reviews.llvm.org/D6105 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D6158: Fix error handling in NativeProcessLinux::AttachToInferior

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r221647. https://reviews.llvm.org/D6158 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D6204: Apply SOCK_CLOEXEC flag to socket API functions in order to avoid handle leakage to a forked child process.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r222004. https://reviews.llvm.org/D6204 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D6490: Use timeout when reading debugserver's port from a named pipe.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r223251. https://reviews.llvm.org/D6490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D6740: Make DynamicLoaderPOSIXDYLD::DidAttach to deduce a target executable by pid if no executable hasn't been assigned to a target so far.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r225332. https://reviews.llvm.org/D6740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D6743: No need to call SetErrorToErrno when pipe2 succeeds.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r224652. https://reviews.llvm.org/D6743 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D6941: Fix XCode build on OSX - add OptionValueChar.cpp

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r225733. https://reviews.llvm.org/D6941 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D6954: Extend PipePosix with support for named pipes/timeout-based IO and integrate it with GDBRemoteCommunication / lldb-gdbserver.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r225849. https://reviews.llvm.org/D6954 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D7115: Make OSX test run firewall friendly.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r226856. https://reviews.llvm.org/D7115 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D12158: Fix typo in lldb --help

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Type is still in code. https://reviews.llvm.org/D12158 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

Re: [Lldb-commits] [PATCH] D12966: Renderscript plugin support for aarch64

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r248003. Repository: rL LLVM https://reviews.llvm.org/D12966 ___ lldb-commits mailing list lldb-commits@lists.llv

Re: [Lldb-commits] [PATCH] D14920: [LLDB][MIPS] Provide actual number of watchpoints supported

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. Please rebase with trunk and run Clang-format. Repository: rL LLVM https://reviews.llvm.org/D14920 ___ lldb-commits mailing li

Re: [Lldb-commits] [PATCH] D16234: Implement missing GoASTContext methods

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r257926. Repository: rL LLVM https://reviews.llvm.org/D16234 ___ lldb-commits mailing list lldb-commits@lists.llv

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r259081. https://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D16695: Update LLDB Windows buildbot to use MSVC 2015 and Python 3.5

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r259246. https://reviews.llvm.org/D16695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

[Lldb-commits] [lldb] r282041 - Fix Clang initialization and Clang-tidy modernize-use-nullptr warnings in source/Plugins/Process/Utility.

Author: eugenezelenko Date: Tue Sep 20 19:59:22 2016 New Revision: 282041 URL: http://llvm.org/viewvc/llvm-project?rev=282041&view=rev Log: Fix Clang initialization and Clang-tidy modernize-use-nullptr warnings in source/Plugins/Process/Utility. Differential revision: https://reviews.llvm.org/D2

Re: [Lldb-commits] [PATCH] D24694: [LLDB] Fix Clang initialization and Clang-tidy modernize-use-nullptr warnings

Eugene.Zelenko added inline comments. Comment at: source/Plugins/Process/Utility/RegisterInfos_x86_64.h:12 @@ -12,1 +11,3 @@ +#include +#include labath wrote: > It's not a "C" include, if it's cstddef now. :) If you could you also move > the headers to the en

Re: [Lldb-commits] [PATCH] D8494: Fix lld command on Windows for many tests

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r233416. https://reviews.llvm.org/D8494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D8937: Add logging plugin for Winodows

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r234607. https://reviews.llvm.org/D8937 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D9753: Enable debugging of multithreaded programs on Windows.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r237392. https://reviews.llvm.org/D9753 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D9535: Don't attempt dsym tests on Windows

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r236620. https://reviews.llvm.org/D9535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D10103: Fix inferior's i/o connections to its console window on Windows 7

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r238629. https://reviews.llvm.org/D10103 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D13679: Fix TestTargetAPI.py test for users who use Swig 3.0.5 or greater.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r250188. https://reviews.llvm.org/D13679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D15723: Allow test decorators to use lists (and not_in(list)) for arches

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r256283. https://reviews.llvm.org/D15723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17152: Improve ReadRegister for RegisterContextWindowsx86

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r260559. https://reviews.llvm.org/D17152 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D15582: Improve error handling for `f s #`

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r256251. Please specify Differential revision in commit message. https://reviews.llvm.org/D15582 ___ lldb-commits ma

Re: [Lldb-commits] [PATCH] D15723: Allow test decorators to use lists (and not_in(list)) for arches

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Committed in r256283. Please specify Differential revision in commit message. https://reviews.llvm.org/D15723 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

Re: [Lldb-commits] [PATCH] D16149: Delete char const** swig typemaps

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r257670. https://reviews.llvm.org/D16149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D16477: Make all x86 target builds on MSVC use the amd64_x86 toolchain

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r258738. https://reviews.llvm.org/D16477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D17521: Update website for building and testing on Windows

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r261795. https://reviews.llvm.org/D17521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r266392. https://reviews.llvm.org/D18848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D23952: Remove unused frame_zero_id local variable

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r280283. https://reviews.llvm.org/D23952 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D23951: Remove unused any_found local variable

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r280283. https://reviews.llvm.org/D23951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D23948: Remove unused variable

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r280283. https://reviews.llvm.org/D23948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D23950: Remove unused local variable

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r280283. https://reviews.llvm.org/D23950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D22831: [LLDB] Documentation for SBAddress class

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please rebase from trunk and run Clang-format. Repository: rL LLVM https://reviews.llvm.org/D22831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

[Lldb-commits] [PATCH] D24694: [LLDB] Fix Clang initialization and Clang-tidy modernize-use-nullptr warnings

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: labath, zturner. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Looks like RegisterContextNetBSD_x86_64.cpp should use RegisterInfos_x86_64.h as much as possible

Re: [Lldb-commits] [PATCH] D24251: LLDB: API for Permission of object file's sections

Eugene.Zelenko added inline comments. Comment at: source/API/SBSection.cpp:257 @@ +256,3 @@ +SectionSP section_sp(GetSP()); +if (section_sp.get()) +return section_sp->GetPermissions(); You don't need to use get(), because smart pointers have http:

Re: [Lldb-commits] [PATCH] D24251: LLDB: API for Permission of object file's sections

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please rebase code on trunk and run Clang-format. https://reviews.llvm.org/D24251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [Lldb-commits] [PATCH] D23881: cmake: Add local module directory to search path for standalone build

Eugene.Zelenko added a comment. I think will be better to use LLVM_MAIN_SRC_DIR. https://reviews.llvm.org/D23881 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be good idea to try to commit these changes before 3.9 branching. Repository: rL LLVM https://reviews.llvm.org/D20436 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] r275641 - Fixes for standalone build:

Author: eugenezelenko Date: Fri Jul 15 17:46:15 2016 New Revision: 275641 URL: http://llvm.org/viewvc/llvm-project?rev=275641&view=rev Log: Fixes for standalone build: * include CheckAtomic to set HAVE_CXX_ATOMICS64_WITHOUT_LIB properly (introduced in r274121) * hint Clang CMake files for LLVM C

Re: [Lldb-commits] [PATCH] D22284: [LLDB] Proposed change in multi-line edit behavior (Return = end/append, Meta+Return = line break)

Eugene.Zelenko added a comment. Sorry, forgot to add "[revision] in commit summary". https://reviews.llvm.org/D22284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22284: [LLDB] Proposed change in multi-line edit behavior (Return = end/append, Meta+Return = line break)

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r275482. Please mention URL of Differential revision to close it automatically after commit. https://reviews.llvm.org/D22284 ___ lldb-commits mailing list lldb-commi

Re: [Lldb-commits] [PATCH] D22322: [LLDB] Fixes for standalone build

Eugene.Zelenko updated this revision to Diff 64000. Eugene.Zelenko added a comment. Improved description, but in generic terms, since two files are needed. Repository: rL LLVM https://reviews.llvm.org/D22322 Files: cmake/modules/LLDBStandalone.cmake Index: cmake/modules/LLDBStandalone.cma

[Lldb-commits] [PATCH] D22322: [LLDB] Fixes for standalone build

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: labath, zturner, nitesh.jain. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. This patch include two fixes: * include CheckAtomic to set HAVE_CXX_ATOMICS64_WITHOU

Re: [Lldb-commits] [PATCH] D22284: [LLDB] Proposed change in multi-line edit behavior (Return = end/append, Meta+Return = line break)

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: include/lldb/Host/Editline.h:289 @@ +288,3 @@ +unsigned char +EndOrAddLineCommand (int ch); + Will be good idea to not add space between name and arguments list in new code. Same for o

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

Eugene.Zelenko added a comment. > Then we need to introduce a 64 bit atomic check in > cmake/modules/LLDBStandalone.cmake. What do you think? > > Thanks I think this should be right solution. Repository: rL LLVM http://reviews.llvm.org/D20464 _

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

Eugene.Zelenko added a comment. As fas as I could judge from log, you built LLDB with LLVM/Clang. But problem happens when it's necessary to build LLDB separately from LLVM/Clang (standalone build). Repository: rL LLVM http://reviews.llvm.org/D20464 __

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

Eugene.Zelenko added a comment. I run CMake with --trace and is mentioned only in condition added there. Repository: rL LLVM http://reviews.llvm.org/D20464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

Eugene.Zelenko added a comment. I see HAVE_CXX_ATOMICS64_WITHOUT_LIB messages during LLVM Cmake run, but I don't see such message during LLDB CMake run. Is this value is supposed to be read form LLVM CMake cache? Repository: rL LLVM http://reviews.llvm.org/D20464

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. This change broke standalone build. Looks like check which should set HAVE_CXX_ATOMICS64_WITHOUT_LIB was not performed. I build LLDB with LLVM STL which doesn't have libatomic. Repository: rL LLVM http://rev

[Lldb-commits] [lldb] r269996 - Fix standalone LLDB build, when LLVM/Clang were built with LLVM_INSTALL_TOOLCHAIN_ONLY=ON.

Author: eugenezelenko Date: Wed May 18 17:50:08 2016 New Revision: 269996 URL: http://llvm.org/viewvc/llvm-project?rev=269996&view=rev Log: Fix standalone LLDB build, when LLVM/Clang were built with LLVM_INSTALL_TOOLCHAIN_ONLY=ON. Fix standalone build with CMake 2.8.12.2. Differential revision:

Re: [Lldb-commits] [PATCH] D20344: [LLDB] Fix standalone LLDB build when LLVM/Clang were built with LLVM_INSTALL_TOOLCHAIN_ONLY=ON

Eugene.Zelenko updated this revision to Diff 57648. Eugene.Zelenko added a comment. Add comments per Pavel suggestion. Repository: rL LLVM http://reviews.llvm.org/D20344 Files: cmake/modules/LLDBStandalone.cmake Index: cmake/modules/LLDBStandalone.cmake ===

[Lldb-commits] [PATCH] D20344: [LLDB] Fix standalone LLDB build when LLVM/Clang were built with LLVM_INSTALL_TOOLCHAIN_ONLY=ON

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: labath, krytarowski, zturner. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Patch also includes fix for CMake 2.8.12.2, see D18018. Repository: rL LLVM http:

Re: [Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

Eugene.Zelenko abandoned this revision. Eugene.Zelenko added a comment. Obsoleted by http://reviews.llvm.org/D20344. Repository: rL LLVM http://reviews.llvm.org/D18018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D15067#428146, @krytarowski wrote: > @Eugene.Zelenko do you agree with this patch and what @labath wrote? If CMake works that way, it's what I need :-) Repository: rL LLVM http://reviews.llvm.org/D15067 _

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D15067#427834, @krytarowski wrote: > In http://reviews.llvm.org/D15067#427814, @Eugene.Zelenko wrote: > > > I would like to see implemented my comment about LLVM_CONFIG and > > find_program(). > > > Could you first push this to clang? I

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

Eugene.Zelenko added a comment. I would like to see implemented my comment about LLVM_CONFIG and find_program(). Repository: rL LLVM http://reviews.llvm.org/D15067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [lldb] r268750 - Fix standalone build on RHEL6.

Author: eugenezelenko Date: Fri May 6 12:03:09 2016 New Revision: 268750 URL: http://llvm.org/viewvc/llvm-project?rev=268750&view=rev Log: Fix standalone build on RHEL6. Differential revision: http://reviews.llvm.org/D19991 Modified: lldb/trunk/cmake/LLDBDependencies.cmake Modified: lldb/t

Re: [Lldb-commits] [PATCH] D19991: [LLDB] Fix standalone build on RHEL6

Eugene.Zelenko added a comment. Undefined symbols were used in clang::CodeGen::CoverageMappingGen. Repository: rL LLVM http://reviews.llvm.org/D19991 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D19991: [LLDB] Fix standalone build on RHEL6

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: zturner, labath. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. There were unresolved symbols related to coverage. Repository: rL LLVM http://reviews.llvm.org

[Lldb-commits] [lldb] r263312 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

Author: eugenezelenko Date: Fri Mar 11 18:31:13 2016 New Revision: 263312 URL: http://llvm.org/viewvc/llvm-project?rev=263312&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes. Modified: lldb/trunk/include/lldb/Core/SearchFilter.h

[Lldb-commits] [lldb] r263300 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

Author: eugenezelenko Date: Fri Mar 11 15:55:47 2016 New Revision: 263300 URL: http://llvm.org/viewvc/llvm-project?rev=263300&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes. Modified: lldb/trunk/source/Core/Logging.cpp lldb/tru

[Lldb-commits] [lldb] r263289 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

Author: eugenezelenko Date: Fri Mar 11 14:20:38 2016 New Revision: 263289 URL: http://llvm.org/viewvc/llvm-project?rev=263289&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes. Modified: lldb/trunk/source/Core/IOHandler.cpp lldb/t

[Lldb-commits] [lldb] r263174 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

Author: eugenezelenko Date: Thu Mar 10 17:57:12 2016 New Revision: 263174 URL: http://llvm.org/viewvc/llvm-project?rev=263174&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes. Modified: lldb/trunk/source/Core/ConstString.cpp lldb

Re: [Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

Eugene.Zelenko added a comment. Probably not since in case of non-standalone build LLVM make file should be enough and LLDBStandalone.cmake will be not executed. Repository: rL LLVM http://reviews.llvm.org/D18018 ___ lldb-commits mailing list ll

Re: [Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

Eugene.Zelenko added a comment. My guess is that project() or cmake_minimum_required() resets policy value set in upper level make file. Repository: rL LLVM http://reviews.llvm.org/D18018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

Eugene.Zelenko added a comment. I didn't work in main CMakeLists.txt. From other side, policy is not set only in standalone build, so place seems logical for me. Repository: rL LLVM http://reviews.llvm.org/D18018 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: zturner. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. LLVM and Clang CMakeLists.txt set this policy explicitly. Repository: rL LLVM http://reviews.llvm.org

[Lldb-commits] [lldb] r262570 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

Author: eugenezelenko Date: Wed Mar 2 18:51:40 2016 New Revision: 262570 URL: http://llvm.org/viewvc/llvm-project?rev=262570&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes. Modified: lldb/trunk/source/Core/DataBufferHeap.cpp l

[Lldb-commits] [lldb] r262450 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

Author: eugenezelenko Date: Tue Mar 1 20:18:18 2016 New Revision: 262450 URL: http://llvm.org/viewvc/llvm-project?rev=262450&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes. Modified: lldb/trunk/source/Core/DataExtractor.cpp ll

[Lldb-commits] [lldb] r262441 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

Author: eugenezelenko Date: Tue Mar 1 19:09:03 2016 New Revision: 262441 URL: http://llvm.org/viewvc/llvm-project?rev=262441&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes. Modified: lldb/trunk/include/lldb/Core/Broadcaster.h

[Lldb-commits] [lldb] r262287 - Fix MSVC build failure in source/Target/Process.cpp.

Author: eugenezelenko Date: Mon Feb 29 20:08:37 2016 New Revision: 262287 URL: http://llvm.org/viewvc/llvm-project?rev=262287&view=rev Log: Fix MSVC build failure in source/Target/Process.cpp. Will be good idea to introduce macro/constexpr for NULL thread_result_t. Modified: lldb/trunk/sourc

[Lldb-commits] [lldb] r262281 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Target/Process.cpp; other minor fixes.

Author: eugenezelenko Date: Mon Feb 29 18:55:51 2016 New Revision: 262281 URL: http://llvm.org/viewvc/llvm-project?rev=262281&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Target/Process.cpp; other minor fixes. Modified: lldb/trunk/source/Target/Process.

[Lldb-commits] [lldb] r262246 - Fix Clang-tidy modernize-use-nullptr warnings in source/Plugins/Language; other minor fixes.

Author: eugenezelenko Date: Mon Feb 29 13:41:30 2016 New Revision: 262246 URL: http://llvm.org/viewvc/llvm-project?rev=262246&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in source/Plugins/Language; other minor fixes. Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/CPlu

[Lldb-commits] [lldb] r261936 - Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in source/Commands/CommandObjectThread.cpp; other minor fixes.

Author: eugenezelenko Date: Thu Feb 25 17:46:36 2016 New Revision: 261936 URL: http://llvm.org/viewvc/llvm-project?rev=261936&view=rev Log: Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in source/Commands/CommandObjectThread.cpp; other minor fixes. Modified: lldb/tr

  1   2   >