https://github.com/erichkeane approved this pull request.
This looks right, but I'd like someone else to go through to make sure it is
right everywhere.
Also, the md5 change looks... odd and counts a lot on the internal
representation of md5, so I'm not sure about that one, but at least it is
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/136077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
erichkeane wrote:
Clang stuff is unchanged, correct? If so I'm fine when the LLDB folks are
happy.
https://github.com/llvm/llvm-project/pull/132234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
@@ -1502,6 +1509,12 @@ enum DeclCode {
/// An ImplicitConceptSpecializationDecl record.
DECL_IMPLICIT_CONCEPT_SPECIALIZATION,
+ // A decls specilization record.
erichkeane wrote:
Note `specialization` is misspelled in this comment and the one below.
htt
@@ -1502,6 +1509,12 @@ enum DeclCode {
/// An ImplicitConceptSpecializationDecl record.
DECL_IMPLICIT_CONCEPT_SPECIALIZATION,
+ // A decls specilization record.
+ DECL_SPECIALIZATIONS,
+
+ // A decls specilization record.
+ DECL_PARTIAL_SPECIALIZATIONS,
+
-
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/125791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
erichkeane wrote:
> > I see the 2nds commit doesn't add any tests! Please make it do so
>
> I've tried and I'm not quite sure how to do it. The issue is we need to test
> AST printing of «implicitly declared» functions, such as builtins and
> functions instrumented by lldb, such as `log` for l
erichkeane wrote:
I see the 2nds commit doesn't add any tests! Please make it do so, else LGTM
(plus might want to do a 'merge' commit to reset the CI to a more stable state).
https://github.com/llvm/llvm-project/pull/93913
___
lldb-commits mailing l
erichkeane wrote:
I have absolutely no idea how to fix it as I don't understand the syntax of the
clangd tests, but it SEEMS like it is just a source-location type thing that is
wrong?
https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/unittests/InlayHintTests.cpp#L810
>F
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/79985
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -8129,29 +8067,133 @@
Sema::BuildExpressionFromIntegralTemplateArgument(const TemplateArgument &Arg,
else
Kind = CharacterLiteralKind::Ascii;
-E = new (Context) CharacterLiteral(Arg.getAsIntegral().getZExtValue(),
- Kind,
@@ -8129,29 +8067,133 @@
Sema::BuildExpressionFromIntegralTemplateArgument(const TemplateArgument &Arg,
else
Kind = CharacterLiteralKind::Ascii;
-E = new (Context) CharacterLiteral(Arg.getAsIntegral().getZExtValue(),
- Kind,
@@ -8129,29 +8067,133 @@
Sema::BuildExpressionFromIntegralTemplateArgument(const TemplateArgument &Arg,
else
Kind = CharacterLiteralKind::Ascii;
-E = new (Context) CharacterLiteral(Arg.getAsIntegral().getZExtValue(),
- Kind,
erichkeane wrote:
I see now that hte problem is probably in the Analyzer, so @steakhal is
probably the best person to be leading this, but any work you can do
@bolshakov-a would also likely be appreciated.
https://github.com/llvm/llvm-project/pull/78041
erichkeane wrote:
@bolshakov-a : The original bug has a good amount of analysis to it, so if you
could see if there is a fix for it, else we probably do have to revert for that
one and miss 18 with this patch.
https://github.com/llvm/llvm-project/pull/78041
erichkeane wrote:
Fixed in : e3ee3762304aa81e4a240500844bfdd003401b36
https://github.com/llvm/llvm-project/pull/79302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/79302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
erichkeane wrote:
Fixed in: e3ee3762304aa81e4a240500844bfdd003401b36
I'll submit a request to cherry-pick to the release branch.
https://github.com/llvm/llvm-project/pull/78041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
erichkeane wrote:
That certainly makes sense to me. Can you submit a patch for review to do so,
then we can get it cherry-picked to 18? It would be great if we could save
this feature in 18.
https://github.com/llvm/llvm-project/pull/78041
___
lldb-
https://github.com/erichkeane ready_for_review
https://github.com/llvm/llvm-project/pull/79302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
erichkeane wrote:
Waiting on CI bots, then I'll submit this revert, then request this for
cherry-pick to the 18 branch.
https://github.com/llvm/llvm-project/pull/79302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/erichkeane created
https://github.com/llvm/llvm-project/pull/79302
Reverts llvm/llvm-project#78041
Based on this comment:
https://github.com/llvm/llvm-project/pull/78041#issuecomment-1908243345
and the author's nonavailability to get to it quickly, we're reverting (and
wil
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/75883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/75883
>From 849b21f202f3c643c12f237920b137c3506996e7 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Tue, 19 Dec 2023 02:48:25 +0100
Subject: [PATCH 1/6] [Clang] Support MSPropertyRefExpr as placement arg to
new-expr
@@ -14310,8 +14310,8 @@ Sema::CreateOverloadedUnaryOp(SourceLocation OpLoc,
UnaryOperatorKind Opc,
PartialDiagnosticAt(OpLoc, PDiag(diag::err_ovl_deleted_oper)
<< UnaryOperator::getOpcodeStr(Opc)
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/78316
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/erichkeane approved this pull request.
1 suggestion, not necessary, but I think it is beneficial.
https://github.com/llvm/llvm-project/pull/78316
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -12,6 +12,7 @@
#include "clang/AST/DeclCXX.h"
#include "clang/AST/DeclTemplate.h"
#include "clang/AST/DeclVisitor.h"
+#include "clang/AST/ODRHash.h"
erichkeane wrote:
We shouldn't be minimizing the #include set, but it is often a 'red flag' when
someone ad
https://github.com/erichkeane commented:
I would love it if @efriedma-quic / @rjmccall looked at the mangling parts, and
@dwblaikie looked at the Debug info.
Else, LGTM.
https://github.com/llvm/llvm-project/pull/78041
___
lldb-commits mailing list
ll
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/78041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -551,6 +646,18 @@ static const T &DiagTemplateArg(const T &DB, const
TemplateArgument &Arg) {
case TemplateArgument::Integral:
return DB << toString(Arg.getAsIntegral(), 10);
+ case TemplateArgument::StructuralValue: {
+// FIXME: We're guessing at LangOptions!
-
erichkeane wrote:
> LGTM @erichkeane you want to look at that?
I'd looked at it a while back, and just did another scroll, happy as-is.
https://github.com/llvm/llvm-project/pull/68485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://l
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/77002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/77002
>From d9f62a6d6b5a66a2e425f5c33f18c4a13c8b88ca Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Thu, 4 Jan 2024 12:19:00 -0800
Subject: [PATCH 1/4] [OpenACC] Implement 'default' clause parsing.
A simple clause
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/77002
>From d9f62a6d6b5a66a2e425f5c33f18c4a13c8b88ca Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Thu, 4 Jan 2024 12:19:00 -0800
Subject: [PATCH 1/3] [OpenACC] Implement 'default' clause parsing.
A simple clause
https://github.com/erichkeane approved this pull request.
I think this is a very positive change, and see nothing besides Aaron's nit to
comment on. Thanks!
https://github.com/llvm/llvm-project/pull/71264
___
lldb-commits mailing list
lldb-commits@li
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/72661
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
erichkeane wrote:
@alexey-bataev : Patch reduced to just parallel as requested.
https://github.com/llvm/llvm-project/pull/72661
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/72661
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/72661
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/72661
>From 01fc81b37ad744a265f712b26fd6c3a85430c719 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Fri, 17 Nov 2023 06:29:35 -0800
Subject: [PATCH 1/3] [OpenACC] Implement initial parsing for
Construct/Directive
@@ -0,0 +1,72 @@
+//===--- OpenACCKinds.h - OpenACC Enums -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -10,18 +10,240 @@
//
//===--===//
+#include "clang/Basic/OpenACCKinds.h"
#include "clang/Parse/ParseDiagnostic.h"
#include "clang/Parse/Parser.h"
+#include "clang/Parse/RAIIObjectsForParser.h"
+#include
erichkeane wrote:
> We will want to have OpenACC label(s) such that people who are interested can
> be notified.
Done, see the next patch in the set here:
https://github.com/llvm/llvm-project/pull/72661
I'll start adding them and see if I can get @llvmbot to teach me how to add it.
https://
@@ -0,0 +1,72 @@
+//===--- OpenACCKinds.h - OpenACC Enums -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -10,18 +10,240 @@
//
//===--===//
+#include "clang/Basic/OpenACCKinds.h"
#include "clang/Parse/ParseDiagnostic.h"
#include "clang/Parse/Parser.h"
+#include "clang/Parse/RAIIObjectsForParser.h"
+#include
@@ -3531,7 +3535,7 @@ class Parser : public CodeCompletionHandler {
/// Placeholder for now, should just ignore the directives after emitting a
/// diagnostic. Eventually will be split into a few functions to parse
/// different situations.
- DeclGroupPtrTy ParseOpenACCD
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/72661
>From 01fc81b37ad744a265f712b26fd6c3a85430c719 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Fri, 17 Nov 2023 06:29:35 -0800
Subject: [PATCH 1/2] [OpenACC] Implement initial parsing for
Construct/Directive
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/70234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/70234
>From b3d64b3f744ccb37e334e3aae8d6874cd8391c56 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Mon, 23 Oct 2023 11:09:11 -0700
Subject: [PATCH 1/8] [OpenACC] Initial commit for OpenACC Support
This is the ini
@@ -3633,6 +3633,22 @@ static void RenderHLSLOptions(const ArgList &Args,
ArgStringList &CmdArgs,
CmdArgs.push_back("-finclude-default-header");
}
+static void RenderOpenACCOptions(const Driver &D, const ArgList &Args,
+ ArgStringList &CmdA
@@ -4001,6 +4008,14 @@ bool CompilerInvocation::ParseLangArgs(LangOptions
&Opts, ArgList &Args,
(T.isNVPTX() || T.isAMDGCN()) &&
Args.hasArg(options::OPT_fopenmp_cuda_mode);
+ // OpenACC Configuration.
+ if (Args.hasArg(option
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/70234
>From b3d64b3f744ccb37e334e3aae8d6874cd8391c56 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Mon, 23 Oct 2023 11:09:11 -0700
Subject: [PATCH 1/7] [OpenACC] Initial commit for OpenACC Support
This is the ini
@@ -1349,6 +1349,19 @@ def fno_hip_emit_relocatable : Flag<["-"],
"fno-hip-emit-relocatable">,
HelpText<"Do not override toolchain to compile HIP source to relocatable">;
}
+// Clang specific/exclusive options for OpenACC.
+def openacc_macro_override
erichk
@@ -229,6 +230,9 @@ class Parser : public CodeCompletionHandler {
/// Parsing OpenMP directive mode.
bool OpenMPDirectiveParsing = false;
+ /// Parsing OpenACC directive mode.
+ bool OpenACCDirectiveParsing = false;
erichkeane wrote:
Ah, I see. As it i
@@ -0,0 +1,14 @@
+// RUN: %clang -S -### -fopenacc %s 2>&1 | FileCheck %s
--check-prefix=CHECK-DRIVER
+// CHECK-DRIVER: "-cc1" {{.*}} "-fopenacc"
+
+// RUN: %clang -S -### -fopenacc -fexperimental-openacc-macro-override=202211
%s 2>&1 | FileCheck %s --check-prefix=CHECK-MACRO-OV
@@ -229,6 +230,9 @@ class Parser : public CodeCompletionHandler {
/// Parsing OpenMP directive mode.
bool OpenMPDirectiveParsing = false;
+ /// Parsing OpenACC directive mode.
+ bool OpenACCDirectiveParsing = false;
erichkeane wrote:
Its currently being
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/70234
>From b3d64b3f744ccb37e334e3aae8d6874cd8391c56 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Mon, 23 Oct 2023 11:09:11 -0700
Subject: [PATCH 1/6] [OpenACC] Initial commit for OpenACC Support
This is the ini
@@ -605,6 +605,17 @@ static void InitializeStandardPredefinedMacros(const
TargetInfo &TI,
Builder.defineMacro("HIP_API_PER_THREAD_DEFAULT_STREAM");
}
}
+
+ if (LangOpts.OpenACC) {
+// FIXME: When we have full support for OpenACC, we should set this to the
+
@@ -1342,6 +1342,15 @@ def err_opencl_logical_exclusive_or : Error<
def err_openclcxx_virtual_function : Error<
"virtual functions are not supported in C++ for OpenCL">;
+// OpenACC Support.
+def warn_pragma_acc_ignored : Warning<
+ "unexpected '#pragma acc ...' in program"
@@ -0,0 +1,14 @@
+// RUN: %clang -S -### -fopenacc %s 2>&1 | FileCheck %s
--check-prefix=CHECK-DRIVER
+// CHECK-DRIVER: "-cc1" {{.*}} "-fopenacc"
erichkeane wrote:
At the moment, there should be no problem with them co-existing. Kernels can
be separately gener
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/70548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/70548
>From 11ceaed39b3f0c60c5a44c3b3a2b5856e7ee9a8d Mon Sep 17 00:00:00 2001
From: letrec
Date: Sat, 28 Oct 2023 18:05:36 +0800
Subject: [PATCH 1/7] Defer the instantiation of explicit-specifier after
constraint c
erichkeane wrote:
Build failures are all 1 test, and are:
`File
/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-fdgrz-1/llvm-project/clang-ci/libcxx/test/libcxx/algorithms/cpp17_iterator_concepts.verify.cpp
Line 410: cannot find start of regex ('{{') in static assertion failed`
The patch r
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/70234
>From b3d64b3f744ccb37e334e3aae8d6874cd8391c56 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Mon, 23 Oct 2023 11:09:11 -0700
Subject: [PATCH 1/5] [OpenACC] Initial commit for OpenACC Support
This is the ini
@@ -5126,6 +5126,14 @@ void CXXNameMangler::mangleExpression(const Expr *E,
unsigned Arity,
Diags.Report(DiagID);
return;
}
+case UETT_VectorElements: {
erichkeane wrote:
OK, SGTM at least, I just know this pattern of 'cannot yet mangle...
@@ -3083,6 +3083,10 @@ ScalarExprEmitter::VisitUnaryExprOrTypeTraitExpr(
E->getTypeOfArgument()->getPointeeType()))
.getQuantity();
return llvm::ConstantInt::get(CGF.SizeTy, Alignment);
+ } else if (E->getKind() == UETT_VectorElements) {
+au
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/69010
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
erichkeane wrote:
> > Also, needs a release note.
>
> How do I do this? I cannot seem to find documentation on the process...
See docs/ReleaseNotes.rst.
https://github.com/llvm/llvm-project/pull/69010
___
lldb-commits mailing list
lldb-commits@lists.
@@ -13595,6 +13595,15 @@ bool IntExprEvaluator::VisitUnaryExprOrTypeTraitExpr(
Info.Ctx.getOpenMPDefaultSimdAlign(E->getArgumentType()))
.getQuantity(),
E);
+ case UETT_VectorElements: {
+QualType Ty = E->getTypeOfArgument();
+//
@@ -5456,9 +5459,8 @@ class DeducedTemplateSpecializationType : public
DeducedType,
/// TemplateArguments, followed by a QualType representing the
/// non-canonical aliased type when the template is a type alias
/// template.
-class alignas(8) TemplateSpecializationType
-:
@@ -0,0 +1,121 @@
+// RUN: %clang_cc1 -O1 -triple aarch64 -target-feature +neon %s -emit-llvm -o
- | FileCheck --check-prefixes=CHECK,NEON %s
erichkeane wrote:
Add -disable-llvm-passes to all of these.
https://github.com/llvm/llvm-project/pull/69010
___
@@ -10136,6 +10136,9 @@ def err_vec_builtin_incompatible_vector : Error<
def err_vsx_builtin_nonconstant_argument : Error<
"argument %0 to %1 must be a 2-bit unsigned literal (i.e. 0, 1, 2 or 3)">;
+def err_vectorelements_non_vector : Error<
+ "'__builtin_vectorelements' arg
@@ -13595,6 +13595,15 @@ bool IntExprEvaluator::VisitUnaryExprOrTypeTraitExpr(
Info.Ctx.getOpenMPDefaultSimdAlign(E->getArgumentType()))
.getQuantity(),
E);
+ case UETT_VectorElements: {
+QualType Ty = E->getTypeOfArgument();
+//
@@ -3083,6 +3083,19 @@ ScalarExprEmitter::VisitUnaryExprOrTypeTraitExpr(
E->getTypeOfArgument()->getPointeeType()))
.getQuantity();
return llvm::ConstantInt::get(CGF.SizeTy, Alignment);
+ } else if (E->getKind() == UETT_VectorElements) {
+//
Botond =?utf-8?q?István_Hprváth?=,
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
erichkeane wrote:
Ah, I see, apologies. I thought you meant the resign/etc complaint meant you
couldn't commit through the UI.
https://github.com/llvm/llvm-project/pull/66487
_
76 matches
Mail list logo
