Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-04-05 Thread Eran Ifrah via lldb-commits
eran.ifrah added inline comments. Comment at: CMakeLists.txt:3-5 @@ -2,1 +2,5 @@ +if(MINGW_DEBUG) + # force debugging info into lldb sources + message("-- Building LLDB in Debug mode") + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -O0") Adding ` -mbig-obj` for

Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-04-05 Thread Eran Ifrah via lldb-commits
eran.ifrah updated this revision to Diff 52715. eran.ifrah marked an inline comment as done. eran.ifrah added a comment. Moved `dbghelp` to system_lib http://reviews.llvm.org/D18519 Files: CMakeLists.txt cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfig.cmake include/lldb/Host/window

Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-04-02 Thread Eran Ifrah via lldb-commits
eran.ifrah added a comment. Spoke too soon, the hack into `CMakeLists.txt` is still needed Passing ` -mbig-obj` crashes `ld.exe` (although it crashes in a much later stage, at about 77% in the build) Comment at: CMakeLists.txt:3-5 @@ -2,1 +2,5 @@ +if(MINGW_DEBUG) +# forc

Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-04-02 Thread Eran Ifrah via lldb-commits
eran.ifrah updated this revision to Diff 52463. eran.ifrah marked 3 inline comments as done. eran.ifrah added a comment. - I have updated the patch with various indention fixes - added the -mbig-obj for clang's CMakeLists.txt file (which makes the hack I did earlier in LLDB obsolete) - answered s

Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-03-29 Thread Eran Ifrah via lldb-commits
On Tue, Mar 29, 2016 at 8:43 AM, Zachary Turner wrote: > It's night here, so I will have a detailed look tomorrow. But in the > meantime, some of the issues don't appear to be addressed. For example the > issue about why logging is disabled, > ​Fixed with the new patch ​ > the disabled code i

Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-03-29 Thread Eran Ifrah via lldb-commits
eran.ifrah updated this revision to Diff 51918. eran.ifrah added a comment. Fixed: WindowsMiniDump should now also compile and work on MinGW by adding `Dbghelp` library Fixed: DebuggerThread: don't pass std::atomic to the LOG macros as it yields g++ error on MinGW, instead use a temp variable F

Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-03-29 Thread Eran Ifrah via lldb-commits
eran.ifrah added a comment. Comment at: CMakeLists.txt:3 @@ -2,1 +2,3 @@ +if(MINGW_DEBUG) +# force debugging info into lldb sources labath wrote: > Why do we need this? Why is `-DCMAKE_BUILD_TYPE=Debug` not sufficient? No. As I mentioned in my previous co

Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-03-28 Thread Eran Ifrah via lldb-commits
eran.ifrah updated this revision to Diff 51873. eran.ifrah marked 21 inline comments as done. eran.ifrah added a comment. An updated patch that fixes all your comments and in includes this one as well: http://reviews.llvm.org/D18520 I also added new command line argument option to `CMake` : `-DMI

Re: [Lldb-commits] [PATCH] D18520: Initialize ProcessWindowsLive when building LLDB with MinGW

2016-03-28 Thread Eran Ifrah via lldb-commits
eran.ifrah added inline comments. Comment at: source/API/SystemInitializerFull.cpp:90 @@ -89,3 +89,3 @@ -#if defined(_MSC_VER) +#if defined(_MSC_VER) || defined(__MINGW32__) #include "lldb/Host/windows/windows.h" zturner wrote: > Just use `LLVM_ON_WIN32` for bo

[Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-03-28 Thread Eran Ifrah via lldb-commits
eran.ifrah created this revision. eran.ifrah added a reviewer: zturner. eran.ifrah added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. As the title http://reviews.llvm.org/D18519 Files: CMakeLists.txt cmake/modules/AddLLDB.cmake cmake/modules/LLDBC

[Lldb-commits] [PATCH] D18520: Initialize ProcessWindowsLive when building LLDB with MinGW

2016-03-28 Thread Eran Ifrah via lldb-commits
eran.ifrah created this revision. eran.ifrah added a reviewer: zturner. eran.ifrah added a subscriber: lldb-commits. Initialize ProcessWindowsLive when building LLDB with MinGW http://reviews.llvm.org/D18520 Files: source/API/SystemInitializerFull.cpp Index: source/API/SystemInitializerFull.c