[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3ff3af3086da: [lldb] Add missing StringExtras.h includes (authored by IncludeGuardian). Changed prior to commit: https:

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

IncludeGuardian added a comment. @fdeazeve Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155178/new/ https://reviews.llvm.org/D155178 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

IncludeGuardian added a comment. Herald added subscribers: Michael137, JDevlieghere. @MaskRay seems like `ninja` on its own after preparing `lldb` isn't enough to build tests. I've now built llvm, clang, flang, bolt, lldb, + tests - I'm hoping that this is it now! Repository: rG LLVM Github

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

IncludeGuardian created this revision. IncludeGuardian added a reviewer: MaskRay. Herald added a subscriber: hiraditya. Herald added a project: All. IncludeGuardian requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. **1st com

[Lldb-commits] [PATCH] D155018: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 5)

This revision was automatically updated to reflect the committed changes. Closed by commit rG90bfe2df25e7: [lldb] Add missing StringExtras.h includes (authored by IncludeGuardian). Changed prior to commit: https://reviews.llvm.org/D155018?vs=539291&id=539872#toc Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D155018: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 5)

IncludeGuardian added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:17 #include "llvm/Support/FormatVariadic.h" #if defined(_WIN32) #define NOMINMAX This should be the final failure on the last time la

[Lldb-commits] [PATCH] D155018: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 5)

IncludeGuardian created this revision. IncludeGuardian added a reviewer: MaskRay. Herald added a subscriber: hiraditya. Herald added a project: All. IncludeGuardian requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. **1st com

[Lldb-commits] [PATCH] D154775: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 4)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5551657b310b: [lldb] Add missing StringExtras.h includes (authored by IncludeGuardian). Changed prior to commit: https:

[Lldb-commits] [PATCH] D154775: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 4)

IncludeGuardian added a comment. Herald added a subscriber: JDevlieghere. After the previous attempt, I believe only LLDB was failing to compile. These are the necessary changes needed to fix all of LLDB locally on `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D154775: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 4)

IncludeGuardian created this revision. IncludeGuardian added a reviewer: MaskRay. Herald added subscribers: arphaman, hiraditya. Herald added a project: All. IncludeGuardian requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits.

[Lldb-commits] [PATCH] D154763: [Support] Move StringExtras.h include from Error.h to Error.cpp (attempt 3)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa11efd49266f: Add missing StringExtras.h includes (authored by Inc

[Lldb-commits] [PATCH] D154763: [Support] Move StringExtras.h include from Error.h to Error.cpp (attempt 3)

IncludeGuardian updated this revision to Diff 538372. IncludeGuardian added a comment. Run clang-format over changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154763/new/ https://reviews.llvm.org/D154763 Files: lldb/source/Host/common/File.cpp lldb/source/Host/common/Socket.cpp

[Lldb-commits] [PATCH] D154763: [Support] Move StringExtras.h include from Error.h to Error.cpp (attempt 3)

IncludeGuardian created this revision. IncludeGuardian added a reviewer: MaskRay. Herald added a subscriber: hiraditya. Herald added a project: All. IncludeGuardian requested review of this revision. Herald added projects: LLDB, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits,