@@ -12,6 +12,9 @@
#include "lldb/Utility/ProcessInfo.h"
#include "gtest/gtest.h"
+#include
+#include
emaste wrote:
Much of this file would work just fine on FreeBSD as well so that might make
sense, although I'm not sure what the best structure would be --
@@ -237,6 +250,16 @@ class ProcessInstanceInfo : public ProcessInfo {
m_cumulative_system_time.tv_usec > 0;
}
+ int8_t GetNiceValue() const { return m_nice_value; }
emaste wrote:
nice and priority are not synonymous though, nice is one input int
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/84026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -362,7 +363,15 @@ TEST(RegisterContextFreeBSDTest, arm64) {
EXPECT_GPR_ARM64(lr, lr);
EXPECT_GPR_ARM64(sp, sp);
EXPECT_GPR_ARM64(pc, elr);
+#if __FreeBSD_version >= 1400084
emaste wrote:
This will be correct when the host running the debugger is the s
emaste wrote:
CC @zxombie
https://github.com/llvm/llvm-project/pull/84032
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/84024
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/84022
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
> However, for minimal dump, the build-id section won't loaded because minimal
> dump only dump the used memory by kernel.
If we fall back to no-UUID-found in that case and don't require that it matches
this is still an improvement, yeah?
https://github.com/llvm/llvm-project/pul
emaste wrote:
Yes I think it's likely fixed. I'll give it a try on my FreeBSD laptop shortly.
https://github.com/llvm/llvm-project/pull/84155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/84155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
@zxombie fyi
https://github.com/llvm/llvm-project/pull/85058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/81355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/emaste approved this pull request.
This is reasonable and in line with the existing special case for NetBSD, but
it seems like this logic shouldn't really be here but in a target-specific
file. When (live or corefile) cross-debugging a FreeBSD target we should look
in $LOCAL
@@ -429,7 +429,43 @@ incompatible with the flags that gdb specifies.
//
// Response is F, followed by the number of bytes written (base 16)
+//--
+// vFile:MD5:
+//
+// BRIEF
+// Generate an MD5 hash of the
emaste wrote:
Ok, submitted https://github.com/llvm/llvm-project/issues/89271 for the MD5
migration. I agree that issue does not block this change.
https://github.com/llvm/llvm-project/pull/88812
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
emaste wrote:
MD5 is insufficient for claiming that files are identical; how do we migrate
this to a secure hash?
https://github.com/llvm/llvm-project/pull/88812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
emaste wrote:
> is there not a Posix way to get these
Not really. On FreeBSD these generally come from sysctl(s).
Of the ones added in this pull request SetParentProcessID is already handled on
FreeBSD, while SetProcessGroupID, SetProcessSessionID, SetUserTime,
SetSystemTime, SetCumulativeUse
https://github.com/emaste commented:
It looks like the commit messages and content are mismatched - the commit
message references AT_HWCAP2 but it doesn't look like that's included here?
https://github.com/llvm/llvm-project/pull/85057
___
lldb-commits
https://github.com/emaste approved this pull request.
(Assuming the comment removal gets squashed into one commit)
https://github.com/llvm/llvm-project/pull/84147
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
emaste wrote:
commit message probably needs updating for the logic change (no longer
beforehand)
Another reason to defer the check until failure occurs - if the user happens to
be running lldb as root ptrace will be able to attach independent of the state
of that sysctl
https://github.com/ll
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/79662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
Thanks for picking this up -- I was starting to take a look but was sidetracked
with a lot of yak shaving.
https://github.com/llvm/llvm-project/pull/79662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
@@ -48,14 +48,36 @@ static Status EnsureFDFlags(int fd, int flags) {
return error;
}
+static Status CanTrace() {
+ int proc_debug, ret;
+ size_t len = sizeof(proc_debug);
+ ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", &proc_debug,
+ &
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) {
return error;
}
+static Status CanTrace() {
+ Status status;
+ int proc_debug, ret;
+ size_t len = sizeof(proc_debug);
+ ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", &proc_debug,
+
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/74198
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1245,9 +1245,10 @@ bool FormatEntity::Format(const Entry &entry, Stream &s,
llvm::Triple::OSType ostype = arch.IsValid()
? arch.GetTriple().getOS()
: llvm::Triple::Unknow
emaste wrote:
commit message has typo `coreected`
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/68210
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
I'm not sure why @aokblast's reply didn't appear here, but indeed `%zu` is the
right format specifier.
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
Hmm, when I attempt to close it via the GitHub UI I get:
I think I can just fetch the commit locally and then push it to the tree
https://github.com/llvm/llvm-project/pull/67106
emaste wrote:
Oh, I think we should also mention GSoC in the commit message. Something like
`This project was part of FreeBSD's participation in Google Summer of Code
2023.` or so.
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mail
emaste wrote:
https://llvm.org/docs/GitHub.html#landing-your-change
> There are two different ways to do this:
>
> - [Interactive rebase](https://git-scm.com/docs/git-rebase#_interactive_mode)
> with fixup’s. This is the recommended method since you can control the final
> commit message and i
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
> I will let other FreeBSD folks do the final approval since I don't work on
> FreeBSD.
@clayborg this change LGTM for FreeBSD. I'm still not fully sorted on the
approach for landing the commits post transition to GitHub. Also see the
comment about author name above.
https://g
emaste wrote:
> Excuse me. If the code works well now, I want to ask if I need to modify the
> commit message by myself so the message looks tidy, or let somebody landing
> this pull request modify the message?
This will be the first substantial change I'd land after LLVM moved to use pull
re
emaste wrote:
Needs to be adapted for f2d32ddcec82c20582c6aa32558b82ca7c3d3c50,
`lldb/source/{Core => Host/common}/StreamFile.cpp`
(I've applied the change locally for testing, and will just fold it into the
patch series if otherwise ready to go.)
https://github.com/llvm/llvm-project/pull/67
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
@@ -0,0 +1,165 @@
+#ifndef
LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H
+#define
LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H
+
+#include
+#include
+#include
+
+#include "lldb/Target/DynamicLoader.h"
+#include
Author: Andrew Turner
Date: 2021-09-28T10:51:06-04:00
New Revision: 993ada05f5a05615ec16da4a69bd368529a7e5d1
URL:
https://github.com/llvm/llvm-project/commit/993ada05f5a05615ec16da4a69bd368529a7e5d1
DIFF:
https://github.com/llvm/llvm-project/commit/993ada05f5a05615ec16da4a69bd368529a7e5d1.diff
On Fri, 13 Nov 2020 at 23:02, Jonas Devlieghere via lldb-commits
wrote:
>
>
> Author: Jonas Devlieghere
> Date: 2020-11-13T20:02:05-08:00
> New Revision: 875be9f454c31c94701bdf4e28f8bea07a8c9c79
>
> URL:
> https://github.com/llvm/llvm-project/commit/875be9f454c31c94701bdf4e28f8bea07a8c9c79
> DIFF
On Wed, 14 Oct 2020 at 10:44, Pavel Labath via lldb-commits
wrote:
>
> Author: Pavel Labath
> Date: 2020-10-14T16:43:45+02:00
> New Revision: ea3a547f0be20d86b041778ae8e2779f2031f714
>
> URL:
> https://github.com/llvm/llvm-project/commit/ea3a547f0be20d86b041778ae8e2779f2031f714
> DIFF:
> https:/
Author: Ed Maste
Date: 2020-09-30T09:25:27-04:00
New Revision: f794160c6cb7da4b5ef354a91fe498341f651d36
URL:
https://github.com/llvm/llvm-project/commit/f794160c6cb7da4b5ef354a91fe498341f651d36
DIFF:
https://github.com/llvm/llvm-project/commit/f794160c6cb7da4b5ef354a91fe498341f651d36.diff
LOG:
Author: Ed Maste
Date: 2020-04-02T09:43:01-04:00
New Revision: 55e32e92cda79a9eb4487ea8e4ec1b968fac5145
URL:
https://github.com/llvm/llvm-project/commit/55e32e92cda79a9eb4487ea8e4ec1b968fac5145
DIFF:
https://github.com/llvm/llvm-project/commit/55e32e92cda79a9eb4487ea8e4ec1b968fac5145.diff
LOG:
Author: Ed Maste
Date: 2020-04-02T00:12:24-04:00
New Revision: af1b7d06d9e45c7e20540aa3bf81f1be5befaa0f
URL:
https://github.com/llvm/llvm-project/commit/af1b7d06d9e45c7e20540aa3bf81f1be5befaa0f
DIFF:
https://github.com/llvm/llvm-project/commit/af1b7d06d9e45c7e20540aa3bf81f1be5befaa0f.diff
LOG:
On Fri, 28 Jun 2019 at 14:14, Jonas Devlieghere via lldb-commits
wrote:
>
> Author: jdevlieghere
> Date: Fri Jun 28 11:14:27 2019
> New Revision: 364669
>
> URL: http://llvm.org/viewvc/llvm-project?rev=364669&view=rev
> Log:
> [GDBRemote] Remove code that flushes GDB remote packets
>
> The arbitra
Author: emaste
Date: Sat Apr 21 06:59:07 2018
New Revision: 330504
URL: http://llvm.org/viewvc/llvm-project?rev=330504&view=rev
Log:
Temporarily skip Go TestExpressions on FreeBSD as it hangs
llvm.org/pr37194
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/go/expressions/TestExpres
Author: emaste
Date: Sat Apr 21 04:23:56 2018
New Revision: 330500
URL: http://llvm.org/viewvc/llvm-project?rev=330500&view=rev
Log:
FreeBSD: propagate error to user if memory access fails
Previously, an attempt to read an unreadable address reported zeros.
Now, if DoReadMemory or DoWriteMemory e
Author: emaste
Date: Mon Feb 26 18:54:17 2018
New Revision: 326166
URL: http://llvm.org/viewvc/llvm-project?rev=326166&view=rev
Log:
Mark test_*int*_t_dwarf as failing on FreeBSD
Further investigation required; tests will be enabled on the buildbot
worker soon. Marking failing tests for now in or
Author: emaste
Date: Mon Feb 26 14:36:41 2018
New Revision: 326139
URL: http://llvm.org/viewvc/llvm-project?rev=326139&view=rev
Log:
Revert r326134 due to broken buildbot
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/enum_types/TestCPP11EnumTypes.py
Modified:
lldb/trunk/pack
Author: emaste
Date: Mon Feb 26 14:12:24 2018
New Revision: 326134
URL: http://llvm.org/viewvc/llvm-project?rev=326134&view=rev
Log:
Mark test_*int*_t_dwarf as failing on FreeBSD
Further investigation required; tests will be enabled on the buildbot
worker soon. Marking failing tests for now in or
Author: emaste
Date: Thu Feb 22 18:50:07 2018
New Revision: 325856
URL: http://llvm.org/viewvc/llvm-project?rev=325856&view=rev
Log:
remove FreeBSD xfail from lit TestCallStdStringFunction
This test is consistently reporting unexpected pass for me, and the
expectedFailure decorator was removed fr
On 26 October 2017 at 22:24, Pavel Labath via lldb-commits
wrote:
> Author: labath
> Date: Thu Oct 26 19:24:04 2017
> New Revision: 316728
>
> URL: http://llvm.org/viewvc/llvm-project?rev=316728&view=rev
> Log:
> Default to using in-tree clang for building test executables
The FreeBSD buildbot is
On 28 September 2017 at 22:20, Sean Callanan via lldb-commits
wrote:
> Author: spyffe
> Date: Thu Sep 28 13:20:25 2017
> New Revision: 314458
>
> URL: http://llvm.org/viewvc/llvm-project?rev=314458&view=rev
> Log:
> [Expression parser] Setting to enable use of ExternalASTMerger
> ...
> + lldb
Author: emaste
Date: Mon Oct 2 07:35:07 2017
New Revision: 314672
URL: http://llvm.org/viewvc/llvm-project?rev=314672&view=rev
Log:
Improve FreeBSD kernel debugging
FreeBSD kernel modules are actually relocatable (.o) ELF files and this
previously caused some issues for LLDB. This change address
On 19 September 2017 at 14:07, Adrian McCarthy via lldb-commits
wrote:
> Author: amccarth
> Date: Tue Sep 19 11:07:33 2017
> New Revision: 313655
>
> URL: http://llvm.org/viewvc/llvm-project?rev=313655&view=rev
> Log:
> Re-land r313210 - Fix for bug 34532 - A few rough corners related to
> post-m
On 13 September 2017 at 18:57, Adrian McCarthy via lldb-commits
wrote:
> Author: amccarth
> Date: Wed Sep 13 15:57:11 2017
> New Revision: 313210
>
> URL: http://llvm.org/viewvc/llvm-project?rev=313210&view=rev
> Log:
> Fix for bug 34532 - A few rough corners related to post-mortem debugging
> (c
Author: emaste
Date: Sat Sep 2 18:44:35 2017
New Revision: 312431
URL: http://llvm.org/viewvc/llvm-project?rev=312431&view=rev
Log:
Add test case for attach-by-pid from different cwd
This was failing on FreeBSD prior to r312430.
Patch by Vignesh Balu.
Differential Revision: https://reviews.llv
Author: emaste
Date: Sat Sep 2 18:41:31 2017
New Revision: 312430
URL: http://llvm.org/viewvc/llvm-project?rev=312430&view=rev
Log:
FreeBSD: attach to pid from different cwd
attach by pid worked when running from the directory from which the
target was launched, but failed from a different direc
Author: emaste
Date: Wed Aug 16 06:10:07 2017
New Revision: 311003
URL: http://llvm.org/viewvc/llvm-project?rev=311003&view=rev
Log:
convert hard tabs to spaces in PlatformOpenBSD.cpp
Another case of this was responsible for the whitespace conflict
in D34776.
Modified:
lldb/trunk/source/Plug
Author: emaste
Date: Wed Aug 16 05:55:02 2017
New Revision: 311002
URL: http://llvm.org/viewvc/llvm-project?rev=311002&view=rev
Log:
Make i386-*-freebsd expression work on JIT path
* Enable i386 ABI creation for freebsd
* Added an extra argument in ABISysV_i386::PrepareTrivialCall for mmap
sysc
Author: emaste
Date: Thu Aug 10 11:26:52 2017
New Revision: 310644
URL: http://llvm.org/viewvc/llvm-project?rev=310644&view=rev
Log:
remove FreeBSD xfail decorator from TestCppNsImport
The Linux xfail decorator was removed in r272326 with the claim that the
test "runs reliably on the linux x86 bu
Author: emaste
Date: Thu Aug 10 10:01:51 2017
New Revision: 310626
URL: http://llvm.org/viewvc/llvm-project?rev=310626&view=rev
Log:
remove FreeBSD xfail decorator from TestCallStdStringFunction
This test is consistently reporting unexpected pass for me on FreeBSD
10 and 12. It was failing on the
On 20 June 2016 at 19:01, Sean Callanan via lldb-commits
wrote:
> Author: spyffe
> Date: Mon Jun 20 18:01:11 2016
> New Revision: 273211
>
> URL: http://llvm.org/viewvc/llvm-project?rev=273211&view=rev
> Log:
> Test that lldb calls the right 'printf' even when a 'printf' method exists.
>
...
> +
>
Author: emaste
Date: Thu Aug 10 09:48:36 2017
New Revision: 310624
URL: http://llvm.org/viewvc/llvm-project?rev=310624&view=rev
Log:
remove FreeBSD xfail decorator from TestExitDuringBreak
This test passes for me on FreeBSD 10 and 12(-CURRENT).
llvm.org/pr18190
Modified:
lldb/trunk/package
Author: emaste
Date: Thu Aug 10 06:47:17 2017
New Revision: 310591
URL: http://llvm.org/viewvc/llvm-project?rev=310591&view=rev
Log:
Report inferior signals as signals, not exceptions, on FreeBSD
This is the FreeBSD equivalent of r238549.
This serves 2 purposes:
* LLDB should handle inferior pr
Author: emaste
Date: Thu May 25 22:15:46 2017
New Revision: 303965
URL: http://llvm.org/viewvc/llvm-project?rev=303965&view=rev
Log:
FreeBSD ProcessMonitor: map TRAP_CAP to a trace trap
In the absense of a more specific handler for TRAP_CAP (generated by
ENOTCAPABLE or ECAPMODE while in capabilit
Author: emaste
Date: Sat Apr 22 21:28:28 2017
New Revision: 301100
URL: http://llvm.org/viewvc/llvm-project?rev=301100&view=rev
Log:
Simplify FreeBSD Host.cpp with early returns
Based on NetBSD's Host.cpp. Also tidy up comments to match NetBSD.
Modified:
lldb/trunk/source/Host/freebsd/Host.c
Author: emaste
Date: Fri Apr 21 20:38:54 2017
New Revision: 301067
URL: http://llvm.org/viewvc/llvm-project?rev=301067&view=rev
Log:
ThreadSanitizer plugin: match for loop variable with expected type
Removes Clang warning ThreadSanitizerRuntime.cpp:591:21: warning:
comparison of integers of diffe
Author: emaste
Date: Fri Apr 7 11:40:25 2017
New Revision: 299781
URL: http://llvm.org/viewvc/llvm-project?rev=299781&view=rev
Log:
Correct environ parsing on FreeBSD
Sync Host:GetEnvironment with Linux and Kamil Rytarowski's forthcoming
NetBSD change in review D31784.
Modified:
lldb/trunk/
On 31 March 2017 at 07:14, Nitesh Jain via lldb-commits
wrote:
> Author: nitesh.jain
> Date: Fri Mar 31 06:14:02 2017
> New Revision: 299200
>
> URL: http://llvm.org/viewvc/llvm-project?rev=299200&view=rev
> Log:
> [LLDB][MIPS] Core Dump Support.
The FreeBSD build is broken as of this commit:
htt
Author: emaste
Date: Tue Feb 7 13:29:10 2017
New Revision: 294340
URL: http://llvm.org/viewvc/llvm-project?rev=294340&view=rev
Log:
Synchronize PlatformFreeBSD with Linux
Inspired by r294145 for NetBSD, this reduces diffs between the FreeBSD
and Linux/NetBSD Platform implementations. Further dif
Author: emaste
Date: Tue Jan 24 08:34:49 2017
New Revision: 292937
URL: http://llvm.org/viewvc/llvm-project?rev=292937&view=rev
Log:
FreeBSD ARM support for software single step
Implementation of software single step for FreeBSD on ARM. The code is
largely based on the Linux implementation of the
emaste added a comment.
In https://reviews.llvm.org/D25947#597160, @labath wrote:
> Ed, if I may suggest, while you are playing with the arm machine, could you
> grab us a core file or two? It'd be great to be able to do a basic sanity
> check on these things without physical access.
I used m
emaste added a comment.
The tests are not in great shape on FreeBSD/arm64 today, but look roughly
equivalent with and without this patch.
At https://reviews.llvm.org/rL287887:
===
Test Result Summary
===
Test Methods: 1148
Reruns: 16
On 21 November 2016 at 18:18, Zachary Turner via lldb-commits
wrote:
> Author: zturner
> Date: Mon Nov 21 17:18:07 2016
> New Revision: 287597
>
> URL: http://llvm.org/viewvc/llvm-project?rev=287597&view=rev
> Log:
> Add the new Args / entry-access API.
FreeBSD buildbot is now failing with:
http:
Author: emaste
Date: Mon Nov 21 20:25:41 2016
New Revision: 287609
URL: http://llvm.org/viewvc/llvm-project?rev=287609&view=rev
Log:
Turn on LLDB_EDITLINE_USE_WCHAR on FreeBSD
Modified:
lldb/trunk/include/lldb/Host/Editline.h
Modified: lldb/trunk/include/lldb/Host/Editline.h
URL:
http://llv
emaste added a comment.
> Ed, what do you think about this one? Is there anyone with a FreeBSD arm64
> setup that could verify this?
We have an arm64 reference machine in the FreeBSD cluster and I will test after
I return from travel later this week, although perhaps @andrew can try it
before
emaste added a comment.
I applied this change on top of my WIP https://reviews.llvm.org/D26617 (which
adds a FreeBSD core test). LLDB builds and my new test passes, so no objections
from me. Once it's in I'll see about porting the new SSE test to FreeBSD too.
https://reviews.llvm.org/D26300
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286035: make-core.sh: add FreeBSD support (authored by
emaste).
Changed prior to commit:
https://reviews.llvm.org/D26315?vs=76951&id=76968#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26315
Fi
Author: emaste
Date: Sat Nov 5 09:45:13 2016
New Revision: 286035
URL: http://llvm.org/viewvc/llvm-project?rev=286035&view=rev
Log:
make-core.sh: add FreeBSD support
Differential Revision: https://reviews.llvm.org/D26315
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/
emaste added a comment.
Good point. https://reviews.llvm.org/D26315 has the change to add FreeBSD
support to make-core.sh -- just avoiding /bin/bash, and the core file handler
check.
I think we should be able to rename this directory to elf-core, and rename the
individual cores to e.g. linux-i
emaste added a comment.
Output on FreeBSD, with the patch:
% sh make-core.sh main.c
+ file=main.c
+ [ -z main.c ]
+ [ FreeBSD '=' Linux ]
+ ulimit -c 1000
+ ulimit -c
+ real_limit=1000
+ [ 1000 -lt 100 ]
+ cc -nostdlib -static -g main.c -o a.out
+ cat
Executable file is in a
emaste created this revision.
emaste added a reviewer: labath.
emaste added a subscriber: lldb-commits.
https://reviews.llvm.org/D26315
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/make-core.sh
Index:
packages/Python/lldbsuite/test/functionalities/postmortem/l
emaste added a comment.
We need to make sure this does not regress FreeBSD core handling -- I will test
as soon as I can, and add FXSAVE parsing for FreeBSD. I'll use fpr_sse.cpp to
generate FreeBSD core files as well (although note that we get ~2.5MB cores
with default configuration, so tweaki
On 24 October 2016 at 06:26, Pavel Labath wrote:
>
> It's not my place to tell you how to work, but I'd recommend a
> different approach to this. If you base your work on the current
> FreeBSD in-process plugin, then when you get around to actually
> implementing remote support, you will find that
emaste added a subscriber: krytarowski.
emaste added a comment.
On a quick look this seems OK. I'll try to test/review in detail.
In https://reviews.llvm.org/D25756#576642, @dmikulin wrote:
> Thanks Pavel! I'll start working on it. Do you know when lldb-server Linux
> changes were committed? I
emaste added a comment.
On a quick look this seems OK. I'll try to test/review in detail.
Comment at: source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:925
+
+ // eRegisterKindDWARF -> RegsiterValue
+ std::unordered_map m_register_values;
typo here
Reposito
emaste added a comment.
In https://reviews.llvm.org/D25756#574258, @labath wrote:
> No, I'm saying someone *should*. :P
>
> Ed looked into that at some point but, I don't think get got too far with it.
> Adding @emaste, who should probably review this.
Yes, it needs to be done. Maybe now that
emaste accepted this revision.
emaste added a reviewer: emaste.
emaste added a comment.
This revision is now accepted and ready to land.
Not tested, but looks reasonable to me.
I think we should avoid `siginfo_t` altogether here in order to support
cross-debugging, but that's for a different cha
On 6 October 2016 at 16:42, Zachary Turner wrote:
> I'm not sure actually. I only noticed this because I was in IRC and I saw
> the message go by about the failure.
>
> Ed (already CC'ed) maintains the FreeBSD builder, so he might have an answer
> for you.
I'm not sure why it's not on the build.
Author: emaste
Date: Thu Oct 6 12:55:22 2016
New Revision: 283472
URL: http://llvm.org/viewvc/llvm-project?rev=283472&view=rev
Log:
Match printf field width arg and type
A '*' as a field width or precision specifies that the field width or
precision is supplied by an int argument.
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282123: Fix typo in lldb --help (authored by emaste).
Changed prior to commit:
https://reviews.llvm.org/D12158?vs=32567&id=72133#toc
Repository:
rL LLVM
https://reviews.llvm.org/D12158
Files:
lldb
Author: emaste
Date: Wed Sep 21 18:30:36 2016
New Revision: 282123
URL: http://llvm.org/viewvc/llvm-project?rev=282123&view=rev
Log:
Fix typo in lldb --help
Patch by Yacine Belkadi
Differential Revision: https://reviews.llvm.org/D12158
Modified:
lldb/trunk/tools/driver/Driver.cpp
Modified
On 21 September 2016 at 21:38, Adrian McCarthy wrote:
> That fix doesn't look complete:
Thanks, I've applied your fix in r282119, and sorry for being hasty
with the original change.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
Author: emaste
Date: Wed Sep 21 17:36:51 2016
New Revision: 282119
URL: http://llvm.org/viewvc/llvm-project?rev=282119&view=rev
Log:
Fix for loop sign fix in r282112 for column = 0
Modified:
lldb/trunk/source/Core/SourceManager.cpp
Modified: lldb/trunk/source/Core/SourceManager.cpp
URL:
htt
On 21 September 2016 at 17:08, Ed Maste via lldb-commits
wrote:
> Author: emaste
> Date: Wed Sep 21 16:08:30 2016
> New Revision: 282111
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282111&view=rev
> Log:
> Fix -Wcovered-switch-default warning in StackFrame.cpp
&
Author: emaste
Date: Wed Sep 21 16:14:31 2016
New Revision: 282112
URL: http://llvm.org/viewvc/llvm-project?rev=282112&view=rev
Log:
Fix integer sign warning from r282105
Modified:
lldb/trunk/source/Core/SourceManager.cpp
Modified: lldb/trunk/source/Core/SourceManager.cpp
URL:
http://llvm.o
Author: emaste
Date: Wed Sep 21 16:08:30 2016
New Revision: 282111
URL: http://llvm.org/viewvc/llvm-project?rev=282111&view=rev
Log:
Fix -Wcovered-switch-default warning in StackFrame.cpp
The switch coveres all possible values. If a new one is added in the
future the compiler will start warning,
1 - 100 of 266 matches
Mail list logo
