[Lldb-commits] [lldb] [lldb-dap] Prevent using an implicit `step-in`. (PR #143644)

2025-06-11 Thread Ebuka Ezike via lldb-commits
da-viper wrote: It is the combination of the first and third. For completness. we do an step-over, which lands us at an instruction, which happens to be the first instruction of an inlined function. lldb-dap takes the PC value and resolves it to a function/block on its own. This returns the

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-10 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/143126 >From 95c61d6a917060d7b3a2bc554575eb6a1086ed6e Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Fri, 6 Jun 2025 13:15:41 +0100 Subject: [PATCH 1/6] [lldb] add plugin names to process save-core error output. -

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-10 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/143126 >From 95c61d6a917060d7b3a2bc554575eb6a1086ed6e Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Fri, 6 Jun 2025 13:15:41 +0100 Subject: [PATCH 1/4] [lldb] add plugin names to process save-core error output. -

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-09 Thread Ebuka Ezike via lldb-commits
@@ -797,7 +797,8 @@ let Command = "process save_core" in { EnumArg<"SaveCoreStyle">, Desc<"Request a specific style " "of corefile to be saved.">; def process_save_core_plugin_name : Option<"plugin-name", "p">, -OptionalArg<"Plugin">, Desc<"Specify a plugin name t

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-09 Thread Ebuka Ezike via lldb-commits
@@ -198,6 +198,8 @@ static constexpr OptionEnumValueElement g_completion_type[] = { "Completes to a type category name."}, {lldb::eCustomCompletion, "custom", "Custom completion."}, {lldb::eThreadIDCompletion, "thread-id", "Completes to a thread ID."}, +{lldb:

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-09 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I overrode the `GetDefinitions` to add the missing options for the `plugin-name arg` it seems like the generic way to do it. https://github.com/llvm/llvm-project/pull/143126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-09 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/143126 >From 95c61d6a917060d7b3a2bc554575eb6a1086ed6e Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Fri, 6 Jun 2025 13:15:41 +0100 Subject: [PATCH 1/2] [lldb] add plugin names to process save-core error output. -

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-06 Thread Ebuka Ezike via lldb-commits
da-viper wrote: Requested from the comments, I added the available plugins that can save a core file. But not to sure how to add it to `help plugin save-core` because help files are all static and this help is dynamically generated. https://github.com/llvm/llvm-project/pull/143126 _

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-06 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/143126 continuation of [#142684](https://github.com/llvm/llvm-project/pull/142684) to show plugin names. >From issue [#14258](https://github.com/llvm/llvm-project/issues/142581) >From 95c61d6a917060d7b3a2bc554575eb

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-05 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I think the latter is better. That way we don't have to revert both of them https://github.com/llvm/llvm-project/pull/142831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/142831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread Ebuka Ezike via lldb-commits
@@ -30,6 +30,8 @@ def test_basic(self): self.assertEqual( len(breakpoint_ids), len(lines), "expect correct number of breakpoints" ) +# Target based capability 'supportsStepInTargetsRequest' is sent in da-viper wrote: the `c

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-04 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I was wondering why llvm build bot did not catch it ( I assume there is a build bot for macos ? ) https://github.com/llvm/llvm-project/pull/142439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/142831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread Ebuka Ezike via lldb-commits
@@ -89,17 +91,14 @@ def test_supported_capability_x86_arch(self): self.assertEqual( len(breakpoint_ids), len(bp_lines), "expect correct number of breakpoints" ) -is_supported = self.dap_server.get_initialize_value( -"supportsStep

[Lldb-commits] [lldb] [lldb-dap] Creating a 'capabilities' event helper. (PR #142831)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/142831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb] Add fetching of source files used in modules. (PR #141773)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/141773 >From 429c656be7e8176c1c4d6f7c4339b7c6d76fa56c Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 09:04:08 +0100 Subject: [PATCH] [lldb] Inital implementation of fetching source files used in mo

[Lldb-commits] [lldb] [lldb-dap][test] Fix DAP disassemble test (PR #142129)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/142129 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread Ebuka Ezike via lldb-commits
@@ -8,10 +8,11 @@ #include "EventHelper.h" #include "DAP.h" -#include "DAPLog.h" +#include "DAPERror.h" da-viper wrote: ```suggestion #include "DAPError.h" ``` https://github.com/llvm/llvm-project/pull/142510 ___ l

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread Ebuka Ezike via lldb-commits
@@ -110,4 +116,48 @@ std::string GetLoadAddressString(const lldb::addr_t addr) { return "0x" + llvm::utohexstr(addr, false, 16); } +protocol::Thread CreateThread(lldb::SBThread &thread, lldb::SBFormat &format) { + std::string name; + lldb::SBStream stream; + if (format &&

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/142510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread Ebuka Ezike via lldb-commits
@@ -116,78 +119,78 @@ void SendProcessEvent(DAP &dap, LaunchMethod launch_method) { // Send a thread stopped event for all threads as long as the process // is stopped. -void SendThreadStoppedEvent(DAP &dap) { +llvm::Error SendThreadStoppedEvent(DAP &dap, bool on_entry) { +

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/142439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not accept invalid `process save-core` plugins (PR #142684)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/142684 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add missing key for capabilities event. (PR #142751)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/142751 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add missing key for capabilities event. (PR #142751)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/142751 fixes the failed tests on arch64. complements #142439 >From ed06cb782cca2a7433ae2dc81e1838009ca6e6d8 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 4 Jun 2025 10:18:54 +0100 Subject: [PATCH] [lldb-dap]

[Lldb-commits] [lldb] [lldb] Do not accept invalid `process save-core` plugins (PR #142684)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/142684 Fixes #142581 >From 7e940dcb0cfde1bc9be73c7cf2a40ba7f08d12e5 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 2 Jun 2025 17:07:50 +0100 Subject: [PATCH 1/4] [lldb-dap] Forward any error from stepping. -

[Lldb-commits] [lldb] [lldb] Do not accept invalid `process save-core` plugins (PR #142684)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142684 >From 0bf47c19e63c3b72a4b3861fa286e273a99bd80c Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 3 Jun 2025 23:22:30 +0100 Subject: [PATCH 1/2] [lldb] Return an error when if process save-core plugin is in

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/142652 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] explicitly set the expr as an alias for expression. (PR #134562)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/134562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142652 >From 7e940dcb0cfde1bc9be73c7cf2a40ba7f08d12e5 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 2 Jun 2025 17:07:50 +0100 Subject: [PATCH 1/2] [lldb-dap] Forward any error from stepping. --- lldb/tools/l

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/142652 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/142652 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/142652 The current implementation hides any possible error from performing a step command. >From 7e940dcb0cfde1bc9be73c7cf2a40ba7f08d12e5 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 2 Jun 2025 17:07:50 +01

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142439 >From 69efc48d722d18600018f25db0f9ea46b9fd1d97 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 14:02:01 +0100 Subject: [PATCH 1/5] [lldb-dap] Use structured types for stepInTargets request --

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -414,6 +415,34 @@ bool fromJSON(const llvm::json::Value &, SteppingGranularity &, llvm::json::Path); llvm::json::Value toJSON(const SteppingGranularity &); +/// A `StepInTarget` can be used in the `stepIn` request and determines into +/// which single target

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142439 >From 69efc48d722d18600018f25db0f9ea46b9fd1d97 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 14:02:01 +0100 Subject: [PATCH 1/4] [lldb-dap] Use structured types for stepInTargets request --

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -78,3 +78,31 @@ def test_basic(self): leaf_frame = self.dap_server.get_stackFrame() self.assertIsNotNone(leaf_frame, "expect a leaf frame") self.assertEqual(step_in_targets[1]["label"], leaf_frame["name"]) + +def test_supported_capability(self): +

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -33,6 +33,23 @@ static void SendThreadExitedEvent(DAP &dap, lldb::tid_t tid) { dap.SendJSON(llvm::json::Value(std::move(event))); } +void SendAdditionalCapabilities(DAP &dap) { + if (dap.target.IsValid()) { da-viper wrote: I wanted to do it like that b

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -414,6 +415,34 @@ bool fromJSON(const llvm::json::Value &, SteppingGranularity &, llvm::json::Path); llvm::json::Value toJSON(const SteppingGranularity &); +/// A `StepInTarget` can be used in the `stepIn` request and determines into +/// which single target

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -33,6 +33,23 @@ static void SendThreadExitedEvent(DAP &dap, lldb::tid_t tid) { dap.SendJSON(llvm::json::Value(std::move(event))); } +void SendAdditionalCapabilities(DAP &dap) { da-viper wrote: Will update was struggling to think of a good name. https:/

[Lldb-commits] [lldb] [lldb-dap] Correct the disconnect helper on server shutdown. (PR #142508)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/142508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142439 >From 69efc48d722d18600018f25db0f9ea46b9fd1d97 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 14:02:01 +0100 Subject: [PATCH 1/3] [lldb-dap] Use structured types for stepInTargets request --

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142439 >From 69efc48d722d18600018f25db0f9ea46b9fd1d97 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 14:02:01 +0100 Subject: [PATCH 1/2] [lldb-dap] Use structured types for stepInTargets request --

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -356,7 +356,21 @@ class StepInRequestHandler : public RequestHandler> { +public: + using RequestHandler::RequestHandler; + static llvm::StringLiteral GetCommand() { return "stepInTargets"; } + FeatureSet GetSupportedFeatures() const override { +return {protocol::eAdapte

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -414,6 +415,34 @@ bool fromJSON(const llvm::json::Value &, SteppingGranularity &, llvm::json::Path); llvm::json::Value toJSON(const SteppingGranularity &); +/// A `StepInTarget` can be used in the `stepIn` request and determines into +/// which single target

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-02 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/142439 None >From 69efc48d722d18600018f25db0f9ea46b9fd1d97 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 14:02:01 +0100 Subject: [PATCH] [lldb-dap] Use structured types for stepInTargets request

[Lldb-commits] [lldb] [lldb-dap][test] Fix DAP disassemble test (PR #142129)

2025-06-02 Thread Ebuka Ezike via lldb-commits
@@ -23,15 +19,23 @@ def test_disassemble(self): self.set_source_breakpoints(source, [line_number(source, "// breakpoint 1")]) self.continue_to_next_stop() -_, pc_assembly = self.disassemble(frameIndex=0) -self.assertIn("location", pc_assembly,

[Lldb-commits] [lldb] [lldb-dap][test] Fix DAP disassemble test (PR #142129)

2025-06-02 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142129 >From 4c0bd999e60b7082fb30916c5f20d7ab064e76fe Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Fri, 30 May 2025 12:49:22 +0100 Subject: [PATCH 1/2] [lldb-dap][test] Fix DAP disassemble test compare the instru

[Lldb-commits] [lldb] [NFC][lldb-dap] Avoid unnecessary copy in setBreakpoint (PR #142179)

2025-06-01 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/142179 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-30 Thread Ebuka Ezike via lldb-commits
da-viper wrote: Changing the test for disassemble to not depend on source location. #142129 https://github.com/llvm/llvm-project/pull/141689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb][lldb-dap] Use the default disassembly flavour if none is provided. (PR #141424)

2025-05-30 Thread Ebuka Ezike via lldb-commits
da-viper wrote: @JDevlieghere sorry about that, I did assume since it was small. will wait for the approval hence forth. https://github.com/llvm/llvm-project/pull/141424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [lldb] [NFC][lldb-dap] Avoid unnecessary copy in setBreakpoint (PR #142179)

2025-05-30 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/142179 None >From 68b17403353418674681a79e1d41fa57ae848db2 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Fri, 30 May 2025 16:56:18 +0100 Subject: [PATCH] [NFC][lldb-dap] remove unnecessary copy. --- lldb/tools/l

[Lldb-commits] [lldb] [lldb-dap][test] Fix DAP disassemble test (PR #142129)

2025-05-30 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/142129 compare the instructions before and after setting breakpoint to make sure they are the same. Do not use the source location as it is not guaranteed to exist. >From 4c0bd999e60b7082fb30916c5f20d7ab064e76fe Mon

[Lldb-commits] [lldb] [lldb][lldb-dap] Support breakpoint info bytes (PR #141122)

2025-05-30 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/141122 >From 9408d17b1acf308c7a299bdc6c413a3505d1a039 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 21 May 2025 23:26:14 +0100 Subject: [PATCH 01/10] [lldb][lldb-dap] support DataBreakpointBytes capability --

[Lldb-commits] [lldb] [lldb][lldb-dap] Use the default disassembly flavour if none is provided. (PR #141424)

2025-05-30 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/141424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap][test] show the expected value in the error message. (PR #142030)

2025-05-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/142030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap][test] show the expected value in the error message. (PR #142030)

2025-05-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142030 >From 2051222d2beede3a5bed8a9436dce3ca217d53a6 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Thu, 29 May 2025 21:28:13 +0100 Subject: [PATCH 1/3] [lldb][lldb-dap][test] show the expected value in the error

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap][test] show the expected value in the error message. (PR #142030)

2025-05-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142030 >From 2051222d2beede3a5bed8a9436dce3ca217d53a6 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Thu, 29 May 2025 21:28:13 +0100 Subject: [PATCH 1/2] [lldb][lldb-dap][test] show the expected value in the error

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-29 Thread Ebuka Ezike via lldb-commits
da-viper wrote: The test for disassembly is failing because the test is wrong. The memory reference can have a corresponding source location. if there is debuginfo installed on the computer or it is downloaded with debuginfod. https://github.com/llvm/llvm-project/blob/84a69a0f8f60b6d852b9a16

[Lldb-commits] [lldb] [lldb][lldb-dap] Support breakpoint info bytes (PR #141122)

2025-05-29 Thread Ebuka Ezike via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] [lldb][lldb-dap] Support breakpoint info bytes (PR #141122)

2025-05-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/141122 >From 9408d17b1acf308c7a299bdc6c413a3505d1a039 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 21 May 2025 23:26:14 +0100 Subject: [PATCH 1/9] [lldb][lldb-dap] support DataBreakpointBytes capability ---

[Lldb-commits] [lldb] [lldb][lldb-dap] Support breakpoint info bytes (PR #141122)

2025-05-29 Thread Ebuka Ezike via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] [WIP] [lldb] Add fetching of source files used in modules. (PR #141773)

2025-05-28 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/141773 Rough implementation of a source locator plugin for LLDB. >From c8ca502eeed9fe026c39c0f34acdbcca7b3f7f30 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 09:04:08 +0100 Subject: [PATCH] [lldb]

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/140727 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/140727 >From cb2db78130e372b67d760cd89d2418252fa37459 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 18 May 2025 09:55:25 +0100 Subject: [PATCH 1/7] [lldb] optionally match the `__debug` namespace for libstdc+

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/140727 >From cb2db78130e372b67d760cd89d2418252fa37459 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 18 May 2025 09:55:25 +0100 Subject: [PATCH 1/8] [lldb] optionally match the `__debug` namespace for libstdc+

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/140727 >From cb2db78130e372b67d760cd89d2418252fa37459 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 18 May 2025 09:55:25 +0100 Subject: [PATCH 1/6] [lldb] optionally match the `__debug` namespace for libstdc+

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-27 Thread Ebuka Ezike via lldb-commits
@@ -19,8 +19,17 @@ def setUp(self): @add_test_categories(["libstdcxx"]) @expectedFailureAll(bugnumber="llvm.org/pr50861", compiler="gcc") def test_with_run_command(self): +self.with_run_command("", {}) da-viper wrote: Mb, Sometimes I don't

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/140727 >From cb2db78130e372b67d760cd89d2418252fa37459 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 18 May 2025 09:55:25 +0100 Subject: [PATCH 1/5] [lldb] optionally match the `__debug` namespace for libstdc+

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/140727 >From cb2db78130e372b67d760cd89d2418252fa37459 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 18 May 2025 09:55:25 +0100 Subject: [PATCH 1/4] [lldb] optionally match the `__debug` namespace for libstdc+

[Lldb-commits] [lldb] [lldb][lldb-dap] Use the default disassembly flavour if none is provided. (PR #141424)

2025-05-26 Thread Ebuka Ezike via lldb-commits
@@ -2039,7 +2039,17 @@ lldb::SBInstructionList SBTarget::ReadInstructions(lldb::SBAddress base_addr, const size_t bytes_read = target_sp->ReadMemory(*addr_ptr, data.GetBytes(), data.GetByteSize(), error, force_live_memory, &load_

[Lldb-commits] [lldb] [lldb][lldb-dap] Use the default disassembly flavour if none is provided. (PR #141424)

2025-05-25 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/141424 This is the currently the default for `SBTarget::ReadInstructions(SBAddress, uint32_t)`. But not for others, to make it consistent used the user assigned instruction flavour. >From 6d3872f06ea10985c05a19f42c0

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-25 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/140727 >From cb2db78130e372b67d760cd89d2418252fa37459 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 18 May 2025 09:55:25 +0100 Subject: [PATCH 1/3] [lldb] optionally match the `__debug` namespace for libstdc+

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-25 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/141122 >From 3b166d8f484cda8702c798a1fa2cf01fd5222f80 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 21 May 2025 23:26:14 +0100 Subject: [PATCH 1/7] [lldb][lldb-dap] support DataBreakpointBytes capability ---

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-25 Thread Ebuka Ezike via lldb-commits
@@ -1649,11 +1649,14 @@ class CommandObjectThreadJump : public CommandObjectParsed { return Status::FromErrorStringWithFormat("invalid line number: '%s'.", option_arg.str().c_str()); break; - case 'b':

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-25 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/141122 >From 3b166d8f484cda8702c798a1fa2cf01fd5222f80 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 21 May 2025 23:26:14 +0100 Subject: [PATCH 1/6] [lldb][lldb-dap] support DataBreakpointBytes capability ---

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-25 Thread Ebuka Ezike via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-25 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper deleted https://github.com/llvm/llvm-project/pull/141122 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread Ebuka Ezike via lldb-commits
@@ -131,9 +133,10 @@ def verify_breakpoint_hit(self, breakpoint_ids, timeout=DEFAULT_TIMEOUT): # So when looking at the description we just want to make sure # the right breakpoint matches and not worry about the actual # locatio

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread Ebuka Ezike via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread Ebuka Ezike via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread Ebuka Ezike via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread Ebuka Ezike via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] [lldb] Adding a new decorator for CMAKE_BUILD_TYPE. (PR #141159)

2025-05-23 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/141159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Assorted small fixes for runInTerminal (PR #140908)

2025-05-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/140908 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/141122 >From a839dde6f9be0d3cbec73b9c001144b6cdbdc732 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 21 May 2025 23:26:14 +0100 Subject: [PATCH 1/5] [lldb][lldb-dap] support DataBreakpointBytes capability ---

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/141122 >From a839dde6f9be0d3cbec73b9c001144b6cdbdc732 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 21 May 2025 23:26:14 +0100 Subject: [PATCH 1/4] [lldb][lldb-dap] support DataBreakpointBytes capability ---

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135778 >From 8070e1a391d876ccbab25dac6d2a6d2d77f16069 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 15 Apr 2025 12:25:41 +0100 Subject: [PATCH 1/5] [lldb] Add test for jumping by offset Signed-off-by: Ebuka E

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/141122 This adds the support for `supportsBreakpointInfoBytes` to set watchpoint on a address range. >From a839dde6f9be0d3cbec73b9c001144b6cdbdc732 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 21 May 2025

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-21 Thread Ebuka Ezike via lldb-commits
@@ -1102,3 +1103,28 @@ def is_feature_enabled(): return "%s is not supported on this system." % feature return skipTestIfFn(is_feature_enabled) + + +def skipIfBinaryToLarge(path: Optional[str], maxSize: int): +"""Skip the test if a binary is to large. +

[Lldb-commits] [lldb] [lldb][lldb-dap][tests] Make sure evaluate test exists with no errors. (PR #140788)

2025-05-21 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/140788 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap][tests] Make sure evaluate test exists with no errors. (PR #140788)

2025-05-21 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/140788 >From a9824d7b8a4b6ad4b7baf1d43901aa796beeff2a Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 20 May 2025 20:11:29 +0100 Subject: [PATCH 1/2] [lldb][lldb-dap][tests] Make sure evaluate test exists with

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -62,6 +65,71 @@ def test(self): substrs=["error"], ) +def test_jump_offset(self): +"""Test Thread Jump by negative or positive offset""" +exe = self.getBuildArtifact("a.out") +file_name = "main.cpp" +self.runCmd(f"targ

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -1649,11 +1649,14 @@ class CommandObjectThreadJump : public CommandObjectParsed { return Status::FromErrorStringWithFormat("invalid line number: '%s'.", option_arg.str().c_str()); break; - case 'b':

[Lldb-commits] [lldb] [lldb][lldb-dap] show modules pane if supported by the adapter (PR #140603)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/140603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Basic implementation of a deferred request. (PR #140260)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/140260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/140777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -1,26 +1,23 @@ """ -Test lldb-dap setBreakpoints request +Test lldb-dap console output """ -import dap_server import lldbdap_testcase -from lldbsuite.test import lldbutil from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * -def get_subproces

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -1,26 +1,23 @@ """ -Test lldb-dap setBreakpoints request +Test lldb-dap console output """ -import dap_server import lldbdap_testcase -from lldbsuite.test import lldbutil from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * -def get_subproces

  1   2   3   4   >