DavidSpickett wrote:
You should email the worker admin and see if they can help. "Worker:" tab then
"admin".
It is doing remote testing but the failure seems to be before that step so I
think it's something to do with the host.
https://github.com/llvm/llvm-project/pull/148996
@@ -0,0 +1,469 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,469 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/DavidSpickett commented:
What happens when you don't put this annotation on one of these? It generates
something I suppose, but it fails when you use lldb-rpc?
https://github.com/llvm/llvm-project/pull/148981
___
lldb-commits mailin
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/148981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,124 @@
+#include "RPCLibraryHeaderEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/AST/Mangle.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/ToolOutputFile.h"
+#include "llvm/S
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,20 @@
+#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H
+#define LLDB_API_SBRPC_CHECKARRAYPTR_H
+
+#include
+#include
+
+#include "lldb/API/SBDefines.h"
+
+namespace lldb {
+class LLDB_API SBRPC_CHECKARRAYPTR {
DavidSpickett wrote:
Not sure about the ALLCAPS n
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,20 @@
+#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H
+#define LLDB_API_SBRPC_CHECKARRAYPTR_H
+
+#include
+#include
+
+#include "lldb/API/SBDefines.h"
+
+namespace lldb {
+class LLDB_API SBRPC_CHECKARRAYPTR {
DavidSpickett wrote:
So these are just test input
@@ -0,0 +1,124 @@
+#include "RPCLibraryHeaderEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/AST/Mangle.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/ToolOutputFile.h"
+#include "llvm/S
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,124 @@
+#include "RPCLibraryHeaderEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/AST/Mangle.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/ToolOutputFile.h"
+#include "llvm/S
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,20 @@
+#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H
+#define LLDB_API_SBRPC_CHECKARRAYPTR_H
+
+#include
+#include
DavidSpickett wrote:
Oh these are just test inputs. So the include can be removed entirely?
https://github.com/llvm/llvm-project/pull/147655
@@ -0,0 +1,15 @@
+RUN: mkdir -p %t/server
+RUN: mkdir -p %t/lib
+RUN: %lldb-rpc-gen --output-dir=%t %S/../../Inputs/CheckSBPointer.h
+
+RUN: cat %t/lib/CheckSBPointer.cpp | FileCheck %s
+
+# Pointers to SB objects must be checked to
+# see if they're null. If so, then a new object
@@ -0,0 +1,20 @@
+#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H
+#define LLDB_API_SBRPC_CHECKARRAYPTR_H
+
+#include
+#include
DavidSpickett wrote:
I think all the cstdio includes can move into the cpp files.
https://github.com/llvm/llvm-project/pull/147655
__
Author: David Spickett
Date: 2025-07-17T09:17:25Z
New Revision: d87170211dc780341e42f7719c7332416f9cc290
URL:
https://github.com/llvm/llvm-project/commit/d87170211dc780341e42f7719c7332416f9cc290
DIFF:
https://github.com/llvm/llvm-project/commit/d87170211dc780341e42f7719c7332416f9cc290.diff
LOG
DavidSpickett wrote:
We had a discussion about preferring one or the other PDB implementation but I
don't recall the conclusion. I think this is just for reading PDB, right? Clang
is going to use llvm's libraries to *write* PDB and of course MSVC is using
Microsoft's implementation.
I think a
DavidSpickett wrote:
What does running API tests with PDB look like? I assume Linaro is not doing
that because we don't pass any extra flags, and often have to disable tests
because link.exe is mangling the DWARF sections.
Or put another way, @Nerixyz how do you make sure PDB is being used whe
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/149057
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Also, the server made it into 21.x but the docs obviously didn't and there's no
release note for it. Is it complete "enough" to cherry-pick this and add a
release note?
https://github.com/llvm/llvm-project/pull/148708
___
lldb-co
https://github.com/DavidSpickett approved this pull request.
LGTM with whatever is the correct thing to document for debugger IDs.
https://github.com/llvm/llvm-project/pull/148708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/149057
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -167,3 +167,49 @@ The result of this is that:
Your VM configuration should have ports ``54321`` and ``49140`` forwarded for
this to work.
+
+QEMU user mode emulation
+
+
+Serious testing of LLDB should be done using system mode emulation. The
follow
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/149057
>From eab94453a4275cdbc5fe60607fb18a7869a2d3a8 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 16 Jul 2025 10:20:59 +
Subject: [PATCH 1/2] [lldb][docs] Add section on testing with QEMU user
T
DavidSpickett wrote:
Perhaps with a release note saying this happened and how to switch back to the
non-default way?
https://github.com/llvm/llvm-project/pull/147887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/149057
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Hopefully there are enough "here be dragons, fighting them is your problem" in
the text.
WASM runtimes is another class of simulator I was thinking of in future. I know
we don't have support for that yet but if that one PR ever gets revived, it
might be a thing. So I'm le
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/149057
This is not recommended to basically anyone but on occasion it's useful and
could be used for testing with other simulator programs for example bare metal
simulators.
Adding this is also an excuse to doc
@@ -1376,29 +1376,26 @@ class EntityRegister : public Materializer::Entity {
return;
}
-DataExtractor register_data;
-
-if (!reg_value.GetData(register_data)) {
- err = Status::FromErrorStringWithFormat(
- "couldn't get the data for register %s"
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/148836
Relates to https://github.com/llvm/llvm-project/issues/135707
Where it was reported that reading the PC using "register read" had different
results to an expression "$pc".
This was happening because regi
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/148823
>From ba64d72e000bd14125b202a70bd7d34831e12cc0 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 15 Jul 2025 10:30:21 +
Subject: [PATCH] [lldb] Improve setting of program for filtering disassemb
Author: David Spickett
Date: 2025-07-15T09:54:58Z
New Revision: a64bfd8a5186bc5b967878689509db81b9d1922c
URL:
https://github.com/llvm/llvm-project/commit/a64bfd8a5186bc5b967878689509db81b9d1922c
DIFF:
https://github.com/llvm/llvm-project/commit/a64bfd8a5186bc5b967878689509db81b9d1922c.diff
LOG
@@ -75,7 +75,69 @@ Configuration example for [Visual Studio
Code](https://code.visualstudio.com/doc
}
```
-### Troubleshooting
+## Tools
+
+Tools are a primitive in the Model Context Protocol that enable servers to
+expose functionality to clients.
+
+LLDB's MCP integration e
@@ -75,7 +75,69 @@ Configuration example for [Visual Studio
Code](https://code.visualstudio.com/doc
}
```
-### Troubleshooting
+## Tools
+
+Tools are a primitive in the Model Context Protocol that enable servers to
+expose functionality to clients.
+
+LLDB's MCP integration e
@@ -75,7 +75,69 @@ Configuration example for [Visual Studio
Code](https://code.visualstudio.com/doc
}
```
-### Troubleshooting
+## Tools
+
+Tools are a primitive in the Model Context Protocol that enable servers to
+expose functionality to clients.
+
+LLDB's MCP integration e
https://github.com/DavidSpickett approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Please fix the formatting before landing -
https://github.com/llvm/llvm-project/actions/runs/16232166455/job/45836933279?pr=145793.
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -90,3 +91,64 @@ TEST_F(TestMCDisasmInstanceRISCV, TestRISCV32Instruction) {
EXPECT_FALSE(inst_sp->IsCall());
EXPECT_TRUE(inst_sp->DoesBranch());
}
+
+TEST_F(TestMCDisasmInstanceRISCV, TestOpcodeBytePrinter) {
+ ArchSpec arch("riscv32-*-linux");
+
+ const unsigned num_o
@@ -304,6 +304,10 @@ Changes to LLDB
stop reason = SIGSEGV: sent by tkill system call (sender pid=649752,
uid=2667987)
```
* ELF Cores can now have their siginfo structures inspected using `thread
siginfo`.
+* Disassembly of unknown instructions now produces "" instead
DavidSpickett wrote:
> So the solution is copying the implementation in
> NativeRegisterContextLinux_arm64.cpp.
Yes, try putting the 64-bit code in a separate file in Process/Linux then using
it in both places.
Currently arm64 includes the arm header, for reasons I am not sure, so if there
i
DavidSpickett wrote:
> the test
By this you mean it skips any test that requires hardware breakpoints? Or you
mean that in the general course of using lldb it doesn't use hardware
breakpoints because of this?
(I assume you could make the test suite launch all debugees as AArch32 but
seems un
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,28 @@
+# REQUIRES: x86
+
+# This test verifies that disassemble -b prints out the correct bytes and
+# format for x86_64 instructions of various sizes, and that an unknown
+# instruction shows the opcode and disassembles as ""
+
+# RUN: llvm-mc -filetype=obj --triple=x8
@@ -0,0 +1,30 @@
+# REQUIRES: riscv
+
+# This test verifies that disassemble -b prints out the correct bytes and
+# format for standard and unknown riscv instructions of various sizes,
+# and that unknown instructions show opcodes and disassemble as "".
+# It also tests that the f
@@ -0,0 +1,30 @@
+# REQUIRES: riscv
+
+# This test verifies that disassemble -b prints out the correct bytes and
+# format for standard and unknown riscv instructions of various sizes,
+# and that unknown instructions show opcodes and disassemble as "".
+# It also tests that the f
@@ -304,6 +304,9 @@ Changes to LLDB
stop reason = SIGSEGV: sent by tkill system call (sender pid=649752,
uid=2667987)
```
* ELF Cores can now have their siginfo structures inspected using `thread
siginfo`.
+* Changed invalid disassembly to say instead of being blank.
-
@@ -304,6 +304,9 @@ Changes to LLDB
stop reason = SIGSEGV: sent by tkill system call (sender pid=649752,
uid=2667987)
```
* ELF Cores can now have their siginfo structures inspected using `thread
siginfo`.
+* Changed invalid disassembly to say instead of being blank.
+
@@ -0,0 +1,30 @@
+# REQUIRES: riscv
+
+# This test verifies that disassemble -b prints out the correct bytes and
+# format for standard and unknown riscv instructions of various sizes,
+# and that unknown instructions show opcodes and disassemble as "".
+# It also tests that the f
DavidSpickett wrote:
> Unfortunately there is no easy way to add testing for this. No RISCV hardware
> at the disposal. I welcome the suggestions.
Make a core file that does not include any internal data and then it can be
tested on any system. If you have to satisfy internal policies around t
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/147434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
I guess you're emulating what the tool gets during the normal build so if it
works it works. Let's find out what the bot thinks.
https://github.com/llvm/llvm-project/pull/147417
___
lldb-com
DavidSpickett wrote:
For relands, please describe the difference between the reland and the original
patch in the PR description. This helps us later when it turns out that either
it did not fix the problem you thought it did, or it did, but now there is
another problem.
https://github.com/ll
DavidSpickett wrote:
> Relands the commit to upstream the lldb-rpc-gen tool in order to fix a build
> failure on the linux remote bots.
And changes what when compared to the original PR?
https://github.com/llvm/llvm-project/pull/147417
___
lldb-commi
DavidSpickett wrote:
> Yes I already found it and its in my list to fix, there are few places where
> DWARF32 parsing but I was planing to do in separate PR. or you want me to do
> it here only ?
Separate PR please.
https://github.com/llvm/llvm-project/pull/147054
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/145033
>From ba8fcf4ef14e25b8a628b994988d6a67bdbea7df Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 19 Jun 2025 10:43:48 +
Subject: [PATCH 1/3] [lldb][AArch64] Add HWCAP3 to register field detectio
DavidSpickett wrote:
> And by searching that error message I found:
Hacking that to be DWARF64 gets more tests passing:
```
Total Discovered Tests: 33363
Skipped : 1 (0.00%)
Unsupported : 518 (1.55%)
Passed : 32696 (98.00%)
Expectedly Failed:31 (0.09%)
DavidSpickett wrote:
> Could use a test case.
But I too still want a targeted test case for this. Especially given that no
one is going to be running a DWARF64 buildbot any time soon.
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits
DavidSpickett wrote:
DWARF64, with this PR branch:
```
Total Discovered Tests: 33363
Skipped : 1 (0.00%)
Unsupported : 518 (1.55%)
Passed : 32716 (98.06%)
Expectedly Failed:31 (0.09%)
Unresolved : 3 (0.01%)
Failed :94 (0.28%)
`
DavidSpickett wrote:
This is the relevant part of the standard, correct?
```
7.5.5 Classes and Forms
18 • stroffsetsptr
19 This is an offset into the .debug_str_offsets section
20 (DW_FORM_sec_offset). It consists of an offset from the beginning of the
21 .debug_str_offsets section to the begin
https://github.com/DavidSpickett commented:
I agree with the change, FixAnyAddress uses whatever is the least destructive
fix.
Jonas should look over the core file bit, I don't know much about MachO.
https://github.com/llvm/llvm-project/pull/147011
_
@@ -44,6 +43,8 @@ def test_armv7_corefile(self):
self.assertTrue(exception.IsValid())
self.assertEqual(exception.GetValueAsUnsigned(), 0x3F5C)
+self.expect("x/4bx $sp-1", substrs=["0x000d", "0xff 0x00 0x01
0x02"])
DavidSpickett
@@ -0,0 +1,15 @@
+# Disabling until the lldb-rpc-gen tool lands.
+UNSUPPORTED: system-windows, system-linux, system-darwin
DavidSpickett wrote:
That's fine with me.
https://github.com/llvm/llvm-project/pull/138032
___
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/146867
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-07-03T14:15:56Z
New Revision: 31bdd5fd39cb26e0c85c7e2cb731d710d96057b6
URL:
https://github.com/llvm/llvm-project/commit/31bdd5fd39cb26e0c85c7e2cb731d710d96057b6
DIFF:
https://github.com/llvm/llvm-project/commit/31bdd5fd39cb26e0c85c7e2cb731d710d96057b6.diff
LOG
@@ -42,12 +42,15 @@ typedef void *rwlock_t;
typedef void *process_t; // Process type is HANDLE
typedef void *thread_t; // Host thread type
typedef void *file_t; // Host file type
-typedef unsigned in
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/146867
We don't want this as part of the public API, and using LLDB_LOG avoids some
warnings when compiling on Windows.
>From d1a2bee27169ae06eb411943bfe086a6b538658c Mon Sep 17 00:00:00 2001
From: David Spicket
Author: David Spickett
Date: 2025-07-03T10:43:20Z
New Revision: 789127036dc90a363b04325be4f1bc9e29d709fd
URL:
https://github.com/llvm/llvm-project/commit/789127036dc90a363b04325be4f1bc9e29d709fd
DIFF:
https://github.com/llvm/llvm-project/commit/789127036dc90a363b04325be4f1bc9e29d709fd.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/146686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -42,12 +42,15 @@ typedef void *rwlock_t;
typedef void *process_t; // Process type is HANDLE
typedef void *thread_t; // Host thread type
typedef void *file_t; // Host file type
-typedef unsigned in
Author: David Spickett
Date: 2025-07-03T10:27:55Z
New Revision: 4e8843ee870eb64b713ddc1f3c06e5a814339a89
URL:
https://github.com/llvm/llvm-project/commit/4e8843ee870eb64b713ddc1f3c06e5a814339a89
DIFF:
https://github.com/llvm/llvm-project/commit/4e8843ee870eb64b713ddc1f3c06e5a814339a89.diff
LOG
@@ -416,12 +416,8 @@ void DWARFFormValue::Dump(Stream &s) const {
case DW_FORM_ref_addr: {
assert(m_unit); // Unit must be valid for DW_FORM_ref_addr objects or we
// will get this wrong
-if (m_unit->GetVersion() <= 2)
- DumpAddress(s.AsRawOst
Author: David Spickett
Date: 2025-07-03T10:00:50Z
New Revision: a17c598145b03a96346e3bdd0fbc20d4e8d69fd5
URL:
https://github.com/llvm/llvm-project/commit/a17c598145b03a96346e3bdd0fbc20d4e8d69fd5
DIFF:
https://github.com/llvm/llvm-project/commit/a17c598145b03a96346e3bdd0fbc20d4e8d69fd5.diff
LOG
Author: David Spickett
Date: 2025-07-03T09:45:29Z
New Revision: dd495f16f7a001ef985d584c4e7f6ea0916d81bb
URL:
https://github.com/llvm/llvm-project/commit/dd495f16f7a001ef985d584c4e7f6ea0916d81bb
DIFF:
https://github.com/llvm/llvm-project/commit/dd495f16f7a001ef985d584c4e7f6ea0916d81bb.diff
LOG
Author: David Spickett
Date: 2025-07-03T09:42:35Z
New Revision: 563bea91222f534d90c2baa645a5e2bc4132e9a8
URL:
https://github.com/llvm/llvm-project/commit/563bea91222f534d90c2baa645a5e2bc4132e9a8
DIFF:
https://github.com/llvm/llvm-project/commit/563bea91222f534d90c2baa645a5e2bc4132e9a8.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/146835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/146835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/146835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
We saw the same thing on Windows on Arm.
https://github.com/llvm/llvm-project/pull/146835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Well, you clearly can but I cannot add you to reviewers :rofl: Permissions are
such mysterious things.
https://github.com/llvm/llvm-project/pull/146686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
DavidSpickett wrote:
> May be I do not have maintainer access yet ..?? Not sure.
That'll be it, for some reason I thought having a merged PR would imply you
could review.
https://github.com/llvm/llvm-project/pull/146686
___
lldb-commits mailing list
@@ -420,8 +420,7 @@ void DWARFFormValue::Dump(Stream &s) const {
DumpAddress(s.AsRawOstream(), uvalue, sizeof(uint64_t) * 2);
else
DumpAddress(s.AsRawOstream(), uvalue,
DavidSpickett wrote:
Done.
https://github.com/llvm/llvm-project/pull/14668
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/146686
>From 3d19a8f5069e0741a2605829adc291cf6c673eeb Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 2 Jul 2025 13:06:09 +
Subject: [PATCH 1/2] [lldb] Use correct size when dumping DWARF64
DW_FORM_
DavidSpickett wrote:
We have the same one, I'll take care of it.
https://github.com/llvm/llvm-project/pull/146632
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Also it's a bit misleading, this is printed but I don't know if it is the cause
of the include problem:
```
fixed-compilation-database: Error while opening fixed database: No such file or
directory
json-compilation-database: Error while opening JSON database: No such file o
DavidSpickett wrote:
> I'm still seeing the no job control error in the pre-commit CI. As far as I
> know this error is not supposed to be happening, RPC should be getting built
> which should mean that the lldb-rpc-gen tool is available for use in the
> shell test. I can't repro locally, I'm
DavidSpickett wrote:
@HemangGadhavi (can't add you to reviewers for whatever reason)
https://github.com/llvm/llvm-project/pull/146686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/146686
Not that we ever do that, because this is unused code, but if someone was
debugging lldb I guess they'd call this.
Was missed in https://github.com/llvm/llvm-project/pull/145645
Relates to https://github
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/146624
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/146624
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
They put up https://github.com/llvm/llvm-project/pull/146632 to fix it, if one
of you wants to check it works.
https://github.com/llvm/llvm-project/pull/145621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
https://github.com/DavidSpickett requested changes to this pull request.
Just requesting changes so we don't forget about the ABI change.
Might need to coordinate with other toolchains, we can deal with that after ABI
discussions.
https://github.com/llvm/llvm-project/pull/146572
__
@@ -0,0 +1,37 @@
+; RUN: llc -O0 -mtriple=aarch64-linux-gnu -filetype=obj < %s \
+; RUN: | llvm-objdump -r - | FileCheck %s
+
+; CHECK: R_AARCH64_TLS_DTPREL64
DavidSpickett wrote:
What does the full output look like? Because this check looks a bit
non-specific.
@@ -30,7 +30,7 @@ void AArch64_ELFTargetObjectFile::Initialize(MCContext &Ctx,
// AARCH64 ELF ABI does not define static relocation type for TLS offset
// within a module. Do not generate AT_location for TLS variables.
DavidSpickett wrote:
This comment s
@@ -1,8 +1,14 @@
-; RUN: llc -filetype=obj -mtriple=aarch64--linux-gnu -o - %s | llvm-dwarfdump
-v - | FileCheck %s
-;
+; RUN: llc -O0 -mtriple=aarch64-non-linux-gnu -filetype=obj < %s \
+; RUN: | llvm-dwarfdump - | FileCheck %s
DavidSpickett wrote:
indent the
@@ -0,0 +1,37 @@
+; RUN: llc -O0 -mtriple=aarch64-linux-gnu -filetype=obj < %s \
+; RUN: | llvm-objdump -r - | FileCheck %s
DavidSpickett wrote:
indent the second line a bit so it's clear it's a continuation:
```
; RUN: | llvm...
```
https://github.com/llvm/llv
1 - 100 of 2062 matches
Mail list logo
