https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/142143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
This test was failing on Windows I think because like many others, we're not
making DWARF or we're not retaining it when linking with link.exe. I've skipped
it there -
https://github.com/llvm/llvm-project/commit/7a66b28fcafdb7546aedeca1271e66438ad04127.
https://github.com
Author: David Spickett
Date: 2025-05-30T14:15:19Z
New Revision: 7a66b28fcafdb7546aedeca1271e66438ad04127
URL:
https://github.com/llvm/llvm-project/commit/7a66b28fcafdb7546aedeca1271e66438ad04127
DIFF:
https://github.com/llvm/llvm-project/commit/7a66b28fcafdb7546aedeca1271e66438ad04127.diff
LOG
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/142143
After https://github.com/llvm/llvm-project/pull/141670, TestLinuxCore.py was
timing out on our Windows on Arm bot.
Non-Linux core files were ok, as were Linux core files unless it was ppc64le,
riscv64 or
DavidSpickett wrote:
After this and the Windows fixup, `TestLinuxCore.py` is hanging on Windows. I
cut it down and found that ppc64, riscv and loongarch cores can no longer be
loaded.
```
.\bin\lldb.exe
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\p
DavidSpickett wrote:
Reverted, please take a look and fix. Reproducing should be possible by
installing the libc debug package, not sure what's going on with the other
failure. Let me know if you need me to investigate it locally.
https://github.com/llvm/llvm-project/pull/141689
__
Author: David Spickett
Date: 2025-05-30T08:48:29Z
New Revision: 114192f586f70d1f7ac91da88061e39524c98ca3
URL:
https://github.com/llvm/llvm-project/commit/114192f586f70d1f7ac91da88061e39524c98ca3
DIFF:
https://github.com/llvm/llvm-project/commit/114192f586f70d1f7ac91da88061e39524c98ca3.diff
LOG
DavidSpickett wrote:
Sorry, the above failure is a different assumption.
Our disassembly test failure is:
```
==
FAIL: test_disassemble (TestDAP_disassemble.TestDAP_disassemble)
Tests the 'disassemble' request.
--
DavidSpickett wrote:
> The memory reference can have a corresponding source location. if there is
> debuginfo installed on the computer or it is downloaded with debuginfod.
Sounds like the failure we see:
```
FAIL: test_generic_evaluate_expressions (TestDAP_evaluate.TestDAP_evaluate)
--
DavidSpickett wrote:
Also have tests failing on Arm and AArch64 Linux:
https://lab.llvm.org/buildbot/#/builders/59/builds/18540
https://lab.llvm.org/buildbot/#/builders/18/builds/16759
https://github.com/llvm/llvm-project/pull/141689
___
lldb-commits m
@@ -188,7 +188,74 @@ AddressClass ObjectFileXCOFF::GetAddressClass(addr_t
file_addr) {
return AddressClass::eUnknown;
}
-void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
+lldb::SymbolType MapSymbolType(llvm::object::SymbolRef::Type sym_type) {
+ if (sym_type == ll
@@ -188,7 +188,74 @@ AddressClass ObjectFileXCOFF::GetAddressClass(addr_t
file_addr) {
return AddressClass::eUnknown;
}
-void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
+lldb::SymbolType MapSymbolType(llvm::object::SymbolRef::Type sym_type) {
Davi
@@ -188,7 +188,74 @@ AddressClass ObjectFileXCOFF::GetAddressClass(addr_t
file_addr) {
return AddressClass::eUnknown;
}
-void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
+lldb::SymbolType MapSymbolType(llvm::object::SymbolRef::Type sym_type) {
+ if (sym_type == ll
@@ -188,7 +188,74 @@ AddressClass ObjectFileXCOFF::GetAddressClass(addr_t
file_addr) {
return AddressClass::eUnknown;
}
-void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
+lldb::SymbolType MapSymbolType(llvm::object::SymbolRef::Type sym_type) {
+ if (sym_type == ll
@@ -188,7 +188,74 @@ AddressClass ObjectFileXCOFF::GetAddressClass(addr_t
file_addr) {
return AddressClass::eUnknown;
}
-void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
+lldb::SymbolType MapSymbolType(llvm::object::SymbolRef::Type sym_type) {
+ if (sym_type == ll
@@ -188,7 +188,74 @@ AddressClass ObjectFileXCOFF::GetAddressClass(addr_t
file_addr) {
return AddressClass::eUnknown;
}
-void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
+lldb::SymbolType MapSymbolType(llvm::object::SymbolRef::Type sym_type) {
+ if (sym_type == ll
@@ -188,7 +188,74 @@ AddressClass ObjectFileXCOFF::GetAddressClass(addr_t
file_addr) {
return AddressClass::eUnknown;
}
-void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
+lldb::SymbolType MapSymbolType(llvm::object::SymbolRef::Type sym_type) {
+ if (sym_type == ll
@@ -188,7 +188,74 @@ AddressClass ObjectFileXCOFF::GetAddressClass(addr_t
file_addr) {
return AddressClass::eUnknown;
}
-void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
+lldb::SymbolType MapSymbolType(llvm::object::SymbolRef::Type sym_type) {
+ if (sym_type == ll
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/141577
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett commented:
I'm a bit bothered by how many `continue` are here, but they seem to be here
for good reasons.
Once you've addressed this round of comments I'll read it again and see if it's
clearer to me.
https://github.com/llvm/llvm-project/pull/141577
__
DavidSpickett wrote:
This situation can also be simulated by telling the kernel to hide the SME
feature, which should work the same in Arm's FVP or qemu-system.
If you're using shrinkwrap:
```
diff --git a/config/arch/v9.5.yaml b/config/arch/v9.5.yaml
index 789e64f..35e2629 100644
--- a/config/
DavidSpickett wrote:
CI failure but looks unrelated.
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
@laverdet I've been told we need kernel changes to handle parts of this. Those
are planned, and I will work on the lldb side once they are available.
In the meantime, this patch does prevent lldb crashing but I'm not comfortable
merging it when other features won't work. I
@@ -0,0 +1,70 @@
+#!/usr/bin/env python3
DavidSpickett wrote:
Does this need a license header?
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
https://github.com/DavidSpickett approved this pull request.
LGTM with the license comment addressed.
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/141770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/141738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -19,8 +19,6 @@ def expect_var_path(self, expr, compare_to_framevar=False,
value=None, type=None
self.runCmd("settings set target.experimental.use-DIL true")
self.assertEqual(value_dil.GetValue(), value_frv.GetValue())
-# int_arr[100] sometimes p
@@ -19,8 +19,6 @@ def expect_var_path(self, expr, compare_to_framevar=False,
value=None, type=None
self.runCmd("settings set target.experimental.use-DIL true")
self.assertEqual(value_dil.GetValue(), value_frv.GetValue())
-# int_arr[100] sometimes p
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/141738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/141738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/141738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/141738
>From ce1b2c86299944608569db2a2fa2403c8e9e2b3b Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 28 May 2025 10:15:42 +
Subject: [PATCH] [lldb][test] Fix flaky DIL array subscript test by recudi
@@ -19,8 +19,6 @@ def expect_var_path(self, expr, compare_to_framevar=False,
value=None, type=None
self.runCmd("settings set target.experimental.use-DIL true")
self.assertEqual(value_dil.GetValue(), value_frv.GetValue())
-# int_arr[100] sometimes p
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/141770
None
>From 8966332b1382d8484078103e04290006ba91812a Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 28 May 2025 14:14:39 +
Subject: [PATCH] [lldb] Remove unused escape code defines from statu
@@ -19,8 +19,6 @@ def expect_var_path(self, expr, compare_to_framevar=False,
value=None, type=None
self.runCmd("settings set target.experimental.use-DIL true")
self.assertEqual(value_dil.GetValue(), value_frv.GetValue())
-# int_arr[100] sometimes p
@@ -19,8 +19,6 @@ def expect_var_path(self, expr, compare_to_framevar=False,
value=None, type=None
self.runCmd("settings set target.experimental.use-DIL true")
self.assertEqual(value_dil.GetValue(), value_frv.GetValue())
-# int_arr[100] sometimes p
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/140761
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -683,14 +683,14 @@ def _get_compilation_command(self, source, obj):
args.append("-fms-compatibility-version=19")
args.append("/c")
+if self.std:
DavidSpickett wrote:
This still needs to be done.
https://github.com/llvm/llvm-pro
https://github.com/DavidSpickett requested changes to this pull request.
Request changes just so the remaining comment doesn't get forgotten, the rest
Michael has approved and if he's cool with it so am I.
https://github.com/llvm/llvm-project/pull/140761
@@ -0,0 +1,57 @@
+// clang-format off
+
+// REQUIRES: target-windows
+// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s
+// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run"
-o "fr v" -o c | FileCheck %s
+
+#include
DavidSpi
DavidSpickett wrote:
This does not fix the test that is xfailed, where you can't read the first
element of a vector. That's something entirely different.
https://github.com/llvm/llvm-project/pull/141738
___
lldb-commits mailing list
lldb-commits@lists
DavidSpickett wrote:
One of the tests added by this was flaky on Linaro's Windows on Arm bot, I've
skipped it for now and https://github.com/llvm/llvm-project/pull/141738 will
fix it properly.
https://github.com/llvm/llvm-project/pull/138551
___
lldb
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/141738
This test has been flaky on Linaro's Windows on Arm bot and I was able to
reproduce it within 10 or so runs locally.
When it fails it's because we failed to read the value of int_arr[100]. When
that happ
Author: David Spickett
Date: 2025-05-28T10:14:28Z
New Revision: 8b6e98559de15dc75edddf616ed37c5b6e23dfba
URL:
https://github.com/llvm/llvm-project/commit/8b6e98559de15dc75edddf616ed37c5b6e23dfba
DIFF:
https://github.com/llvm/llvm-project/commit/8b6e98559de15dc75edddf616ed37c5b6e23dfba.diff
LOG
DavidSpickett wrote:
@asb might have a IRSC-V Linux system handy to generate a core file from.
`lldb/test/API/functionalities/postmortem/elf-core/main_fpr.c` would cover GPR
and FPR, I think that's all we need here. It can be added to
`lldb/test/API/functionalities/postmortem/elf-core/TestLinu
DavidSpickett wrote:
> That's the part where I'm not sure either
This PR is strictly better than before, so it's fine as it is.
https://github.com/llvm/llvm-project/pull/141290
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
https://github.com/DavidSpickett approved this pull request.
LGTM. This is a nice improvement thanks for working on it.
https://github.com/llvm/llvm-project/pull/141290
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
DavidSpickett wrote:
This looks like a good candidate for a [release
note](https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.md#changes-to-lldb).
You can add that here or in a follow up PR.
https://github.com/llvm/llvm-project/pull/140150
___
@@ -16,12 +15,61 @@
namespace lldb_dap {
+static llvm::Expected
+HandleDataBreakpointBytes(DAP &dap,
+ const protocol::DataBreakpointInfoArguments &args) {
+ llvm::StringRef address = args.name;
+
+ unsigned long long load_addr = LLDB_INVALID_ADDRES
@@ -0,0 +1,22 @@
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class MissingDllTestCase(TestBase):
+@skipUnlessWindows
+def test(self):
DavidSpickett wrote:
Add a doc
DavidSpickett wrote:
I see the magic exit value listed in
https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-erref/596a1078-e883-4972-9bbc-49e60bebca55.
I wondered if we could say "exited with NTSTATUS ", but I'm not sure if
all exit codes in this scenario would be NTSATUS or onl
@@ -16,12 +15,61 @@
namespace lldb_dap {
+static llvm::Expected
+HandleDataBreakpointBytes(DAP &dap,
+ const protocol::DataBreakpointInfoArguments &args) {
+ llvm::StringRef address = args.name;
+
+ unsigned long long load_addr = LLDB_INVALID_ADDRES
@@ -16,12 +15,61 @@
namespace lldb_dap {
+static llvm::Expected
+HandleDataBreakpointBytes(DAP &dap,
+ const protocol::DataBreakpointInfoArguments &args) {
+ llvm::StringRef address = args.name;
+
+ unsigned long long load_addr = LLDB_INVALID_ADDRES
DavidSpickett wrote:
I've pushed it directly to get the bot green:
https://github.com/llvm/llvm-project/commit/f30a85b7005cb332b88d91dfe9ef094ef6249bd9
Thanks for figuring out the reason for the failure.
https://github.com/llvm/llvm-project/pull/141407
__
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/141407
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-05-27T11:39:50Z
New Revision: f30a85b7005cb332b88d91dfe9ef094ef6249bd9
URL:
https://github.com/llvm/llvm-project/commit/f30a85b7005cb332b88d91dfe9ef094ef6249bd9
DIFF:
https://github.com/llvm/llvm-project/commit/f30a85b7005cb332b88d91dfe9ef094ef6249bd9.diff
LOG
https://github.com/DavidSpickett approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/141062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -11,7 +11,7 @@ image show-unwind -n func0
# CHECK-NEXT: This UnwindPlan is sourced from the compiler: yes.
# CHECK-NEXT: This UnwindPlan is valid at all instruction locations: no.
# CHECK-NEXT: This UnwindPlan is for a trap handler function: no.
-# CHECK-NEXT: Address range
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/141122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/141122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
The reasoning is fine but I'm pretty sure there's an existing way to write this
skipif, let me look for it.
https://github.com/llvm/llvm-project/pull/141407
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
@@ -0,0 +1,57 @@
+// clang-format off
+
+// REQUIRES: target-windows
+// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s
+// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run"
-o "fr v" -o c | FileCheck %s
+
+#include
DavidSpi
@@ -100,29 +100,25 @@ function(add_lldb_library name)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")
DavidSpickett wrote:
> And even if they did, llvm_add_library should know how to handle that.
Oh is this why you left those bits in?
https://github.com/ll
@@ -100,29 +100,25 @@ function(add_lldb_library name)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")
DavidSpickett wrote:
Also the bit:
```
elseif (PARAM_OBJECT)
set(libkind OBJECT)
```
https://github.com/llvm/llvm-project/pull/141066
@@ -100,29 +100,25 @@ function(add_lldb_library name)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")
DavidSpickett wrote:
Should you remove OBJECT from:
```
cmake_parse_arguments(PARAM
"MODULE;SHARED;STATIC;OBJECT;PLUGIN;FRAMEWORK;NO_INTERNAL_DEPENDE
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/141063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -93,13 +93,6 @@ function(add_lldb_library name)
set(libkind STATIC)
endif()
- #PIC not needed on Win
- # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options
DavidSpickett wrote:
Sounds reasonable, I've been bitten by distro c
@@ -93,13 +93,6 @@ function(add_lldb_library name)
set(libkind STATIC)
endif()
- #PIC not needed on Win
- # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options
DavidSpickett wrote:
Do we in fact use target_compile_options? Or do
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/141063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/141063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Such a hack might be breaking on a place that does have debug information and
stepping into one that doesn't, then placing a breakpoint on subsequent
assembly lines. Might be. Didn't try it because it seemed like it might defeat
the point of the test as it wouldn't place t
DavidSpickett wrote:
Looks like a Windows/PDB/COFF vs. Linux/DWARF/ELF difference. We can't break on
a function when there's no debug information. It's not due to the architecture.
So if you feel like coming up with a hack to make it work, the failure should
reproduce on x64 Windows as well. P
Author: David Spickett
Date: 2025-05-22T09:48:31Z
New Revision: c82b30c13463073b359695a83d1dc1b7fc1c8088
URL:
https://github.com/llvm/llvm-project/commit/c82b30c13463073b359695a83d1dc1b7fc1c8088
DIFF:
https://github.com/llvm/llvm-project/commit/c82b30c13463073b359695a83d1dc1b7fc1c8088.diff
LOG
DavidSpickett wrote:
This is failing on Windows on Arm, started here:
https://lab.llvm.org/buildbot/#/builders/141/builds/8891
```
AssertionError: False is not true : breakpoint not hit,
stopped_events=[{'body': {'exitCode': 0}, 'event': 'exited', 'seq': 0, 'type':
'event'}]
Config=aarch64-C:
DavidSpickett wrote:
Let's see what I find first, sometimes these things are quite simple to fix.
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/DavidSpickett approved this pull request.
LGTM.
I got us to a point where every file in llvm-project is `Maintainers.*` but
didn't have the appetite to make them all Markdown yet.
https://github.com/llvm/llvm-project/pull/140958
__
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,241 @@
+# LLDB Maintainers
+
+This file is a list of the
[maintainers](https://llvm.org/docs/DeveloperPolicy.html#maintainers) for LLDB.
+
+## Current Maintainers
+
+The following people are the active maintainers for the project. Please reach
out to them for code rev
https://github.com/DavidSpickett commented:
A couple of comments to be addressed but otherwise I have no problems with this.
https://github.com/llvm/llvm-project/pull/138032
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -312,10 +312,27 @@ NativeProcessLinux::Manager::Attach(
Log *log = GetLog(POSIXLog::Process);
LLDB_LOG(log, "pid = {0:x}", pid);
- auto tids_or = NativeProcessLinux::Attach(pid);
- if (!tids_or)
-return tids_or.takeError();
- ArrayRef<::pid_t> tids = *tids_or;
+
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
https://github.com/DavidSpickett commented:
I leave the discussion of race conditions or lack of to @labath .
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> I added my gist to the description, let me know what you think
This part looks good, that'll be enough to test this / explain why it exists.
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-com
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Candidates for how it ever worked:
* Out of bounds write managing to break something else in just the right way.
Then adding new extension registers meant it was invalidating registers again,
probably guarded control stack registers.
* LLDB got less aggressive about re-read
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/140875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/140875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/140875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/140875
Recently the Linux Kernel has fixed a bunch of issues in SME support and while
testing that, I found two tests failing: FAIL:
test_za_register_dynamic_config_main_disabled
(TestZAThreadedDynamic.AArch64Z
1 - 100 of 1788 matches
Mail list logo
