[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

2024-10-11 Thread David Mentler via lldb-commits
https://github.com/mentlerd updated https://github.com/llvm/llvm-project/pull/111892 >From b1e6178b1130135262884d99262716fcc0ada86e Mon Sep 17 00:00:00 2001 From: David Mentler Date: Mon, 7 Oct 2024 21:46:50 +0200 Subject: [PATCH 1/8] Make existing tests break --- .../data-formatter-stl/libcx

[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

2024-10-11 Thread David Mentler via lldb-commits
mentlerd wrote: > A high-level comment: could we split up `FindLibCppStdFunctionCallableInfo`? > Exactly how I haven't fully thought through. But possibly a function for each > of the callable cases? Sure! I think a natural split could be to make a version which returns a (possibly dummy) `Va

[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

2024-10-11 Thread David Mentler via lldb-commits
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo( if (!valobj_sp) return optional_info; + // std::function has many variants, try to disambiguate + ValueObjectSP func_as_base_ptr; + { +ValueObjectSP outer_f = valobj_sp->GetChildMemberWit

[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

2024-10-11 Thread David Mentler via lldb-commits
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo( if (!valobj_sp) return optional_info; + // std::function has many variants, try to disambiguate + ValueObjectSP func_as_base_ptr; + { +ValueObjectSP outer_f = valobj_sp->GetChildMemberWit

[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

2024-10-11 Thread David Mentler via lldb-commits
@@ -191,14 +191,6 @@ llvm::Error ItaniumABILanguageRuntime::TypeHasVTable(CompilerType type) { type = pointee_type; } - // Make sure this is a class or a struct first by checking the type class - // bitfield that gets returned. - if ((type.GetTypeClass() & (eTypeCl

[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

2024-10-11 Thread David Mentler via lldb-commits
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo( if (!valobj_sp) return optional_info; + // std::function has many variants, try to disambiguate + ValueObjectSP func_as_base_ptr; + { +ValueObjectSP outer_f = valobj_sp->GetChildMemberWit

[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

2024-10-10 Thread David Mentler via lldb-commits
https://github.com/mentlerd updated https://github.com/llvm/llvm-project/pull/111892 >From b1e6178b1130135262884d99262716fcc0ada86e Mon Sep 17 00:00:00 2001 From: David Mentler Date: Mon, 7 Oct 2024 21:46:50 +0200 Subject: [PATCH 1/7] Make existing tests break --- .../data-formatter-stl/libcx

[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

2024-10-10 Thread David Mentler via lldb-commits
https://github.com/mentlerd updated https://github.com/llvm/llvm-project/pull/111892 >From b1e6178b1130135262884d99262716fcc0ada86e Mon Sep 17 00:00:00 2001 From: David Mentler Date: Mon, 7 Oct 2024 21:46:50 +0200 Subject: [PATCH 1/5] Make existing tests break --- .../data-formatter-stl/libcx

[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

2024-10-10 Thread David Mentler via lldb-commits
https://github.com/mentlerd created https://github.com/llvm/llvm-project/pull/111892 Work in progress attempt at fixing #111291. Looking for maintainer feedback/direction from @Michael137 >From b1e6178b1130135262884d99262716fcc0ada86e Mon Sep 17 00:00:00 2001 From: David Mentler Date: Mon, 7