[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

theraven added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:49 + if (TT.isOSBinFormatELF()) +return filename.starts_with("libobjc.so"); + if (TT.isOSWindows()) This is a bit unfortunate. I

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

theraven added a comment. The test looks fine to me, I'm quite surprised that it passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ https://reviews.llvm.org/D146154 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

theraven added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:131 +ExecutionContext &exe_ctx) { + // TODO: This function is supposed to check whether an ObjC selector is +

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

theraven added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:42 +LanguageType language) { + if (language != eLanguageTypeObjC) +return nullptr;

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

theraven added inline comments. Comment at: lldb/test/CMakeLists.txt:39 +if (LLDB_TEST_OBJC_GNUSTEP_DIR) + message(STATUS "Found GNUstep ObjC runtime: ${LLDB_TEST_OBJC_GNUSTEP_DIR}/${gnustep_info}") +endif() DavidSpickett wrote: > sgraenitz wrote: > > Might be

[Lldb-commits] [PATCH] D119044: Add a case for Rust in LLDB's PDB reader

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ccfef14e57e: Add a case for Rust in LLDB's PDB reader (authored by arlosi, committed by theraven). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119044/new/

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

theraven added a comment. Does the new plugin work with processes that are created with `pdfork`? The last time I tried this, it caused the old plugin to lock up the debugger entirely. Please can you ensure that there are tests that cover `pdfork` and `cap_enter` in the child? These are curr