[Lldb-commits] [PATCH] D115137: [formatters] Add a pointer and reference tests for a list and forward_list formatters for libstdcpp and libcxx

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115137 Files: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cp

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

danilashtefan added a comment. Hi @labath, Thank you so much for your comment and correction. The initial version of the test was the following, with array of ValueCheck objects: `def check(self, var_name, size): var = self.findVariable(var_name) self.assertEqual(var.GetNumChildren(), size)

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

danilashtefan updated this revision to Diff 389700. danilashtefan added a comment. As we discussed offline, I add the print tests, since SBValue.GetValue() doesn't work for complex structures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114008/new

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

danilashtefan updated this revision to Diff 389597. danilashtefan added a comment. Unified tests added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114008/new/ https://reviews.llvm.org/D114008 Files: lldb/examples/synthetic/gnu_libstdcpp.py l

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

danilashtefan updated this revision to Diff 389303. danilashtefan added a comment. Deleted duplicated tests from both platforms Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114433/new/ https://reviews.llvm.org/D114433 Files: lldb/bindings/inter

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

danilashtefan updated this revision to Diff 389300. danilashtefan added a comment. List tests unification for libcxx and libstdcpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114433/new/ https://reviews.llvm.org/D114433 Files: lldb/bindings/in

[Lldb-commits] [PATCH] D114461: Draft PR for the bitset capping size limitation avoidance

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114461 Files: lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

danilashtefan updated this revision to Diff 389249. danilashtefan marked 3 inline comments as done. danilashtefan added a comment. Done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114433/new/ https://reviews.llvm.org/D114433 Files: lldb/bindi

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

danilashtefan added inline comments. Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:66-69 if not _list_uses_loop_detector: logger >> "Asked not to use loop detection" +_list_uses_loop_detector = True return False --

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114433 Files: lldb/bindings/interface/SBTarget.i lldb/examples/syntheti

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

danilashtefan updated this revision to Diff 388745. danilashtefan added a comment. Size determined Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114008/new/ https://reviews.llvm.org/D114008 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/

[Lldb-commits] [PATCH] D114266: [formatters] Draft Optional PR

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114266 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/source/Plug

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

danilashtefan updated this revision to Diff 388016. danilashtefan added a comment. Done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113760/new/ https://reviews.llvm.org/D113760 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/source/Plu

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

danilashtefan updated this revision to Diff 388012. danilashtefan marked 9 inline comments as done. danilashtefan added a comment. All the above-mentioned is changed. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113760/new/ https://revi

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

danilashtefan added a comment. When I mocked the num_children to return 4, formatter works for any structure with size <= 4. here is the example: std::deque d; d.push_front(7); d.push_front(5); d.push_front(13); d.push_front(25); (std::deque >) $0 = size=4 { [0] = 25 [1] =

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

danilashtefan added inline comments. Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:60 + +def num_children_impl(self): +# logger = lldb.formatters.Logger.Logger() This method does not currently work. I simply tried to calculate the size from

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114008 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/source/Plug

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

danilashtefan updated this revision to Diff 387084. danilashtefan added a comment. Some naming corrections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113760/new/ https://reviews.llvm.org/D113760 Files: lldb/examples/synthetic/gnu_libstdcpp.py

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

danilashtefan updated this revision to Diff 387022. danilashtefan added a comment. Cosmetic change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113760/new/ https://reviews.llvm.org/D113760 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

danilashtefan added a comment. Hi Walter, Thank you for the hints. Everything works now, including the string case. There was a small difficulty with set case, but then I figured out that for set case I need to take not the 5th, but 4th template argument. I will be waiting for your comments. A

[Lldb-commits] [PATCH] D113760: [formatters] Draft diff for unordered_map libstdcpp formatter

danilashtefan updated this revision to Diff 387020. danilashtefan added a comment. All the changes are done and tests pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113760/new/ https://reviews.llvm.org/D113760 Files: lldb/examples/synthetic/

[Lldb-commits] [PATCH] D113760: [formatters] Draft diff for unordered_map libstdcpp formatter

danilashtefan added inline comments. Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:77 +key = self.get_child_key(index) +return current.CreateChildAtOffset('[' + str(key.GetValue()) + ']', self.next.GetType().GetByteSize() + self.data_size, self.dat

[Lldb-commits] [PATCH] D113760: [formatters] Draft diff for unordered_map libstdcpp formatter

danilashtefan added a comment. Hi Walter :) This is the Draft PR for the unordered_map/set data formatter. Currently it works well in case both key and values are of the same primitive data types (except string). Unfortunately, the following problems are encountered: 1. When key and value are

[Lldb-commits] [PATCH] D113760: [formatters] Draft diff for unordered_map libstdcpp formatter

danilashtefan updated this revision to Diff 386824. danilashtefan added a comment. Small cosmetic change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113760/new/ https://reviews.llvm.org/D113760 Files: lldb/examples/synthetic/gnu_libstdcpp.py

[Lldb-commits] [PATCH] D113760: next

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113760 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/source/Plug

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

danilashtefan updated this revision to Diff 385904. danilashtefan added a comment. Right size is returned and tests are unified! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113362/new/ https://reviews.llvm.org/D113362 Files: lldb/examples/s

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

danilashtefan added inline comments. Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:92 +return 1 +size = self.node_value_pointer_offset current = self.next wallace wrote: > let's better initialize

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

danilashtefan updated this revision to Diff 385744. danilashtefan marked 10 inline comments as done. danilashtefan added a comment. All the requested changes are done :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113362/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

danilashtefan updated this revision to Diff 385526. danilashtefan marked 8 inline comments as done. danilashtefan added a comment. All of the requested changes are done. Please, let me know if any other corrections are needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

danilashtefan added a comment. Hi Walter:) Please, could you advise what can I change/do more? As a next step, I will unify the tests across the libcxx and libstdcpp formatters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113362/new/ https://rev

[Lldb-commits] [PATCH] D113362: Summary:

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113362 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/source/Plug

[Lldb-commits] [PATCH] D112785: [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs

danilashtefan updated this revision to Diff 383621. danilashtefan added a comment. refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112785/new/ https://reviews.llvm.org/D112785 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/sour

[Lldb-commits] [PATCH] D112785: [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs

danilashtefan updated this revision to Diff 383619. danilashtefan added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112785/new/ https://reviews.llvm.org/D112785 Files: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage

[Lldb-commits] [PATCH] D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs

danilashtefan added a comment. I thought that you misprinted the name and wanted to call the formatter MapLikeSynth provider. Please, correct me if I am wrong and I will change names accordingly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112752

[Lldb-commits] [PATCH] D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs

danilashtefan updated this revision to Diff 383587. danilashtefan added a comment. All the above specified parts are changed. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112752/new/ https://reviews.llvm.org/D112752 Files: lldb/examp

[Lldb-commits] [PATCH] D112785: Summary:

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112785 Files: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cp

[Lldb-commits] [PATCH] D112752: [formatters] Add a libstdcpp formatter for multimap and unify tests across stdlibs

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112752 Files: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cp

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan updated this revision to Diff 382734. danilashtefan added a comment. Last thing corrected :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files: lldb/examples/synthetic/gnu_libstdcpp.py

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan updated this revision to Diff 382729. danilashtefan added a comment. Refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/sour

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan updated this revision to Diff 382668. danilashtefan added a comment. Small formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/set/TestDataFormatterGenericSet.py:45 "[3] = 3", "[6] = 6"]) wallace wrote: > can you add additional asse

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan updated this revision to Diff 382665. danilashtefan edited the summary of this revision. danilashtefan added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files: lldb/e

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs

danilashtefan updated this revision to Diff 382463. danilashtefan added a comment. Reactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180 Files: lldb/source/Plugins/Language/CPlusPlus/CMakeLists.txt

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs

danilashtefan updated this revision to Diff 382456. danilashtefan added a comment. Refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180 Files: lldb/source/Plugins/Language/CPlusPlus/CMakeLists.tx

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan updated this revision to Diff 382453. danilashtefan added a comment. With this changes I substitute the verbose long printed check with ValueCheck approach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llv

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan updated this revision to Diff 382370. danilashtefan added a comment. Fixing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180 Files: lldb/source/Plugins/Language/CPlusPlus/CMakeLists.txt l

[Lldb-commits] [PATCH] D112537: Set synthetic children

danilashtefan updated this revision to Diff 382348. danilashtefan added a comment. Deleted libcxx tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files: lldb/source/Plugins/Language/CPlusPlus/CPlu

[Lldb-commits] [PATCH] D112537: Set synthetic children. I have dove the generic tests for set. I have considered Libcxx tests as the one covering all the edge cases (including pointer and reference va

danilashtefan updated this revision to Diff 382336. danilashtefan added a comment. Set synthetic child Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files: lldb/source/Plugins/Language/CPlusPlus/CPlus

[Lldb-commits] [PATCH] D112537: Set synthetic children. I have dove the generic tests for set. I have considered Libcxx tests as the one covering all the edge cases (including pointer and reference va

danilashtefan updated this revision to Diff 382330. danilashtefan added a comment. Set synthetic children Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files: lldb/source/Plugins/Language/CPlusPlus/CP

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

danilashtefan updated this revision to Diff 382325. danilashtefan added a comment. Minor corrections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180 Files: lldb/source/Plugins/Language/CPlusPlus/CPlusPl

[Lldb-commits] [PATCH] D112537: Set synthetic children. I have dove the generic tests for set. I have considered Libcxx tests as the one covering all the edge cases (including pointer and reference va

danilashtefan created this revision. Herald added a subscriber: mgorny. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ...properties. However, I have decided to vhange them only when applying the set summary provider, and ch

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

danilashtefan updated this revision to Diff 382066. danilashtefan added a comment. I have corrected everything according to the previous comments. Wallace will kindly help me to format the code, since I have the following formatter error Stack dump: 0.Program arguments: clang-format -lines=1

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

danilashtefan created this revision. Herald added a subscriber: mgorny. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112180 Files: lldb/source/Plugins/Lang